diff options
| author | Lasse Collin <lasse.collin@tukaani.org> | 2020-01-26 20:53:25 +0200 |
|---|---|---|
| committer | Lasse Collin <lasse.collin@tukaani.org> | 2020-02-05 22:00:28 +0200 |
| commit | 4433c2dc5727ee6aef570e001a5a024e0d94e609 (patch) | |
| tree | 26f2a34859cb84e287e27481a028d86bd5ae1512 | |
| parent | xz: Move flush_needed from mytime.h to file_pair struct in file_io.h. (diff) | |
| download | xz-4433c2dc5727ee6aef570e001a5a024e0d94e609.tar.xz | |
xz: Set the --flush-timeout deadline when the first input byte arrives.
xz --flush-timeout=2000, old version:
1. xz is started. The next flush will happen after two seconds.
2. No input for one second.
3. A burst of a few kilobytes of input.
4. No input for one second.
5. Two seconds have passed and flushing starts.
The first second counted towards the flush-timeout even though
there was no pending data. This can cause flushing to occur more
often than needed.
xz --flush-timeout=2000, after this commit:
1. xz is started.
2. No input for one second.
3. A burst of a few kilobytes of input. The next flush will
happen after two seconds counted from the time when the
first bytes of the burst were read.
4. No input for one second.
5. No input for another second.
6. Two seconds have passed and flushing starts.
| -rw-r--r-- | src/xz/coder.c | 6 | ||||
| -rw-r--r-- | src/xz/file_io.c | 6 | ||||
| -rw-r--r-- | src/xz/mytime.c | 1 |
3 files changed, 6 insertions, 7 deletions
diff --git a/src/xz/coder.c b/src/xz/coder.c index 8bad038e..85f95439 100644 --- a/src/xz/coder.c +++ b/src/xz/coder.c @@ -733,9 +733,6 @@ coder_normal(file_pair *pair) if (coder_write_output(pair)) break; - // Set the time of the most recent flushing. - mytime_set_flush_time(); - // Mark that we haven't seen any new input // since the previous flush. pair->src_has_seen_input = false; @@ -906,8 +903,7 @@ coder_run(const char *filename) // is used. if (opt_mode == MODE_TEST || !io_open_dest(pair)) { // Remember the current time. It is needed - // for progress indicator and for timed - // flushing. + // for progress indicator. mytime_set_start_time(); // Initialize the progress indicator. diff --git a/src/xz/file_io.c b/src/xz/file_io.c index c891f3ca..464a8b15 100644 --- a/src/xz/file_io.c +++ b/src/xz/file_io.c @@ -1167,7 +1167,11 @@ io_read(file_pair *pair, io_buf *buf, size_t size) } pos += (size_t)(amount); - pair->src_has_seen_input = true; + + if (!pair->src_has_seen_input) { + pair->src_has_seen_input = true; + mytime_set_flush_time(); + } } return pos; diff --git a/src/xz/mytime.c b/src/xz/mytime.c index 573b97de..70444001 100644 --- a/src/xz/mytime.c +++ b/src/xz/mytime.c @@ -51,7 +51,6 @@ extern void mytime_set_start_time(void) { start_time = mytime_now(); - next_flush = start_time + opt_flush_timeout; return; } |