aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEnrico Scholz <enrico.scholz@sigma-chemnitz.de>2010-02-28 14:40:57 +0100
committerDavid Sommerseth <dazo@users.sourceforge.net>2010-10-21 11:33:42 +0200
commit798497ae52d782248cc89fb8bf0e4fcdba98a0d3 (patch)
tree1c125ff95ec4bbf2c681c08276fc40ceef2d8073
parentremove duplicate code in FREEBSD+DRAGONFLY system-dependent ifconfig (diff)
downloadopenvpn-798497ae52d782248cc89fb8bf0e4fcdba98a0d3.tar.xz
Allow 'lport 0' setup for random port binding
I am running a multihomed host where 'local <extip>' must be specified for proper operation. Unfortunately, this implies 'lport 1194' or another static port. This causes problems with stateful firewalls which register the host/port pairs in the internal connection tracking table. On ungraceful reconnects, the new TCP connection will have same the host/port pairs but unexpected sequence numbers. The new connection will be assumed as invalid hence and be dropped. It would be nice when local port can be configured to be bound to a random port number. After reading code, | else if (streq (p[0], "lport") && p[1]) | ... | port = atoi (p[1]); |- if (!legal_ipv4_port (port)) |+ if (port != 0 && !legal_ipv4_port (port)) | { in options.c seems to be the only required change. This has been discussed here: <http://thread.gmane.org/gmane.network.openvpn.user/28622> Signed-off-by: David Sommerseth <dazo@users.sourceforge.net> Acked-by: Gert Doering <gert@greenie.muc.de>
-rw-r--r--options.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/options.c b/options.c
index 5f1efc5..6d3ef8e 100644
--- a/options.c
+++ b/options.c
@@ -4258,7 +4258,7 @@ add_option (struct options *options,
VERIFY_PERMISSION (OPT_P_GENERAL|OPT_P_CONNECTION);
port = atoi (p[1]);
- if (!legal_ipv4_port (port))
+ if ((port != 0) && !legal_ipv4_port (port))
{
msg (msglevel, "Bad local port number: %s", p[1]);
goto err;