aboutsummaryrefslogtreecommitdiff
path: root/src/wallet (follow)
AgeCommit message (Collapse)AuthorFilesLines
2024-07-16Merge pull request #9379luigi11112-24/+12
6c28bdb wallet2: move get_rpc_status func to RPC server definition file (j-berman)
2024-07-16Merge pull request #9344luigi11112-4/+22
a026d5a wallet2: validate fetched block height and parent hash (Oscar Mira) c634c26 wallet2: use start_height consistently as const in process_parsed_blocks (Oscar Mira)
2024-07-16Merge pull request #9343luigi11111-0/+1
302fa9b wallet: fetch pool txs in pruned form (jeffro256)
2024-07-16Merge pull request #9338luigi111139-39/+39
4a376d6 copyright: fix vector.h typo (hinto.janaiyo) d61e8e9 workflows: delete copyright.yml (plowsof) 341771a copyright: bump to 2024 (copyCat)
2024-07-16Merge pull request #8619luigi111110-89/+1634
e71c8bf wallet: background sync with just the view key (j-berman)
2024-07-05wallet2: validate fetched block height and parent hashOscar Mira1-0/+18
2024-07-04wallet2: use start_height consistently as const in process_parsed_blocksOscar Mira2-4/+4
2024-06-24wallet2: move get_rpc_status func to RPC server definition filej-berman2-24/+12
2024-05-28wallet: fetch pool txs in pruned formjeffro2561-0/+1
2024-05-24wallet: background sync with just the view keyj-berman10-89/+1634
- When background syncing, the wallet wipes the spend key from memory and processes all new transactions. The wallet saves all receives, spends, and "plausible" spends of receives the wallet does not know key images for. - When background sync disabled, the wallet processes all background synced txs and then clears the background sync cache. - Adding "plausible" spends to the background sync cache ensures that the wallet does not need to query the daemon to see if any received outputs were spent while background sync was enabled. This would harm privacy especially for users of 3rd party daemons. - To enable the feature in the CLI wallet, the user can set background-sync to reuse-wallet-password or custom-background-password and the wallet automatically syncs in the background when the wallet locks, then processes all background synced txs when the wallet is unlocked. - The custom-background-password option enables the user to open a distinct background wallet that only has a view key saved and can be opened/closed/synced separately from the main wallet. When the main wallet opens, it processes the background wallet's cache. - To enable the feature in the RPC wallet, there is a new `/setup_background_sync` endpoint. - HW, multsig and view-only wallets cannot background sync.
2024-05-21add key exchange round booster to multisig_accountkoe8-73/+260
2024-05-21wallet2: correct variable usage in get_multisig_seedselsta1-1/+1
2024-05-21copyright: bump to 2024copyCat39-39/+39
2024-05-20Merge pull request #9310luigi11111-1/+1
6d4f7b8 wallet2: fix stagenet get_approximate_blockchain_height (selsta)
2024-05-20Merge pull request #9305luigi11111-2/+2
de9c461 common: support boost filesystem copy_options. Co-authored-by: selsta <selsta@sent.at> (0xFFFC0000)
2024-05-20Merge pull request #9270luigi11111-1/+1
267e31f Add drop_and_recreate in privatefile class. When creating a private file we need to delete the file if exist. (0xFFFC0000)
2024-05-20Merge pull request #9259luigi11111-3/+3
427ba77 wallet2: ensure transfers and sweeps use same fee calc logic rnd2 (j-berman)
2024-05-20Merge pull request #9211luigi11112-2/+7
9b946ae Removed default cryptonote address (SyntheticBird45)
2024-05-20Merge pull request #9151luigi11116-49/+74
ff49444 @tobtoht: undo rebase changes tx.dsts -> tx_dsts (jeffro256) 38f354e Enforce Tx unlock_time is Zero by Relay Rule (jeffro256)
2024-05-20Merge pull request #7852luigi11117-64/+105
8d94d08 replace 'multisig()' with 'get_multisig_status()' using multisig_account_status and including '.kex_is_done' member (koe)
2024-04-30common: support boost filesystem copy_options.0xFFFC00001-2/+2
Co-authored-by: selsta <selsta@sent.at>
2024-04-28wallet2: fix stagenet get_approximate_blockchain_heightselsta1-1/+1
2024-04-22Add drop_and_recreate in privatefile class.0xFFFC00001-1/+1
When creating a private file we need to delete the file if exist.
2024-04-05@tobtoht: undo rebase changes tx.dsts -> tx_dstsjeffro2561-4/+4
2024-03-22wallet2: ensure transfers and sweeps use same fee calc logic rnd2j-berman1-3/+3
Looks like the logic from #8882 was accidentally removed in #8861 (regressing to the behavior noted in the #8882 description). This commit brings that logic back.
2024-03-08Removed default cryptonote addressSyntheticBird452-2/+7
- Removed `localhost:8080` default value to address string in wallet rpc - Added an error response in case string is empty fixed indentation removed if and errors, default to localhost and port based on nettype Forgot ":" forgot ; and m_ removed wallet_rpc_server_error_codes.h
2024-03-08wallet2: adjust fee during backlog, fix set priorityselsta1-2/+2
2024-02-24Enforce Tx unlock_time is Zero by Relay Rulejeffro2566-49/+74
Related to https://github.com/monero-project/research-lab/issues/78 Added a relay rule that enforces the `unlock_time` field is equal to 0 for non-coinbase transactions. UIs changed: * Removed `locked_transfer` and `locked_sweep_all` commands from `monero-wallet-cli` APIs changed: * Removed `unlock_time` parameters from `wallet2` transfer methods * Wallet RPC transfer endpoints send error codes when requested unlock time is not 0 * Removed `unlock_time` parameters from `construct_tx*` cryptonote core functions
2024-02-24Merge pull request #9160luigi11115-4/+31
c50ade5 Daemon-specific proxy for the wallet-rpc. (0xFFFC0000)
2024-02-24Merge pull request #9006luigi11111-4/+4
47042ce wallet2: call on_reorg callback in handle_reorg (j-berman)
2024-02-20wallet: feature: transfer amount with fee includedjeffro2566-37/+187
To transfer ~5 XMR to an address such that your balance drops by exactly 5 XMR, provide a `subtractfeefrom` flag to the `transfer` command. For example: transfer 76bDHojqFYiFCCYYtzTveJ8oFtmpNp3X1TgV2oKP7rHmZyFK1RvyE4r8vsJzf7SyNohMnbKT9wbcD3XUTgsZLX8LU5JBCfm 5 subtractfeefrom=all If my walet balance was exactly 30 XMR before this transaction, it will be exactly 25 XMR afterwards and the destination address will receive slightly less than 5 XMR. You can manually select which destinations fund the transaction fee and which ones do not by providing the destination index. For example: transfer 75sr8AAr... 3 74M7W4eg... 4 7AbWqDZ6... 5 subtractfeefrom=0,2 This will drop your balance by exactly 12 XMR including fees and will spread the fee cost proportionally (3:5 ratio) over destinations with addresses `75sr8AAr...` and `7AbWqDZ6...`, respectively. Disclaimer: This feature was paid for by @LocalMonero.
2024-02-18Daemon-specific proxy for the wallet-rpc.0xFFFC00005-4/+31
1. Daemon-specific proxy is exclusive with global proxy (--proxy). 2. If you set global proxy (--proxy) you cannot set daemon-specific proxy. 3. If you don't set global proxy, you can set proxy (or not set) proxy for each daemon connection with the proxy field in jsonrpc to the wallet-rpc.
2024-01-18Merge pull request #9077luigi11112-35/+35
2525200 serialization: remove container wrappers and serialize directly (jeffro256)
2024-01-18Merge pull request #9059luigi11111-0/+13
2766d12 MMS: Ignore 2 more API errors thrown by latest PyBitmessage (rbrunner7)
2024-01-18Merge pull request #9049luigi11111-3/+1
1062b17 wallet: sign_tx: get tx pubkey from extra (tobtoht)
2024-01-18Merge pull request #9023luigi11111-16/+43
b2eb47d wallet: mitigate statistical dependence for decoy selection within rings (jeffro256)
2023-11-28serialization: remove container wrappers and serialize directlyjeffro2562-35/+35
Some downstream code (most notably PR https://github.com/UkoeHB/monero/pull/25) wants to use the src/serialization lib for storing information persistently. When one builds classes/machines wishing to serialize containers, they must use the `serializable_*` container classes. In this case, this makes the Seraphis library code unnecessarily tightly coupled with the src/serialization code since one cannot swap out their type of storage format without major refactoring of class field types. By serializing STL containers directly, we can abstract the serialization details away, making for much cleaner design. Also small bonus side effect of this change is that STL containers with custom Comparators, Allocators, and Hashers are serializable. `std::multimap` is added to the list of serializable containers. Depends upon https://github.com/monero-project/monero/pull/9069.
2023-11-06Merge pull request #9050luigi11111-0/+26
23179a0 wallet: fix multisig key memory leak (jeffro256)
2023-11-06Merge pull request #9038luigi11111-1/+0
e191083 epee: remove dead code in math_helper and string_tools (jeffro256)
2023-11-05MMS: Ignore 2 more API errors thrown by latest PyBitmessagerbrunner71-0/+13
2023-11-02wallet: sign_tx: get tx pubkey from extratobtoht1-3/+1
2023-11-02wallet: fix multisig key memory leakjeffro2561-0/+26
Multisig keys per-transfer were being wiped, but not erased, which lead to a ginormous quadratic bloat the more transfers and exports you performed with the wallet.
2023-10-25Merge pull request #9002luigi11111-0/+3
932bba3 depends: remove libiconv: unused (tobtoht)
2023-10-25Merge pull request #8974luigi11111-1/+1
759293d wallet2: fix version check at hf version 1 (j-berman)
2023-10-25Merge pull request #8969luigi11112-71/+71
8190f25 KV_SERIALIZE: remove extraneous semicolons in DSL (jeffro256)
2023-10-25epee: remove dead code in math_helper and string_toolsjeffro2561-1/+0
2023-10-17wallet: mitigate statistical dependence for decoy selection within ringsjeffro2561-16/+43
Since we are required to check for uniqueness of decoy picks within any given ring, and since some decoy picks may fail due to unlock time or malformed EC points, the wallet2 decoy selection code was building up a larger than needed *unique* set of decoys for each ring according to a certain distribution *without replacement*. After filtering out the outputs that it couldn't use, it chooses from the remaining decoys uniformly random *without replacement*. The problem with this is that the picks later in the picking process are not independent from the picks earlier in the picking process, and the later picks do not follow the intended decoy distribution as closely as the earlier picks. To understand this intuitively, imagine that you have 1023 marbles. You label 512 marbles with the letter A, label 256 with the letter B, so on and so forth, finally labelling one marble with the letter J. You put them all into a bag, shake it well, and pick 8 marbles from the bag, but everytime you pick a marble of a certain letter, you remove all the other marbles from that bag with the same letter. That very first pick, the odds of picking a certain marble are exactly how you would expect: you are twice as likely to pick A as you are B, twice as likely to pick B as you are C, etc. However, on the second pick, the odds of getting the first pick are 0%, and the chances for everything else is higher. As you go down the line, your picked marbles will have letters that are increasingly more unlikely to pick if you hadn't remove the other marbles. In other words, the distribution of the later marbles will be more "skewed" in comparison to your original distribution of marbles. In Monero's decoy selection, this same statistical effect applies. It is not as dramatic since the distribution is not so steep, and we have more unique values to choose from, but the effect *is* measureable. Because of the protocol rules, we cannot have duplicate ring members, so unless that restriction is removed, we will never have perfectly independent picking. However, since the earlier picks are less affected by this statistical effect, the workaround that this commit offers is to store the order that the outputs were picked and commit to this order after fetching output information over RPC.
2023-09-26wallet2: call on_reorg callback in handle_reorgj-berman1-4/+4
2023-09-25depends: remove libiconv: unusedtobtoht1-0/+3
2023-09-21wallet: store watch-only wallet correctly when `change_password()` is calledjeff1-2/+2
The Monero GUI code was calling `Monero::wallet::setPassword()` on every open/close for some reason, and the old `store_to()` code called `store_keys()` with `watch_only=false`, even for watch-only wallets. This caused a bug where the watch-only keys file got saved with with the JSON field `watch_only` set to 0, and after saving a watch-only wallet once, a user could never open it back up against because `load()` errored out. This never got brought up before this because you would have to change the file location of the watch-only wallet to see this bug, and I guess that didn't happen often, but calling the new `store_to()` function with the new `force_rewrite` parameter set to `true` triggers key restoring and the bug appeared.
2023-08-23wallet2: fix `store_to()` and `change_password()`jeffro2562-34/+90
Resolves #8932 and: 2. Not storing cache when new path is different from old in `store_to()` and 3. Detecting same path when new path contains entire string of old path in `store_to()` and 4. Changing your password / decrypting your keys (in this method or others) and providing a bad original password and getting no error and 5. Changing your password and storing to a new file
2023-08-17wallet2: fix version check at hf version 1j-berman1-1/+1
2023-08-17Merge pull request #8956luigi11111-4/+9
f7fb5c7 scan_tx: fix custom comparator for == case; fixes #8951 (j-berman)
2023-08-17Merge pull request #8950luigi11111-4/+4
a0e5c3c wallet2: when checking frozen multisig tx set, don't assume order (jeffro256)
2023-08-17Merge pull request #8914luigi11114-25/+59
45b52de wallet-rpc: restore from multisig seed (jeffro256)
2023-08-17Merge pull request #8882luigi11111-3/+3
a8d2a58 wallet2: ensure transfers and sweeps use same fee calc logic (j-berman)
2023-08-10`KV_SERIALIZE`: remove extraneous semicolons in DSLjeffro2562-71/+71
Prereq of https://github.com/monero-project/monero/pull/8867
2023-07-28wallet-rpc: restore from multisig seedjeffro2564-25/+59
2023-07-19scan_tx: fix custom comparator for == case; fixes #8951j-berman1-4/+9
Co-authored-by: woodser <woodser@protonmail.com>
2023-07-16wallet2: when checking frozen multisig tx set, don't assume orderjeffro2561-4/+4
2023-07-06Merge pull request #8904luigi11112-2/+40
369a5a8 wallet: respect frozen key images in multisig wallets (jeffro256)
2023-07-06Merge pull request #8902luigi11111-0/+4
c138a28 wallet2: take ignored-by-value outputs into account in balance (Crypto City)
2023-07-06Merge pull request #8747luigi11112-7/+1
a668312 wallet: remove CLI code for non default ring sizes (Jeffro256)
2023-07-06Merge pull request #8888luigi11111-157/+59
a6639df wallet_rpc_server: dedup transfer RPC responses (jeffro256) Very special PR.
2023-06-27wallet: remove CLI code for non default ring sizesJeffro2562-7/+1
2023-06-27Merge pull request #8884luigi11111-0/+2
eeda4a8 wallet2: do not lose exception in current thread on refresh (Crypto City f868768 wallet2: fix missing exceptions from failing wallet refresh (Crypto City)
2023-06-27Merge pull request #8772luigi11111-0/+1
87e2a64 Allow option 'non-interactive' in monerod config file (almalh)
2023-06-15wallet2: fix rescanning tx via scan_txj-berman7-54/+399
- Detach & re-process txs >= lowest scan height - ensures that if a user calls scan_tx(tx1) after scanning tx2, the wallet correctly processes tx1 and tx2 - if a user provides a tx with a height higher than the wallet's last scanned height, the wallet will scan starting from that tx's height - scan_tx requires trusted daemon iff need to re-process existing txs: in addition to querying a daemon for txids, if a user provides a txid of a tx with height *lower* than any *already* scanned txs in the wallet, then the wallet will also query the daemon for all the *higher* txs as well. This is likely unexpected behavior to a caller, and so to protect a caller from revealing txid's to an untrusted daemon in an unexpected way, require the daemon be trusted.
2023-06-12wallet: respect frozen key images in multisig walletsjeffro2562-2/+40
Before this change, if a multisig peer asked you to sign a transaction with a frozen enote, the wallet will do it without any error or warning. This change makes it so that wallets will refuse to sign multisig transactions with frozen enotes. Disclaimer: This PR was generously funded by @LocalMonero.
2023-06-10wallet2: take ignored-by-value outputs into account in balanceCrypto City1-0/+4
2023-06-02wallet_rpc_server: dedup transfer RPC responsesjeffro2561-157/+59
2023-05-30wallet2: do not lose exception in current thread on refreshCrypto City1-0/+1
2023-05-30wallet2: fix missing exceptions from failing wallet refreshCrypto City1-0/+1
2023-05-27wallet2: ensure transfers and sweeps use same fee calc logicj-berman1-3/+3
Ensures both transfers and sweeps use a fee that's calculated from the tx's weight. Using different logic could theoretically enable distinguishability between the two types of txs. We don't want that.
2023-05-06fix missing <cstdint> includestobtoht1-0/+1
2023-04-25remove defunct light wallet codetobtoht6-1185/+21
2023-04-25Merge pull request #8724luigi111111-625/+24
d2a591d wallet, simplewallet: Drop support for mine-to-use RPC system (Jeffrey Ryan)
2023-04-25Merge pull request #8802luigi11111-2/+2
eb0e405 gamma picker: relax constructor requirements and test for selecting outputs from first spendable block (jeffro256)
2023-04-25Merge pull request #8798luigi11112-12/+11
f383fd3 wallet2: make m_process_pool_txs local to refresh method (jeffro256)
2023-04-25Merge pull request #8796luigi11111-0/+18
7a4a03d wallet2: do not commit transactions more than once (moneromooo-monero)
2023-04-25Merge pull request #8788luigi11111-4/+9
c61d33e wallet2: fix outdated wallet check (Crypto City)
2023-04-25wallet, simplewallet: Drop support for mine-to-use RPC systemJeffrey Ryan11-625/+24
Using post-PR wallet with pre-PR node will generate error message specific to this PR and not generic "command failed" mesages.
2023-04-25Merge pull request #8730luigi11111-2/+2
9e09093 wallet_rpc_server: allow creating more than 64 addresses at once (moneromooo-monero)
2023-04-25Merge pull request #8716luigi11112-1/+5
9c7d28b wallet2: add on_reorg callback (Crypto City)
2023-04-25Merge pull request #8698luigi111142-42/+42
5b4fea7 Copyright: Update to 2023 (mj-xmr)
2023-04-15Allow option 'non-interactive' in monerod config filealmalh1-0/+1
2023-04-02gamma picker: relax constructor requirements and test for selecting outputs ↵jeffro2561-2/+2
from first spendable block
2023-03-30wallet2: fix infinite loop in fake out selectionCrypto City2-3/+4
The gamma picker and the caller code did not quite agree on the number of rct outputs available for use - by one block - which caused an infinite loop if the picker could never pick outputs from that block but already had picked all other outputs from previous blocks. Also change the range to select from using code from UkoeHB.
2023-03-21wallet2: make m_process_pool_txs local to refresh methodjeffro2562-12/+11
2023-03-21wallet2: do not commit transactions more than oncemoneromooo-monero1-0/+18
Fixes #8793
2023-03-19wallet2: fix outdated wallet checkCrypto City1-4/+9
it was mistaking the number of forks in the fork table for the last fork, and assuming the table was including every single fork
2023-03-18Merge pull request #8076luigi11115-183/+423
c4af33e Enforce restricted # pool txs served via RPC + optimize chunked reqs (j-berman) 9752116 wallet2, RPC: Optimize RPC calls for periodic refresh from 3 down to 1 call (rbrunner7)
2023-03-07Enforce restricted # pool txs served via RPC + optimize chunked reqsj-berman5-94/+135
- `/getblocks.bin` respects the `RESTRICTED_TX_COUNT` (=100) when returning pool txs via a restricted RPC daemon. - A restricted RPC daemon includes a max of `RESTRICTED_TX_COUNT` txs in the `added_pool_txs` field, and returns any remaining pool hashes in the `remaining_added_pool_txids` field. The client then requests the remaining txs via `/gettransactions` in chunks. - `/gettransactions` no longer does expensive no-ops for ALL pool txs if the client requests a subset of pool txs. Instead it searches for the txs the client explicitly requests. - Reset `m_pool_info_query_time` when a user: (1) rescans the chain (so the wallet re-requests the whole pool) (2) changes the daemon their wallets points to (a new daemon would have a different view of the pool) - `/getblocks.bin` respects the `req.prune` field when returning pool txs. - Pool extension fields in response to `/getblocks.bin` are optional with default 0'd values.
2023-02-28replace 'multisig()' with 'get_multisig_status()' using ↵koe7-64/+105
multisig_account_status and including '.kex_is_done' member
2023-02-03wallet_rpc_server: allow creating more than 64 addresses at oncemoneromooo-monero1-2/+2
it's too low a limit (at least one person mentioned having to call create_address in a loop due to it)
2023-01-19wallet2: add on_reorg callbackCrypto City2-1/+5
2023-01-16Copyright: Update to 2023mj-xmr42-42/+42
Co-authored-by: plowsof <plowsof@protonmail.com> extra files
2023-01-11Merge pull request #8686luigi11111-1/+2
7a3a593 common: move boost_serialization_helper.h out and cleanup includes (Jeffrey Ryan)
2023-01-09Refactored rx-slow-hash.cSChernykh1-2/+1
- Straight-forward call interface: `void rx_slow_hash(const char *seedhash, const void *data, size_t length, char *result_hash)` - Consensus chain seed hash is now updated by calling `rx_set_main_seedhash` whenever a block is added/removed or a reorg happens - `rx_slow_hash` will compute correct hash no matter if `rx_set_main_seedhash` was called or not (the only difference is performance) - New environment variable `MONERO_RANDOMX_FULL_MEM` to force use the full dataset for PoW verification (faster block verification) - When dataset is used for PoW verification, dataset updates don't stall other threads (verification is done in light mode then) - When mining is running, PoW checks now also use dataset for faster verification
2022-12-30wallet2, RPC: Optimize RPC calls for periodic refresh from 3 down to 1 callrbrunner72-125/+324
2022-12-22common: move boost_serialization_helper.h out and cleanup includesJeffrey Ryan1-1/+2
2022-12-01Merge pull request #8618luigi11111-0/+2
1114e7e fix(trezor-tests): fix trezor tests build, fix integrated addr test (Dusan Klinec)
2022-12-01Merge pull request #8616luigi11112-8/+4
cac5083 wallet2: fix create view-only wallet from existing wallet (j-berman)
2022-12-01Merge pull request #8610luigi11111-1/+1
97b86a0 wallet_api: take priority into account when estimating fee (selsta)
2022-11-17fix(trezor-tests): fix trezor tests build, fix integrated addr testDusan Klinec1-0/+2
- fix integrated address test, it was not testing integrated address suport - fix trezor test build as dependent classes were changed - add a friend test class for Monero::WalletImpl to support wallet api tests When using wallet_api in tests, synthetic chain is used. Without being able to set `allow_mismatched_daemon_version` in the underlying wallet, we are not able to use a synthetic chain with the tests
2022-10-28Merge pull request #8529luigi11111-1/+0
09d69b6 rpc: remove overwriting value (SerHack)
2022-10-28Merge pull request #8525luigi11111-1/+0
501db2c Wallet RPC: remove duplicate line (SerHack)
2022-10-28Merge pull request #8355luigi11113-6/+16
23fde15 wallet_rpc_server: chunk refresh to keep responding to RPC while refreshing (moneromooo-monero) 5bb2369 wallet_rpc_server: add --no-initial-sync flag for quicker network binding (moneromooo-monero)
2022-10-18wallet2: fix create view-only wallet from existing walletj-berman2-8/+4
2022-10-13wallet_api: take priority into account when estimating feeselsta1-1/+1
2022-09-26Merge pull request #8586luigi11112-3/+4
e9ce347 wallet2: fail to establish daemon cxn == 'Disconnected' cxn status (j-berman)
2022-09-26Merge pull request #8576luigi11112-4/+4
28f25c0 Second thread pool for IO (SChernykh)
2022-09-26Merge pull request #8329luigi11117-25/+31
4b0785f add an option to force-update multisig key exchange under some circumstances (koe)
2022-09-21wallet2: fail to establish daemon cxn == "Disconnected" cxn statusj-berman2-3/+4
2022-09-21add an option to force-update multisig key exchange under some circumstanceskoe7-25/+31
2022-09-20Second thread pool for IOSChernykh2-4/+4
2022-09-15Merge pull request #8556luigi11116-17/+199
b8271ab wallet2: check wallet compatibility with daemon's hard fork version (j-berman)
2022-09-15Merge pull request #8551luigi11112-8/+7
eca7f6a Fix segfault restoring encrypted multisig seed (j-berman) f713c3c Require user ack multisig is experimental to restore (j-berman) 564a7a3 multisig: fix #8537 seed restore (suggestions by @UkoeHB) (j-berman)
2022-09-12wallet2: check wallet compatibility with daemon's hard fork versionj-berman6-17/+199
2022-09-09Merge pull request #8554luigi11111-1/+1
76a5b54 Fix missing semi-colon in error message (j-berman)
2022-09-09Merge pull request #8513luigi11115-51/+164
959a3e6 wallet2: ensure imported outputs subaddresses are created (moneromooo-monero) a098504 wallet2: better test on whether to allow output import (moneromooo-monero) c5579ac allow exporting outputs in chunks (moneromooo-monero) 1e912ec wallet2: fixes for export/import output flow (j-berman) 692f1d4 wallet2: do not assume imported outputs must be non empty (moneromooo-monero) 67b6d6a wallet2: prevent importing outputs in a hot wallet (moneromooo-monero) d9fc666 wallet2: fix missing subaddress indices in 'light' exported outputs (moneromooo-monero)
2022-09-06Fix missing semi-colon in error messagej-berman1-1/+1
Co-authored-by: woodser <woodser@protonmail.com>
2022-09-06multisig: fix #8537 seed restore (suggestions by @UkoeHB)j-berman2-8/+7
- spend secret key is no longer the sum of multisig key shares; no need to check that is the case upon restore. - restoring a multisig wallet from multisig info means that the wallet must have already completed all setup rounds. Upon restore, set the number of rounds completed accordingly.
2022-08-24wallet2: ensure imported outputs subaddresses are createdmoneromooo-monero1-0/+4
reported by j-berman
2022-08-22Merge pull request #8450luigi11111-1/+1
600de07 wallet_rpc_server: longer timeout for stop_mining (moneromooo-monero) ac6db92 functional_tests: silence the cpu power test program (moneromooo-monero)
2022-08-22Merge pull request #8359luigi11111-0/+4
4d7f6f5 GCC: fix some unused warnings (Jeffrey Ryan)
2022-08-22rpc: remove overwriting valueSerHack1-1/+0
2022-08-21Wallet RPC: remove duplicate lineSerHack1-1/+0
2022-08-18wallet2: better test on whether to allow output importmoneromooo-monero2-6/+25
Being offline is not a good enough heuristic, so we keep track of whether the wallet ever refreshed from a daemon, which is a lot better, and probably the best we can do without manual user designation (which would break existing cold wallet setups till the user designates those wallets)
2022-08-18allow exporting outputs in chunksmoneromooo-monero5-46/+122
this will make it easier huge wallets to do so without hitting random limits (eg, max string size in node).
2022-08-16wallet2: fixes for export/import output flowj-berman2-2/+8
- only allow offline wallets to import outputs - don't import empty outputs - export subaddress indexes when exporting outputs
2022-08-16wallet2: do not assume imported outputs must be non emptymoneromooo-monero1-2/+2
2022-08-16wallet2: prevent importing outputs in a hot walletmoneromooo-monero1-0/+2
2022-08-16wallet2: fix missing subaddress indices in "light" exported outputsmoneromooo-monero2-2/+8
2022-07-21wallet_rpc_server: longer timeout for stop_miningmoneromooo-monero1-1/+1
That RPC will wait for mining to actually stop, which can be a while if randomx has just started on randomx_init_dataset. This fixes occasional failures in the mining functional test
2022-07-14Merge pull request #8433luigi11111-9/+14
db8181a wallet2: force using output distribution for ringct outs (tobtoht)
2022-07-14Merge pull request #8432luigi11112-0/+12
edcc094 derive multisig tx secret keys from an entropy source plus the tx inputs' key images (koe)
2022-07-14Merge pull request #7986luigi11111-2/+5
5770265 wallet2: keep around transaction prefix for confirmed transfers (tobtoht)
2022-07-13derive multisig tx secret keys from an entropy source plus the tx inputs' ↵koe2-0/+12
key images
2022-07-13Merge pull request #8421luigi11111-0/+2
bd1e7c5 wallet2: prevent crash when reading tx w/fewer outputs than expected (j-berman)
2022-07-13Merge pull request #8149luigi11112-95/+234
c7b2944 multisig: fix critical vulnerabilities in signing (anon)
2022-07-11GCC: fix some unused warningsJeffrey Ryan1-0/+4
hash_extra: don't test for success in `jh_hash` and `skein_hash` since its guaranteed device_ledger: move anonymous global variable apdu_verbose into .cpp file Add comments to `refreshed` method variable in wallet2
2022-07-06Merge pull request #8408luigi11111-37/+0
09a597b wallet2: don't use DNS to obtain segregation heights (tobtoht)
2022-07-06Merge pull request #8404luigi11111-26/+1
50ccc7e wallet2: remove obsolete rpc version check (tobtoht)
2022-07-06Merge pull request #8394luigi11111-1/+2
4278a3a cryptonote_basic: catch crypto api errors (moneromooo-monero)
2022-07-05Merge pull request #8388luigi11111-7/+11
04c0da2 Chunk /gettransactions to avoid hitting restricted RPC limit (tobtoht)
2022-07-05Merge pull request #8371luigi11113-7/+10
16f8e04 Remove erraneous commas (Luke Parker) da0715e Improve consistency between on_money_received and on_money_received_unconfirmed (Luke Parker)
2022-07-05wallet2: prevent crash when reading tx w/fewer outputs than expectedj-berman1-0/+2
2022-07-03Merge pull request #8356luigi11113-0/+44
de2f0d0 wallet_api: add scanTransactions function (selsta)
2022-06-30multisig: fix critical vulnerabilities in signinganon2-95/+234
2022-06-28wallet2: don't use DNS to obtain segregation heightstobtoht1-37/+0
2022-06-27Chunk /gettransactions to avoid hitting restricted RPC limittobtoht1-7/+11
2022-06-25wallet2: force using output distribution for ringct outstobtoht1-9/+14
Co-authored-by: j-berman <justinberman@protonmail.com>
2022-06-24wallet2: remove obsolete rpc version checktobtoht1-26/+1
2022-06-20cryptonote_basic: catch crypto api errorsmoneromooo-monero1-1/+2
2022-06-03wallet_rpc_server: chunk refresh to keep responding to RPC while refreshingmoneromooo-monero3-5/+11
2022-06-01Remove erraneous commasLuke Parker1-3/+3
2022-06-01Improve consistency between on_money_received and on_money_received_unconfirmedLuke Parker3-7/+10
unconfirmed solely uses a - b, and received now accepts b so it can provide more detailed logs on what occurred (printing a - b, yet with a and b).
2022-05-26Merge pull request #8331luigi11111-9/+5
fde7c96 wallet2: fix spurious reorg detection with untrusted nodes (moneromooo-monero)
2022-05-26Merge pull request #8328luigi11115-1/+48
2979474 disable multisig by default (moneromooo-monero)
2022-05-26wallet_api: add scanTransactions functionselsta3-0/+44
2022-05-25wallet_rpc_server: add --no-initial-sync flag for quicker network bindingmoneromooo-monero1-1/+5
2022-05-17disable multisig by defaultmoneromooo-monero5-1/+48
There are vulnerabilities in multisig protocol if the parties do not trust each other, and while there is a patch for it, it has not been throroughly reviewed yet, so it is felt safer to disable multisig by default for now. If all parties in a multisig setup trust each other, then it is safe to enable multisig.
2022-05-16Merge pull request #8308luigi11111-6/+1
f63f7dc wallet2: fix a couple unused variable warnings (selsta)
2022-05-15wallet2: fix spurious reorg detection with untrusted nodesmoneromooo-monero1-9/+5
When forced to deal with an untrusted node, a wallet will quantize its current height to disguise the real height to the adversary, to try and minimize the daemon's ability to distinguish returning wallets. Daemons will thus return more blocks than the wallet needs, starting from earlier in the chain. These extra blocks will be disregarded by the wallet, which had already scanned them. However, for the purposes of reorg size detection, the wallet assumes all blocks the daemon sends are different, which is only correct if the wallet hasn't been coy, which is only the case for trusted daemons (which you should use). This causes an issue when the size of this "fake reorg" is above the sanity check threshold at which the wallet refuses a reorg. To fix this, the reorg size check is moved later on, when the reorg is about to actually happen, after the wallet has checked which blocks are actually different from the ones it expects.
2022-05-13wallet2: speedup large tx construction: reserve vector memorymoneromooo-monero1-1/+7
2.8 seconds -> 2.6 seconds on a test case
2022-05-13wallet2: speedup large tx construction: batch ringdb lookupsCrypto City4-5/+58
3.3 seconds -> 2.8 seconds on a test case
2022-05-13wallet2: speedup large tx construction: batch ringdb updatesCrypto City4-5/+30
5.2 seconds -> 4.1 seconds on a test case
2022-05-13wallet2: speedup large tx construction: cache public key validitymoneromooo-monero2-28/+36
5.9 second -> 5.2 seconds on a test case
2022-05-10Merge pull request #8277luigi11111-3/+1
baee2c0 Preserve commitment format inside transactions (kayabaNerve)
2022-05-10Merge pull request #8220luigi11112-4/+8
0d6ecb1 multisig: add post-kex verification round to check that all participants have completed the multisig address (koe)
2022-05-02wallet2: fix a couple unused variable warningsselsta1-6/+1
2022-04-29multisig: add post-kex verification round to check that all participants ↵koe2-4/+8
have completed the multisig address
2022-04-25Merge pull request #8249luigi11111-1/+0
a14fdf8 Remove /include (Jeffrey)
2022-04-25Merge pull request #8178luigi11111-0/+4
5d388eb Bump ring size to 16 for v15 & remove set default in wallet cli (j-berman)
2022-04-21Preserve commitment format inside transactionsLuke Parker1-3/+1
2022-04-19Merge pull request #8254luigi11111-1/+1
9df7179 wallet2: use BP+ for cold signing (moneromooo-monero)
2022-04-18Bump ring size to 16 for v15 & remove set default in wallet clij-berman1-0/+4
2022-04-18Add view tags to outputs to reduce wallet scanning timej-berman3-136/+220
Implements view tags as proposed by @UkoeHB in MRL issue https://github.com/monero-project/research-lab/issues/73 At tx construction, the sender adds a 1-byte view tag to each output. The view tag is derived from the sender-receiver shared secret. When scanning for outputs, the receiver can check the view tag for a match, in order to reduce scanning time. When the view tag does not match, the wallet avoids the more expensive EC operations when deriving the output public key using the shared secret.
2022-04-10wallet2: use BP+ for cold signingmoneromooo-monero1-1/+1
reported by ukoehb
2022-04-10Fee changes from ArticMinemoneromooo-monero5-36/+80
https://github.com/ArticMine/Monero-Documents/blob/master/MoneroScaling2021-02.pdf with a change to use 1.7 instead of 2.0 for the max long term increase rate
2022-04-09Remove /includeJeffrey1-1/+0
* `IWallet.h` hasn't been touched since 2014, and has been replaced by `src/wallet/api/wallet2_api.h` * `INode.h` is in a similar situation with `src/p2p/net_node.h`
2022-04-06Merge pull request #8215luigi11112-3/+13
d1f1947 wallet_rpc_server: support regex for get_accounts tag (reemuru)
2022-04-06Merge pull request #8213luigi11111-6/+0
7dcfccb wallet_rpc_server: fix make_integrated_address with no payment id (moneromooo-monero)
2022-04-06Merge pull request #8197luigi111142-42/+48
da9aa1f Copyright: Update to 2022 (mj-xmr)
2022-04-06Merge pull request #8195luigi11111-4/+4
3c82958 wallet2: update stagenet rollback blocks (selsta)
2022-04-06Merge pull request #8179luigi11112-10/+167
ae0a840 wallet2: decrease the amount of data exchanged for output export (moneromooo-monero)
2022-04-05Merge pull request #7170luigi11113-39/+53
bd27deb Bulletproofs+ (SarangNoether) b7713cc Precompute initial transcript hash (SarangNoether) b535d66 Updates from security audit (SarangNoether) a0d80b1 plug bulletproofs plus into consensus (moneromooo-monero) 75bd004 ringct: a few minor optimizations from review (moneromooo-monero) a345060 ringct: port some of vtnerd's review changes from BP+ to BP (moneromooo-monero) 4c94cfe store outPk/8 in the tx for speed (moneromooo-monero) 5acdd0e bulletproofs+: some minor cleanup from vtnerd's review (moneromooo-monero)
2022-04-05Merge pull request #7153luigi11112-0/+10
354e1d9 Make the wallet name optional when locked. (Norman Moeschter)
2022-04-05store outPk/8 in the tx for speedmoneromooo-monero1-1/+3
It avoids dividing by 8 when deserializing a tx, which is a slow operation, and multiplies by 8 when verifying and extracing the amount, which is much faster as well as less frequent
2022-04-05plug bulletproofs plus into consensusmoneromooo-monero3-38/+50
2022-03-29wallet2: decrease the amount of data exchanged for output exportmoneromooo-monero2-10/+167
2022-03-18Merge pull request #8158luigi11111-0/+13
e5000a9 Balance includes unconfirmed transfers to self (woodser)
2022-03-13wallet_rpc_server: support regex for get_accounts tagreemuru2-3/+13
This commit adds a 'regexp' boolean field to the get_accounts request. The flag is set to false by default and maintains backwards compatibility. When set to true the user can search tags by regular expression filters. An additional error message was added for failed regular expression searches. Bump minor version to 25.
2022-03-11wallet_rpc_server: fix make_integrated_address with no payment idmoneromooo-monero1-6/+0
2022-03-10Make the wallet name optional when locked.Norman Moeschter2-0/+10
2022-03-04Copyright: Update to 2022mj-xmr42-42/+48
2022-03-02Merge pull request #8145luigi11112-1/+9
fb5b2b3 support authentication in monero-wallet-rpc set_daemon (woodser)
2022-03-02Merge pull request #7877luigi11117-574/+164
e08abaa multisig key exchange update and refactor (koe)
2022-03-01wallet2: update stagenet rollback blocksselsta1-4/+4