aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authormj-xmr <mjxmr@protonmail.com>2021-08-16 10:11:05 +0200
committermj-xmr <mjxmr@protonmail.com>2021-09-07 14:24:53 +0200
commiteed7e79c04354b3313445913211b429a0f488426 (patch)
tree817de4a54583035a02d548245cf5cf2a6ff40413 /src
parentMerge pull request #7893 (diff)
downloadmonero-eed7e79c04354b3313445913211b429a0f488426.tar.xz
UB: Not calling virtual method in destructor of WalletImpl
Diffstat (limited to 'src')
-rw-r--r--src/wallet/api/wallet.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/wallet/api/wallet.cpp b/src/wallet/api/wallet.cpp
index 0afbda705..989061250 100644
--- a/src/wallet/api/wallet.cpp
+++ b/src/wallet/api/wallet.cpp
@@ -450,7 +450,7 @@ WalletImpl::~WalletImpl()
LOG_PRINT_L1(__FUNCTION__);
m_wallet->callback(NULL);
// Pause refresh thread - prevents refresh from starting again
- pauseRefresh();
+ WalletImpl::pauseRefresh(); // Call the method directly (not polymorphically) to protect against UB in destructor.
// Close wallet - stores cache and stops ongoing refresh operation
close(false); // do not store wallet as part of the closing activities
// Stop refresh thread