diff options
| author | j-berman <justinberman@protonmail.com> | 2022-09-09 20:34:18 -0600 |
|---|---|---|
| committer | j-berman <justinberman@protonmail.com> | 2023-06-15 02:21:29 -0700 |
| commit | e6b86af931f16291ef0b7083d55816b38be1d3b6 (patch) | |
| tree | c98bfdbcbadab6d83401e8f2b12d423028f4abb2 /.github/workflows | |
| parent | Merge pull request #8842 (diff) | |
| download | monero-e6b86af931f16291ef0b7083d55816b38be1d3b6.tar.xz | |
wallet2: fix rescanning tx via scan_tx
- Detach & re-process txs >= lowest scan height
- ensures that if a user calls scan_tx(tx1) after scanning tx2,
the wallet correctly processes tx1 and tx2
- if a user provides a tx with a height higher than the wallet's
last scanned height, the wallet will scan starting from that tx's
height
- scan_tx requires trusted daemon iff need to re-process existing
txs: in addition to querying a daemon for txids, if a user
provides a txid of a tx with height *lower* than any *already*
scanned txs in the wallet, then the wallet will also query the
daemon for all the *higher* txs as well. This is likely
unexpected behavior to a caller, and so to protect a caller from
revealing txid's to an untrusted daemon in an unexpected way,
require the daemon be trusted.
Diffstat (limited to '.github/workflows')
| -rw-r--r-- | .github/workflows/build.yml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 801f85b7a..7aae84977 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -154,7 +154,7 @@ jobs: - name: install monero dependencies run: ${{env.APT_INSTALL_LINUX}} - name: install Python dependencies - run: pip install requests psutil monotonic zmq + run: pip install requests psutil monotonic zmq deepdiff - name: tests env: CTEST_OUTPUT_ON_FAILURE: ON |