diff options
| author | jeff <jeffro256@tutanota.com> | 2023-09-21 22:33:00 -0500 |
|---|---|---|
| committer | jeff <jeffro256@tutanota.com> | 2023-09-21 22:42:16 -0500 |
| commit | 9f981ac2190461cb34b15876b8a5d1ccf47b274b (patch) | |
| tree | e8ac840dc7ab7f6903863ae66c4524e2aa25aa82 /.gitattributes | |
| parent | Merge pull request #8976 (diff) | |
| download | monero-9f981ac2190461cb34b15876b8a5d1ccf47b274b.tar.xz | |
wallet: store watch-only wallet correctly when `change_password()` is called
The Monero GUI code was calling `Monero::wallet::setPassword()` on every open/close for some reason,
and the old `store_to()` code called `store_keys()` with `watch_only=false`, even for watch-only wallets.
This caused a bug where the watch-only keys file got saved with with the JSON field `watch_only` set to 0,
and after saving a watch-only wallet once, a user could never open it back up against because `load()` errored out.
This never got brought up before this because you would have to change the file location of the watch-only
wallet to see this bug, and I guess that didn't happen often, but calling the new `store_to()` function with the
new `force_rewrite` parameter set to `true` triggers key restoring and the bug appeared.
Diffstat (limited to '.gitattributes')
0 files changed, 0 insertions, 0 deletions