aboutsummaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorLasse Collin <lasse.collin@tukaani.org>2022-09-09 13:51:57 +0300
committerLasse Collin <lasse.collin@tukaani.org>2022-09-09 13:51:57 +0300
commitf8ee61e74eb40600445fdb601c374d582e1e9c8a (patch)
tree7f2d7b0545b4824a91b3947b220b77987c791ba3 /tests
parentliblzma: lzma_index_append: Add missing integer overflow check. (diff)
downloadxz-f8ee61e74eb40600445fdb601c374d582e1e9c8a.tar.xz
liblzma: lzma_filters_copy: Keep dest[] unmodified if an error occurs.
lzma_stream_encoder() and lzma_stream_encoder_mt() always assumed this. Before this patch, failing lzma_filters_copy() could result in free(invalid_pointer) or invalid memory reads in stream_encoder.c or stream_encoder_mt.c. To trigger this, allocating memory for a filter options structure has to fail. These are tiny allocations so in practice they very rarely fail. Certain badness in the filter chain array could also make lzma_filters_copy() fail but both stream_encoder.c and stream_encoder_mt.c validate the filter chain before trying to copy it, so the crash cannot occur this way.
Diffstat (limited to 'tests')
0 files changed, 0 insertions, 0 deletions