diff options
| author | Lasse Collin <lasse.collin@tukaani.org> | 2008-12-31 00:30:49 +0200 |
|---|---|---|
| committer | Lasse Collin <lasse.collin@tukaani.org> | 2008-12-31 00:30:49 +0200 |
| commit | 7ed9d943b31d3ee9c5fb2387e84a241ba33afe90 (patch) | |
| tree | 5f9107c718aa996be6850b431ba319584064c9d7 /tests | |
| parent | Use 28 MiB as memory usage limit for encoding in test_compress.sh. (diff) | |
| download | xz-7ed9d943b31d3ee9c5fb2387e84a241ba33afe90.tar.xz | |
Remove lzma_init() and other init functions from liblzma API.
Half of developers were already forgetting to use these
functions, which could have caused total breakage in some future
liblzma version or even now if --enable-small was used. Now
liblzma uses pthread_once() to do the initializations unless
it has been built with --disable-threads which make these
initializations thread-unsafe.
When --enable-small isn't used, liblzma currently gets needlessly
linked against libpthread (on systems that have it). While it is
stupid for now, liblzma will need threads in future anyway, so
this stupidity will be temporary only.
When --enable-small is used, different code CRC32 and CRC64 is
now used than without --enable-small. This made the resulting
binary slightly smaller, but the main reason was to clean it up
and to handle the lack of lzma_init_check().
The pkg-config file lzma.pc was renamed to liblzma.pc. I'm not
sure if it works correctly and portably for static linking
(Libs.private includes -pthread or other operating system
specific flags). Hopefully someone complains if it is bad.
lzma_rc_prices[] is now included as a precomputed array even
with --enable-small. It's just 128 bytes now that it uses uint8_t
instead of uint32_t. Smaller array seemed to be at least as fast
as the more bloated uint32_t array on x86; hopefully it's not bad
on other architectures.
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/test_block_header.c | 1 | ||||
| -rw-r--r-- | tests/test_check.c | 2 | ||||
| -rw-r--r-- | tests/test_filter_flags.c | 2 | ||||
| -rw-r--r-- | tests/test_index.c | 2 | ||||
| -rw-r--r-- | tests/test_stream_flags.c | 2 | ||||
| -rw-r--r-- | tests/tests.h | 2 |
6 files changed, 1 insertions, 10 deletions
diff --git a/tests/test_block_header.c b/tests/test_block_header.c index 5c0f8b9a..2fb22a5a 100644 --- a/tests/test_block_header.c +++ b/tests/test_block_header.c @@ -237,7 +237,6 @@ test3(void) int main(void) { - lzma_init(); succeed(lzma_lzma_preset(&opt_lzma, 1)); test1(); diff --git a/tests/test_check.c b/tests/test_check.c index 40715c6a..cb6b8ec1 100644 --- a/tests/test_check.c +++ b/tests/test_check.c @@ -81,8 +81,6 @@ test_crc64(void) int main(void) { - lzma_init_check(); - bool error = false; error |= test_crc32(); diff --git a/tests/test_filter_flags.c b/tests/test_filter_flags.c index 490864f8..dd4f56ac 100644 --- a/tests/test_filter_flags.c +++ b/tests/test_filter_flags.c @@ -269,8 +269,6 @@ test_lzma(void) int main(void) { - lzma_init(); - #if defined(HAVE_ENCODER_SUBBLOCK) && defined(HAVE_DECODER_SUBBLOCK) test_subblock(); #endif diff --git a/tests/test_index.c b/tests/test_index.c index 46e1d871..8a2cb266 100644 --- a/tests/test_index.c +++ b/tests/test_index.c @@ -489,8 +489,6 @@ test_corrupt(void) int main(void) { - lzma_init(); - test_equal(); test_overflow(); diff --git a/tests/test_stream_flags.c b/tests/test_stream_flags.c index 2ff216db..a82a20b5 100644 --- a/tests/test_stream_flags.c +++ b/tests/test_stream_flags.c @@ -171,8 +171,6 @@ test_decode_invalid(void) int main(void) { - lzma_init(); - // Valid headers known_flags.backward_size = 1024; for (lzma_check check = LZMA_CHECK_NONE; diff --git a/tests/tests.h b/tests/tests.h index 49994727..7b7b3d40 100644 --- a/tests/tests.h +++ b/tests/tests.h @@ -38,7 +38,7 @@ static inline const char * lzma_ret_sym(lzma_ret ret) { - if ((unsigned)(ret) > LZMA_PROG_ERROR) + if ((unsigned int)(ret) > LZMA_PROG_ERROR) return "UNKNOWN_ERROR"; static const char *msgs[] = { |