diff options
author | Jia Tan <jiat0218@gmail.com> | 2023-12-06 18:30:25 +0800 |
---|---|---|
committer | Jia Tan <jiat0218@gmail.com> | 2023-12-07 20:06:57 +0800 |
commit | ee2f48350099201694a7586e41d7aa2f09fc74da (patch) | |
tree | 35ce97c6b55eeda46cb843195c176a400f6b63a5 /tests/ossfuzz/fuzz_decode_alone.c | |
parent | Tests: Add fuzz_encode_stream ossfuzz target. (diff) | |
download | xz-ee2f48350099201694a7586e41d7aa2f09fc74da.tar.xz |
Tests: Minor cleanups to OSS-Fuzz files.
Most of these fixes are small typos and tweaks. A few were caused by bad
advice from me. Here is the summary of what is changed:
- Author line edits
- Small comment changes/additions
- Using the return value in the error messages in the fuzz targets'
coder initialization code
- Removed fuzz_encode_stream.options. This set a max length, which may
prevent some worthwhile code paths from being properly exercised.
- Removed the max_len option from fuzz_decode_stream.options for the
same reason as fuzz_encode_stream. The alone decoder fuzz target still
has this restriction.
- Altered the dictionary contents for fuzz_lzma.dict. Instead of keeping
the properties static and varying the dictionary size, the properties
are varied and the dictionary size is kept small. The dictionary size
doesn't have much impact on the code paths but the properties do.
Closes: https://github.com/tukaani-project/xz/pull/73
Diffstat (limited to '')
-rw-r--r-- | tests/ossfuzz/fuzz_decode_alone.c | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/tests/ossfuzz/fuzz_decode_alone.c b/tests/ossfuzz/fuzz_decode_alone.c index d07874bc..2fb7bc09 100644 --- a/tests/ossfuzz/fuzz_decode_alone.c +++ b/tests/ossfuzz/fuzz_decode_alone.c @@ -1,11 +1,10 @@ /////////////////////////////////////////////////////////////////////////////// // -/// \file fuzz_decode_auto.c -/// \brief Fuzz test program for liblzma lzma_auto_decoder() +/// \file fuzz_decode_alone.c +/// \brief Fuzz test program for liblzma .lzma decoding // -// Author: Maksym Vatsyk -// -// Based on Lasse Collin's original fuzzer for liblzma +// Authors: Maksym Vatsyk +// Lasse Collin // // This file has been put into the public domain. // You can do whatever you want with this file. @@ -25,11 +24,13 @@ LLVMFuzzerTestOneInput(const uint8_t *inbuf, size_t inbuf_size) lzma_stream strm = LZMA_STREAM_INIT; // Initialize a LZMA alone decoder using the memory usage limit // defined in fuzz_common.h - if (lzma_alone_decoder(&strm, MEM_LIMIT) != LZMA_OK) { + lzma_ret ret = lzma_alone_decoder(&strm, MEM_LIMIT); + + if (ret != LZMA_OK) { // This should never happen unless the system has // no free memory or address space to allow the small // allocations that the initialization requires. - fprintf(stderr, "lzma_alone_decoder() failed\n"); + fprintf(stderr, "lzma_alone_decoder() failed (%d)\n", ret); abort(); } |