diff options
author | Lasse Collin <lasse.collin@tukaani.org> | 2023-09-11 18:53:31 +0300 |
---|---|---|
committer | Lasse Collin <lasse.collin@tukaani.org> | 2023-09-22 20:06:27 +0300 |
commit | 18a66fbac031c98f9c2077fc88846e4d07849197 (patch) | |
tree | f348bae228b00567059a3533c38b5d11978fd9d5 /src/xz | |
parent | Build: Omit -Wc99-c11-compat since it warns about _Noreturn. (diff) | |
download | xz-18a66fbac031c98f9c2077fc88846e4d07849197.tar.xz |
Remove incorrect uses of __attribute__((__malloc__)).
xrealloc() is obviously incorrect, modern GCC docs even
mention realloc() as an example where this attribute
cannot be used.
liblzma's lzma_alloc() and lzma_alloc_zero() would be
correct uses most of the time but custom allocators
may use a memory pool or otherwise hold the pointer
so aliasing issues could happen in theory.
The xstrdup() case likely was correct but I removed it anyway.
Now there are no __malloc__ attributes left in the code.
The allocations aren't in hot paths so this should make
no practical difference.
Diffstat (limited to '')
-rw-r--r-- | src/xz/util.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/xz/util.h b/src/xz/util.h index 4a536f52..3fac8961 100644 --- a/src/xz/util.h +++ b/src/xz/util.h @@ -20,11 +20,11 @@ /// \brief Safe realloc() that never returns NULL extern void *xrealloc(void *ptr, size_t size) - lzma_attribute((__malloc__)) lzma_attr_alloc_size(2); + lzma_attr_alloc_size(2); /// \brief Safe strdup() that never returns NULL -extern char *xstrdup(const char *src) lzma_attribute((__malloc__)); +extern char *xstrdup(const char *src); /// \brief Fancy version of strtoull() |