diff options
| author | Lasse Collin <lasse.collin@tukaani.org> | 2023-01-06 22:53:38 +0200 |
|---|---|---|
| committer | Jia Tan <jiat0218@gmail.com> | 2023-01-09 20:35:20 +0800 |
| commit | 0c210ca7f489e971e94e1ddc72b0b0806e3c7935 (patch) | |
| tree | e788812643eb868420235de1d781b28c64a9289f /src/common/tuklib_gettext.h | |
| parent | Tests: Refactors existing filter flags tests. (diff) | |
| download | xz-0c210ca7f489e971e94e1ddc72b0b0806e3c7935.tar.xz | |
Tests: test_filter_flags: Clean up minor issues.
Here are the list of the most significant issues addressed:
- Avoid using internal common.h header. It's not good to copy the
constants like this but common.h cannot be included for use outside
of liblzma. This is the quickest thing to do that could be fixed later.
- Omit the INIT_FILTER macro. Initialization should be done with just
regular designated initializers.
- Use start_offset = 257 for BCJ tests. It demonstrates that Filter
Flags encoder and decoder don't validate the options thoroughly.
257 is valid only for the x86 filter. This is a bit silly but
not a significant problem in practice because the encoder and
decoder initialization functions will catch bad alignment still.
Perhaps this should be fixed but it's not urgent and doesn't need
to be in 5.4.x.
- Various tweaks to comments such as filter id -> Filter ID
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions