diff options
author | Lasse Collin <lasse.collin@tukaani.org> | 2021-01-11 22:01:51 +0200 |
---|---|---|
committer | Lasse Collin <lasse.collin@tukaani.org> | 2021-01-11 22:58:58 +0200 |
commit | 194029ffaf74282a81f0c299c07f73caca3232ca (patch) | |
tree | c63229f664132123b8b3cf4eea0b76bd948110b1 /TODO | |
parent | liblzma: Make lzma_outq usable for threaded decompression too. (diff) | |
download | xz-194029ffaf74282a81f0c299c07f73caca3232ca.tar.xz |
Scripts: Fix exit status of xzdiff/xzcmp.
This is a minor fix since this affects only the situation when
the files differ and the exit status is something else than 0.
In such case there could be SIGPIPE from a decompression tool
and that would result in exit status of 2 from xzdiff/xzcmp
while the correct behavior would be to return 1 or whatever
else diff or cmp may have returned.
This commit omits the -q option from xz/gzip/bzip2/lzop arguments.
I'm not sure why the -q was used in the first place, perhaps it
hides warnings in some situation that I cannot see at the moment.
Hopefully the removal won't introduce a new bug.
With gzip the -q option was harmful because it made gzip return 2
instead of >= 128 with SIGPIPE. Ignoring exit status 2 (warning
from gzip) isn't practical because bzip2 uses exit status 2 to
indicate corrupt input file. It's better if SIGPIPE results in
exit status >= 128.
With bzip2 the removal of -q seems to be good because with -q
it prints nothing if input is corrupt. The other tools aren't
silent in this situation even with -q. On the other hand, if
zstd support is added, it will need -q since otherwise it's
noisy in normal situations.
Thanks to Étienne Mollier and Sebastian Andrzej Siewior.
Diffstat (limited to 'TODO')
0 files changed, 0 insertions, 0 deletions