diff options
| author | Alexander Bluhm <alexander.bluhm@gmx.net> | 2021-10-05 23:33:16 +0200 |
|---|---|---|
| committer | Lasse Collin <lasse.collin@tukaani.org> | 2022-07-12 19:01:09 +0300 |
| commit | 906b990b151b93750958371e39ad00e8d1daada9 (patch) | |
| tree | 0230a9f91ab557bf9bf65b8d3da6ed91b996c58b | |
| parent | Update THANKS. (diff) | |
| download | xz-906b990b151b93750958371e39ad00e8d1daada9.tar.xz | |
xz: Avoid fchown(2) failure.
OpenBSD does not allow to change the group of a file if the user
does not belong to this group. In contrast to Linux, OpenBSD also
fails if the new group is the same as the old one. Do not call
fchown(2) in this case, it would change nothing anyway.
This fixes an issue with Perl Alien::Build module.
https://github.com/PerlAlien/Alien-Build/issues/62
| -rw-r--r-- | src/xz/file_io.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/src/xz/file_io.c b/src/xz/file_io.c index 0ba8db8f..676508dc 100644 --- a/src/xz/file_io.c +++ b/src/xz/file_io.c @@ -368,7 +368,13 @@ io_copy_attrs(const file_pair *pair) mode_t mode; - if (fchown(pair->dest_fd, (uid_t)(-1), pair->src_st.st_gid)) { + // With BSD semantics the new dest file may have a group that + // does not belong to the user. If the src file has the same gid + // nothing has to be done. Nevertheless OpenBSD fchown(2) fails + // in this case which seems to be POSIX compliant. As there is + // nothing to do, skip the system call. + if (pair->dest_st.st_gid != pair->src_st.st_gid && + fchown(pair->dest_fd, (uid_t)(-1), pair->src_st.st_gid)) { message_warning(_("%s: Cannot set the file group: %s"), pair->dest_name, strerror(errno)); // We can still safely copy some additional permissions: |