aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJia Tan <jiat0218@gmail.com>2022-09-21 16:15:50 +0800
committerLasse Collin <lasse.collin@tukaani.org>2022-09-29 16:54:39 +0300
commit166431e9951613481b8136f52b570d7bc30b5a03 (patch)
treee468452e14e886f5a4675122abd2d2fee8aceee1
parentTests: Create a test for the lzma_index_cat bug. (diff)
downloadxz-166431e9951613481b8136f52b570d7bc30b5a03.tar.xz
liblzma: Add dest and src NULL checks to lzma_index_cat.
The documentation states LZMA_PROG_ERROR can be returned from lzma_index_cat. Previously, lzma_index_cat could not return LZMA_PROG_ERROR. Now, the validation is similar to lzma_index_append, which does a NULL check on the index parameter.
-rw-r--r--src/liblzma/common/index.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/liblzma/common/index.c b/src/liblzma/common/index.c
index e0b14a3d..24ec3c10 100644
--- a/src/liblzma/common/index.c
+++ b/src/liblzma/common/index.c
@@ -771,6 +771,9 @@ extern LZMA_API(lzma_ret)
lzma_index_cat(lzma_index *restrict dest, lzma_index *restrict src,
const lzma_allocator *allocator)
{
+ if (dest == NULL || src == NULL)
+ return LZMA_PROG_ERROR;
+
const lzma_vli dest_file_size = lzma_index_file_size(dest);
// Check that we don't exceed the file size limits.