aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLasse Collin <lasse.collin@tukaani.org>2022-02-22 02:04:18 +0200
committerLasse Collin <lasse.collin@tukaani.org>2022-02-22 02:04:18 +0200
commit4f78f5fcf63592f2d77e921cfe0d5de300867374 (patch)
tree66b277211e1ff34d00546ab75d03bc766329122f
parentUpdate THANKS. (diff)
downloadxz-4f78f5fcf63592f2d77e921cfe0d5de300867374.tar.xz
liblzma: Check the return value of lzma_index_append() in threaded encoder.
If lzma_index_append() failed (most likely memory allocation failure) it could have gone unnoticed and the resulting .xz file would have an incorrect Index. Decompressing such a file would produce the correct uncompressed data but then an error would occur when verifying the Index field.
-rw-r--r--src/liblzma/common/stream_encoder_mt.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/src/liblzma/common/stream_encoder_mt.c b/src/liblzma/common/stream_encoder_mt.c
index 91cda998..24addd40 100644
--- a/src/liblzma/common/stream_encoder_mt.c
+++ b/src/liblzma/common/stream_encoder_mt.c
@@ -732,6 +732,10 @@ stream_encode_mt(void *coder_ptr, const lzma_allocator *allocator,
ret = lzma_index_append(coder->index,
allocator, unpadded_size,
uncompressed_size);
+ if (ret != LZMA_OK) {
+ threads_stop(coder, false);
+ return ret;
+ }
// If we didn't fill the output buffer yet,
// try to read more data. Maybe the next
@@ -741,8 +745,7 @@ stream_encode_mt(void *coder_ptr, const lzma_allocator *allocator,
}
if (ret != LZMA_OK) {
- // coder->thread_error was set or
- // lzma_index_append() failed.
+ // coder->thread_error was set.
threads_stop(coder, false);
return ret;
}