aboutsummaryrefslogtreecommitdiff
path: root/socket.c
diff options
context:
space:
mode:
authorDavid Sommerseth <dazo@users.sourceforge.net>2010-02-18 21:20:14 +0100
committerDavid Sommerseth <dazo@users.sourceforge.net>2010-02-18 21:22:24 +0100
commit4880739c17b502d00a9ec45c6f6dd3e8bbff057f (patch)
tree6eca331aba41e1264ffcc49ac98fc507c2fe61a7 /socket.c
parentAdded mapping files from SVN commit ID to more descriptive commit IDs. (diff)
downloadopenvpn-4880739c17b502d00a9ec45c6f6dd3e8bbff057f.tar.xz
Do not randomize resolving of IP addresses in getaddr()
Based on a discussion on the mailing list and in the IRC meeting Feb 18, it was decided to remove get_random() from the getaddr() function as that can conflict with round-robin/randomization done by DNS servers. This change must be documented in the release notes. Signed-off-by: David Sommerseth <dazo@users.sourceforge.net>
Diffstat (limited to 'socket.c')
-rw-r--r--socket.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/socket.c b/socket.c
index fecc398..e42ccb9 100644
--- a/socket.c
+++ b/socket.c
@@ -212,12 +212,11 @@ getaddr (unsigned int flags,
++n;
ASSERT (n >= 2);
- msg (D_RESOLVE_ERRORS, "RESOLVE: NOTE: %s resolves to %d addresses, choosing one by random",
+ msg (D_RESOLVE_ERRORS, "RESOLVE: NOTE: %s resolves to %d addresses, choosing the first resolved IP address",
hostname,
n);
- /* choose address randomly, for basic load-balancing capability */
- ia.s_addr = *(in_addr_t *) (h->h_addr_list[get_random () % n]);
+ ia.s_addr = *(in_addr_t *) (h->h_addr_list[0]);
}
}