From d099658522c6f17055a3b9977f74c6e91c6c8199 Mon Sep 17 00:00:00 2001
From: anonimal <anonimal@getmonero.org>
Date: Sat, 7 Sep 2019 00:29:09 +0000
Subject: bootstrap_daemon: resolve CID 203915 (UNCAUGHT_EXCEPT)

The issue is triggered by the captured `this` in RPC server, which
passes reference to throwable `core_rpc_server`:

`core_rpc_server.cpp:164: m_bootstrap_daemon.reset(new bootstrap_daemon([this]{ return get_random_public_node(); }));`

The solution is to simply remove noexcept from the remaining `bootstrap_daemon`
constructors because noexcept is false in this context.

>"An exception of type "boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::asio::invalid_service_owner>>" is thrown but the throw list "noexcept" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate()."
---
 src/rpc/bootstrap_daemon.cpp | 2 +-
 src/rpc/bootstrap_daemon.h   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

(limited to 'src/rpc')

diff --git a/src/rpc/bootstrap_daemon.cpp b/src/rpc/bootstrap_daemon.cpp
index 6f8426ee7..c97b2c95a 100644
--- a/src/rpc/bootstrap_daemon.cpp
+++ b/src/rpc/bootstrap_daemon.cpp
@@ -12,7 +12,7 @@
 namespace cryptonote
 {
 
-  bootstrap_daemon::bootstrap_daemon(std::function<boost::optional<std::string>()> get_next_public_node) noexcept
+  bootstrap_daemon::bootstrap_daemon(std::function<boost::optional<std::string>()> get_next_public_node)
     : m_get_next_public_node(get_next_public_node)
   {
   }
diff --git a/src/rpc/bootstrap_daemon.h b/src/rpc/bootstrap_daemon.h
index 130a6458d..6276b1b21 100644
--- a/src/rpc/bootstrap_daemon.h
+++ b/src/rpc/bootstrap_daemon.h
@@ -15,7 +15,7 @@ namespace cryptonote
   class bootstrap_daemon
   {
   public:
-    bootstrap_daemon(std::function<boost::optional<std::string>()> get_next_public_node) noexcept;
+    bootstrap_daemon(std::function<boost::optional<std::string>()> get_next_public_node);
     bootstrap_daemon(const std::string &address, const boost::optional<epee::net_utils::http::login> &credentials);
 
     std::string address() const noexcept;
-- 
cgit v1.2.3