From 1a568deacbb3bbcd65fd092fcd4c20b14ffa6a26 Mon Sep 17 00:00:00 2001 From: SChernykh Date: Thu, 8 Dec 2022 09:56:20 +0100 Subject: Cache successful `verRctNonSemanticsSimple` calls --- src/ringct/rctSigs.cpp | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) (limited to 'src/ringct/rctSigs.cpp') diff --git a/src/ringct/rctSigs.cpp b/src/ringct/rctSigs.cpp index 477a7907d..7b16f017b 100644 --- a/src/ringct/rctSigs.cpp +++ b/src/ringct/rctSigs.cpp @@ -30,6 +30,7 @@ #include "misc_log_ex.h" #include "misc_language.h" +#include "common/data_cache.h" #include "common/perf_timer.h" #include "common/threadpool.h" #include "common/util.h" @@ -1578,6 +1579,42 @@ namespace rct { } } + bool verRctNonSemanticsSimpleCached(const rctSig & rv) + { + // Hello future Monero dev! If you got this assert, read the following carefully: + // + // RCT cache assumes that this function will serialize and hash all rv's fields used for RingCT verification + // If you're about to add a new RCTType here, first you must check that binary_archive serialization writes all rv's fields to the binary blob + // If it's not the case, rewrite this function to serialize everything, even some "temporary" fields which are not serialized normally + CHECK_AND_ASSERT_MES_L1(rv.type <= RCTTypeBulletproofPlus, false, "Unknown RCT type. Make sure RCT cache works correctly with this type and then enable it in the code here."); + + // Don't cache older (or newer) rctSig types + // This cache only makes sense when it caches data from mempool first, + // so only "current fork version-enabled" RCT types need to be cached + if (rv.type != RCTTypeBulletproofPlus) + return verRctNonSemanticsSimple(rv); + + // Get the hash of rv + std::stringstream ss; + binary_archive ar(ss); + + ::do_serialize(ar, const_cast(rv)); + + crypto::hash h; + cryptonote::get_blob_hash(ss.str(), h); + + static tools::data_cache cache; + + if (cache.has(h)) + return true; + + const bool res = verRctNonSemanticsSimple(rv); + if (res) + cache.add(h); + + return res; + } + //RingCT protocol //genRct: // creates an rctSig with all data necessary to verify the rangeProofs and that the signer owns one of the -- cgit v1.2.3