From 9e64a71e7d1fd70cdf94a3b78782ad06828362b3 Mon Sep 17 00:00:00 2001
From: moneromooo-monero <moneromooo-monero@users.noreply.github.com>
Date: Wed, 5 Dec 2018 00:12:29 +0000
Subject: blockchain: call deinit in dtor

This ensures the io service that runs in another thread cannot
access data after it's deleted
---
 src/cryptonote_core/blockchain.cpp | 17 ++++++++++-------
 src/cryptonote_core/blockchain.h   |  5 +++++
 2 files changed, 15 insertions(+), 7 deletions(-)

(limited to 'src/cryptonote_core')

diff --git a/src/cryptonote_core/blockchain.cpp b/src/cryptonote_core/blockchain.cpp
index 80e0a983e..97b8f0765 100644
--- a/src/cryptonote_core/blockchain.cpp
+++ b/src/cryptonote_core/blockchain.cpp
@@ -171,6 +171,11 @@ Blockchain::Blockchain(tx_memory_pool& tx_pool) :
   LOG_PRINT_L3("Blockchain::" << __func__);
 }
 //------------------------------------------------------------------
+Blockchain::~Blockchain()
+{
+  deinit();
+}
+//------------------------------------------------------------------
 bool Blockchain::have_tx(const crypto::hash &id) const
 {
   LOG_PRINT_L3("Blockchain::" << __func__);
@@ -550,15 +555,13 @@ bool Blockchain::deinit()
   // as this should be called if handling a SIGSEGV, need to check
   // if m_db is a NULL pointer (and thus may have caused the illegal
   // memory operation), otherwise we may cause a loop.
-  if (m_db == NULL)
-  {
-    throw DB_ERROR("The db pointer is null in Blockchain, the blockchain may be corrupt!");
-  }
-
   try
   {
-    m_db->close();
-    MTRACE("Local blockchain read/write activity stopped successfully");
+    if (m_db)
+    {
+      m_db->close();
+      MTRACE("Local blockchain read/write activity stopped successfully");
+    }
   }
   catch (const std::exception& e)
   {
diff --git a/src/cryptonote_core/blockchain.h b/src/cryptonote_core/blockchain.h
index dfe833fb4..835e5addc 100644
--- a/src/cryptonote_core/blockchain.h
+++ b/src/cryptonote_core/blockchain.h
@@ -120,6 +120,11 @@ namespace cryptonote
      */
     Blockchain(tx_memory_pool& tx_pool);
 
+    /**
+     * @brief Blockchain destructor
+     */
+    ~Blockchain();
+
     /**
      * @brief Initialize the Blockchain state
      *
-- 
cgit v1.2.3