From c0c75ac19d77a542abacd27796364c6518f7ae59 Mon Sep 17 00:00:00 2001 From: SChernykh Date: Tue, 8 Dec 2020 18:27:19 +0100 Subject: Fixed issues found by static analysis - rolling_median: tried to free uninitialized pointer in a constructor - net_node.inl: erase-remove idiom was used incorrectly. remove_if doesn't actually remove elements, see http://cpp.sh/6fcjv - bulletproofs.cc: call to sizeof() instead of vector.size(), luckily it only impacts performance and not code logic there --- contrib/epee/include/rolling_median.h | 1 - 1 file changed, 1 deletion(-) (limited to 'contrib/epee/include') diff --git a/contrib/epee/include/rolling_median.h b/contrib/epee/include/rolling_median.h index 088a71d3e..877814e57 100644 --- a/contrib/epee/include/rolling_median.h +++ b/contrib/epee/include/rolling_median.h @@ -141,7 +141,6 @@ public: rolling_median_t(rolling_median_t &&m) { - free(data); memcpy(this, &m, sizeof(rolling_median_t)); m.data = NULL; } -- cgit v1.2.3