From e1b526b371876d797f510f8e458d6401624bd1b1 Mon Sep 17 00:00:00 2001 From: Jean Pierre Dudey Date: Wed, 14 Mar 2018 21:56:19 -0400 Subject: Remove the `Blockchain::get_all_known_block_ids` function. This function isn't used in the codebase. Signed-off-by: Jean Pierre Dudey --- src/cryptonote_core/blockchain.cpp | 19 ------------------- src/cryptonote_core/blockchain.h | 9 --------- 2 files changed, 28 deletions(-) diff --git a/src/cryptonote_core/blockchain.cpp b/src/cryptonote_core/blockchain.cpp index d2d43490e..a0031559b 100644 --- a/src/cryptonote_core/blockchain.cpp +++ b/src/cryptonote_core/blockchain.cpp @@ -744,25 +744,6 @@ bool Blockchain::get_block_by_hash(const crypto::hash &h, block &blk, bool *orph return false; } //------------------------------------------------------------------ -//FIXME: this function does not seem to be called from anywhere, but -// if it ever is, should probably change std::list for std::vector -void Blockchain::get_all_known_block_ids(std::list &main, std::list &alt, std::list &invalid) const -{ - LOG_PRINT_L3("Blockchain::" << __func__); - CRITICAL_REGION_LOCAL(m_blockchain_lock); - - for (auto& a : m_db->get_hashes_range(0, m_db->height() - 1)) - { - main.push_back(a); - } - - for (const blocks_ext_by_hash::value_type &v: m_alternative_chains) - alt.push_back(v.first); - - for (const blocks_ext_by_hash::value_type &v: m_invalid_blocks) - invalid.push_back(v.first); -} -//------------------------------------------------------------------ // This function aggregates the cumulative difficulties and timestamps of the // last DIFFICULTY_BLOCKS_COUNT blocks and passes them to next_difficulty, // returning the result of that call. Ignores the genesis block, and can use diff --git a/src/cryptonote_core/blockchain.h b/src/cryptonote_core/blockchain.h index dd490cdd5..1a52e20bf 100644 --- a/src/cryptonote_core/blockchain.h +++ b/src/cryptonote_core/blockchain.h @@ -206,15 +206,6 @@ namespace cryptonote */ bool get_block_by_hash(const crypto::hash &h, block &blk, bool *orphan = NULL) const; - /** - * @brief get all block hashes (main chain, alt chains, and invalid blocks) - * - * @param main return-by-reference container to put result main chain blocks' hashes in - * @param alt return-by-reference container to put result alt chain blocks' hashes in - * @param invalid return-by-reference container to put result invalid blocks' hashes in - */ - void get_all_known_block_ids(std::list &main, std::list &alt, std::list &invalid) const; - /** * @brief performs some preprocessing on a group of incoming blocks to speed up verification * -- cgit v1.2.3