| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
de9c461 common: support boost filesystem copy_options. Co-authored-by: selsta <selsta@sent.at> (0xFFFC0000)
|
|
463228b Skip privacy networks (on tx sends) that don't have outgoing connections (Lee *!* Clagett)
|
|
d6609b8 serialization: do any N-tuple (jeffro256)
|
|
8e80585 functional_tests: test HTTP digest auth (jeffro256)
|
|
7194506 Blockchain: remove old fee calc logic (jeffro256)
|
|
e151ff7 update blake2b test vectors (koe)
fa47c7b add blake2b to src/crypto (koe)
|
|
9d101d5 serialization: protect blob serialization from undefined behavior (jeffro256)
|
|
ff49444 @tobtoht: undo rebase changes tx.dsts -> tx_dsts (jeffro256)
38f354e Enforce Tx unlock_time is Zero by Relay Rule (jeffro256)
|
|
4689ad2 trezor: support c++17 and protobuf v25, libusb fix (Dusan Klinec)
|
|
236e5d4 update TimingsDatabase to support csv format and incremental updating (koe)
|
|
e0b3507 tests: update block_weight for 2021 scaling (moneromooo-monero)
|
|
a46b6ba contrib: add more valgrind suppressions for spurious issues (moneromooo-monero)
7f3e31d unit_tests: fix accessing invalid memory in tree_hash test (moneromooo-monero)
|
|
8d94d08 replace 'multisig()' with 'get_multisig_status()' using multisig_account_status and including '.kex_is_done' member (koe)
|
|
Co-authored-by: selsta <selsta@sent.at>
|
|
- fix If there is no protobuf version installed, if fails
- passphrase test fix, wallet keys init was missing
|
|
|
|
|
|
|
|
Test:
1. Can't login to RPC server with --rpc-login enabled, but no auth provided
2. Can access RPC server with correct login
3. Can use internal HTTP client to access RPC server with correct login
With commit 0ae5c91e504b8007dedc2b89c9b2b49c404ffec6 not reverted, we fail test 3.
|
|
There is currently no compiler protection when someone tries to
do (for example) `BLOB_SERIALIZER(std::vector<int>)`. You just
get runtime allocation errors. This has already eaten up dev time
before, so this PR adds a static assertion that the type must be
trivially copyable, as defined by the C++ standard. Types can
override this if applicable if they use `BLOB_SERIALIZER_FORCED`.
|
|
|
|
|
|
Related to https://github.com/monero-project/research-lab/issues/78
Added a relay rule that enforces the `unlock_time` field is equal to 0 for non-coinbase transactions.
UIs changed:
* Removed `locked_transfer` and `locked_sweep_all` commands from `monero-wallet-cli`
APIs changed:
* Removed `unlock_time` parameters from `wallet2` transfer methods
* Wallet RPC transfer endpoints send error codes when requested unlock time is not 0
* Removed `unlock_time` parameters from `construct_tx*` cryptonote core functions
|
|
b1c9a80 Add <cstdint> to aligned test (Lee *!* Clagett)
|
|
cd7ccfb Disable/fix ports with I2P (Lee Clagett)
|
|
0c545f6 epee/test: remove levin_protocol_handler and core_proxy tests (jeffro256)
|
|
48b7d08 epee binary: container can read from empty seq of any type (jeffro256)
|
|
To transfer ~5 XMR to an address such that your balance drops by exactly 5 XMR, provide a `subtractfeefrom` flag to the `transfer` command. For example:
transfer 76bDHojqFYiFCCYYtzTveJ8oFtmpNp3X1TgV2oKP7rHmZyFK1RvyE4r8vsJzf7SyNohMnbKT9wbcD3XUTgsZLX8LU5JBCfm 5 subtractfeefrom=all
If my walet balance was exactly 30 XMR before this transaction, it will be exactly 25 XMR afterwards and the destination address will receive slightly
less than 5 XMR. You can manually select which destinations fund the transaction fee and which ones do not by providing the destination index.
For example:
transfer 75sr8AAr... 3 74M7W4eg... 4 7AbWqDZ6... 5 subtractfeefrom=0,2
This will drop your balance by exactly 12 XMR including fees and will spread the fee cost proportionally (3:5 ratio) over destinations with addresses
`75sr8AAr...` and `7AbWqDZ6...`, respectively.
Disclaimer: This feature was paid for by @LocalMonero.
|
|
|
|
|
|
|
|
01c6e4b OpenBSD: node server fix IP localhost by aliasing (mesaoptimizer)
|
|
eed975d Fix missing checks for IsObject in ZMQ jsonrpc reading (Lee Clagett)
|
|
53e632b fix merge mining with more than one merge mined chain (Crypto City)
|
|
a11e03a serialization: fix infinite loops and clean up dispatching (jeffro256)
|
|
|
|
The test node_server.bind_same_p2p_port fails by default on OpenBSD
for at least the debug build. Using the same ifconfig command as
described for MacOS results in the test passing.
|
|
reported by sech1
|
|
|
|
Resolves #8687
|
|
504269e unit tests: fix running from pwd and auto test selected location (jeffro256)
|
|
5443240 core_tests: fix gcc7 compilation (selsta)
|
|
30cf537 unit tests: wallet_storage: generate in 'Ascii' format test (jeffro256)
|
|
c17f73a add sp_transcript (koe) 51e40f7 add seraphis_crypto directory (koe)
|
|
|
|
|
|
1025e4f unit_test: set data dir relative to exe & add log-level arg (jeff)
|
|
8190f25 KV_SERIALIZE: remove extraneous semicolons in DSL (jeffro256)
|
|
b0bf49a blockchain_db: add k-anonymity to txid fetching (jeffro256)
|
|
c444a7e trezor: support v2.5.2+, add more trezor tests, fix chaingen and tests (Dusan Klinec)
056c996 fix chaingen tests (Dusan Klinec)
|
|
|
|
|
|
- passphrase logic: remove backward compatibility for 2.4.3, code cleanup.
- fix LibUSB cmake for static builds on OSX
- tests: all tests now work with passphrase logic enabled. Passphrase test added with different passphrase. no_passphrase test added, Trezor pin test added. Testing wallet opening with correct and incorrect passphrase. Trezor test chain revamp, cleanup. Smaller chain, chain file versioning added.
- tests: Trezor tests support TEST_MINING_ENABLED, TEST_MINING_TIMEOUT env vars to change mining-related tests behaviour.
- requires protobuf@21 on osx for now (c++14), building with unlinked protobuf: `CMAKE_PREFIX_PATH=$(find /opt/homebrew/Cellar/protobuf@21 -maxdepth 1 -type d -name "21.*" -print -quit) \
make debug-test-trezor -j8`
|
|
- fix tx create from sources, input locking. Originally, creating a synthetic transactions with chaingen could create a transaction with outputs that are still locked in the current block, thus failing chain validation by the daemon. Simple unlock check was added. Some buggy tests were fixed as well as new unlock-checking version of tx creation rejected those, fixes are simple - mostly using correct block after a rewind to construct a transaction
|
|
d4d8840 functional_tests: fix multisig tests noutputs assertion (jeffro256)
|
|
|
|
|
|
|
|
Resolves #8932 and:
2. Not storing cache when new path is different from old in `store_to()` and
3. Detecting same path when new path contains entire string of old path in `store_to()` and
4. Changing your password / decrypting your keys (in this method or others) and providing a bad original password and getting no error and
5. Changing your password and storing to a new file
|
|
The changes to the multisig tests in #8914 and #8904 affected each other, this PR cleans up the code and fixes that issue.
|
|
ffbf9f4 blockchain_and_pool: move to crytonote_core and enforce its usage (jeffro256)
d6f86e5 Avoid nullptr dereference when constructing Blockchain and tx_memory_pool (lukas)
|
|
45b52de wallet-rpc: restore from multisig seed (jeffro256)
|
|
e8cac61 core_rpc_server: return ID of submitted block (jeffro256)
|
|
6ff87ef net: tor_address: remove support for v2 onion addresses (tobtoht)
|
|
Prereq of https://github.com/monero-project/monero/pull/8867
|
|
Read more about k-anonymity [here](https://en.wikipedia.org/wiki/K-anonymity). We implement this feature in the monero daemon for transactions
by providing a "Txid Template", which is simply a txid with all but `num_matching_bits` bits zeroed out, and the number `num_matching_bits`. We add an operation to `BlockchainLMDB` called
`get_txids_loose` which takes a txid template and returns all txids in the database (chain and mempool) that satisfy that template. Thus, a client can
ask about a specific transaction from a daemon without revealing the exact transaction they are inquiring about. The client can control the statistical
chance that other TXIDs (besides the one in question) match the txid template sent to the daemon up to a power of 2. For example, if a client sets their `num_matching_bits`
to 5, then statistically any txid has a 1/(2^5) chance to match. With `num_matching_bits`=10, there is a 1/(2^10) chance, so on and so forth.
Co-authored-by: ACK-J <60232273+ACK-J@users.noreply.github.com>
|
|
|
|
369a5a8 wallet: respect frozen key images in multisig wallets (jeffro256)
|
|
ea053b6 Update tests/hash/main.cpp (0xFFFC0000)
6bae913 Tests: Add blake2b Test Cases for hash testing. * Adding blake2b test function to src/tests/hash * New files for testvector. * Adding the test to CMakeLists.txt * Adding brief documentation for the test. (0xFFFC0000)
|
|
d9c7cd5 common: do not use DNS to determine if address is local (tobtoht)
|
|
Co-authored-by: j-berman <justinberman@protonmail.com>
|
|
|
|
|
|
|
|
eb94356 Add to_hex::buffer (Lee *!* Clagett)
|
|
25a803f tests: remove unused perl scripts (tobtoht)
|
|
f7deb7d tests: remove daemon_tests (tobtoht)
|
|
2a7435e variant: add mutable unwrap and visitation (koe)
bc3cec4 add variant class with cleaner interface than boost::variant<> (koe)
|
|
5c505bd performance test framework updates: allow custom test parameters, better error reporting (koe)
|
|
- Detach & re-process txs >= lowest scan height
- ensures that if a user calls scan_tx(tx1) after scanning tx2,
the wallet correctly processes tx1 and tx2
- if a user provides a tx with a height higher than the wallet's
last scanned height, the wallet will scan starting from that tx's
height
- scan_tx requires trusted daemon iff need to re-process existing
txs: in addition to querying a daemon for txids, if a user
provides a txid of a tx with height *lower* than any *already*
scanned txs in the wallet, then the wallet will also query the
daemon for all the *higher* txs as well. This is likely
unexpected behavior to a caller, and so to protect a caller from
revealing txid's to an untrusted daemon in an unexpected way,
require the daemon be trusted.
|
|
Removing preprocessor macro and replacing it with constexpr.
Co-authored-by: Jeffro <jeffreyryan@tutanota.com>
|
|
Before this change, if a multisig peer asked you to sign a transaction with a frozen enote, the wallet will do it without any error or warning. This change makes it
so that wallets will refuse to sign multisig transactions with frozen enotes.
Disclaimer: This PR was generously funded by @LocalMonero.
|
|
* Adding blake2b test function to src/tests/hash
* New files for testvector.
* Adding the test to CMakeLists.txt
* Adding brief documentation for the test.
|
|
|
|
|
|
|
|
|
|
eb0e405 gamma picker: relax constructor requirements and test for selecting outputs from first spendable block (jeffro256)
|
|
7a4a03d wallet2: do not commit transactions more than once (moneromooo-monero)
|
|
5b4fea7 Copyright: Update to 2023 (mj-xmr)
|
|
from first spendable block
|
|
Fixes #8793
|
|
|
|
multisig_account_status and including '.kex_is_done' member
|
|
|
|
|
|
Co-authored-by: plowsof <plowsof@protonmail.com>
extra files
|
|
7a3a593 common: move boost_serialization_helper.h out and cleanup includes (Jeffrey Ryan)
|
|
8687da6 common: DNSResolver can handle hostnames without dot characters (Jeffrey Ryan)
|
|
faaf2af p2p: fix exclusive node DNS resolution for certain hosts (Jeffrey Ryan)
|
|
|
|
error reporting
|
|
a7bf3af Fix dandelion++ fluff/stem bug with local txes (Lee Clagett)
|
|
1114e7e fix(trezor-tests): fix trezor tests build, fix integrated addr test (Dusan Klinec)
|
|
50b7492 unit_tests: suppress memwipe unit warning (Jeffrey Ryan)
|
|
Unrelated, but similar code-wise to #8643. There is a check in `DNSResolver` which automatically fails to resolve hostnames which do not contain the `.` character. This PR removes that check.
|
|
Fixes #8633. The function `append_net_address` did not parse hostname + port addresses (e.g. `bar:29080`) correctly if the hostname did not contain a `'.'` character.
@vtnerd comments 1
clear up 2nd conditional statement
|
|
- fix integrated address test, it was not testing integrated address suport
- fix trezor test build as dependent classes were changed
- add a friend test class for Monero::WalletImpl to support wallet api tests
When using wallet_api in tests, synthetic chain is used. Without being able to set `allow_mismatched_daemon_version` in the underlying wallet, we are not able to use a synthetic chain with the tests
|
|
|
|
8e7c7af Move update_checkpoints() to a later stage (SChernykh)
|
|
28f25c0 Second thread pool for IO (SChernykh)
|
|
4b0785f add an option to force-update multisig key exchange under some circumstances (koe)
|
|
update_checkpoints() makes a few DNS requests and can take up to 20-30 seconds to complete (3-6 seconds on average). It is currently called from core::handle_incoming_block() which holds m_incoming_tx_lock, so it blocks all incoming transactions and blocks processing while update_checkpoints() is running. This PR moves it to until after a new block has been processed and relayed, to avoid full monerod locking.
|
|
|
|
|
|
Fixes warning:
```
warning: ‘*(uint32_t*)quux’ may be used uninitialized [-Wmaybe-uninitialized]
49 | MDEBUG(std::hex << std::setw(8) << std::setfill('0') << *(uint32_t*)quux);
warning: ‘quux’ may be used uninitialized [-Wmaybe-uninitialized]
50 | if (wipe) { ASSERT_TRUE(memcmp(quux, "bar", 3)); }
```
|
|
b8271ab wallet2: check wallet compatibility with daemon's hard fork version (j-berman)
|
|
eca7f6a Fix segfault restoring encrypted multisig seed (j-berman)
f713c3c Require user ack multisig is experimental to restore (j-berman)
564a7a3 multisig: fix #8537 seed restore (suggestions by @UkoeHB) (j-berman)
|
|
|
|
3987827 Fix shared_ptr cycle in test_epee_connection.test_lifetime (Lee Clagett)
|
|
959a3e6 wallet2: ensure imported outputs subaddresses are created (moneromooo-monero)
a098504 wallet2: better test on whether to allow output import (moneromooo-monero)
c5579ac allow exporting outputs in chunks (moneromooo-monero)
1e912ec wallet2: fixes for export/import output flow (j-berman)
692f1d4 wallet2: do not assume imported outputs must be non empty (moneromooo-monero)
67b6d6a wallet2: prevent importing outputs in a hot wallet (moneromooo-monero)
d9fc666 wallet2: fix missing subaddress indices in 'light' exported outputs (moneromooo-monero)
|
|
- spend secret key is no longer the sum of multisig key shares;
no need to check that is the case upon restore.
- restoring a multisig wallet from multisig info means that the
wallet must have already completed all setup rounds. Upon restore,
set the number of rounds completed accordingly.
|
|
|
|
600de07 wallet_rpc_server: longer timeout for stop_mining (moneromooo-monero)
ac6db92 functional_tests: silence the cpu power test program (moneromooo-monero)
|
|
1fc60ca Publish submitted txs via zmq (j-berman)
|
|
a0df140 feat(trezor): add HF15 support, BP+ (Dusan Klinec)
|
|
Being offline is not a good enough heuristic, so we keep track
of whether the wallet ever refreshed from a daemon, which is a
lot better, and probably the best we can do without manual user
designation (which would break existing cold wallet setups till
the user designates those wallets)
|
|
this will make it easier huge wallets to do so without hitting
random limits (eg, max string size in node).
|
|
- only allow offline wallets to import outputs
- don't import empty outputs
- export subaddress indexes when exporting outputs
|
|
the test was still performed with consensus rules from before
that change
|
|
|
|
it's very spammy and drowns the test output
|
|
a82fba4 address PR comments (j-berman)
3be1dbd connection: fix implementation (anon)
724ff21 connection: add segfault and deadlocks demo (anon)
|
|
key images
|
|
|
|
|
|
|
|
|
|
- BP+ support added for Trezor
- old Trezor firmware version support removed, code cleanup
|
|
08080df unit_tests: add more sha256sum test cases (Jeffrey Ryan)
a66a52d common: update sha256sum to use OpenSSL 3.0 API (Jeffrey Ryan)
|
|
2dab31f Don't exclusively drop tor/i2p outgoing cxns in idle loop (j-berman)
|
|
|
|
|
|
There are vulnerabilities in multisig protocol if the parties do not
trust each other, and while there is a patch for it, it has not been
throroughly reviewed yet, so it is felt safer to disable multisig by
default for now.
If all parties in a multisig setup trust each other, then it is safe
to enable multisig.
|
|
0226df9 More tests for view tags (SChernykh)
|
|
41da2fe Update copyright to 2022 for Hardfork files (Akrit)
|
|
baee2c0 Preserve commitment format inside transactions (kayabaNerve)
|
|
0d6ecb1 multisig: add post-kex verification round to check that all participants have completed the multisig address (koe)
|
|
P2Pool can create transactions with more than 128 outputs, which make output_index's varint larger than 1 byte. Added this test case.
|
|
have completed the multisig address
|
|
Update Makefile and LICENSE
|
|
5d388eb Bump ring size to 16 for v15 & remove set default in wallet cli (j-berman)
|
|
|
|
ea87b30 Add view tags to outputs to reduce wallet scanning time (j-berman)
|
|
|
|
|
|
Implements view tags as proposed by @UkoeHB in MRL issue
https://github.com/monero-project/research-lab/issues/73
At tx construction, the sender adds a 1-byte view tag to each
output. The view tag is derived from the sender-receiver
shared secret. When scanning for outputs, the receiver can
check the view tag for a match, in order to reduce scanning
time. When the view tag does not match, the wallet avoids the
more expensive EC operations when deriving the output public
key using the shared secret.
|
|
https://github.com/ArticMine/Monero-Documents/blob/master/MoneroScaling2021-02.pdf
with a change to use 1.7 instead of 2.0 for the max long term increase rate
|
|
|
|
The integrated address functional test fails in the workflows due
to an assertion for missing payment id that is no longer needed.
Remove the assertion and update the assertion count.
Fixes 7dcfccb: ("wallet_rpc_server: fix make_integrated_address with no payment id")
|
|
1ce9e9c Remove dead code from parserse_base_utils and fix unit tests (Jeffrey)
|
|
0d6fce8 Compil. time: cryptonote_core minus portable_storage header (mj-xmr)
|
|
da9aa1f Copyright: Update to 2022 (mj-xmr)
|
|
It avoids dividing by 8 when deserializing a tx, which is a slow
operation, and multiplies by 8 when verifying and extracing the
amount, which is much faster as well as less frequent
|
|
|
|
|
|
* Remove `match_string()`, `match_number()`, and `match_word()`
* Remove `match_word_with_extrasymb()` and `match_word_til_equal_mark()`
* Adapt unit test for `match_number()` to `match_number2()`
* Adapt unit test for `match_string()` to `match_string2()`
Note: the unit tests were testing for the old version of the functions, and
the interfaces for these functions changed slightly, so I had to also edit
the tests.
As of writing, this PR has no merge conflicts with #8211
Additional changes during review:
* Explicitly set up is_[float/signed]_val to be changed before each call
* Structify the tests and fix uninitialized variables
|
|
e5000a9 Balance includes unconfirmed transfers to self (woodser)
|
|
|
|
|
|
c36ea26 fix ge_p3_is_point_at_infinity(), which is evaluating field elements that haven't been reduced by the field order (koe)
|
|
e08abaa multisig key exchange update and refactor (koe)
|
|
|
|
|
|
haven't been reduced by the field order
|
|
|
|
avoids mining txes after a fork that are invalid by this fork's
rules, but were valid by the previous fork rules at the time
they were verified and added to the txpool.
|
|
9154883 node_server: fix race condition (anon)
8922f96 node_server: add race condition demo (anon)
|
|
5eaedb5 unit_tests: fix use after free in serialization test (moneromooo-monero)
|
|
|
|
|
|
|
|
573a025 core_tests: remove unused typedef, fix warning (selsta)
|
|
b2c59af EasyLogging++: new anti-UB test and propagating exception (mj-xmr)
|
|
|
|
|
|
9c8e3e8 unit_tests: fix broken tests (anon)
|
|
7354ffb p2p: remove blocked addresses/hosts from peerlist (moneromooo-monero)
|
|
|
|
|
|
boosted_tcp_server: check condition before sleep too
cryptonote_protocol_handler: each instance of BlockchainLMDB requires separate thread due to private thread local fields
|
|
|
|
CID 1446559
|
|
08e4497 Improve cryptonote (block and tx) binary read performance (Lee Clagett)
|
|
3450f4b Doc: funtional_tests add new mining env vars and how to use them (mj-xmr)
|
|
b40129e Warnings: unused var in core_tests:chaingen.h (mj-xmr)
|
|
|
|
cbd54ea cmake: set 3.5 as minimum version (selsta)
|
|
3cc4428 clang: fix -Wpessimizing-move warning (selsta)
|
|
451b5a5 clang: fix -Wrange-loop-analysis warnings (selsta)
|
