Age | Commit message (Collapse) | Author | Files | Lines |
|
Coverity 184940
|
|
It seems the more prudent thing to do here. It will not catch
attempts to use that value before it is initialized when using
ASAN or valgrind, but in a case where it does, it will have
smaller repercussions.
So it seems appropriate in this particular case.
Coverity 182498
|
|
0aff4987 rpc: fix build with older compilers (moneromooo-monero)
|
|
3bb4b0d4 miner: fix build with boost 1.69 (moneromooo-monero)
|
|
62f94e1b device_io_hid.cpp: fix copyright header (moneromooo-monero)
|
|
3ffbec15 rpc: init m_rpc_version in Message ctor (moneromooo-monero)
bfa2dce1 rpc: remove unused ctors (moneromooo-monero)
7cc39845 account: init creation timestamp to 0 (moneromooo-monero)
32123789 wallet2: initialize some scalar fields in ctor where appropriate (moneromooo-monero)
4eca42b2 blockchain_db: initialize m_hardfork in ctor just in case (moneromooo-monero)
|
|
a7960542 WalletAPI: rescanBlockchain, rescanBlockchainAsync (mmitkevich)
|
|
2d48861d p2p: only deinitialize what's been initialized in offline mode (moneromooo-monero)
|
|
e54e5668 daemon: Show mining address (Ricardo de Vries)
|
|
0fbbb065 p2p: a negative result from UPNP_GetValidIGD is an error (moneromooo-monero)
|
|
e51c9787 rpc: fix wrongly formatted JSON for pruned tx (stoffu)
|
|
04ddf02e Return appropriate RPC error code when key image signature check fails (Michał Sałaban)
|
|
68e9744d simplewallet: perform trivial error checks before password prompt (xiphon)
|
|
67e76aa0 wallet_rpc_server: optionally return tx keys in sign_transfer (moneromooo-monero)
|
|
f2c2c47a simplewallet: fixed deadlock if a user hits CTRL+C twice (xiphon)
|
|
93a88d73 Utils: add support for newer Windows versions detection (Gregory Lemercier)
|
|
977fc1bc wallet_rpc_server: add describe_transfer RPC (moneromooo-monero)
|
|
fd62b6e7 blocks: use auto-generated .c files instead of 'LD -r -b binary' (xiphon)
|
|
341b3931 cryptonote_core: warn when the block rate deviates from expectations (moneromooo-monero)
|
|
9907ea06 cryptonote: sort tx_extra fields (moneromooo-monero)
|
|
|
|
in order to unbias selection from blocks with few txes
|
|
|
|
Fix for #4399.
Also unifies code for serializing pruned tx to binary/json into one.
|
|
|
|
f5f7c2ac rpc: blanket initialize 0MQ request and response structures (moneromooo-monero)
|
|
6ca00b6d miner: really reset flags/precision on std::cout (moneromooo-monero)
|
|
a39c0358 blockchain: add check test options are given for fakechain mode (moneromooo-monero)
|
|
92a0827e wallet2: make fake out selection messages less spammy (moneromooo-monero)
|
|
cf75ee72 blockchain: move two new verification errors to the verify category (moneromooo-monero)
|
|
b916ca63 rpc: fix output distribution caching ignoring chain changes (moneromooo-monero)
|
|
25d327e7 device: extended logging, refactored device selection code (xiphon)
825d836f device: fixed Ledger Nano S device selection (xiphon)
|
|
99cd6f96 Rename "blackball" for clarity (moneromooo-monero)
|
|
c39e0a17 core: don't verify range proofs multiple times (moneromooo-monero)
|
|
776aefda tx_pool: revert #4592 and move bin2hex conversion to on_get_transaction_pool (stoffu)
|
|
c7743929 spawn: close all file descriptors before execve (moneromooo-monero)
|
|
|
|
Lest we get people get scared again
|
|
0 is placeholder for whole chain, so we should compare chain
height changes rather than chain-height-or-zero. Even this isn't
totally foolproof if a blocks are popped and the same number
added again, but it is much better as it prevents the data from
slowly going out of sync.
|
|
Apparently some people seem to think it's a censorship list...
|
|
|
|
|
|
|
|
|
|
|
|
No need to give whatever we're calling access to what we use
|
|
|
|
9b6dd934 Providing user supplied default constructor for expect<void> (Lee Clagett)
|
|
6f28667a daemon: fix reading past stack on exit (moneromooo-monero)
|
|
99d45a95 wallet_rpc_server: fix change_wallet_password RPC (moneromooo-monero)
|
|
|
|
0cdd4b07 wallet2_api: fix generating new wallet in the GUI (moneromooo-monero)
|
|
It was creating a new wallet without a password first (this should
be fixed), then not changing the password correctly
|
|
Coverity 182501
|
|
Also prevents coverity from moaning about them not initializing fields
|
|
Never actually used uninitialized
Coverity 136615
|
|
Coverity 188336
|
|
Coverity 136568
|
|
|
|
|
|
|
|
|
|
as per the source documentation
|
|
|
|
9a856697 rpc: fixed typo in JSON command error response message (AnythingTechPro)
|
|
00901e9c epee: initialize a few data members where it seems to be appropriate (moneromooo-monero)
144a6c32 abstract_tcp_server2: move m_period to subclass (moneromooo-monero)
758d7684 connection_basic: remove unused floating time start time (moneromooo-monero)
e5108a29 Catch more exceptions in dtors (moneromooo-monero)
|
|
6844ae1b tx_pool: avoid parsing a whole tx if only the prefix is needed (moneromooo-monero)
|
|
a677492f tx_pool: store hex string instead of raw binary to tx_blob of get_transaction_pool RPC (stoffu)
|
|
d886b97f SOFTWARE is the default wallet device (m2049r)
|
|
c0822fdd simplewallet: mark default-ring-size setting as obsolete (moneromooo-monero)
|
|
76d6d832 Revert "p2p: connect via the bound ip, if any" (moneromooo-monero)
|
|
c3b8328c daemon: do not run complex code in a signal handler (moneromooo-monero)
e736964a Remove epee header dependency on cryptonote_core (moneromooo-monero)
|
|
14ed029b simplewallet: fix view key parsing in --generate-from-view-key (moneromooo-monero)
|
|
0e33cf89 password: fix secure input with echo on windows (moneromooo-monero)
|
|
dc8f6924 password: fix backspace outputting ^? on linux on echoing secure input (moneromooo-monero)
|
|
get_transaction_pool RPC
Inspired by https://github.com/masari-project/masari/issues/93
|
|
This reverts commit 909398efc79cb1fa92e330e9a50a316ca5858953.
It looks like it's causing trouble with tor on some setups
|
|
|
|
instead, delegate the work to a one off thread
and notify it from the signal handler
|
|
|
|
|
|
|
|
|
|
|
|
Co-authored-by: moneromooo-monero <moneromooo-monero@users.noreply.github.com>
|
|
|
|
|
|
Thanks to iDunk for the testing back and forth
|
|
|
|
|
|
|
|
|
|
8833aec0 wallet2: fix cold signing using non padded bulletproofs (moneromooo-monero)
|
|
c716a331 device: increase ledger timeout to 2 minutes (selsta)
|
|
bd7b800f device_io_hid: fix DEFAULT_* type (too short) and init time (moneromooo-monero)
|
|
This code was deciding which bulletproof configuration to use
based on ptx which weren't created yet.
|
|
for unsigned tx sets using a view only wallet
|
|
|
|
|
|
8f22e808 device: destroy device objects on exit (moneromooo-monero)
|
|
77471e23 blockchain_blackball: fix stray ! (moneromooo-monero)
|
|
c5a97315 Remove last traces of libpcsc-lite (moneromooo-monero)
|
|
This reverts commit 79d46c4d551a9b1261801960095bf4d24967211a, reversing
changes made to c9fc61dbb56cca442c775faa2554a7460879b637.
|
|
|
|
|
|
|
|
|
|
Coverity 188616
|
|
85e58cb2 blockchain_blackball: fix stats double counting (moneromooo-monero)
|
|
|
|
|
|
9acf42d3 Multisig M/N functionality core tests added (naughtyfox)
9f3963e8 Arbitrary M/N multisig schemes: * support in wallet2 * support in monero-wallet-cli * support in monero-wallet-rpc * support in wallet api * support in monero-gen-trusted-multisig * unit tests for multisig wallets creation (naughtyfox)
|
|
This removes some small amount of fingerprinting entropy.
There is no consensus rule to require this since this field
is technically free form, and a transaction is free to have
custom data in it.
|
|
Some strings were not detected by lupdate because "tr() cannot be called without
context".
|
|
02d3ef7b blocks: use auto-generated .c files instead of 'LD -r -b binary' (xiphon)
|
|
34a85e0c wallet2: disable height based segregation (moneromooo-monero)
|
|
c5928bde wallet2_api: fix build with C++14 (moneromooo-monero)
|
|
a0613532 secure_pwd_reader: Add proper Unicode handling [Ryo contribution] (fireice-uk)
579383c2 simplewallet: Add Unicode input_line [Ryo backport] (fireice-uk)
|
|
7c790f11 Fix rtxn usage in BlockchainLMDB::get_estimated_batch_size (Howard Chu)
|
|
|
|
|
|
|
|
|
|
It can still be enable via DNS if a key reusing fork pops up
|
|
5ec929fb daemon: do not display uptime when not known (moneromooo-monero)
|
|
bccd88dd wallet2: clear found out for every tx key (doy-lee)
|
|
2c74b1a1 wallet_rpc_server: include all transfer records for a txid (moneromooo-monero)
|
|
25e5890d wallet: fix --generate-from-json using wrong password (moneromooo-monero)
|
|
d5541e44 common: Windows 'spawn' support for tx and block notifications (xiphon)
|
|
fa9e54b6 build: fix gcc false positive 'stringop-overflow' warning (xiphon)
|
|
6da36ea0 wallet2_api: blackball/unblackball now take two parameters (moneromooo-monero)
|
|
2fbf38ee Fix 32bit depends builds (TheCharlatan)
17142ec9 malloc scratchpad for all supported android archs (m2049r)
6a781408 Make depends use self built clang for darwin (TheCharlatan)
69da14e1 fixes make debug compilation on OSX (Dusan Klinec)
fe125647 Fixup RENAME_DB() macro (Howard Chu)
b2972927 osx compilation fix: missing boost libs added (Dusan Klinec)
174f31bf simplewallet: don't complain about payment id on pool mined blocks (moneromooo-monero)
89288863 README: mention ASAN usage alongside valgrind (moneromooo-monero)
83debef9 wallet_rpc_server: remove verbose field in incoming_transfers query (moneromooo-monero)
a69271fa Fixed a typo (Piotr Kąkol)
92d1da28 unit_tests: fix build with GCC 5.4.0 on ubuntu (moneromooo-monero)
a21da905 Wallet: use unique_ptr for WalletImpl members (oneiric)
7a056f44 WalletAPI: multisigSignData bug fixed (naughtyfox)
43a06350 ringdb: use cursors to be a bit faster (moneromooo-monero)
7964d4f8 wallet2: handle corner case in picking fake outputs (moneromooo-monero)
6f5360b3 bump version to 0.13.0.1 (Riccardo Spagni)
cf470bf3 switch from master to rc (Riccardo Spagni)
|
|
fa942ef6 daemon: silence daemon update warnings on testnet (iDunk5400)
|
|
8110bea3 dns_utils: refresh list of usable DNSSEC servers (moneromooo-monero)
|
|
Misc coverity reports
|
|
Should only stop the rtxn if we actually started it
Fixes Coverity 184960
|
|
Avoids triggering the sanity check
|
|
|
|
|
|
* support in wallet2
* support in monero-wallet-cli
* support in monero-wallet-rpc
* support in wallet api
* support in monero-gen-trusted-multisig
* unit tests for multisig wallets creation
|
|
Since subaddresses were added, a tx can now create more than
one payment
|
|
|
|
|
|
amount and offset (instead of pubkey)
|
|
73403004 add --block-notify to monerod and --tx-notify to monero-wallet-{cli,rpc} (moneromooo-monero)
|
|
7dd11711 wallet2: fix transfers between subaddresses hitting the sanity check (moneromooo-monero)
|
|
bcf3f6af fuzz_tests: catch unhandled exceptions (moneromooo-monero)
3ebd05d4 miner: restore stream flags after changing them (moneromooo-monero)
a093092e levin_protocol_handler_async: do not propagate exception through dtor (moneromooo-monero)
1eebb82b net_helper: do not propagate exceptions through dtor (moneromooo-monero)
fb6a3630 miner: do not propagate exceptions through dtor (moneromooo-monero)
2e2139ff epee: do not propagate exception through dtor (moneromooo-monero)
0749a8bd db_lmdb: do not propagate exceptions in dtor (moneromooo-monero)
1b0afeeb wallet_rpc_server: exit cleanly on unhandled exceptions (moneromooo-monero)
418a9936 unit_tests: catch unhandled exceptions (moneromooo-monero)
ea7f9543 threadpool: do not propagate exceptions through the dtor (moneromooo-monero)
6e855422 gen_multisig: nice exit on unhandled exception (moneromooo-monero)
53df2deb db_lmdb: catch error in mdb_stat calls during migration (moneromooo-monero)
e67016dd blockchain_blackball: catch failure to commit db transaction (moneromooo-monero)
661439f4 mlog: don't remove old logs if we failed to rename the current file (moneromooo-monero)
5fdcda50 easylogging++: test for NULL before dereference (moneromooo-monero)
7ece1550 performance_test: fix bad last argument calling add_arg (moneromooo-monero)
a085da32 unit_tests: add check for page size > 0 before dividing (moneromooo-monero)
d8b1ec8b unit_tests: use std::shared_ptr to shut coverity up about leaks (moneromooo-monero)
02563bf4 simplewallet: top level exception catcher to print nicer messages (moneromooo-monero)
c57a65b2 blockchain_blackball: fix shift range for 32 bit archs (moneromooo-monero)
|
|
921b0fb1 use default create_address_file argument (m2049r)
|
|
06d05c21 device: set device name correctly if key_on_device is set (Dusan Klinec)
|
|
17142ec9 malloc scratchpad for all supported android archs (m2049r)
|
|
fe125647 Fixup RENAME_DB() macro (Howard Chu)
|
|
174f31bf simplewallet: don't complain about payment id on pool mined blocks (moneromooo-monero)
|
|
83debef9 wallet_rpc_server: remove verbose field in incoming_transfers query (moneromooo-monero)
|
|
a21da905 Wallet: use unique_ptr for WalletImpl members (oneiric)
|
|
7a056f44 WalletAPI: multisigSignData bug fixed (naughtyfox)
|
|
43a06350 ringdb: use cursors to be a bit faster (moneromooo-monero)
|
|
Add architecture flags when cmake invokes gcc manually.
Add 32bit to Travis.
|
|
17142ec9 malloc scratchpad for all supported android archs (m2049r)
|
|
fe125647 Fixup RENAME_DB() macro (Howard Chu)
|
|
174f31bf simplewallet: don't complain about payment id on pool mined blocks (moneromooo-monero)
|
|
83debef9 wallet_rpc_server: remove verbose field in incoming_transfers query (moneromooo-monero)
|
|
a21da905 Wallet: use unique_ptr for WalletImpl members (oneiric)
|
|
7a056f44 WalletAPI: multisigSignData bug fixed (naughtyfox)
|
|
43a06350 ringdb: use cursors to be a bit faster (moneromooo-monero)
|
|
7964d4f8 wallet2: handle corner case in picking fake outputs (moneromooo-monero)
|
|
7964d4f8 wallet2: handle corner case in picking fake outputs (moneromooo-monero)
|
|
|
|
The key image (which was only supplied if verbose was true) is
readily available, not a secret key, and it was only modelled
after the CLI command because it's a bit spammy for the CLI.
|
|
A few of them are now returning invalid replies.
|
|
|
|
Make sure target DB's record is on a writable page
|
|
|
|
|
|
Those use the extra nonce without a payment id
|
|
357441a2 add checkpoints for testnet and mainnet (Riccardo Spagni)
d9f666d7 update checkpoints.dat (Riccardo Spagni)
6b1b4e83 update version to 13.0 (Riccardo Spagni)
6f153533 update readme with v13.0 (Riccardo Spagni)
|
|
e350cc5a wallet2: fix duplicate output making it to the RPC (moneromooo-monero)
bf9a0f4c epee: fix stack overflow on crafted input (moneromooo-monero)
45683ee0 epee: fix invalid memory write reading an array entry (moneromooo-monero)
|
|
|
|
c39ad0cd tx_pool: fix tx removal at startup keeping references (moneromooo-monero)
|
|
4d0a8db0 device: fix warnings about overridden functions (moneromooo-monero)
|
|
6e270fbd wallet2_api: fix for latest code changes (moneromooo-monero)
|
|
50981c40 blockchain: add stagenet v8 and v9, two weeks before mainnet (moneromooo-monero)
|
|
b35beaa8 wallet_rpc_server: include account index in incoming_transfers RPC (moneromooo-monero)
|
|
83907f88 wallet_rpc_server: fix --run-as-service on Windows (moneromooo-monero)
|
|
|
|
|
|
|
|
Remove PCSC dependencies which is a bit hard (not user friendly) to install on linux and Mac
Split Ledger logic and device IO
|
|
|
|
instead of merging that with other scalar multiplications
where possible for speed, since this is not actually safe
|
|
|
|
|
|
Use unique_ptr to manage WalletImpl internals, rather than raw
pointers.
|
|
|
|
f3cd51a1 cryptonote tweak v2.2 (Lee Clagett)
|
|
If we originally think we have enough outputs on the blockchain
to pick random fake outputs, we might end up with not enough of
them if enough are actually blackballed.
|
|
Thanks iDunk for the windows testing
|
|
|
|
|
|
Thanks iDunk for building patches on windows
|
|
8db2d8d4 simplewallet: fix --generate-from-json setting wrong wallet filename (moneromooo-monero)
|