| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
6c28bdb wallet2: move get_rpc_status func to RPC server definition file (j-berman)
|
|
9fc48f4 Fix ZMQ Tx Pruning (Lee Clagett)
|
|
32f3245 cryptonote_protocol: prevent duplicate txs in fluff queue (0xFFFC0000)
|
|
0fad1a8 src: update checkpoints to match v0.18.3.4 (selsta)
|
|
a026d5a wallet2: validate fetched block height and parent hash (Oscar Mira)
c634c26 wallet2: use start_height consistently as const in process_parsed_blocks (Oscar Mira)
|
|
302fa9b wallet: fetch pool txs in pruned form (jeffro256)
|
|
4a376d6 copyright: fix vector.h typo (hinto.janaiyo)
d61e8e9 workflows: delete copyright.yml (plowsof)
341771a copyright: bump to 2024 (copyCat)
|
|
025021d BlockchainDB: shorter fixup() (jeffro256)
|
|
262ef47 BlockchainDB: remove lock/unlock methods (jeffro256)
|
|
18fbe54 add sum of amounts for unspent_outputs (SNeedlewoods)
|
|
3837bb8 remove repetitive word (cuinix)
|
|
e71c8bf wallet: background sync with just the view key (j-berman)
|
|
|
|
|
|
|
|
|
|
1. Fix duplicate transaction #9335
2. Add test for cases where there are duplicate transaction in fluff
Co-authored-by: Boog900 <boog900@tutanota.com>
|
|
|
|
|
|
- When background syncing, the wallet wipes the spend key
from memory and processes all new transactions. The wallet saves
all receives, spends, and "plausible" spends of receives the
wallet does not know key images for.
- When background sync disabled, the wallet processes all
background synced txs and then clears the background sync cache.
- Adding "plausible" spends to the background sync cache ensures
that the wallet does not need to query the daemon to see if any
received outputs were spent while background sync was enabled.
This would harm privacy especially for users of 3rd party daemons.
- To enable the feature in the CLI wallet, the user can set
background-sync to reuse-wallet-password or
custom-background-password and the wallet automatically syncs in
the background when the wallet locks, then processes all
background synced txs when the wallet is unlocked.
- The custom-background-password option enables the user to
open a distinct background wallet that only has a view key saved
and can be opened/closed/synced separately from the main wallet.
When the main wallet opens, it processes the background wallet's
cache.
- To enable the feature in the RPC wallet, there is a new
`/setup_background_sync` endpoint.
- HW, multsig and view-only wallets cannot background sync.
|
|
|
|
|
|
|
|
697986d net_node: update seed nodes (selsta)
|
|
6d4f7b8 wallet2: fix stagenet get_approximate_blockchain_height (selsta)
|
|
f9d9dd8 simplewallet: change boost::filesystem::complete to absolute. (0xFFFC0000)
|
|
de9c461 common: support boost filesystem copy_options. Co-authored-by: selsta <selsta@sent.at> (0xFFFC0000)
|
|
b27fda2 src: update checkpoints to match latest release (selsta)
|
|
267e31f Add drop_and_recreate in privatefile class. When creating a private file we need to delete the file if exist. (0xFFFC0000)
|
|
463228b Skip privacy networks (on tx sends) that don't have outgoing connections (Lee *!* Clagett)
|
|
427ba77 wallet2: ensure transfers and sweeps use same fee calc logic rnd2 (j-berman)
|
|
d6609b8 serialization: do any N-tuple (jeffro256)
|
|
7194506 Blockchain: remove old fee calc logic (jeffro256)
|
|
9b946ae Removed default cryptonote address (SyntheticBird45)
|
|
e151ff7 update blake2b test vectors (koe)
fa47c7b add blake2b to src/crypto (koe)
|
|
9d101d5 serialization: protect blob serialization from undefined behavior (jeffro256)
|
|
ff49444 @tobtoht: undo rebase changes tx.dsts -> tx_dsts (jeffro256)
38f354e Enforce Tx unlock_time is Zero by Relay Rule (jeffro256)
|
|
4689ad2 trezor: support c++17 and protobuf v25, libusb fix (Dusan Klinec)
|
|
236e5d4 update TimingsDatabase to support csv format and incremental updating (koe)
|
|
8d94d08 replace 'multisig()' with 'get_multisig_status()' using multisig_account_status and including '.kex_is_done' member (koe)
|
|
Also remove port for I2P seed nodes
|
|
Co-authored-by: selsta <selsta@sent.at>
|
|
|
|
|
|
When creating a private file we need to delete the file if exist.
|
|
Signed-off-by: cuinix <915115094@qq.com>
|
|
Instead of hard-coding all missing key images into the code and inserting if missing,
we simply pop all blocks after height 202611. This makes the `monerod` binary about
0.35% smaller.
|
|
|
|
- fix If there is no protobuf version installed, if fails
- passphrase test fix, wallet keys init was missing
|
|
|
|
|
|
|
|
|
|
Looks like the logic from #8882 was accidentally removed in #8861
(regressing to the behavior noted in the #8882 description).
This commit brings that logic back.
|
|
|
|
|
|
Caused in commit 05231400cebfeedbbc0a5386f38a033bba6314b3, PR #9035.
|
|
There is currently no compiler protection when someone tries to
do (for example) `BLOB_SERIALIZER(std::vector<int>)`. You just
get runtime allocation errors. This has already eaten up dev time
before, so this PR adds a static assertion that the type must be
trivially copyable, as defined by the C++ standard. Types can
override this if applicable if they use `BLOB_SERIALIZER_FORCED`.
|
|
|
|
a01d7cc Fixed mempool pruning (SChernykh)
|
|
e6f4875 wallet2: adjust fee during backlog, fix set priority (selsta)
|
|
- Removed `localhost:8080` default value to address string in wallet rpc
- Added an error response in case string is empty
fixed indentation
removed if and errors, default to localhost and port based on nettype
Forgot ":"
forgot ; and m_
removed wallet_rpc_server_error_codes.h
|
|
- Fixed undefined behavior after a call to `remove_tx_from_transient_lists` (it used an invalid iterator)
- Fixed `txCompare` (it wasn't strictly weak ordered)
|
|
66e5081 get_block_template_backlog: better sorting logic (SChernykh)
|
|
7815023 tx_memory_pool: make double spends a no-drop offense (jeffro256)
|
|
std::sort is unstable, so it can return random sets of transactions when mempool has many transactions with the same fee/byte. It can result in p2pool mining empty blocks sometimes because it doesn't pick up "new" transactions immediately.
|
|
|
|
2a2da79 free function serialization DSL (jeffro256)
|
|
Nodes who see different txs in a double spend attack will drop each other, splitting the network.
Issue found by @boog900.
|
|
Related to https://github.com/monero-project/research-lab/issues/78
Added a relay rule that enforces the `unlock_time` field is equal to 0 for non-coinbase transactions.
UIs changed:
* Removed `locked_transfer` and `locked_sweep_all` commands from `monero-wallet-cli`
APIs changed:
* Removed `unlock_time` parameters from `wallet2` transfer methods
* Wallet RPC transfer endpoints send error codes when requested unlock time is not 0
* Removed `unlock_time` parameters from `construct_tx*` cryptonote core functions
|
|
Example usage for Seraphis types (in global or `sp` namespace):
```
BEGIN_SERIALIZE_OBJECT_FN(sp::SpCoinbaseEnoteCore)
FIELD_F(onetime_address)
VARINT_FIELD_F(amount)
END_SERIALIZE()
BEGIN_SERIALIZE_OBJECT_FN(sp::SpEnoteCore)
FIELD_F(onetime_address)
FIELD_F(amount_commitment)
END_SERIALIZE()
```
|
|
|
|
f7670c9 cryptonote_core: early out on out of bounds scaling parameter (selsta)
|
|
c50ade5 Daemon-specific proxy for the wallet-rpc. (0xFFFC0000)
|
|
ed50938 Zero initialize rctSigBase elements (Lee *!* Clagett)
|
|
cd7ccfb Disable/fix ports with I2P (Lee Clagett)
|
|
8d25418 daemon: warn user on specifiying ZMQ args with --no-zmq (jeffro256)
|
|
0c545f6 epee/test: remove levin_protocol_handler and core_proxy tests (jeffro256)
|
|
47042ce wallet2: call on_reorg callback in handle_reorg (j-berman)
|
|
|
|
To transfer ~5 XMR to an address such that your balance drops by exactly 5 XMR, provide a `subtractfeefrom` flag to the `transfer` command. For example:
transfer 76bDHojqFYiFCCYYtzTveJ8oFtmpNp3X1TgV2oKP7rHmZyFK1RvyE4r8vsJzf7SyNohMnbKT9wbcD3XUTgsZLX8LU5JBCfm 5 subtractfeefrom=all
If my walet balance was exactly 30 XMR before this transaction, it will be exactly 25 XMR afterwards and the destination address will receive slightly
less than 5 XMR. You can manually select which destinations fund the transaction fee and which ones do not by providing the destination index.
For example:
transfer 75sr8AAr... 3 74M7W4eg... 4 7AbWqDZ6... 5 subtractfeefrom=0,2
This will drop your balance by exactly 12 XMR including fees and will spread the fee cost proportionally (3:5 ratio) over destinations with addresses
`75sr8AAr...` and `7AbWqDZ6...`, respectively.
Disclaimer: This feature was paid for by @LocalMonero.
|
|
|
|
1. Daemon-specific proxy is exclusive with global proxy (--proxy).
2. If you set global proxy (--proxy) you cannot set daemon-specific proxy.
3. If you don't set global proxy, you can set proxy (or not set) proxy for
each daemon connection with the proxy field in jsonrpc to the wallet-rpc.
|
|
Resolves https://github.com/monero-project/monero/issues/9127
|
|
|
|
|
|
430b102 Cleanup scoped_ptr in src/common/dns_utils.cpp and header include: * No need for entire new class (Fix #8732). * Fix stdint.h header include in contrib/epee/include/net/http_base.h. (0xFFFC0000)
|
|
eed975d Fix missing checks for IsObject in ZMQ jsonrpc reading (Lee Clagett)
|
|
2525200 serialization: remove container wrappers and serialize directly (jeffro256)
|
|
53e632b fix merge mining with more than one merge mined chain (Crypto City)
|
|
a11e03a serialization: fix infinite loops and clean up dispatching (jeffro256)
|
|
2766d12 MMS: Ignore 2 more API errors thrown by latest PyBitmessage (rbrunner7)
|
|
4acae11 Fix EAGAIN bug in ZMQ-RPC/ZMQ-PUB (Lee *!* Clagett)
|
|
1062b17 wallet: sign_tx: get tx pubkey from extra (tobtoht)
|
|
b2eb47d wallet: mitigate statistical dependence for decoy selection within rings (jeffro256)
|
|
|
|
* No need for entire new class (Fix #8732).
* Fix stdint.h header include in contrib/epee/include/net/http_base.h.
|
|
reported by sech1
|
|
|
|
Some downstream code (most notably PR https://github.com/UkoeHB/monero/pull/25) wants to use the src/serialization lib
for storing information persistently. When one builds classes/machines wishing to serialize containers, they must use
the `serializable_*` container classes. In this case, this makes the Seraphis library code unnecessarily tightly coupled
with the src/serialization code since one cannot swap out their type of storage format without major refactoring of class
field types. By serializing STL containers directly, we can abstract the serialization details away, making for much
cleaner design. Also small bonus side effect of this change is that STL containers with custom Comparators, Allocators,
and Hashers are serializable. `std::multimap` is added to the list of serializable containers.
Depends upon https://github.com/monero-project/monero/pull/9069.
|
|
Resolves #8687
|
|
23179a0 wallet: fix multisig key memory leak (jeffro256)
|
|
ade57b6 JH hash compiler workarounds (SChernykh)
|
|
e191083 epee: remove dead code in math_helper and string_tools (jeffro256)
|
|
0523140 ringct: make
ctSigBase serialization follow strict aliasing rule (jeffro256)
|
|
56dab0f cryptonote_config: include cstdint (jeffro256)
|
|
c17f73a add sp_transcript (koe) 51e40f7 add seraphis_crypto directory (koe)
|
|
80b5bf8 gcc: fix uninitialized constructor warnings (jeff)
|
|
1e2e703 core_rpc_server: silence unused warnings (jeffro256)
|
|
|
|
|
|
- Fixed uninitialized `state->x` warning
- Fixed broken code with `-O3` or `-Ofast`
The old code is known to break GCC 10.1 and GCC 11.4
|
|
|
|
|
|
Multisig keys per-transfer were being wiped, but not erased, which lead to a ginormous
quadratic bloat the more transfers and exports you performed with the wallet.
|
|
|
|
932bba3 depends: remove libiconv: unused (tobtoht)
|
|
9b231c9 add account_generators for mapping public EC generators to account keys (koe)
|
|
759293d wallet2: fix version check at hf version 1 (j-berman)
|
|
8190f25 KV_SERIALIZE: remove extraneous semicolons in DSL (jeffro256)
|
|
f71e2dc multisig: better errors for small malformed kex msgs (jeffro256)
|
|
b0bf49a blockchain_db: add k-anonymity to txid fetching (jeffro256)
|
|
c444a7e trezor: support v2.5.2+, add more trezor tests, fix chaingen and tests (Dusan Klinec)
056c996 fix chaingen tests (Dusan Klinec)
|
|
|
|
Accessing an object of type `char` thru an lvalue of type `crypto::hash8` is undefined behavior.
https://developers.redhat.com/blog/2020/06/03/the-joys-and-perils-of-aliasing-in-c-and-c-part-2
|
|
Header was using `uint64_t` without including `<cstdint>` which caused some issues downstream for windows builds
|
|
Since we are required to check for uniqueness of decoy picks within any given
ring, and since some decoy picks may fail due to unlock time or malformed EC points,
the wallet2 decoy selection code was building up a larger than needed *unique* set of
decoys for each ring according to a certain distribution *without replacement*. After
filtering out the outputs that it couldn't use, it chooses from the remaining decoys
uniformly random *without replacement*.
The problem with this is that the picks later in the picking process are not independent
from the picks earlier in the picking process, and the later picks do not follow the
intended decoy distribution as closely as the earlier picks. To understand this
intuitively, imagine that you have 1023 marbles. You label 512 marbles with the letter A,
label 256 with the letter B, so on and so forth, finally labelling one marble with the
letter J. You put them all into a bag, shake it well, and pick 8 marbles from the bag,
but everytime you pick a marble of a certain letter, you remove all the other marbles
from that bag with the same letter. That very first pick, the odds of picking a certain
marble are exactly how you would expect: you are twice as likely to pick A as you are B,
twice as likely to pick B as you are C, etc. However, on the second pick, the odds of
getting the first pick are 0%, and the chances for everything else is higher. As you go
down the line, your picked marbles will have letters that are increasingly more unlikely
to pick if you hadn't remove the other marbles. In other words, the distribution of the
later marbles will be more "skewed" in comparison to your original distribution of marbles.
In Monero's decoy selection, this same statistical effect applies. It is not as dramatic
since the distribution is not so steep, and we have more unique values to choose from,
but the effect *is* measureable. Because of the protocol rules, we cannot have duplicate
ring members, so unless that restriction is removed, we will never have perfectly
independent picking. However, since the earlier picks are less affected by this
statistical effect, the workaround that this commit offers is to store the order that
the outputs were picked and commit to this order after fetching output information over RPC.
|
|
|
|
The long term block weight cache was doing a wrong calculation when
adding a new block to the cache.
|
|
- passphrase logic: remove backward compatibility for 2.4.3, code cleanup.
- fix LibUSB cmake for static builds on OSX
- tests: all tests now work with passphrase logic enabled. Passphrase test added with different passphrase. no_passphrase test added, Trezor pin test added. Testing wallet opening with correct and incorrect passphrase. Trezor test chain revamp, cleanup. Smaller chain, chain file versioning added.
- tests: Trezor tests support TEST_MINING_ENABLED, TEST_MINING_TIMEOUT env vars to change mining-related tests behaviour.
- requires protobuf@21 on osx for now (c++14), building with unlinked protobuf: `CMAKE_PREFIX_PATH=$(find /opt/homebrew/Cellar/protobuf@21 -maxdepth 1 -type d -name "21.*" -print -quit) \
make debug-test-trezor -j8`
|
|
|
|
|
|
The Monero GUI code was calling `Monero::wallet::setPassword()` on every open/close for some reason,
and the old `store_to()` code called `store_keys()` with `watch_only=false`, even for watch-only wallets.
This caused a bug where the watch-only keys file got saved with with the JSON field `watch_only` set to 0,
and after saving a watch-only wallet once, a user could never open it back up against because `load()` errored out.
This never got brought up before this because you would have to change the file location of the watch-only
wallet to see this bug, and I guess that didn't happen often, but calling the new `store_to()` function with the
new `force_rewrite` parameter set to `true` triggers key restoring and the bug appeared.
|
|
|
|
|
|
|
|
Resolves #8932 and:
2. Not storing cache when new path is different from old in `store_to()` and
3. Detecting same path when new path contains entire string of old path in `store_to()` and
4. Changing your password / decrypting your keys (in this method or others) and providing a bad original password and getting no error and
5. Changing your password and storing to a new file
|
|
|
|
f7fb5c7 scan_tx: fix custom comparator for == case; fixes #8951 (j-berman)
|
|
192d87c remove more 'using namespace' statements from headers (jeffro256)
|
|
a0e5c3c wallet2: when checking frozen multisig tx set, don't assume order (jeffro256)
|
|
1104b59 Update help for set command in simplewallet Add help for max-reorg-depth and load-deprecated-formats options (MasFlam)
|
|
ffbf9f4 blockchain_and_pool: move to crytonote_core and enforce its usage (jeffro256)
d6f86e5 Avoid nullptr dereference when constructing Blockchain and tx_memory_pool (lukas)
|
|
45b52de wallet-rpc: restore from multisig seed (jeffro256)
|
|
2a2cf03 blockchain_db: add clarification to get_block_already_generated_coins (jeffro256)
|
|
e8cac61 core_rpc_server: return ID of submitted block (jeffro256)
|
|
a8d2a58 wallet2: ensure transfers and sweeps use same fee calc logic (j-berman)
|
|
6ff87ef net: tor_address: remove support for v2 onion addresses (tobtoht)
|
|
503c3e0 core: do not force sync the db when finding a block in regtest mode (Crypto City)
|
|
Prereq of https://github.com/monero-project/monero/pull/8867
|
|
Resolves https://github.com/monero-project/monero/issues/8493
|
|
|
|
Read more about k-anonymity [here](https://en.wikipedia.org/wiki/K-anonymity). We implement this feature in the monero daemon for transactions
by providing a "Txid Template", which is simply a txid with all but `num_matching_bits` bits zeroed out, and the number `num_matching_bits`. We add an operation to `BlockchainLMDB` called
`get_txids_loose` which takes a txid template and returns all txids in the database (chain and mempool) that satisfy that template. Thus, a client can
ask about a specific transaction from a daemon without revealing the exact transaction they are inquiring about. The client can control the statistical
chance that other TXIDs (besides the one in question) match the txid template sent to the daemon up to a power of 2. For example, if a client sets their `num_matching_bits`
to 5, then statistically any txid has a 1/(2^5) chance to match. With `num_matching_bits`=10, there is a 1/(2^10) chance, so on and so forth.
Co-authored-by: ACK-J <60232273+ACK-J@users.noreply.github.com>
|
|
|
|
Co-authored-by: woodser <woodser@protonmail.com>
|
|
|
|
|
|
1c20198 Fixup error message. (ComputeryPony)
|
|
369a5a8 wallet: respect frozen key images in multisig wallets (jeffro256)
|
|
2608b24 Add CLSAG serialization to ZMQ code (Lee Clagett)
|
|
c138a28 wallet2: take ignored-by-value outputs into account in balance (Crypto City)
|
|
c589e15 Speed up perf_timer init on x86 (SChernykh)
|
|
d9c7cd5 common: do not use DNS to determine if address is local (tobtoht)
|
|
d391ac0 blockchain: ensure base fee cannot reach 0 (Crypto City)
|
|
a668312 wallet: remove CLI code for non default ring sizes (Jeffro256)
|
|
16d17f6 add crypto/generators for direct access to canonical fixed generators (koe)
|
|
70bbd25 core_rpc_server: new file: rpc_ssl.fingerprint (Jeffrey Ryan)
|
|
ce86368 Remove src/platform (Jeffrey)
|
|
a6639df wallet_rpc_server: dedup transfer RPC responses (jeffro256)
Very special PR.
|
|
Co-authored-by: j-berman <justinberman@protonmail.com>
|
|
|
|
All the files in src/platform are currently unused and unnecessary. See below:
* `mingw/alloca.h`: unused throughout project
* `msc/sys/param.h`:
1. In `fix_darwin.patch`, `sys/param.h` is well-defined to be used only in OpenBSD environment
2. `int-util.h` already handles when `sys/param.h` is not present and injects its own values
3. `db_drivers/liblmdb/mdb.c` is a similar situation: already explicity handles different platforms
4. `src/crypto/chacha.h` uses `int-util.h` for endianness context
* `msc/alloca.h`: unused
* `msc/inline_c.h`: not needed. the `inline` keyword is supported for C99 I believe, and certainly for C11, C14+
* `msc/stdbool.h`: `stdbool.h` is standard since C99, and MSVC has supported it for a long time (~10 years)
|
|
|
|
Add help for max-reorg-depth and load-deprecated-formats options
|
|
|
|
|
|
|
|
|
|
Looks like the extra MWARNING was supposed to be guarded by the if statement.
|
|
eeda4a8 wallet2: do not lose exception in current thread on refresh (Crypto City
f868768 wallet2: fix missing exceptions from failing wallet refresh (Crypto City)
|
|
9f80797 protocol: drop peers sending duplicate txes (moneromooo-monero)
|
|
bb83eb1 daemon: remove --fluffy-blocks (tobtoht)
|
|
6b8dfb8 daemon: remove os-version (tobtoht)
|
|
7206ef8 cryptonote_basic: fix amount overflow detection on 32-bit systems (jeffro256)
|
|
24d56c5 bump lmdb sync threshold for performance (moneromooo-monero)
|
|
092e964 Fixed RandomX initialization when mining from scratch (SChernykh)
|
|
ca6c42a Message about DNS_PUBLIC to help users with issue #8452 (OrvilleRed)
|
|
87e2a64 Allow option 'non-interactive' in monerod config file (almalh)
|
|
c90c1c3 Show IPv6 addresses in connection list (Guillaume Le Vaillant)
|
|
f50b9e3 revisions (koe) e5aa058 vtnerd review comments (koe)
c60b11f add compare_func() method so user-defined comparison functions are easier to use (koe)
7329873 adjust is_sorted_and_unique() (koe)
3d60475 comment updates (koe) acfaaed add container helpers (koe)
|
|
2a7435e variant: add mutable unwrap and visitation (koe)
bc3cec4 add variant class with cleaner interface than boost::variant<> (koe)
|
|
|
|
- Detach & re-process txs >= lowest scan height
- ensures that if a user calls scan_tx(tx1) after scanning tx2,
the wallet correctly processes tx1 and tx2
- if a user provides a tx with a height higher than the wallet's
last scanned height, the wallet will scan starting from that tx's
height
- scan_tx requires trusted daemon iff need to re-process existing
txs: in addition to querying a daemon for txids, if a user
provides a txid of a tx with height *lower* than any *already*
scanned txs in the wallet, then the wallet will also query the
daemon for all the *higher* txs as well. This is likely
unexpected behavior to a caller, and so to protect a caller from
revealing txid's to an untrusted daemon in an unexpected way,
require the daemon be trusted.
|
|
Before this change, if a multisig peer asked you to sign a transaction with a frozen enote, the wallet will do it without any error or warning. This change makes it
so that wallets will refuse to sign multisig transactions with frozen enotes.
Disclaimer: This PR was generously funded by @LocalMonero.
|
|
|
|
|
|
All Monero binaries have 1 second startup delay because of this code. This is especially noticeable and affects UX in Monero GUI wallet with local node where it often starts another monerod instance to run commands and query node status.
|
|
|
|
On systems where `ULONG_MAX` != `ULLONG_MAX` (e.g. most 32-bit systems), the `round_money_up` function will not correctly detect overflows.
|
|
|
