| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
6955976b Add various readline related fixes (Jethro Grassie)
|
|
c3bb6bec daemon: fix status in command line mode if using restricted rpc (moneromooo-monero)
|
|
f5f985c0 miner: fix background mining options parsing (moneromooo-monero)
|
|
33d17c37 Don't hardcode /tmp (Howard Chu)
|
|
8db68a57 Fix #2164 histogram output (Howard Chu)
|
|
02d66db4 tx_pool: initialize padding in txpool meta structure (moneromooo-monero)
0722aea3 cryptonote_core: initialize checkpoint flag (moneromooo-monero)
|
|
5cea3552 simplewallet: lock idle scope when sweeping (moneromooo-monero)
|
|
|
|
They were set as uint8_t, which boost was apparently treating
as a character type, rather than a numeric type
|
|
|
|
When there are more than 50txs, the timestamp for the last
bin was printed incorrectly. Subtracting "now" was omitted by mistake
in 3fc22e7b78ab1dd409de4f3e8f5bff27be19735b
|
|
- Add missing unbind key
- Fix colored messages
- Add command completion
- Preserve last command input
- Fix cursor position issues
- Fix trailing whitespace in commands
- Synchronize set_prompt
|
|
f98bf48b Minor cleanup: tab vs. space + logs messages (binaryFate)
|
|
3b599d2b wallet2: get current height from the daemon on creation (moneromooo-monero)
d3bb72ff wallet2: fix infinite loop on future refresh height (moneromooo-monero)
32754784 wallet: fix refresh_from_height setting on new wallet (moneromooo-monero)
|
|
5a09d79c Fix #2120: return per-tx amount in transfer_split RPC call. (binaryFate)
|
|
b592cb3f Fix on_transfer RPC incorrect logging info (Mike C)
|
|
76043b17 monero-wallet-cli: hang on exit in readline code (#2117) (moneromooo-monero)
a73a42a6 monero-wallet-cli: hang on exit in readline code (#2117) (moneromooo-monero)
be9d4f04 Fix multiline wallet cli output with readline (Jethro Grassie)
|
|
7d2c89b6 Add french translation (Guillaume LE VAILLANT)
3255887f simplewallet: typo fixes (Guillaume LE VAILLANT)
|
|
bdab3436 Fix mismatch of parameter name between header file and implementation for set_user_options() (Julien Klepatch)
|
|
bb708ab8 electrum-words: fix seed mistakenly thought to be old style (moneromooo-monero)
|
|
|
|
|
|
This ensures the chain and related structures can't change
while we're using them
|
|
Since I had to add an ID to the derived classes anyway,
this can be used instead. This removes an apparently
pointless warning from CLANG too.
|
|
|
|
|
|
Use current time to estimate current height only if the daemon
cannot be queried.
|
|
If the refresh height is in the future, the current code will
loop till the actual height reaches this. Fix it by bailing out
if we receive only three hashes, which is what we set in the
call parameters.
|
|
The previous patch was based on a wrong premise (that the
daemon height was 0 because the daemon calling code wasn't
yet initialized). In fact, current height approximation
was not setup for testnet. Fix this.
|
|
monero-wallet-cli commands which have multine output sometimes causes
issues with the readline support. This patch fixes show_transfers,
payments and incoming_transfers.
|
|
e4da88a2 Fixed typo in rpc/core_rpc_server.cpp (Julien Klepatch)
|
|
07c4276c Don't issue a new timedsync while one is already in progress (Howard Chu)
cf3a376c Don't timeout a slow operation that's making progress (Howard Chu)
340830de Fix PR#2039 (Howard Chu)
|
|
|
|
|
|
set_user_options()
|
|
It'd see "empty" words due to extraneous spaces
|
|
|
|
|
|
|
|
not the actual tx secret key
|
|
4e13ab30 wallet_api: fix missing transaction parameter in callback (moneromooo-monero)
|
|
235df7f4 blockchain_db: add a txpool tx getter which returns existence (moneromooo-monero)
|
|
b2319a03 simplewallet: new command to generate a random payment id (moneromooo-monero)
|
|
1dd52415 Fix #1991 asm multiply again (Howard Chu)
|
|
ac0714dc add simplewallet --generate-new-wallet arg checks (Michael Shick)
|
|
e1f3dfcc Add readline support to cli (jethro)
|
|
71f8249a Prevent crash if performing certain actions before wallet is initialized (Robby Weinberg)
|
|
3fc22e7b Add histogram to poolstats (Howard Chu)
d09620b0 Fix PR#2039 (Howard Chu)
|
|
6fc2dc39 cryptonote_protocol_handler: fix crash in debug log (moneromooo-monero)
|
|
This PR adds readline support to the daemon and monero-wallet-cli. Only
GNU readline is supported (e.g. not libedit) and there are cmake checks
to ensure this.
There is a cmake variable, Readline_ROOT_DIR that can specify a
directory to find readline, otherwise some default paths are searched.
There is also a cmake option, USE_READLINE, that defaults to ON. If set
to ON, if readline is not found, the build continues but without
readline support.
One negative side effect of using readline is that the color prompt in
the wallet-cli now has no color and just uses terminal default. I know
how to fix this but it's quite a big change so will tackle another time.
|
|
1b75ad91 Add OSX background mining (jethro)
|
|
072102cf abstracted nework addresses (moneromooo-monero)
|
|
|
|
A timedsync is issued every minute on a connection, but the input
tineout is 2 minutes. This means a new sync request could be issued
while a slow sync request was already in progress. The additional
request will further clog the network on a slow connection, and
cause a premature timeout.
|
|
It was unused, so harmless
Reported by erikd on IRC
|
|
Avoids exception spam for the "nope, not found" case
|
|
This is trivial, but often requested, and possibly hard to do
in Windows. That makes it more user friendly.
|
|
Tweak temp variables and constraints. Was working before if not inlined
but newer gcc tends to inline it.
|
|
Implements miner::get_system_times, miner::get_process_time and
miner::on_battery_power for OSX so that background mining works on OSX.
|
|
Add fail-fast paths that reduce frustration around the misuse of
--wallet-file combined with --restore-deterministic-wallet. Flow now
gives more descriptive errors and avoids having users type in their
whole seed before the failure condition is noticed.
|
|
|
|
|
|
|
|
6bcd3b2d fix get_upper_transaction rename (schnerchi)
|
|
d17c0fc2 Don't copy blockchain for coinbase_tx_sum (Howard Chu)
|
|
31417d57 tx_pool: add missing blockchain lock in add_tx (moneromooo-monero)
|
|
Since we're just counting txs, there's no reason to deserialize all the blobs.
|
|
Changed Blockchain::for_all_blocks() to for_blocks_range()
Operate on blockchain in-place instead of building a copy first.
|
|
|
|
|
|
05f3dcf7 simplewallet: fix refresh height for new wallets (moneromooo-monero)
|
|
740bc24c Wallet API: Set seed lang when recovering form keys (Jaquee)
|
|
4b932ff3 changed crypto to cncrypto so it generated libcncrypto (Gentian)
|
|
89e20bb9 Fix typo (xmr-eric)
|
|
89b2f306 tests: fix invalid key image test (moneromooo-monero)
a374a522 wallet2: check key image validity domain in import_key_images (moneromooo-monero)
|
|
dd8e3266 shared libs build (i.e. make debug) (stoffu)
|
|
a5739201 Update sync time copy (xmr-eric)
|
|
e2529347 Correct spelling of 'get_upper_transaction_size_limit' (Nano Akron)
3029d0ef Remove the 1.25x multiplier in max transaction size in just the wallet (Nano Akron)
|
|
8ac2496c corrected typo in help regarding min-outputs-* (stoffu)
|
|
6cb1ad1f wallet fix: ensure iterator to be valid (stoffu)
|
|
0a182576 node_rpc_proxy: fix earliest fork height query for unknown forks (moneromooo-monero)
391c918d wallet2: fix sweep_unmixable assuming wrong minimum mixin at v5 (moneromooo-monero)
|
|
b52abd13 Move txpool to the database (moneromooo-monero)
|
|
With the recent change to wallet creation code, the code was
calling to the daemon before the wallet's daemon address was
initialized, and thus failing. This was causing all new wallets
to refresh from 0 instead of just fetching early block hashes.
|
|
All code which was using ip and port now uses a new IPv4 object,
subclass of a new network_address class. This will allow easy
addition of I2P addresses later (and also IPv6, etc).
Both old style and new style peer lists are now sent in the P2P
protocol, which is inefficient but allows peers using both
codebases to talk to each other. This will be removed in the
future. No other subclasses than IPv4 exist yet.
|
|
|
|
Integration could go further (ie, return_tx_to_pool calls should
not be needed anymore, possibly other things).
poolstate.bin is now obsolete.
|
|
|
|
fix a cmakelist
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
The bump to minimum mixin 4 was moved from v5 to v6
|
|
bbf4c210 Wallet API: add spend/view key getters (Jaquee)
|
|
12fff108 Change Old_English to English_Old - 'Old English' is actually a language (Nano Akron)
533187f0 Change all wallet language names into native names (and scripts) (Nano Akron)
|
|
8277e67f Add anchor connections (Miguel Herranz)
|
|
|
|
|
|
It sweeps all outputs below the given threshold
This is available via the existing sweep_all RPC, by setting
amount_threshold the desired amount (in atomic units)
|
|
|
|
a6d5bb75 wallet2: refer to triangular distribution for recent zone in comment (moneromooo-monero)
ac1aba90 wallet2: bias fake outs more towards recent outputs (moneromooo-monero)
|
|
7f4beaa4 wallet2: fix removal of wrong txes from unconfirmed_payments (moneromooo-monero)
|
|
a255a540 simplewallet: allow multiline seed (moneromooo-monero)
5fce581c mnemonics: ignore multiple whitespace between words (moneromooo-monero)
|
|
72d113dd Amended software licenses for Portuguese and Spanish (Nano Akron)
54bcd260 Added Simplified Chinese electrum word list (Nano Akron)
|
|
a7d78dda wallet2: fix --generate-from-json in RPC mode (moneromooo-monero)
|
|
e9fb44ed wallet cli: removed some inappropriate return-false (kenshi84)
|
|
5e5b8512 Fix obsolete OpenSSL API usage (hyc)
6c72d6a0 Fix Android recognition (hyc)
e65d66fe Fix ARM64 identification (hyc)
a4673218 Clean up ARMv8-a aes_expand_key() (hyc)
a3d77901 Fix block_longhash_worker thread (hyc)
|
|
89d70756 wallet2: fix spurious output splitting when not merging destinations (moneromooo-monero)
|
|
10e137be wallet2: mention escaping/quoting --password in help string (moneromooo-monero)
|
|
110b6831 Resolve #92 add ability to create wallets thru RPC (Howard Chu)
|
|
bff90264 Add expected total reward to RPC "getblocktemplate". Only works from V5 fork onward - returns 0 before that block. (assylias)
|
|
It was wrongly refering to equiprobable distribution, which I think
I'd originally done, but forgot to update the comment after changing
to triangular
Reported by smooth on IRC
|
|
Two recent papers quantified the real usage bias for the
real output in a ring being the true one, and shows that
the current biasing is much too weak.
While we wait for a better solution, we increase the ratio
of recent-to-total fake outputs, as well as decrease the
time window for recent outputs, so that half the fake outs
are selected within the last 1.8 day. Value plucked from
figure 10, page 11 of An Empirical Analysis of Linkability
in the Monero Blockchain, 2017, Miller et al.
This is also arbitrary, of course, but serves as a stopgap
till a better selection algorithm is chosen.
|
|
Only works from V5 fork onward - returns 0 before that block.
|
|
unconfirmed_payments changed from having the txid as key to
the payment id, and this was not changed to match.
|
|
|
|
|
|
People are likely to enter it in three lines as it is how it
is displayed at creation time
|
|
|
|
The daemon address was initialized too late
|
|
The inline asm was lying about its parameters
|
|
Wasn't getting its stack size initialized; crashes on Android
with a default stack size of 1MB.
|
|
|
|
|
|
- Performance improvements
- Added `span` for zero-copy pointer+length arguments
- Added `std::ostream` overload for direct writing to output buffers
- Removal of unused `string_tools::buff_to_hex`
|
|
Reviewed and squashed. Open/Create is only allowed if no walletfile
was specified at startup.
|
|
eb20f720 daemon: print average fee per byte in print_pool_stats (moneromooo-monero)
37be70bb daemon: add fee/byte when print pool transaction info (moneromooo-monero)
893f5a30 tx_pool: add blob size and fee/byte when logging a new tx (moneromooo-monero)
|
|
5b632468 core: fix blob size cache, and reenable hash and blob size caches (moneromooo-monero)
|
|
548075b1 daemon: new relay_tx command and RPC (moneromooo-monero)
|
|
0a7885bf Wallet API: fix Cold signing split tx (Jaquee)
|
|
f5bd3465 IOS CMAKE build settings (Jaquee)
d8a88d05 add IOS CMAKE toolchain (Jaquee)
|
|
0ee018b4 wallet2: do not go over the target tx size if many destinations (moneromooo-monero)
9ae566d0 simplewallet: fix cold signing of split transactions (moneromooo-monero)
aae14a10 simplewallet: allow setting confirm-missing-payment-id in watch wallets (moneromooo-monero)
|
|
a38343bf miner: add a debug log in pause and resume (moneromooo-monero)
|
|
17c7c62d Add per transaction fee to transfer command (Antti Keränen)
|
|
64377c90 Add other possible paths of AC power status file on Linux (Guillaume LE VAILLANT)
|
|
89e100bc wallet cli: remove redundant password confirm in donate command (kenshi84)
|
|
89949706 simplewallet: factor the per-variable code in set_variable (moneromooo-monero)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
If using a large input and many destinations, the code would
generate as many outputs as it could using that input, even if
it would bring the resulting tx above the max tx size.
|
|
They'd be rejected as suspicious as the change goes to more
than one destination. However, split transactions will most
likely include fake zero amount change to random addresses,
so we only consider change with non zero amount for this.
|
|
These can create transactions, even though they cannot sign them.
|
|
Allows priority argument default/unimportant/normal/elevated/priority to
be used per transaction in CLI wallet's transfer command. Resolves #1913.
|
|
|
|
|
|
|
|
|
|
|
|
Looks like it doesn't work on win64
|
|
93b32892 Silence warning about possibly uninitialized pointer (Guillaume LE VAILLANT)
|
|
6e679478 mnemonics: sanity checks for word lists (moneromooo-monero)
e98f1114 mnemonics: misc cleanup (moneromooo-monero)
|
|
|
|
and a test to go with it
Remember to run the test when changing word lists, or simplewallet
will throw uncaught if that word list is used.
|
|
Pass relevant information to the base class instead of overwriting
default values later, use objects instead of pointers to objects
to avoid having to new objects unnecessarily.
|
|
With the change from the original transfer method to the new
algorithm, payments to the same destination were merged. It
seemed like a good idea, optimizing space. However, it is a
useful tool for people who want to split large outputs into
several smaller ones (ie, service providers making frequent
payments, and who do not like a large chunk of their balance
being locked for 10 blocks after each payment).
Default to off, which is a change from the previous behavior.
|
|
6d315459 core: avoid possible reordering bugs wth tx/bloch hash cache (moneromooo-monero)
|
|
2bee92db Fixed typo in v5 hard fork finalized date (Derek Zhang)
d17179d1 Fixed typo in CLI wallet help message (Derek Zhang)
|
|
0ad87db0 wallet: try to save large outputs when using an unneeded second input (moneromooo-monero)
|
|
|
|
|
|
|
|
|
|
When a single input is enough to satisfy a transfer, the code would
previously try to add a second input, to match the "canonical" makeup
of a transaction with two inputs and two outputs. This would cause
wallets to slowly merge outputs till all the monero ends up in a
single output, which causes trouble when making two transactions
one after the other, since change is locked for 10 blocks, and an
increasing portion of the remaining balance would end up locked on
each transaction.
There are two new settings (min-output-count and min-output-value)
which can control when to stop adding such unneeded second outputs.
The idea is that small "dust" outputs will still get added, but
larger ones will not.
Enable with, eg:
set min-output-count 10
set min-output-value 30
to avoid using an unneeded second output of 30 monero or more, if
there would be less than 10 such outputs left.
This does not invalidate any other reason why such outputs would
be used (ie, when they're really needed to satisfy a transfer, or
when randomly picked in the normal course of selection). This may
be improved in the future.
|
|
5a798358 blockchain: offset v5 addition date on testnet (moneromooo-monero)
|
|
a8646b09 Wallet API: add hard fork info functions (Jaquee)
|
|
31616af3 Fixes #1850 - Add French mnemonics wordlist (assylias)
|
|
8bbcbcfb wallet rpc: enable solo mining (stoffu)
|
|
to silence the update warning, since v5 was done very early
on testnet
|
|
|
|
|
|
00cbf720 ringct: move ge_frombytes_vartime failure error to warning (moneromooo-monero)
|
|
91d41090 tx_pool: ensure txes loaded from poolstate.bin have their txid cached (moneromooo-monero)
aaeb164c tx_pool: remove transactions if they're in the blockchain (moneromooo-monero)
558cfc31 core, wallet: faster tx pool scanning (moneromooo-monero)
f065234b core: cache tx and block hashes in the respective classes (moneromooo-monero)
|
|
9bccf1b1 Transfer help (Akademik Prokhor Zakharov)
|
|
c94f8fac daemon: better error reporting in commands (moneromooo-monero)
|
|
2242d8eb tx_pool: silence use of uninitialized warning (moneromooo-monero)
|
|
The txid is not saved, and we want to make sure the transactions
have their txid cached while in the pool, since get_transactions
copies the transaction object, so any txid calculation on those
copies would not benefit any later caller, since the original tx
would be left without a cached txid.
|
|
When starting up, if the pool state was not saved, the pool
might contain transactions which made it into the blockchain,
so these need removing
|
|
Includes a new RPC to get tx pool hashes fast.
|
|
An idea from smooth
|
|
Avoids scaring people when seeing some invalid txes
|
|
New pull request because I couldn't figure out how to change the previous one.
1. For clarity, I want to focus the help text for the 'transfer' command on the most typical use case (a single payment).
2. New users will prefer to use 'transfer', so the older method 'transfer_original' should refer to 'transfer' rather than the other way around.
|
|
|
|
The result is not actually used when uninitialized
|
|
44a5b038 create a foreground non-interactive mode (Noah Watkins)
|
|
995969b1 wallet: fix set_log not handling 0,xxx style settings (moneromooo-monero)
|
|
350e99ae wallet2: cache which pool txes were scanned already (moneromooo-monero)
|
|
c1e9ccc7 wallet2: speed up transactions using remote nodes (moneromooo-monero)
|
|
|
|
This massively speeds up the wallet updating the pool on mainnet,
where the tx backlog is more than 500 txes.
|
