Age | Commit message (Collapse) | Author | Files | Lines |
|
Make sure dataset gets re-init'd if a reorg changes the epoch
|
|
We don't need to detect if the cache has changed, just always
call to set it on the VM. The call will be a no-op if the cache
hasn't changed.
|
|
Was using the wrong cache slot, and returning invalid PoW hashes to RPC clients
|
|
9baf2a7 build: link wallet_merged against blockchain_db and hardforks obj (xiphon)
|
|
bd9c12e simplewallet: remove erroneously added line under subaddress-lookahead (stoffu)
|
|
b9da023 blockchain: keep block template timestamp not below recent median (moneromooo-monero)
|
|
6bbc646 Fix bug in mempool get_transaction_stats histogram calculation (tomsmeding)
|
|
c89f7ef wallet2_api: fix load unsigned tx from file error propagation (xiphon)
|
|
Coverity fixes [3a81639, 1bd962d, 2825f07, d099658, d46f701, cd57a10] (anonimal)
|
|
|
|
Support RandomX PoW algorithm
|
|
7b076d5 p2p: fix bans taking port into account (moneromooo-monero)
|
|
Revert a96c1a4 and adc16d2 (moneromooo-monero)
|
|
a444f06 blockchain: enforce 10 block age for spending outputs (moneromooo-monero)
|
|
f9b3f6e Removed Berkeley DB and db switching logic (JesusRami)
|
|
2cd4fd8 Changed the use of boost:value_initialized for C++ list initializer (JesusRami)
4ad191f Removed unused boost/value_init header (whyamiroot)
928f4be Make null hash constants constexpr (whyamiroot)
|
|
32f725d Properly format multiline logs (moneromooo-monero)
|
|
functional_tests (moneromooo-monero)
|
|
So it can be used by others without encumbrance
|
|
Some custom wallet code apparently ignores this, which causes users
of that code to be fingerprinted
|
|
Also fix part of the RPC results being returned as binary.
This makes the RPC backward incompatible.
|
|
|
|
|
|
As a side effect, colouring on Windows should now work
regardless of version
|
|
|
|
f0356f7 wallet2: enable ignoring fractional outputs also when sweeping (stoffu)
|
|
f91a06c Dropping cppzmq dependency; adding some zmq utils (vtnerd)
|
|
7d3bba5 wallet2_api: add missing parameter (selsta)
|
|
f380f69 simplewallet: warn if invalid default ring size is set and actually ignore the setting (stoffu)
|
|
495a7e5 rpc: don't include an address in mining_status when not mining (moneromooo-monero)
|
|
3407743 wallet_rpc_server: add locked field to get_transfers/get_{bulk_,}_payments (moneromooo-monero)
|
|
83ca764 wallet_rpc_server: call deinit on exit (moneromooo-monero)
|
|
1f1fff2 daemon: print mining algorithm in mining_status even when not mining (moneromooo-monero)
|
|
21f6c80 rpc: move a leftover light wallet RPC out of daemon RPC (moneromooo-monero)
|
|
11f13da blockchain: fix logging bad number of blocks if first one fails (moneromooo-monero)
19bfe7e simplewallet: fix warnings about useless std::move (moneromooo-monero)
|
|
2cb22d4 core: make the 'update probably needed soon' message less scary (moneromooo-monero)
|
|
26072f1 blockchain: forbid v1 coinbase from v12 (moneromooo-monero)
555dc7c core: from v12, require consistent ring size for mixable txes (moneromooo-monero)
d22dfb7 blockchain: reject rct signatures in coinbase txes from v12 (moneromooo-monero)
|
|
Such a template would yield an invalid block, though would require
an attacker to have mined a long blockchain with drifting times
(assuming the miner's clock is roughly correct)
Fixed by crCr62U0
|
|
|
|
This reverts commit a96c1a46d4b3854252de75cbe09458ad5d1aecb0.
|
|
This reverts commit adc16d2504d3e76b0115791caf10446684d45433.
|
|
|
|
|
|
2ec455d wallet: fix mismatch between two concepts of 'balance' (moneromooo-monero)
|
|
c4da1a2 wallet2: fix unset_ring tx retrieval checks (moneromooo-monero)
|
|
b51f4cd daemon: add pruned and publicrpc flags to print_pl (moneromooo-monero)
|
|
894cc81 wallet2: fix cold signing losing tx keys (moneromooo-monero)
|
|
9f68669 blockchain_blackball: add --historical-stat which prints historical stats of spent ratio (stoffu)
2425f27blockchain_blackball: use is_output_spent instead of ringdb.blackballed for spentness test (stoffu)
50813c1 ringdb: fix bug in blackballing (stoffu)
|
|
87d2f06 simplewallet: moan harder about untrusted nodes (moneromooo-monero)
|
|
cae488d p2p: reject incoming connections to self (moneromooo-monero)
|
|
063eebb daemon: implement 'set_bootstrap_daemon' command (xiphon)
|
|
e353e3d p2p: sanitize peer lists (moneromooo-monero)
|
|
2e26536 p2p: move log away from global (moneromooo-monero)
|
|
26f7a26 device: fix ledger requesting secret keys export twice (xiphon)
|
|
289d215 rpc: fix unitialized 'core_rpc_server::m_was_bootstrap_ever_used' (xiphon)
|
|
5a4c6cc daemon: fix merge error removing the 'never seen before' timestamp check (moneromooo-monero)
|
|
|
|
The issue is triggered by the captured `this` in RPC server, which
passes reference to throwable `core_rpc_server`:
`core_rpc_server.cpp:164: m_bootstrap_daemon.reset(new bootstrap_daemon([this]{ return get_random_public_node(); }));`
The solution is to simply remove noexcept from the remaining `bootstrap_daemon`
constructors because noexcept is false in this context.
>"An exception of type "boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::asio::invalid_service_owner>>" is thrown but the throw list "noexcept" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate()."
|
|
|
|
Simplify m_template initialization in miner
|
|
One considers the blockchain, while the other considers the
blockchain and some recent actions, such as a recently created
transaction which spend some outputs, but isn't yet mined.
Typically, the "balance" command wants the latter, to reflect
the recent action, but things like proving ownership wants
the former.
This fixes a crash in get_reserve_proof, where a preliminary
check and the main code used two concepts of "balance".
|
|
Much easier to work with than the raw unlock_time field
|
|
IP addresses are stored in network byte order even on little
endian hosts
|
|
|
|
|
|
|
|
839fc62 reject setting lookahead major or minor to 0 (moneromoo-monero)
|
|
07cb087 blockchain: Fix alt chain generated coins overflow (iamamyth)
|
|
69465e3 cryptonote_protocol: fix '--no-sync', ignore new blocks and txes (xiphon)
|
|
082730b daemon: automatic public nodes discovering and bootstrap daemon switching (xiphon)
|
|
1a367d6 simplewallet: lock console on inactivity (moneromooo-monero)
|
|
|
|
|
|
bdfc63a Add ref-counted buffer byte_slice. Currently used for sending TCP data. (vtnerd)
3b24b1d Added support for 'noise' over I1P/Tor to mask Tx transmission. (vtnerd)
|
|
the setting
|
|
|
|
Best case is an address mined previously and it'll get returned,
worst case it was never initialized in the first place
|
|
|
|
|
|
|
|
|
|
|
|
The 98th percentile position in the agebytes map was incorrectly
calculated: it assumed the transactions in the mempool all have unique
timestamps at second-granularity. This commit fixes this by correctly
finding the right cumulative number of transactions in the map suffix.
This bug could lead to an out-of-bounds write in the rare case that
all transactions in the mempool were received (and added to the mempool)
at a rate of at least 50 transactions per second. (More specifically,
the number of *unique* receive_time values, which have second-
granularity, must be at most 2% of the number of transactions in the
mempool for this crash to trigger.) If this condition is satisfied, 'it'
points to *before* the agebytes map, 'delta' gets a nonsense value, and
the value of 'i' in the first stats.histo-filling loop will be out of
bounds of stats.histo.
|
|
3a0451a MLSAG speedup and additional checks (SarangNoether)
|
|
|
|
7c894fc device_ledger: add paranoid buffer overflow check (moneromooo-monero)
f07524b device_ledger: fix uninitialized additional_key (moneromooo-monero)
|
|
1dc3b1a wallet: add --extra-entropy command line flag (moneromooo-monero)
|
|
33e91e1 wallet, rpc: add a release field to get_version (moneromooo-monero)
|
|
|
|
It does not leak much since you can make a fair guess by RPC
version already, and some people want to avoid non release
clients when using third parties' nodes (because they'd never
lie about it)
|
|
Coverity 200185
|
|
Coverity 200183
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
New CLI wallet variable: export-format with options "binary" (the default),
or "ascii". "Binary" behaves as before, "ascii" forces the wallet to convert
data to ASCII using base64.
Reading files from the disk tries to auto detect what format has been
used (using a magic string added when exporting the data).
Implements https://github.com/monero-project/monero/issues/2859
|
|
|
|
spentness test
|
|
spent ratio
|
|
It lets the user add custom entropy to the PRNG.
It does this by hashing the new data and xoring the resulting
hash with the PRNG state.
|
|
30779de fix feature not introduced until boost 1.66 (jtgrassie)
|
|
50ec40e Increase max_dbs from 20 to 32 (hyc)
|
|
adc16d2 Fix check for disconnecting peers when syncing (jagerman)
|
|
5a91b83 simplewallet: add a few missing settings help text (stoffu)
ae7bf37 simplewallet: fix arg indexing bug in set_device_name (stoffu)
|
|
4b1df4e Fix for biased signature nonce (SarangNoether)
|
|
6ca033d hid_error() could return a null, which causes the program to crash with (TheQuantumPhysicist)
|
|
8703aa5 MMS: Use chans instead of normal addresses for auto-config (rbrunner7)
|
|
7a3e458 improve tx_sanity_check clarification (vicsn)
|
|
884df82 wallet: provide original address for outgoing transfers (xiphon)
|
|
65f29a8 simplewallet: add restore_height command (tobtoht)
|
|
0d916a6 Fix incorrectly named binding for MMS send_signer_config command (tobtoht)
|
|
256d286 Minor formatting fix in help set command (tobtoht)
|
|
c393e82 CryptonightR_JIT: fix return value on error (selene-kovri)
|
|
8be5fea simplewallet: optional all flag to export_outputs/export_key_images (moneromooo-monero)
|
|
Also remove the delta time fixup, since we now ignore those
as they're attacker controlled
|
|
It was here while debugging, and I forgot to move it away
|
|
|
|
|
|
|
|
|
|
fd60d05 daemon: fix print_pl only printing public zone peers (moneromooo-monero)
|
|
|
|
|
|
b712ae0 rpc: work around a GCC 7.4.0 (at least) bug (moneromooo-monero)
|
|
6560bfa rpc: get_block_template add optional extra_nonce (jtgrassie)
|
|
7b9a420 Replace std::random_shuffle with std::shuffle (tomsmeding)
|
|
dc8b7a8 zmq: MacPorts latest fix (jtgrassie)
|
|
c164f90 Remove unnecessary m_check_txin_table, fix const correctness (omartijn)
|
|
bcd2da7 miner: fix --bg-mining-enable description (moneromooo-monero)
|
|
c8709fe wallet: do not print log settings when unset (moneromooo-monero)
7b18e83 unit_tests: check return values on test data parsing (moneromooo-monero)
|
|
|
|
We're supposed to have a fixed ring size now
Already checked by MLSAG verification, but here seems more intuitive
|
|
|
|
|
|
Apply the overflow logic used for computing already_generated_coins in
the main chain to alternative chains.
|
|
We've added a lot of new indices recently, and 20 isn't enough for them plus
new DBs opened during format migrations.
|
|
a604241 simplewallet: don't ask about mining when running a command line (moneromooo-monero)
|
|
def703a wallet_api: add multi destination tx support (selsta)
|
|
The check added here (in #5732/#5733) is supposed to disconnect behind
peers when the current node is syncing, but actually disconnects behind
peers always.
We are syncing when `target > our_height`, but the check here triggers
when `target > remote_height`, which is basically always true when the
preceding `m_core.have_block(hshd.top_id)` check is true.
|
|
|
|
1db5357 rpc headers fix (malbit)
|
|
3768db2 p2p: add a reference to Cao, Tong et al. for the last_seen changes (moneromooo-monero)
|
|
fcbf7b3 p2p: propagate out peers limit to payload handler (moneromooo-monero)
098aadf p2p: close the right number of connections on setting max in/out peers (moneromooo-monero)
|
|
097cca5 wallet_api: catch getTxKey exception (ph4r05)
|
|
b2bfcab wallet2: fix change subaddress mixup when sending pre rct outputs (moneromooo-monero)
|
|
64fb0f8 device: tx_key caching fixed, store recovered txkey (ph4r05)
|
|
6bb2797 daemon: print 128bit diff properly (stoffu)
|
|
8ccc30b Fix --restore-date usage (hyc)
|
|
a182df2 Bans for RPC connections (hyc)
|
|
69f9420 core: do not complain about low block rate if disconnected (moneromooo-monero)
|
|
According to [1], std::random_shuffle is deprecated in C++14 and removed
in C++17. Since std::shuffle is available since C++11 as a replacement
and monero already requires C++11, this is a good replacement.
A cryptographically secure random number generator is used in all cases
to prevent people from perhaps copying an insecure std::shuffle call
over to a place where a secure one would be warranted. A form of
defense-in-depth.
[1]: https://en.cppreference.com/w/cpp/algorithm/random_shuffle
|
|
1488109 rpc: fix get_transactions getting v1 txes from the txpool (moneromooo-monero)
|
|
52cd2fa rpc: implement get_public_nodes command (xiphon)
|
|
0605406 daemon: sort alt chains by height (moneromooo-monero)
4228ee0 daemon: add optional arguments to alt_chain_info (moneromooo-monero)
880ebfd daemon: add more chain specific info in alt_chain_info (moneromooo-monero)
|
|
df83ed7 consensus: from v12, enforce >= 2 outputs (moneromooo-monero)
|
|
7d9b7fe functional_tests: add validate_address tests (moneromooo-monero)
|
|
155475d Add IPv6 support (KeeJef/tewinget)
|
|
|
|
|
|
|
|
|
|
std::logic_error()
|
|
new cli options (RPC ones also apply to wallet):
--p2p-bind-ipv6-address (default = "::")
--p2p-bind-port-ipv6 (default same as ipv4 port for given nettype)
--rpc-bind-ipv6-address (default = "::1")
--p2p-use-ipv6 (default false)
--rpc-use-ipv6 (default false)
--p2p-require-ipv4 (default true, if ipv4 bind fails and this is
true, will not continue even if ipv6 bind
successful)
--rpc-require-ipv4 (default true, description as above)
ipv6 addresses are to be specified as "[xx:xx:xx::xx:xx]:port" except
in the cases of the cli args for bind address. For those the square
braces can be omitted.
|
|
|
|
|
|
|
|
get_attribute expects 2 values instead of 1
|
|
03aa14e tx_sanity_check: don't print an error when not enough outs to check (monermooo-monero)
|
|
6b41bd8 Delete more include string.h (wepeng)
|
|
b8cfa92 rpc: implement set_bootstrap_daemon method (xiphon)
|
|
068fa1c p2p: delay IGP probing on startup (moneromooo-monero)
|
|
c820e18 simplewallet: print errors on exceptions creating wallets (moneromooo-monero)
|
|
cf8cb68 rpc: use ip address string representation for peer::host field (xiphon)
|
|
dd58057 Remember RPC version on initial connect (hyc)
|
|
343c0b4 add a command line option to disable ZMQ server (jtgrassie)
|
|
2aa1134 daemon: display peer address type in print_cn (moneromooo-monero)
|
|
f074b6b device: show address on device display (ph4r05)
|
|
f17dcde Remove unused txs member in NOTIFY_RESPONSE_GET_OBJECT (Doy-lee)
|
|
cd720c7 add cumulative difficulty to diff command (wowario)
|
|
270a3ae Unused private member m_miner_address (JesusRami)
|
|
fcfcc3a rpc: in/out peers can now return the setting's value (moneromooo-monero)
|
|
577324a wallet_manager: omit redundant disconnect, drop unused variable (xiphon)
|
|
162c3e1 blockchain_export: allow exporting blocks.dat format from pruned (moneromooo-monero)
|
|
c07bbd5 daemon: fix 'never seen before' time span display for peers (moneromooo-monero)
|
|
4c66614 expose set/get walletcache attribute functionality in wallet api (selsta)
|
|
6abaaaa remove obsolete save_graph skeleton code (moneromooo-monero)
|
|
06b8f29 blockchain: keep alternative blocks in LMDB (moneromooo-monero)
|
|
e4d100b wallet2: don't wait a day before using new version fees (moneromooo-monero)
|
|
bc94ba4 wallet: distinguish between empty and absent attributes (moneromooo-monero)
|
|
25a7cfd add a few checks where it seems appropriate (moneromooo-monero)
1a66a86 remove unused code (moneromooo-monero)
|
|
a23dbe6 simplewallet: prompt when spending more than one old out in one tx (moneromooo-monero)
|
|
3b9ce45 wallet_rpc_server: remove unused variable (moneromooo-monero)
|
|
6aa3c2f dns_checks: new helper program to check on DNSSEC lookups (moneromooo-monero)
|
|
515ac29 p2p: store network address directly in blocked host list (moneromooo-monero)
65c4004 allow blocking whole subnets (moneromooo-monero)
|
|
|
|
|