Age | Commit message (Collapse) | Author | Files | Lines |
|
When doing a first refresh on HW-token based wallet KI sync is required if money were received. Received money may indicate wallet was already used before the restore I.e., some transaction could have been already sent from the wallet. The spent UTXO would not be detected as spent which could lead to double spending errors on submitting a new transaction.
Thus if the wallet is HW-token based with the cold signing protocol and the first refresh detected received money the user is asked to perform the key image sync.
|
|
- adds a new option `--hw-device-deriv-path` to the simple wallet. Enables to specify wallet derivation path / wallet code (path avoided so it can be misinterpreted as a file path).
- devices can use different derivation mechanisms. Trezor uses standard SLIP-10 mechanism with fixed SLIP-44 prefix for Monero
- Trezor: when empty, the default derivation mechanism is used with 44'/128'/0'. When entered the derivation path is 44'/128'/PATH.
- Trezor: the path is always taken as elements are hardened (1<<31 bit turned on)
|
|
- simple device callback object added. Device can request passphrase/PIN entry via the callback or notify user some action is required
- callback is routed to wallet2, which routes the callback to i_wallet_callback so CLI or GUI wallets can support passphrase entry for HW tokens
- wallet: device open needs wallet callback first - passphrase protected device needs wallet callback so user can enter passphrase
|
|
fc98f7a0 rpc: speedup get_outs.bin (moneromooo-monero)
|
|
|
|
2c7195d8 bulletproofs: avoid std::vector allocations for slice (moneromooo-monero)
|
|
c5ee14ae json_archive: initialize inner_array_size in ctor (moneromooo-monero)
|
|
dffec258 db_lmdb: error out if the db needs migration in read only mode (moneromooo-monero)
|
|
b9b307d1 rpc: speedup get_output_distribution (moneromooo-monero)
|
|
2ffe53d9 device/trezor: webusb transport added, cmake fixes (Dusan Klinec)
|
|
1a4d1603 wallet2: remove redundant chacha key generation in store_keys (stoffu)
|
|
- webusb transport based on libusb added. Provides direct access to Trezor via USB, no need for Trezor bridge.
- trezor protocol message handler improved, no recursion used. Ready for upcoming integration tests.
- libusb (for docker) bumped from v1.0.9 to v1.0.22, newer version required for webusb transport, for device enumeration.
- cmake improvements and fixes. Cmake Trezor checks are moved to a dedicated CheckTrezor.cmake file. In case of a problem Trezor is excluded from build.
- ifdefs made consistent to Ledger.
- UDP Transport enumeration disabled by default in release mode
|
|
and decrease the amount of data carried around
|
|
2a48c2a2 slow-hash: some more big endian fixes (xiphon)
b39fdf8e slow-hash: fix for big endian (moneromooo-monero)
|
|
|
|
This prevents asking for just 0, and the RPC layer already does this
|
|
This reverts commit b2bb9312a75781e714acf3c406634b3d4cded418.
|
|
|
|
|
|
ac23b10f blockchain: fix innocuous difficulty cache inconsistency (moneromooo-monero)
3b14d972 blockchain: use uint64_t for block height, not size_t (moneromooo-monero)
|
|
6a1062f5 bulletproofs: reserve vector memory when known in advance (moneromooo-monero)
|
|
00907c39 rct: speedup commit a little (moneromooo-monero)
|
|
7ae36e91 wallet_rpc_server: account for watch-only/non-deterministic/multisig when querying seed (stoffu)
|
|
79b4dae6 simplewallet: slightly adjust wording when printing multisig seed (stoffu)
|
|
f4988454 perf_timer: remove stray debug addition (moneromooo-monero)
|
|
5d7c2316 rct: add a zeroCommit cache for common pre-rct case (moneromooo-monero)
|
|
e198b06e Fix: out_of_hashchain_bounds_error in refresh (Hasan Pekdemir)
|
|
5d4f3df8 simplewallet: reorganize SCOPED_WALLET_UNLOCK a bit more (stoffu)
|
|
5878fe95 simplewallet: don't skip asking for password when watch-only (stoffu)
|
|
177a9d76 wallet: warn if lockable memory limit is too low (moneromooo-monero)
|
|
0afdb00b wallet2: fix print_ring printing double entries for transactions (moneromooo-monero)
|
|
8f3963d2 wallet2: demote a few uninteresting recurring logs to TRACE (moneromooo-monero)
|
|
c22e85fe simplewallet: remove redundant messages on daemon connection failure (stoffu)
|
|
1c04c21d wallet_rpc_server: include additional tx keys in sign_transfer response (stoffu)
|
|
71eb32a9 dns_utils: do not exit if DNS records are corrupt (moneromooo-monero)
|
|
c17a1d43 daemon: use msg_writer, not cout, to display information (moneromooo-monero)
|
|
03fc731b p2p: less frequent incoming connections check (moneromooo-monero)
14a5c206 p2p: tone down "no incoming connections" warning to info if in peers is 0 (moneromooo-monero)
|
|
2bd46065 Expose limit-rate defaults from command line help (RaskaRuby)
|
|
cf552c75 tx_pool: allow take_tx to work without m_txs_by_fee_and_receive_time (moneromooo-monero)
|
|
09dbd9cb tx_pool: fix comment about transaction_prefix (moneromooo-monero)
|
|
1598f01c wallet2: use padded bulletproofs for multisig signing (stoffu)
|
|
a9357141 Add new command "export_transfers" to save transfers to csv (sachaaaaa)
|
|
Coverity 136581
|
|
|
|
5808530f blockchain: remove unused output_scan_worker parameter (moneromooo-monero)
1426209a blockchain: don't run threads if we have just one function to run (moneromooo-monero)
6f7a5fd4 db_lmdb: slight speedup getting array data from the blockchain (moneromooo-monero)
99fbe100 db_lmdb: save some string copies for readonly db keys/values (moneromooo-monero)
bf31447e tx_pool: speed up take_tx for transactions from blocks (moneromooo-monero)
4f005a77 tx_pool: remove unnecessary get_transaction_hash (moneromooo-monero)
593ef598 perf_timer: call reserve on new timer array (moneromooo-monero)
6ecc99ad core: avoid unnecessary tx/blob conversions (moneromooo-monero)
00cc1a16 unit_tests: notify test special case for the usual weirdo (moneromooo-monero)
|
|
6e1282b6 wallet2: fix off by one in output picking (moneromooo-monero)
|
|
db24a2e5 hash: fix hash_permutation on big endian (moneromooo-monero)
|
|
42d8d508 crypto: fix AES encryption on big endian (xiphon)
|
|
157054b8 hardfork: initialize current_fork_index in ctor (moneromooo-monero)
2362baf7 network_throttle: initialize m_last_sample_time in ctor (moneromooo-monero)
d9400f69 serializtion: add missing mainnet and stagenet fields for 0mq (moneromooo-monero)
cbe0122b wallet2: initialize amount to 0 in tx_scan_info_t ctor (moneromooo-monero)
|
|
e61062b6 use current height - 1 for top block height in err msgs (cryptochangements34)
|
|
dad5bbfd return message in stop_mining if mining never started (cryptochangements34)
|
|
f3019efe wallet-rpc: add on_restore_deterministic RPC call. (Hasan Pekdemir)
|
|
6d3311ac libwallet_api_tests: add missing dependency on Boost Locale and ICU (stoffu)
f0459abb cmake: move Boost_LOCALE_LIBRARY out of ICU_LIBRARIES (stoffu)
|
|
|
|
|
|
|
|
|
|
|
|
840bf155 build: fix Ubuntu 16.04 (GCC 5.4.0) compilation (xiphon)
|
|
|
|
|
|
|
|
1fd017cf Fix build of monero-gui by adding device_trezor to wallet_merged (buricl)
|
|
b3e8677c cryptonote: use logging functions for errors, not std::cout (moneromooo-monero)
|
|
9335d5a2 wallet2: save ring in the ringdb once a tx is created (moneromooo-monero)
|
|
0a95cdaa blockchain_utilities: fix logs and cout output colliding (moneromooo-monero)
|
|
107f3398 wallet2: fix ring reuse breaking when using histogram (moneromooo-monero)
|
|
73e504c1 rpc: adjust ring size error message now that too high is also possible (moneromooo-monero)
a5ca7f4f core: fix unmixable special case allowing ring size below 11 (moneromooo-monero)
|
|
b3067962 cryptonote_core: avoid gratuitous recalculations in check_block_rate() (xiphon)
|
|
f26ce08c wallet: add a non destructive blockchain rescan (moneromooo-monero)
|
|
e86af52e wallet2: rewrite keys file in a safer manner (Nathan Dorfman)
|
|
1f35de23 simplewallet: display locked/unlocked state in show_transfers (moneromooo-monero)
|
|
91eaea9c mnemonics: fix words_to_bytes on big endian (moneromooo-monero)
|
|
5f614ba9 simplewallet: print the number of show/all transfers (moneromooo-monero)
8d71b2b1 wallet2: only export necessary outputs and key images (moneromooo-monero)
769ae42a wallet2: faster output and key image import/export (moneromooo-monero)
|
|
c4fbfd78 Small function declaration cleanup in slow-hash.c (Pol Mauri)
|
|
97cad7e9 db_lmdb: log which output was not found in get_output_key (moneromooo-monero)
|
|
|
|
and take into account wallet level minimum spend age
|
|
This inconsistent state would not actually be used in practice
|
|
for consistency
|
|
|
|
saves a conversion, and uses a double scalarmult instead of
two scalarmults
|
|
querying seed
Followup on #4653
|
|
|
|
|
|
Undefined symbols for architecture x86_64:
"cryptonote::core::get_output_distribution(unsigned long long, unsigned long long, unsigned long long, unsigned long long&, std::__1::vector<unsigned long long, std::__1::allocator<unsigned long long> >&, unsigned long long&) const", referenced from:
cryptonote::rpc::RpcHandler::get_output_distribution(cryptonote::core&, unsigned long long, unsigned long long, unsigned long long, bool) in rpc_handler.cpp.o
|
|
|
|
and disable annoying test that requires ridiculous amounts
of skullduggery every time some format changes
|
|
|
|
70877b1d wallet2/create_transactions_2: removed obsolete '/ 1024' on min_fee calc (Paul Shapiro)
|
|
a43daebf Add stats utility (Howard Chu)
|
|
74fb3d88 multiexp: some minor speedups (moneromooo-monero)
a6d2e246 bulletproofs: only enable profiling on request (moneromooo-monero)
a110e6aa multiexp: tune which variants to use for which number of points (moneromooo-monero)
8b476722 bulletproofs: speedup prover (moneromooo-monero)
6f9ae5b6 multiexp: handle pippenger multiexps with part precalc (moneromooo-monero)
10e5a927 bulletproofs: maintain -z4, -z5, and -y0 to avoid subtractions (moneromooo-monero)
8629a42c bulletproofs: rework flow to use sarang's fast batch inversion code (moneromooo-monero)
fc9f7d9c bulletproofs: merge multiexps as per sarang's new python code (moneromooo-monero)
4061960a multiexp: pack the digits table when STRAUS_C is 4 (moneromooo-monero)
bf8e4b98 bulletproofs: some more minor speedup (moneromooo-monero)
c415df97 performance_tests: sc_check and ge_dsm_precomp (moneromooo-monero)
a281b950 bulletproofs: remove single value prover (moneromooo-monero)
484155d0 bulletproofs: some more speedup (moneromooo-monero)
a621d6c8 bulletproofs: random minor speedups (moneromooo-monero)
a49a1761 bulletproofs: shave off a lot of scalar muls from the g/h construction (moneromooo-monero)
4564a5d1 bulletproofs: speedup PROVE (moneromooo-monero)
|
|
cb4aafd2 blockchain_utilities: simplify getting block blob from height (moneromooo-monero)
|
|
7f0dd094 wallet2: sanity check rct output distribution from the daemon (moneromooo-monero)
|
|
ba0faae7 crypto: fixed groestl on big-endian platforms (xiphon)
ed36335c crypto: fixed incremental keccak API on big-endian platforms (xiphon)
|
|
5a2e54a1 Fix prune using receive time as tx_weight (doy-lee)
|
|
6097472a Update ZMQ fee estimate and add ZMQ output distribution (Lee Clagett)
|
|
cf646e3a wallet2/create_transactions_2: removed extraneous shuffle before sort of unused_*_indices_per_subaddr (Paul Shapiro)
|
|
76681b9b wallet2/create_transactions_2: fixed typo in try_tx=true's estimate_fee args (Paul Shapiro)
|
|
4a003bb5 mnemonics/electrum-words/create_checksum_index(): updated to work with non fixed word list length mnemonic (Paul Shapiro)
|
|
3a85af40 core: fix handle_incoming_tx* comment about return value (moneromooo-monero)
|
|
29ffb6bb device/trezor: trezor support added (Dusan Klinec)
|
|
233f00c6 cryptonote_core: fix build error gcc 5.4.0 'sign-compare' (xiphon)
|
|
15:43 < hahsun> Im on stagenet and I suddenly get this exception: 2018-11-04 14:42:52.416 [RPC0] ERROR wallet.wallet2 src/wallet/wallet2.cpp:2070 !m_blockchain.is_in_bounds(current_index). THROW EXCEPTION: error::out_of_hashchain_bounds_error
16:01 <+moneromooo> OK, possibly because the blckchain is always seeded with the genesis block hash...
16:02 <+moneromooo> So that case should be allowed, assuming it doesn't break the code around it.
16:05 <+moneromooo> OK if stop_height == size || (size==1 && stop_heigt ==0)
16:05 <+moneromooo> Throw if not that.
16:06 < hahsun> k
|
|
This is called for every pre-rct output at blockchain sync time,
and a lot of them wil hit the cache, saving a scalarmult each.
|
|
|
|
|
|
|
|
Followup on #4555
|
|
|
|
|
|
|
|
|
|
When a tx gets from unconfirmed to conirmed, the rings for that
transaction were being added twice
|
|
|
|
|
|
try_connect_to_daemon with silent=false already prints failure message
|
|
Followup on #4552
|
|
|
|
|
|
|
|
|
|
|
|
61304151 db_lmdb: use MDB_MULTIPLE_NEXT where possible for some speedup (moneromooo-monero)
|
|
d6937e37 ringct: use dummy bulletproofs when in fake mode, for speed (moneromooo-monero)
|
|
ca9b996d perf_timer: separate log categories based on caller categories (moneromooo-monero)
|
|
ade369f9 Add RPC error code for non-deterministic wallet (Michał Sałaban)
|
|
a7bffead daemon: fix base fee stating /kB even when it is per byte (moneromooo-monero)
|
|
6f88c03d Simplewallet: update help text for show_transfers. (Ted Moravec)
|
|
ec301390 Update db_lmdb.cpp (Cactii1)
|
|
|
|
Also add an info if not offline, since it weakens the network
|
|
This happens for every historical tx when syncing, and the
unnecessary parsing is actually showing up on profile.
Since these are kept cached for just one block, this does
not increase memory usage after syncing.
|
|
|
|
to avoid reallocations in the vast majority of the time
|
|
|
|
|
|
This should make it possible to have two daemons running on the
same database again.
|
|
It was leftover from a change that was undone before commit,
but the comment change was let through
|
|
Analogous to #4540
|
|
|
|
|
|
|
|
Also order init list to match actual runtime init order
Coverity 136605
|
|
Coverity 184940
|
|
It seems the more prudent thing to do here. It will not catch
attempts to use that value before it is initialized when using
ASAN or valgrind, but in a case where it does, it will have
smaller repercussions.
So it seems appropriate in this particular case.
Coverity 182498
|
|
|
|
|
|
|
|
Even if it is never relayed, it ensures a daemon supplying
fake outs on demand will never be asked for a set with the
real input being the only intersecting member (only a problem
with people who trust their privacy to some stranger's node,
but it seems to be a massively common thing, even in Monero)
|
|
|
|
|
|
|
|
|
|
0aff4987 rpc: fix build with older compilers (moneromooo-monero)
|
|
3bb4b0d4 miner: fix build with boost 1.69 (moneromooo-monero)
|
|
62f94e1b device_io_hid.cpp: fix copyright header (moneromooo-monero)
|
|
3ffbec15 rpc: init m_rpc_version in Message ctor (moneromooo-monero)
bfa2dce1 rpc: remove unused ctors (moneromooo-monero)
7cc39845 account: init creation timestamp to 0 (moneromooo-monero)
32123789 wallet2: initialize some scalar fields in ctor where appropriate (moneromooo-monero)
4eca42b2 blockchain_db: initialize m_hardfork in ctor just in case (moneromooo-monero)
|
|
a7960542 WalletAPI: rescanBlockchain, rescanBlockchainAsync (mmitkevich)
|
|
2d48861d p2p: only deinitialize what's been initialized in offline mode (moneromooo-monero)
|
|
e54e5668 daemon: Show mining address (Ricardo de Vries)
|
|
0fbbb065 p2p: a negative result from UPNP_GetValidIGD is an error (moneromooo-monero)
|
|
e51c9787 rpc: fix wrongly formatted JSON for pruned tx (stoffu)
|
|
04ddf02e Return appropriate RPC error code when key image signature check fails (Michał Sałaban)
|
|
68e9744d simplewallet: perform trivial error checks before password prompt (xiphon)
|
|
67e76aa0 wallet_rpc_server: optionally return tx keys in sign_transfer (moneromooo-monero)
|
|
f2c2c47a simplewallet: fixed deadlock if a user hits CTRL+C twice (xiphon)
|
|
93a88d73 Utils: add support for newer Windows versions detection (Gregory Lemercier)
|
|
977fc1bc wallet_rpc_server: add describe_transfer RPC (moneromooo-monero)
|
|
fd62b6e7 blocks: use auto-generated .c files instead of 'LD -r -b binary' (xiphon)
|
|
341b3931 cryptonote_core: warn when the block rate deviates from expectations (moneromooo-monero)
|
|
9907ea06 cryptonote: sort tx_extra fields (moneromooo-monero)
|
|
it doesn't display the details, which are already displayed
in show_transfer
|
|
|
|
|
|
|
|
- These functions are declared twice in slow-hash.c. Remove one of the copies.
- The declarations have the wrong return type, should be void, not int.
Function definitions here: https://github.com/monero-project/monero/blob/1e74586ee99e4bd89626d2eb4d23883cd91f0f81/src/crypto/aesb.c#L151-L180
Test plan: make release-test
|
|
|
|
|
|
Report statistics from a blockchain DB
|
|
in order to unbias selection from blocks with few txes
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Spotted by stoffu
|
|
|
|
It is now expressed in terms of the array prover
|
|
|
|
|
|
|
|
|
|
|