| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
9996d5e9 wallet2: guard against the dameon sending blocks before last checkpoint (moneromooo-monero)
eadaa6aa wallet_rpc_server: fix wallet leak on error exit (moneromooo-monero)
|
|
7c4f01a7 blockchain_import: more informative verification switch (moneromooo-monero)
|
|
776b44f1 Add misc hardening flags to the cmake machinery (moneromooo-monero)
|
|
2d17feb0 factor STL container serialization (moneromooo-monero)
|
|
66eeeaa1 wallet2: fix failure to create tx if inputs are not enough for fee (moneromooo-monero)
|
|
8a4610c3 blake256: fix wrong hash when computed in parts (moneromooo-monero)
|
|
6d8b29ef fix some link errors in debug mode for macos (stoffu)
fdd4c5e5 move memwipe to epee to avoid common<->crypto circular dependencies (moneromooo-monero)
40ab12a7 epee: remove dependency on common (moneromooo-monero)
|
|
6fc4fc85 sweep_below: do not prematurely exclude subaddresses set (stoffu)
|
|
b63afbaa simplewallet: detect typo for incoming_transfers options (stoffu)
|
|
c765f951 simplewallet: disable donations on testnet (Matt Smith)
|
|
277a5aef wallet2: fix m_key_image_{partial,known} in_light_wallet code (moneromooo-monero)
|
|
586ee642 simplewallet: lock idle scope in {im,ex}port_{key_images,outputs} (moneromooo-monero)
|
|
ae860230 Fix exceptions not finding txpool txes when relaying (moneromooo-monero)
|
|
|
|
|
|
|
|
294adc83 Additional fix for core_tests (Howard Chu)
d52b732e Fix stale readcursor flags (Howard Chu)
|
|
c70e8daa threadpool: fix deadlock in recursive waiter usage (moneromooo-monero)
|
|
55556fab wallet_rpc_server: factor transfer info return and add missing info (moneromooo-monero)
|
|
14c29814 wallet2: fix use of uninitialized data (moneromooo-monero)
|
|
5cbcf0aa wallet: support for multisig seeds (moneromooo-monero)
|
|
db2bc965 Embed the translation files in the binary (Guillaume LE VAILLANT)
|
|
See https://wiki.debian.org/Hardening#User_Space
|
|
Reset thread-local info if it doesn't match the current env.
Only happens when a process opens/closes env multiple times in the
same process, doesn't affect monerod.
|
|
e20e489a Better definite article use (xmr-eric)
|
|
1a686bf8 daemon: print num txes in print_bc (moneromooo-monero)
|
|
9e07ccf1 daemon: remove some superfluous includes (moneromooo-monero)
|
|
4f45f9da simplewallet: factor out tx exceptions (moneromooo-monero)
|
|
d0d38dc8 wallet2: print tx size in bytes and kB (moneromooo-monero)
|
|
da0fd71d only include the easylogging++ stack trace code when needed (moneromooo-monero)
81b04cfa easlogging++: omit some unneded macros (moneromooo-monero)
|
|
Reset thread-specific flags when a write txn is started.
Also remove some redundant start-readtxn code.
|
|
|
|
|
|
|
|
|
|
7e7b1a82 Revert "return subaddress in get_bulk_payments" (moneromooo-monero)
|
|
This reverts commit b60f48f0e31c17638f771042887b2fffdbad15b4.
|
|
5ad312a1 wallet2: switch to chacha20 instead of chacha8 (moneromooo-monero)
1e5491e9 Add a chacha20 variant to go with chacha8 (moneromooo-monero)
|
|
aaae94f0 wallet2: reinstate the single preferred output selection (moneromooo-monero)
|
|
Wallet caches and keys files are loaded with chacha8 as needed,
but only saved with chacha20. Other data (eg, cold wallet data
files, etc) will be incompatible.
|
|
|
|
04349492 wallet2: error out in get_seed if the language is invalid (moneromooo-monero)
|
|
ae55bacd resumption support for updates using range requests (moneromooo-monero)
fe0fae50 epee: add a get_file_size function (moneromooo-monero)
|
|
d28c388f p2p: stop net server before closing starting connections (moneromooo-monero)
|
|
6b5bd129 Account tagging (stoffu)
|
|
a1d44f27 updates: use https for updates (moneromooo-monero)
472a93c8 download: SSL suport (moneromooo-monero)
|
|
bd5cce07 network_throttle: fix ineffective locking (moneromooo-monero)
e0a61299 network_throttle: remove unused xxx static member (moneromooo-monero)
24f584d9 cryptonote_core: remove unused functions with off by one bugs (moneromooo-monero)
b1634aa3 blockchain: don't leave dangling pointers in this (moneromooo-monero)
8e60b81c cryptonote_core: fix db leak on error (moneromooo-monero)
213e326c abstract_tcp_server2: log init_server errors as fatal (moneromooo-monero)
b51dc566 use const refs in for loops for non tiny types (moneromooo-monero)
f0568ca6 net_parse_helpers: fix regex error checking (moneromooo-monero)
b49ddc76 check accessing an element past the end of a container (moneromooo-monero)
2305bf26 check return value for generate_key_derivation and derive_public_key (moneromooo-monero)
a4240d9f catch const exceptions (moneromooo-monero)
45a1c4c0 add empty container sanity checks when using front() and back() (moneromooo-monero)
56fa6ce1 tests: fix a buffer overread in a unit test (moneromooo-monero)
b4524892 rpc: guard against json parsing a non object (moneromooo-monero)
c2ed8618 easylogging++: avoid buffer underflow (moneromooo-monero)
187a6ab2 epee: trap failure to parse URI from request (moneromooo-monero)
061789b5 checkpoints: trap failure to load JSON checkpoints (moneromooo-monero)
ba2fefb9 checkpoints: pass std::string by const ref, not const value (moneromooo-monero)
38c8f4e0 mlog: terminate a string at last char, just in case (moneromooo-monero)
d753d716 fix a few leaks by throwing objects, not newed pointers to objects (moneromooo-monero)
fe568db8 p2p: use size_t for arbitrary counters instead of uint8_t (moneromooo-monero)
46d6fa35 cryptonote_protocol: sanity check chain hashes from peer (moneromooo-monero)
25584f86 cryptonote_protocol: print peer versions when unexpected (moneromooo-monero)
490a5d41 rpc: do not try to use an invalid txid in relay_tx (moneromooo-monero)
|
|
f5bc7f18 simplewallet: fix default unspent_outputs output with subaddresses (moneromooo-monero)
|
|
a9217641 wallet-rpc: added receiving address to res of get(_bulk)_payments; selective addresses for getaddress (stoffu)
|
|
1741fb5f node_rpc_proxy: remove unused local and time call (moneromooo-monero)
|
|
b60f48f0 return subaddress in get_bulk_payments (Dmitriy Plekhanov)
|
|
3f24e901 wallet2: don't write a .new file when not needed (moneromooo-monero)
|
|
83b0f9e6 version: add -master to master version (moneromooo-monero)
493f7d09 util: allow non numeric version parts (moneromooo-monero)
|
|
ca18ff64 wallet2: detect spends in txes without a valid public tx key (moneromooo-monero)
6afcd8e3 cn_deserialize: print tx extra fields in partly decoded tx extra (moneromooo-monero)
|
|
|
|
Makes it easier to debug leaks
|
|
|
|
Fix no new line
|
|
If a queued job uses a waiter, then we want to run that waiter's
jobs in the current thread if all threads are busy, even if the
queue is empty, since there is no guarantee that any thread will
free up to take care of that new job, since all the threads might
be running a job which spawns such a recursive job and will block
till that recursive job is done, which it will never be since it
relies on the queue being polled by one of those blocked threads.
|
|
|
|
This does not happen when used by the monero code
|
|
|
|
|
|
|
|
This ensures we can't get races
|
|
|
|
They are hex rather than words, because they are a lot longer
than "normal" seeds, as they have to embed a lot more information
|
|
Additional tx keys, amounts and fees were missing in some cases
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
also avoid integer underflow on zero height
|
|
|
|
addresses for getaddress
|
|
|
|
ceabc4f9 change the N-1/N multisig second message signer for auth (moneromooo-monero)
55c2845d core_tests: multisig test now tests multiple inputs (moneromooo-monero)
98db7ee4 wallet: factor multisig info parsing (moneromooo-monero)
31a97e76 wallet: use raw encrypted data in multisig import/export RPC (moneromooo-monero)
2fa707d1 wallet: add multisig sign/submit RPC (moneromooo-monero)
e36f5b60 Match surae's recommendation to derive multisig keys (moneromooo-monero)
a36c261d wallet2: fix slow multisig unit tests with subaddress patch (moneromooo-monero)
fa569712 make multisig work with subaddresses (moneromooo-monero)
dffa0dce simplewallet: add export_raw_multisig command (moneromooo-monero)
7f4c220b simplewallet: add multisig to wallet type in wallet_info output (moneromooo-monero)
26529038 wallet: guard against partly initialized multisig wallet (moneromooo-monero)
66e34e85 add multisig core test and factor multisig building blocks (moneromooo-monero)
f4eda44c N-1/N multisig (moneromooo-monero)
cd64c799 multisig address generation RPC (moneromooo-monero)
fff871a4 gen_multisig: generates multisig wallets if participants trust each other (moneromooo-monero)
95a21a79 wallet2: allow empty wallet filename to avoid saving data (moneromooo-monero)
b84b3565 tests: add multisig unit tests (moneromooo-monero)
4c313324 Add N/N multisig tx generation and signing (moneromooo-monero)
6d219a92 wallet: add multisig key generation (moneromooo-monero)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
While there, move the wallet2 ctor to the cpp file as it's a huge
amount of init list now, and remove an unused one.
|
|
Thanks to kenshi84 for help getting this work
|
|
It exports raw transactions, so they may be used by other tools,
for instance to be relayed to the network externally.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Useful to speed tests up and avoid unnecessary leftover files
|
|
Scheme by luigi1111:
Multisig for RingCT on Monero
2 of 2
User A (coordinator):
Spendkey b,B
Viewkey a,A (shared)
User B:
Spendkey c,C
Viewkey a,A (shared)
Public Address: C+B, A
Both have their own watch only wallet via C+B, a
A will coordinate spending process (though B could easily as well, coordinator is more needed for more participants)
A and B watch for incoming outputs
B creates "half" key images for discovered output D:
I2_D = (Hs(aR)+c) * Hp(D)
B also creates 1.5 random keypairs (one scalar and 2 pubkeys; one on base G and one on base Hp(D)) for each output, storing the scalar(k) (linked to D),
and sending the pubkeys with I2_D.
A also creates "half" key images:
I1_D = (Hs(aR)+b) * Hp(D)
Then I_D = I1_D + I2_D
Having I_D allows A to check spent status of course, but more importantly allows A to actually build a transaction prefix (and thus transaction).
A builds the transaction until most of the way through MLSAG_Gen, adding the 2 pubkeys (per input) provided with I2_D
to his own generated ones where they are needed (secret row L, R).
At this point, A has a mostly completed transaction (but with an invalid/incomplete signature). A sends over the tx and includes r,
which allows B (with the recipient's address) to verify the destination and amount (by reconstructing the stealth address and decoding ecdhInfo).
B then finishes the signature by computing ss[secret_index][0] = ss[secret_index][0] + k - cc[secret_index]*c (secret indices need to be passed as well).
B can then broadcast the tx, or send it back to A for broadcasting. Once B has completed the signing (and verified the tx to be valid), he can add the full I_D
to his cache, allowing him to verify spent status as well.
NOTE:
A and B *must* present key A and B to each other with a valid signature proving they know a and b respectively.
Otherwise, trickery like the following becomes possible:
A creates viewkey a,A, spendkey b,B, and sends a,A,B to B.
B creates a fake key C = zG - B. B sends C back to A.
The combined spendkey C+B then equals zG, allowing B to spend funds at any time!
The signature fixes this, because B does not know a c corresponding to C (and thus can't produce a signature).
2 of 3
User A (coordinator)
Shared viewkey a,A
"spendkey" j,J
User B
"spendkey" k,K
User C
"spendkey" m,M
A collects K and M from B and C
B collects J and M from A and C
C collects J and K from A and B
A computes N = nG, n = Hs(jK)
A computes O = oG, o = Hs(jM)
B anc C compute P = pG, p = Hs(kM) || Hs(mK)
B and C can also compute N and O respectively if they wish to be able to coordinate
Address: N+O+P, A
The rest follows as above. The coordinator possesses 2 of 3 needed keys; he can get the other
needed part of the signature/key images from either of the other two.
Alternatively, if secure communication exists between parties:
A gives j to B
B gives k to C
C gives m to A
Address: J+K+M, A
3 of 3
Identical to 2 of 2, except the coordinator must collect the key images from both of the others.
The transaction must also be passed an additional hop: A -> B -> C (or A -> C -> B), who can then broadcast it
or send it back to A.
N-1 of N
Generally the same as 2 of 3, except participants need to be arranged in a ring to pass their keys around
(using either the secure or insecure method).
For example (ignoring viewkey so letters line up):
[4 of 5]
User: spendkey
A: a
B: b
C: c
D: d
E: e
a -> B, b -> C, c -> D, d -> E, e -> A
Order of signing does not matter, it just must reach n-1 users. A "remaining keys" list must be passed around with
the transaction so the signers know if they should use 1 or both keys.
Collecting key image parts becomes a little messy, but basically every wallet sends over both of their parts with a tag for each.
Thia way the coordinating wallet can keep track of which images have been added and which wallet they come from. Reasoning:
1. The key images must be added only once (coordinator will get key images for key a from both A and B, he must add only one to get the proper key actual key image)
2. The coordinator must keep track of which helper pubkeys came from which wallet (discussed in 2 of 2 section). The coordinator
must choose only one set to use, then include his choice in the "remaining keys" list so the other wallets know which of their keys to use.
You can generalize it further to N-2 of N or even M of N, but I'm not sure there's legitimate demand to justify the complexity. It might
also be straightforward enough to support with minimal changes from N-1 format.
You basically just give each user additional keys for each additional "-1" you desire. N-2 would be 3 keys per user, N-3 4 keys, etc.
The process is somewhat cumbersome:
To create a N/N multisig wallet:
- each participant creates a normal wallet
- each participant runs "prepare_multisig", and sends the resulting string to every other participant
- each participant runs "make_multisig N A B C D...", with N being the threshold and A B C D... being the strings received from other participants (the threshold must currently equal N)
As txes are received, participants' wallets will need to synchronize so that those new outputs may be spent:
- each participant runs "export_multisig FILENAME", and sends the FILENAME file to every other participant
- each participant runs "import_multisig A B C D...", with A B C D... being the filenames received from other participants
Then, a transaction may be initiated:
- one of the participants runs "transfer ADDRESS AMOUNT"
- this partly signed transaction will be written to the "multisig_monero_tx" file
- the initiator sends this file to another participant
- that other participant runs "sign_multisig multisig_monero_tx"
- the resulting transaction is written to the "multisig_monero_tx" file again
- if the threshold was not reached, the file must be sent to another participant, until enough have signed
- the last participant to sign runs "submit_multisig multisig_monero_tx" to relay the transaction to the Monero network
|
|
Scheme by luigi1111
|
|
|
|
7193b89f Scrub keys from memory just before scope end. (moneromooo-monero)
|
|
43f5269f Wallets now do not depend on the daemon rpc lib (moneromooo-monero)
bb89ae8b move connection_basic and network_throttle from src/p2p to epee (moneromooo-monero)
4abf25f3 cryptonote_core does not depend on p2p anymore (moneromooo-monero)
|
|
|
|
The shared RPC code is now moved off into a separate lib
|
|
These even had the epee namespace.
This fixes some ugly circular dependencies.
|
|
As a followon side effect, this makes a lot of inline code
included only in particular cpp files (and instanciated
when necessary.
|
|
|
|
Partially implements #74.
Securely erases keys from memory after they are no longer needed. Might have a
performance impact, which I haven't measured (perf measurements aren't
generally reliable on laptops).
Thanks to @stoffu for the suggestion to specialize the pod_to_hex/hex_to_pod
functions. Using overloads + SFINAE instead generalizes it so other types can
be marked as scrubbed without adding more boilerplate.
|
|
abebe392 rpc: add offline state in info rpc (moneromooo-monero)
7696e849 core: make --offline also disable DNS lookups (moneromooo-monero)
|
|
1c838552 Simplewallet.cpp: Fewer pleases in seed NOTE (xmr-eric)
3f18c642 Fix password capitalization mismatch (xmr-eric)
|
|
2b0a32f8 Small cleanup of daemon synchronization output (xmr-eric)
|
|
cf5f6236 Corrections in rate limiting / trottle code, especially in 'out' direction (rbrunner7)
|
|
a1e3670b catch wallet decrypt false positive (Riccardo Spagni)
|
|
3dffe71b new wipeable_string class to replace std::string passphrases (moneromooo-monero)
7a2a5741 utils: initialize easylogging++ in on_startup (moneromooo-monero)
54950829 use memwipe in a few relevant places (moneromooo-monero)
000666ff add a memwipe function (moneromooo-monero)
|
|
009eed17 rpc: increase the max number of outs one can request (moneromooo-monero)
|
|
3af19c80 set_node command, allows setting node without restart (Tobias Hoffmann)
|
|
Helpful now that tx sizes are smaller
|
|
Removing it nullified the min-outputs-{count,value} system,
and will not increase the number of attempted transactions
in the general case.
|
|
If a translation file exists in a "translations" directory located in
the same directory as the binary, it is used in priority (this can be
useful when working on translations as you don't have to recompile the
whole program all the time), and if no such file is found the embedded
translation file is used (if it exists).
|
|
|
|
|
|
This fixes a hang on exit due to race where a connection adds
itself to the server after the starting connections are closed,
but before the net server marks itself as stopped.
|
|
|
|
|
|
If no subaddress index is given, consider all of them
|
|
b927f0b1 cryptonote_protocol: fix corner case looping asking for same block hashes (moneromooo-monero)
|
|
|
|
8d4469a0 ringct: do not include bulletproof commitments in signed message (moneromooo-monero)
|
|
Those are not serialized, but are restored from the outPk masks,
so depending on what tries to validate the tx, those commitments
may or may not be filled with valid data at the time. The outPk
masks are already hashed as part of the rctSigBase field.
|
|
|
|
|
|
|
|
|
|
Changes from sarang
|
|
|
|
Based on Java code from Sarang Noether
|
|
|
|
|
|
|
|
|
|
|
|
This makes master versions play better with automated update checks
|
|
|
|
|
|
|
|
|
|
|
|
|
|
23b6f685 RPC: allow binding of restricted port in addition to core port (Tim L)
|
|
b0426d4c Fixes #759 Add sanity check on restore height (Cifrado)
|
|
c0ae52c0 simplewallet: prevent (wrong) integrated adresses on accounts > 0 (moneromooo-monero)
|
|
d875a9ff wallet2: detect multiple outputs from a tx to different subaddresses (moneromooo-monero)
|
|
f9fad186 blockchain_db: sanity check on tx/hash vector sizes (flozilla)
|
|
310b790a make connection_id a string in RPC (moneromooo-monero)
|
|
287dde63 Added command descriptions (Cifrado)
|
|
6cbe7bcd wallet2: check generate_key_derivation return value (moneromooo-monero)
|
|
|
|
|
|
Deleted 3 out of 4 calls to method connection_basic::sleep_before_packet
that were erroneous / superfluous, which enabled the elimination of a
"fudge" factor of 2.1 in connection_basic::set_rate_up_limit;
also ended the multiplying of limit values and numbers of bytes
transferred by 1024 before handing them over to the global throttle
objects
|
|
Monero.ts: Fewer pleases in seed NOTE
Monero_it.ts: Fewer pleases in seed NOTE
Monero_fr.ts: Fewer pleases in seed NOTE
|
|
|
|
|
|
It will be reinitialized later once we know about log file
and other command line configuration
|
|
|
|
It's meant to avoid being optimized out
memory_cleanse lifted from bitcoin
|
|
Add period to second sentence
|
|
0b08bf39 fixed common/util.cpp to link against libressl (ston1th)
|
|
|
|
fdf0acbf Tools, daemonizer: fix building on Windows (iDunk5400)
|
|
ac5cd865 simplewallet: fix typo in incoming monero message (moneromooo-monero)
|
|
51895fd7 split wallet and wallet_api (moneromooo-monero)
|
|
0d149f70 Add out-of-bound exceptions and handle them in RPC (Michał Sałaban)
|
|
93c33985 simplewallet: translate ring size 0 to mixin 0 (default values) (moneromooo-monero)
|
|
61712384 daemon & simplewallet: don't set max-concurrency when unspecified (stoffu)
|
|
da706b61 Fix false GCC warning '‘*((void*)& subaddr_account +4)’ may be used unitialized' (binaryFate)
|
|
0b726be7 wallet2: minimize the number of construct_tx calls (moneromooo-monero)
9d505d26 wallet2: cleanup some debug logs (moneromooo-monero)
|
|
7e387fb1 wallet2: only add a dummy 0 output if there's one output otherwise (moneromooo-monero)
|
|
b42ee213 Wallet: update ring size in outdated error msgs with set_default_ring_size (binaryFate)
|
|
54a4c1cb cryptonote: do not overwrite const data (moneromooo-monero)
|
|
b0b7e0f0 Spend proof without txkey (stoffu)
|
|
43f27c7d core: warn when free disk space is low (moneromooo-monero)
|
|
47c0948a Implement missing miner functions on FreeBSD (Vasil Dimov)
fdb5bd16 Remove unused variables and fix typos in comments (Vasil Dimov)
|
|
9739da1e wallet_rpc_server: new relay_tx command (moneromooo-monero)
01dc8297 wallet: transfer RPC can now return tx metadata (pending_tx) (moneromooo-monero)
83fa9047 serialization: add std::set and std::unordered_set serialization (moneromooo-monero)
|
|
2d1ccc1b mnemonics: support for arbitrary (if multiple of 4 bytes) length data (moneromooo-monero)
|
|
It takes a full tx+metadata hex string as input
|
|
|
|
|
|
It's getting hit too easily
|
|
|
|
|
|
|
