| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
3367ed86 blockchain_blackball: fix build with CLANG 5 (moneromooo-monero)
|
|
It doesn't like the explicit NULL dereference (which is fine, honest)
|
|
|
|
When additional keys was needed, the TX scan failed because the
derivation data was always recomputed with the main tx_key and not
the corresponding additional one.
Moreover this patch avoid perf decreasing when not using HW device.
|
|
73951cbd wallet2: request transactions in slices when scanning for known rings (moneromooo-monero)
25fe67e4 rpc: allow getting pruned blocks from gettransactions (moneromooo-monero)
|
|
08343aba tx_pool: fix loading with colliding key images (moneromooo-monero)
|
|
a9cc88ee common: make this build with unbound 1.4.20 (moneromooo-monero)
|
|
24acb66e wallet2: fix misc issues when the ringdb can't be initialized (moneromooo-monero)
|
|
0b26c4d5 wallet2: move segregation height to v7 (moneromooo-monero)
|
|
eecfb57d wallet: warn if not using the default ring size (moneromooo-monero)
|
|
aa5c2e01 simplewallet: warn about key reuse on startup (moneromooo-monero)
|
|
eb59f7c5 cryptonote_tx_util: make destinations properly shuffled (stoffu)
|
|
1e0958c0 wallet: fix default mixin (4 -> 6) (sneurlax)
|
|
|
|
0beb94f3 device: fix endianess dependence on subaddress secret key generation (moneromooo-monero)
|
|
11c933e1 fix lambda compile error on openbsd (moneromooo-monero)
|
|
c77d2bfa Add the possibility to export private view key for fast scan. (cslashm)
100b7bc1 Change mutex lock model to avoid dead lock and ensure locks are always released. (cslashm)
641dfc99 Automatic height setup when creating/restoring hw device. (cslashm)
|
|
dac3895a update block hashes for checkpoints.dat (Riccardo Spagni)
|
|
1834127c rpc: make get_output_distribution a non-restricted RPC (moneromooo-monero)
|
|
eaa8bfe7 wallet2: set from_height of GET_OUTPUT_DISTRIBUTION correctly The previous expression (stoffu)
0a619f78 wallet2: enable the mitigation only after the fork height (stoffu)
|
|
5f664793 p2p: correct port number for seed nodes (stoffu)
|
|
0098ed33 wallet2: fix for loading settings of key reuse mitigation (stoffu)
|
|
57300491 wallet: catch exceptions dealing with ringdb and warn (moneromooo-monero)
|
|
A key image may be present more than once if all but one of the
txes spending that key image are coming from blocks. When loading
a txpool from storage, we must load the one that's not from a
block first to avoid rejection
|
|
Common on currently used distros
|
|
This avoid massive memory consumption for huge wallets
|
|
and get them pruned in find_and_save_rings, since it does not need
the pruned data in the first place.
Also set decode_to_json to false where missing, we don't need this
either.
|
|
since people seem to really want to use things the wrong way.
|
|
On client startup the device asks for authorization to export the private view key.
If user agree, the client hold the private view key allowing a fast blockchain scan.
If the user does not agree, the blockchain scan is fully done via the device.
|
|
Additional cosmetic fixes:
move 'name' as protected
remove unnecessary local var
Fix debug log
|
|
When creating/restoring wallet, if --restore-height option is not used the current estimate
height is used for starting the scan. In other words it is assume we are creating a new account.
|
|
|
|
|
|
|
|
|
|
We now force little endianness
|
|
|
|
|
|
so that those nodes can still be used for sending transactions
|
|
The previous expression
req_t.from_height = X ? Y >= Z : 0;
forces the parameter to take the value of either 0 or 1.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
8ea3c4d5 simplewallet: new --use-english-language-names flag (moneromooo-monero)
|
|
1e393f4b wallet: make the segregation height settable (moneromooo-monero)
|
|
|
|
On some Windows systems, displaying language names in their own
languages freezes the display.
|
|
via user setting first, then DNS TXT record, hardcoded fallback
|
|
9732a37e wallet_rpc_server: add sweep_unmixable as alias for sweep_dust (moneromooo-monero)
|
|
20a00266 blockchain: forbid bulletproof types before v8 (moneromooo-monero)
|
|
|
|
They were already forbidden implicitely, but let's make that
explicit for robustness
|
|
lookahead in order to avoid
so looooong time of set-up when creating a HW based wallet.
|
|
6f54c910 simplewallet: fix restore height prompt that got disabled by #3175 (stoffu)
|
|
524cbdc1 blockchain: fix log message about per-kB fee (stoffu)
|
|
833f9fcf show '<Not set>' for empty wallet description (cryptochangements34)
|
|
57c0b1ed Fix typos in various files (Dimitris Apostolou)
|
|
It can now take a txid (to display rings for all its inputs),
and will print rings in a format that set_ring understands
|
|
|
|
|
|
|
|
|
|
This will avoid careless forkers polluting the shared database
even if they make their own chain. They'll then automatically
start using another subdb, and any key-reusing fork of those
forks will reuse their subdbs.
|
|
This is so one can set rings for spent key images in case the
attackers don't merge the ring matching patch set.
|
|
|
|
|
|
It scans for known spent outputs and stores their public keys
in a database which can then be read by the wallet, which can
then avoid using those as fake outs in new transactions.
Usage: monero-blockchain-blackball db1 db2...
This uses the shared database in ~/.shared-ringdb
|
|
|
|
If a pre-fork output is spent on both Monero and attack chain,
any post-fork output can be deduced to be a fake output, thereby
decreasing the effective ring size.
The segregate-per-fork-outputs option, on by default, allows
selecting only pre-fork outputs in this case, so that the same
ring can be used when spending it on the other side, which does
not decrease the effective ring size.
This is intended to be SET when intending to spend Monero on the
attack fork, and to be UNSET if not intending to spend Monero
on the attack fork (since it leaks the fact that the output being
spent is pre-fork).
If the user is not certain yet whether they will spend pre-fork
outputs on a key reusing fork, the key-reuse-mitigation2 option
should be SET instead.
If you use this option and intend to spend Monero on both forks,
then spend real Monero first.
|
|
This maps key images to rings, so that different forks can reuse
the rings by key image. This avoids revealing the real inputs like
would happen if two forks spent the same outputs with different
rings. This database is meant to be shared with all Monero forks
which don't bother making a new chain, putting users' privacy at
risk in the process. It is placed in a shared data directory by
default ($HOME/.shared-ringdb on UNIX like systems). You may
use --shared-ringdb-dir to override this location, and should
then do so for all Monero forks for them to share the database.
|
|
|
|
|
|
|
|
|
|
|
|
c5024c5b simplewallet: add a warning when getting a daemon error in transfer (moneromooo-monero)
|
|
e1b526b3 Remove the `Blockchain::get_all_known_block_ids` function. (Jean Pierre Dudey)
|
|
A malicious daemon (or MITM) could attempt to add spurious errors
so the wallet tries again, sending another set of fake outs.
|
|
calls to wallet2
|
|
This function isn't used in the codebase.
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
|
|
invoke_http_json_rpc("/json_rpc",methodname,...) to reduce boilerplate
|
|
c577abab wallet: fix auto low priority so that it takes effect only when saved default is 0 (stoffu)
|
|
1d39b265 wallet2: fix use_fork_rules() when querying version that is defined but not enabled yet (stoffu)
|
|
523371c0 p2p: fix network ID being uninitialised when using exclusive peers (moneromooo-monero)
|
|
9abeff59 wallet2: handle no blocks returned in refresh to mean no new blocks (moneromooo-monero)
|
|
ec41006c node_rpc_proxy: fix target height caching (moneromooo-monero)
|
|
b63ea060 simplewallet: do not call a RPC when displaying the prompt (moneromooo-monero)
|
|
c3e23b2d ringct: 17% improvement in Borromean signature verification (moneromooo-monero)
|
|
|
|
hash: add prehashed version cn_slow_hash_prehashed
slow-hash: let cn_slow_hash take 4th parameter for deciding prehashed or not
slow-hash: add support for prehashed version for the other 3 platforms
|
|
|
|
|
|
When #3303 was merged, a cyclic dependency chain was generated:
libdevice <- libcncrypto <- libringct <- libdevice
This was because libdevice needs access to a set of basic crypto operations
implemented in libringct such as scalarmultBase(), while libringct also needs
access to abstracted crypto operations implemented in libdevice such as
ecdhEncode(). To untangle this cyclic dependency chain, this patch splits libringct
into libringct_basic and libringct, where the basic crypto ops previously in
libringct are moved into libringct_basic. The cyclic dependency is now resolved
thanks to this separation:
libcncrypto <- libringct_basic <- libdevice <- libcryptonote_basic <- libringct
This eliminates the need for crypto_device.cpp and rctOps_device.cpp.
Also, many abstracted interfaces of hw::device such as encrypt_payment_id() and
get_subaddress_secret_key() were previously implemented in libcryptonote_basic
(cryptonote_format_utils.cpp) and were then called from hw::core::device_default,
which is odd because libdevice is supposed to be independent of libcryptonote_basic.
Therefore, those functions were moved to device_default.cpp.
|
|
|
|
aa8bef0c fix error message typo in wallet2.cpp (cryptochangements34)
|
|
84decbea core: add v7 for 1539500 on mainnet (moneromooo-monero)
|
|
1979d53d wallet: fixes and tweaks to the save_watch_only command (moneromooo-monero)
|
|
1ff35fda Wallet API: make nettype non-defaulted to disambiguate from deprecated versions (and make libwallet_api_tests compilable) (stoffu)
|
|
978663d4 Stagenet: successive forks up to v7 (stoffu)
|
|
0bbd521f libwallet_merged: added missing libdevice (stoffu)
|
|
ffe70b8f Make mixin optional with default for rpc transfer (cryptochangements34)
|
|
73dd883d Ledger HW Bug fixes (Cédric)
|
|
e0cda74a wallet2_api: add info/error/warning entry points (moneromooo-monero)
|
|
91d97dd4 fuzz_tests: set small subaddress lookahead for speed (moneromooo-monero)
5f85cc7e wallet2: guard against overflowing of subaddress indices (moneromooo-monero)
|
|
649a1b7a wallet2 / simplewallet: Must opt-in to create '.address.txt' files for new wallets (Leon Klingele)
|
|
|
|
enabled yet
|
|
default is 0
|
|
|
|
Fix the way the REAL mode is handle:
Let create_transactions_2 and create_transactions_from construct the vector of transactions.
Then iterate on it and resign.
We just need to add 'outs' list in the TX struct for that.
Fix default secret keys value when DEBUG_HWDEVICE mode is off
The magic value (00...00 for view key and FF..FF for spend key) was not correctly set
when DEBUG_HWDEVICE was off. Both was set to 00...00.
Add sub-address info in ABP map in order to correctly display destination sub-address on device
Fix DEBUG_HWDEVICE mode:
- Fix compilation errors.
- Fix control device init in ledger device.
- Add more log.
Fix sub addr control
Fix debug Info
|
|
This is not a possible return from the daemon, but I want this in
now so all wallets handle this when the daemon starts doing so.
|
|
|
|
Speeds up refresh when you have a lot of in/out transactions
|
|
wallets
Previously, a file containing the unencrypted Monero address was
created by default in the wallet's directory. This file might pose
as a privacy risk. The creation of this file is now opt-in and can
be enabled by providing
--create-address-file
|
|
|
|
|
|
38657fd0 Bump min ring size from 5 to 7 from v7 (moneromooo-monero)
|
|
04a0cc89 slow-hash: fix uint64 type typo (moneromooo-monero)
|
|
55a65f32 Wallet API: corrected testnet/mainnet ordering (stoffu)
|
|
49c70962 device: remove dependency on readline (stoffu)
|
|
557a6fb6 cn_deserialize: link with device and ringct (moneromooo-monero)
|
|
9a6be3da wallet_manager: fixed typo deviuce/device.hpp (stoffu)
|
|
|
|
|
|
- save the new keys file as FOO-watchonly.keys, not FOO.keys-watchonly
- catch any exception (eg, I/O errors) and error out
- print the new keys filename in simplewallet
|
|
|
|
|
|
|
|
|
|
versions (and make libwallet_api_tests compilable)
|
|
|
|
|
|
|
|
This is the first variant of many, with the intent to improve
Monero's resistance to ASICs and encourage mining decentralization.
|
|
|
|
|
|
f2bb8085 Fix #3297 use the password_prompter helper (Howard Chu)
|
|
399120dd simplewallet: set seed language when restoring from english-old seed (stoffu)
|
|
43026822 Wallet2 + CLI wallet: UTF-8 support for filenames and paths under Windows (rbrunner7)
|
|
3d452367 allow using ring size instead of mixin for rpc transfer (cryptochangements34)
|
|
c95dddd2 remove unused function keyImageV (h908714124)
|
|
25ea307d Fix invalid device unique_ptr cast (MoroccanMalinois)
|
|
51219457 core: fix sending to the source address with a short payment id (moneromooo-monero)
|
|
6b40ea93 simplewallet: fix print_ring_members printing wrong heights (moneromooo-monero)
|
|
71bff546 wallet api: when restoring from EnglishOld, set language to English (stoffu)
|
|
6f8779d2 blockchain: fix random sync failures (moneromooo-monero)
|
|
223d7d0c db_lmdb: fix free space reporting (moneromooo-monero)
|
|
34a2a085 rctSigs - loop invariant code removed from the loop (Dusan Klinec)
|
|
0e7ad2e2 Wallet API: generalize 'bool testnet' to 'NetworkType nettype' (stoffu)
af773211 Stagenet (stoffu)
cc9a0bee command_line: allow args to depend on more than one args (stoffu)
55f8d917 command_line::get_arg: remove 'required' for dependent args as they're always optional (stoffu)
450306a0 command line: allow has_arg to handle arg_descriptor<bool,false,true> #3318 (stoffu)
9f9e095a Use `genesis_tx` parameter in `generate_genesis_block`. #3261 (Jean Pierre Dudey)
|
|
f3b74e75 Fix refresh height estimation (Howard Chu)
|
|
6d900a40 removed systemd private tempdir (ston1th)
496055d1 monerod: do not log to tmpdir in daemon mode (ston1th)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
always optional
|
|
|
|
* src/cryptnote_config.h: The constant `config::testnet::GENESIS_TX` was
changed to be the same as `config::GENESIS_TX` (the mainnet's transaction)
because the mainnet's transaction was being used for both networks.
* src/cryptonote_core/cryptonote_tx_utils.cpp: The `generate_genesis_block` function
was ignoring the `genesis_tx` parameter, and instead it was using the `config::GENESIS_TX`
constant. That's why the testnet genesis transaction was changed. Also five lines of unused
code were removed.
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
|
|
|
|
|
|
The basic approach it to delegate all sensitive data (master key, secret
ephemeral key, key derivation, ....) and related operations to the device.
As device has low memory, it does not keep itself the values
(except for view/spend keys) but once computed there are encrypted (with AES
are equivalent) and return back to monero-wallet-cli. When they need to be
manipulated by the device, they are decrypted on receive.
Moreover, using the client for storing the value in encrypted form limits
the modification in the client code. Those values are transfered from one
C-structure to another one as previously.
The code modification has been done with the wishes to be open to any
other hardware wallet. To achieve that a C++ class hw::Device has been
introduced. Two initial implementations are provided: the "default", which
remaps all calls to initial Monero code, and the "Ledger", which delegates
all calls to Ledger device.
|
|
It would fail to send, thinking it needs a destination address,
since the destination matches the change address in this case.
|
|
And also use uint64_t instead of int for heights where appropriate
|
|
|
|
|
|
|
|
The logging to /tmp/bitmonero.daemon.stdout.stderr caused segfaults
if the /tmp mount was full (#2851).
Now the daemon is only logging to /tmp/bitmonero.daemon.stdout.stderr
in the debug builds.
|
|
When a block is added as part of a chunk (when syncing historical
blocks), a block may end up already in the blockchain if it was
added to the queue before being added to the chain (though it's
not clear how that could happen, but it's an implementation detail)
and thus may not be added to the chain when add_block is called.
This would cause m_blocks_txs_check to not be cleared, causing it
to get out of sync at next call, and thus wrongfully reject the
next block.
|
|
reported by Brad Richards
|
|
|
|
df5273de wallet2: fix auto_low_priority field name typo on load (moneromooo-monero)
|
|
6514f0ed db_lmdb: fix return code mixup in for_all_* (moneromooo-monero)
|
|
fd57e13a simplewallet: typo in generate-from-multisig-keys (stoffu)
|
|
4a78a99f cryptonote_core: change wording of fork warning message (moneromooo-monero)
|
|
1d28c0d8 p2p: restore m_testnet assignment lost during rebase (whythat)
|
|
10f78f63 p2p: need libcryptonote_core due to arg_testnet_on being used (stoffu)
|
|
d4e728c9 simplewallet: reword donate command message for clarity (Serhack)
|
|
b2d4bb9b Remove `voting_version` parameter documentation. (Jean Pierre Dudey)
|
|
da25757b simplewallet: do nothing in on_skip_transaction (wallet2 already logs warnings) (stoffu)
|
|
3962bcb2 Closes #2886: really ignore battery checking (Timothy D. Prime)
|
|
89ad162a wallet2: remove unused m_subaddresses_inv (moneromooo-monero)
f2c4c399 wallet2: speed up subaddress generation (by about a third) (moneromooo-monero)
|
|
3c33e131 wallet2: don't store invalid key image when watch-only (stoffu)
0133b348 wallet2: don't throw when spent amount is inconsistent (stoffu)
|
|
6866ed46 Add default value to max_height, otherwise it's 0 (Michał Sałaban)
|
|
|
|
|
|
|
|
An udpate may or may not be available now, but should be soon if not.
This will prevent too many people freaking out.
|
|
|
|
|
|
ed6c68db crypto: add missing include (WIN32) (iDunk5400)
|
|
a4b50a6f handle ^D and ^C while password prompting (Jethro Grassie)
|
|
b3b2d4d2 options: add testnet option dependencies (whythat)
c5f55bb4 common: implement dynamic option dependencies mechanism (whythat)
05a12ccc options: remove testnet-* options (whythat)
c33cb60e common: implement dependent option descriptor (whythat)
|
