Age | Commit message (Collapse) | Author | Files | Lines |
|
23df29d functional_tests: add simple relay_tx test (moneromooo-monero)
e306834 rpc: fix relay_tx error return mixup (moneromooo-monero)
|
|
96b7697 daemon: remove time based 'update needed' status string (moneromooo-monero)
|
|
5285ecc rpc: don't display invalid json errors on default log level (moneromooo-monero)
|
|
|
|
|
|
It's not something the user needs to know, and will display
attacker controlled data
|
|
buffer_send[4] (LC) is an unsigned char, len should not
exceed 254 (255 - 1 for the option).
|
|
|
|
ada8172 rpc: lock access to the rpc payment object (moneromooo-monero)
|
|
0d92fe5 rpc: add a sanity limit to a few RPC in restricted mode (moneromooo-monero)
|
|
99d702e cryptonote_core: remove 'We are most likely forked' message (moneromooo-monero)
|
|
|
|
|
|
|
|
f01d529 cryptonote_protocol: reject requests/notifications before handshake (moneromooo-monero)
bbab044 cryptonote_protocol: stricter limit to number of objects requested (moneromooo-monero)
|
|
cef39dc protocol: move the 'peer claims higher version' warning to debug (moneromooo-monero)
|
|
705c78b wallet2: fix multisig data clearing stomping on a vector (moneromooo-monero)
|
|
4291344 serialization: fix bad rapidjson api usage (moneromooo-monero)
|
|
bb4d95c blockchain: detect and log bad difficulty calculations (moneromooo-monero)
|
|
44e3782 protocol: don't drop a connection if we can't get a compatible chain (moneromooo-monero)
|
|
4a9c3a Revert 'simplewallet: noob-friendly help menu' (selsta)
7633ba0 simplewallet: help_advanced -> help (selsta)
|
|
f35ced6 build: fix boost 1.73 compatibility (selsta)
|
|
f526977 easylogging++: sanitize log payload (moneromooo-monero)
|
|
It's time based and we don't have forks every 6 months anymore
|
|
Because there's a neverending supply of cunts claiming a wrong
version just to say "look at me" I guess
|
|
|
|
|
|
Reported by xnbya
|
|
Reported by xnbya
|
|
Some of it might be coming from untrusted sources
Reported by itsunixiknowthis
|
|
|
|
This can now happen if:
- we have a pruned db
- we have not connected to the monero network for a while
- we connect to a node
- that node asks us for history
- we only have a pruned version of the most recent common block
In that case, it's better to not reply but keep the connection alive,
so we can sync off it.
|
|
|
|
This reverts commit 67b4a19edf7b9d6a407a79eca5c57819863bfd71.
|
|
1b48f32 simplewallet: don't complain about incoming payment ids on change (moneromooo-monero)
|
|
ab44293 trezor: add new firmware version support (ph4r05)
|
|
|
|
|
|
|
|
|
|
70609d7 cryptonote_core: take out the time based upgrade warning (moneromooo-monero)
|
|
42e1484 wallet2: fix keys file deserialization exception handling (xiphon)
|
|
It doesn't really work anymore since we don't have a fork soon
|
|
f80ab3e cryptonote_protocol: do not request pruned borromean sig txes (moneromooo-monero)
|
|
We don't have a function to calculate their weight from a pruned
version (yet).
|
|
feee455 Fixes for ZMQ JSON-RPC endpoint names for raw tx (vtnerd)
|
|
7a8c1ee wallet2: fix subaddress expansion when receiving monero (moneromooo-monero)
|
|
e7d0105 message_store: don't print an error when there is no mms file (moneromooo-monero)
|
|
119f706 rpc: fix 'use_bootstrap_daemon_if_necessary' return value (xiphon)
|
|
4f489fa wallet2: check_connection return false on get_version status != OK (xiphon)
|
|
ee58362 Used legacy category to match insert_key_images behavior (vtnerd)
|
|
2efbd5f cryptonote: fix reuse of non default tx data when relaying (moneromooo-monero)
|
|
c6a1294 add another seed node (Gingeropolous/selsta)
9faf3d1 Add erciccione's seed node (erciccione/selsta)
|
|
a813c46 cryptonote_core: skip dns checkpoints on startup if not enforced (xiphon)
|
|
8b655de simplewallet: report timestamp based expected unlock time on balance (moneromooo-monero)
|
|
613071f use memwipe on secret k/alpha values (moneromooo-monero)
|
|
|
|
4ed60b6 Bulletproofs: verification speedup (SarangNoether)
|
|
d2d3a81 bootstrap_daemon: fix missing virtual destructor and lambda capture (clang warning) (xiphon)
|
|
27d551d simplewallet: add sweep_account command (moneromooo-monero)
|
|
e509ede trezor: adapt to new passphrase mechanism (ph4r05)
|
|
b367630 simplewallet : missing function block separator (sumogr)
|
|
145be6d p2p: startup speedup, init seed nodes on first 'connect_to_seed()' (xiphon)
|
|
7c4a400 simplewallet: fix strings (show_transfers & export_transfers) (sumogr)
|
|
688a3e8 Add timelock verification on device (cslashm)
|
|
da99157 Use byte_slice for sending zmq messages - removes data copy within zmq (vtnerd)
|
|
|
|
|
|
|
|
- choice where to enter passphrase is now made on the host
- use wipeable string in the comm stack
- wipe passphrase memory
- protocol optimizations, prepare for new firmware version
- minor fixes and improvements
- tests fixes, HF12 support
|
|
It confuses people
|
|
|
|
|
|
|
|
An automatic tx variable is initialized properly on the first
run through the loop, but not the second. Moving the variable
inside the loop ensures the ctor is called again to init it.
|
|
node is funded by random people and managed by me. currently functioning as public node at uwillrunanodesoon.moneroworld.com
|
|
|
|
|
|
|
|
79a1653 p2p: add seed node. (guywillett)
|
|
5715460 Always reject duplicate key-images from second txid (vtnerd)
babf25d Allow unrestricted rpc calls to get full txpool info (vtnerd)
|
|
09abca7 wallet_api: checkUpdate - optional version and buildtag params (xiphon)
|
|
5ef7138 daemon: fix print_net_stats RPC calls (moneromooo-monero)
|
|
|
|
87d7558 Allow wallet2.h to run in WebAssembly (woodser)
|
|
387fd66 Daemon: Print estimates for time until fully synced (rbrunner7)
|
|
|
|
warning)
|
|
- Add abstract_http_client.h which http_client.h extends.
- Replace simple_http_client with abstract_http_client in wallet2,
message_store, message_transporter, and node_rpc_proxy.
- Import and export wallet data in wallet2.
- Use #if defined __EMSCRIPTEN__ directives to skip incompatible code.
|
|
Reported by UkoeHB_ and sarang
|
|
|
|
Expects an account number, then the usual sweep_all options
Useful to move monero that was accidentally sent to a subaddress
with a very large account index.
|
|
|
|
8d23047 p2p: add another seed node (moneromooo-monero)
|
|
5de2295 Correct key image check in tx_pool (vtnerd)
|
|
69b5992 simplewallet: new 'address one-off <major> <minor>' command (moneromooo-monero)
|
|
8958b4e blockchain_db: faster fetching of consecutive txes (moneromooo-monero)
|
|
927fd47 simplewallet: fix smart mining not starting after first setup (moneromooo-monero)
|
|
|
|
|
|
|
|
|
|
ad13a4b Fixing static_asserts in ZMQ JSON (vtnerd)
|
|
ec01077 db_lmdb: fix race crash using a stale cursor (moneromooo-monero)
|
|
e719760 Fix receive order leakage with tx fluffing (vtnerd)
|
|
ebf3c10 Added logging for dropped local txes with no i2p/tor connections (vtnerd)
|
|
7b9017f p2p: plug tor to clearnet association vector (Aaron Hook)
|
|
6e1cb5a device: Ledger - fix wide char hidapi error string conversion (xiphon)
|
|
68a6507 Fixed bug in ZMQ JSON-RPC method field (vtnerd)
|
|
42a7a4d daemon: auto public nodes - cache and prioritize most stable nodes (xiphon)
|
|
6810150 daemon: if no banned IPs print something (sumogr)
|
|
81c5943 Remove temporary std::string creation in some hex->bin calls (vtnerd)
5fcc23a Move hex->bin conversion to monero copyright files and with less includes (vtnerd)
3387f0e Reduce template bloat in hex->bin for ZMQ json (vtnerd)
|
|
fcb06f7 cryptonote_core: skip block notify on blockchain switching rollback (xiphon)
|
|
82da832 rpc: Add check for too old timestamps in payment signatures. (glv2)
|
|
c61abf8 remove empty statements (shopglobal)
|
|
80d5320 Hash domain separation (SarangNoether)
|
|
cc18926 wallet2_api: wallet recovery - seed offset passphrase support (xiphon)
|
|
9bde70e core: mention time being off in hash rate changes message (moneromooo-monero)
|
|
29b7cd1 device_ledger: include status code name in error message (xiphon)
|
|
1a6e7bd wallet2: mention --daemon-ssl-allow-any-cert in --proxy error msg (xiphon)
|
|
6d6af70 cryptonote_basic: drop unused verification_context::m_not_rct field (xiphon)
|
|
|
|
|
|
|
|
|
|
When a handshake fails, it can fail due to timeout or destroyed
connection, in which case the connection will be, or already is,
closed, and we don't want to do it twice.
Additionally, when closing a connection directly from the top
level code, ensure the connection is gone from the m_connects
list so it won't be used again.
AFAICT this is now clean in netstat, /proc/PID/fd and print_cn.
This fixes a noisy (but harmless) exception.
|
|
760ecf2 console_handler: do not let exception past the dor (moneromooo-monero)
09c8111 threadpool: lock mutex in create (moneromooo-monero)
e377977 tx_pool: catch theoretical error in get_block_reward (moneromooo-monero)
|
|
3627e53 rpc: fix print_pool_sh not finding local txes (moneromooo-monero)
|
|
2e9d1e6 wallet2: fix store-tx-info loading (moneromooo-monero)
|
|
dab604e wallet2_api: implement estimateTransactionFee (xiphon)
|
|
9989cb0 simplewallet: warn about correlations if print-ring-members is not set (moneromooo-monero)
|
|
fe92fa1 [randomx] Add missing randomx_vm_set_cache() (cohcho)
|
|
320bc84 rpc: add --rpc-payment-allow-free-loopback (moneromooo-monero)
|
|
054b4c7 protocol: request txpool contents when synced (moneromooo-monero)
|
|
|
|
|
|
|
|
The warning about spending more than one output with similar creation
time was skipped if print-ring-members was not set, and it defaults to
false, which means most people probably aren't getting this warning if
they spend correlated outputs.
Reported by SeventhAlpaca.
|
|
Node from syksy, administered by mooo
|
|
9c1f970b wallet2: remember daemon address overrides when loading a new wallet (moneromooo-monero)
|
|
50e59cfa wallet2: reject zero keys in json input (moneromooo-monero)
|
|
bcae95a2 p2p: do not add recently failed addresses to the peerlist (moneromooo-monero)
|
|
ffe7165e wallet: reroll fake outs selection on local tx_sanity_check failure (xiphon)
|
|
0349347e ringdb: use a different iv for key and data in rings table (moneromooo-monero)
7b882087 simplewallet: reword mixin in user message in terms of ring size (moneromooo-monero)
f507a43a wallet2: do not remove known rings when a tx fails (moneromooo-monero)
|
|
d0641b42 net: fix incorrect less operator for top/i2p addresses (Aaron Hook)
|
|
02224e71 Fix check_fee() discrepancy. (UkoeHB)
|
|
a84131ce p2p: fix off by one adding fallback peers (moneromooo-monero)
|
|
66472074 Daemon: Guard against reporting "synchronized" too early (rbrunner7)
|
|
b818522d p2p: fix spurious warning when we're connected to at last one seed (moneromooo-monero)
|
|
36bdf402 p2p: fix adding wrong indices to the filtered peer list (moneromooo-monero)
|
|
aa93e388 p2p: remove old debug commands (Aaron Hook)
|
|
f8d76f39 core: move the LockedTXN class out of txpool so it may be reused (moneromooo-monero)
|
|
- New flag in NOTIFY_NEW_TRANSACTION to indicate stem mode
- Stem loops detected in tx_pool.cpp
- Embargo timeout for a blackhole attack during stem phase
|
|
A newly synced Alice sends a (typically quite small) list of
txids in the local tpxool to a random peer Bob, who then uses
the existing tx relay system to send Alice any tx in his txpool
which is not in the list Alice sent
|
|
|
|
|
|
|
|
|
|
|
|
|
|
for example, in the RPC server
|
|
This allows RPC coming from the loopback interface to not have
to pay for service. This makes it possible to run an externally
accessible RPC server for payment while also having a local RPC
server that can be run unrestricted and payment free.
|
|
0f78b06e Various improvements to the ZMQ JSON-RPC handling: (Lee Clagett)
|
|
a6c24412 wallet: fix exceptions getting the hash of a pruned tx (moneromooo-monero)
|
|
4771a7ae p2p: remove obsolete local time in handshake (moneromooo-monero)
2fbbc4a2 p2p: avoid sending the same peer list over and over (moneromooo-monero)
3004835b epee: remove backward compatible endian specific address serialization (moneromooo-monero)
39a343d7 p2p: remove backward compatible peer list (moneromooo-monero)
60631802 p2p: simplify last_seen serialization now we have optional stores (moneromooo-monero)
9467b2e4 cryptonote_protocol: omit top 64 bits of difficulty when 0 (moneromooo-monero)
b595583f serialization: do not write optional fields with default value (moneromooo-monero)
5f98b46d p2p: remove obsolete local time from TIMED_SYNC (moneromooo-monero)
|
|
If a db resize happened, the txpool meta cursor might be stale,
and was not being renewed when necessary.
It would cause this SEGSEGV:
in mdb_cursor_set ()
in mdb_cursor_get ()
in cryptonote::BlockchainLMDB::get_txpool_tx_blob(crypto::hash const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, cryptonote::relay_category) const ()
in cryptonote::tx_memory_pool::get_transaction(crypto::hash const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, cryptonote::relay_category) const ()
in cryptonote::t_cryptonote_protocol_handler<cryptonote::core>::handle_notify_new_fluffy_block(int, epee::misc_utils::struct_init<cryptonote::NOTIFY_NEW_FLUFFY_BLOCK::request_t>&, cryptonote::cryptonote_connection_context&) ()
|
|
|
|
|
|
|
|
During the handshake for an incoming connection, the peer id is checked against the local node's peer id only for the specific zone of the incoming peer, in order to avoid linking public addresses to tor addresses:
https://github.com/monero-project/monero/blob/5d7ae2d2791c0244a221872a7ac62627abb81896/src/p2p/net_node.inl#L2343
However, on handshakes for outgoing connections, all zones are checked:
https://github.com/monero-project/monero/blob/5d7ae2d2791c0244a221872a7ac62627abb81896/src/p2p/net_node.inl#L1064
If an attacker wanted to link a specific tor node to a public node, they could potentially connect to as many public nodes as possible, get themselves added to the peer whitelist, maybe stuff some more attacker-owned addresses into the greylist, then disconnect, and for any future incoming connections, respond with the tor node's id in an attempt to link the public/tor addresses.
|
|
|
|
|
|
- Finding handling function in ZMQ JSON-RPC now uses binary search
- Temporary `std::vector`s in JSON output now use `epee::span` to
prevent allocations.
- Binary -> hex in JSON output no longer allocates temporary buffer
- C++ structs -> JSON skips intermediate DOM creation, and instead
write directly to an output stream.
|
|
|
|
21c3d42e p2p: drop the peerlist dump to TRACE (moneromooo-monero)
|
|
f717d593 wallet2: guard against race with multiple decrypt_keys users (moneromooo-monero)
|
|
a6a2ad6c simplewallet: set manual refresh mode in rescan_bc (moneromooo-monero)
|
|
88b82bef simplewallet: point to "set help" in the lock screen message (moneromooo-monero)
f19c9f23 util: allow newlines in string to be split (moneromooo-monero)
|
|
69336931 rpc: fill miner_tx_hash again (moneromooo-monero)
|
|
716012ca rpc: drop the obsolete and wrong "unpruned size" log (moneromooo-monero)
|
|
ae84ec90 wallet-cli/rpc: allow sweep_all to use outputs in all subaddresses within an account (stoffu)
|
|
bc6d8aa3 Corrected message typo (palomato)
|
|
5cbb17b9 wallet2: fix hang in wallet refresh (moneromooo-monero)
|
|
987c3139 print_coinbase_tx_sum now supports 128 bits sums (moneromooo-monero)
|
|
d93e1dff simplewallet: warn on refresh if refresh-from-block-height seems off (moneromooo-monero)
|
|
c3613031 Silence miner debugmsg spam (Howard Chu)
|
|
72ca7e3b Fix time comparison math (Jason Rhinelander)
|
|
a2578892 --disable-ban-rpc option to prevent RPC users from banning (naughtyfox)
|
|
94266eeb simplewallet: fix output age display with duplicate heights (moneromooo-monero)
f1d379d2 simplewallet: fix "outputs in same tx" detector (moneromooo-monero)
|
|
5985c5af rpc: add bad-blocks to flush_cache RPC (moneromooo-monero)
|
|
ef95a76d remove unused variable 'ptx' from on_describe_transfer() (woodser)
|
|
|
|
Useful for wallet refresh or node sync
|
|
|
|
5f2a32c daemon: run with -rpc-payment-address and --rpc-restricted-bind-port (moneromooo-monero)
|
|
f812783 simplewallet: fix encrypted payment id note triggering on dummy ones (moneromooo-monero)
|
|
316ab7b wallet2: better error when restoring a wallet with the wrong keys (moneromooo-monero)
|
|
096a9db Wallet: Distingush amounts for a single subaddress (tmoravec)
|
|
|
|
Cleaning up a little around the code base.
|