aboutsummaryrefslogtreecommitdiff
path: root/src (follow)
AgeCommit message (Collapse)AuthorFilesLines
2016-09-01Fix some rct tx size calculationsluigi11111-9/+6
Some variance is still expected
2016-09-01Merge pull request #1029Riccardo Spagni1-21/+33
f1d87c8 simplewallet: add magic and public keys to key image export file (moneromooo-monero) f4e894a simplewallet: make the key image export format binary (moneromooo-monero)
2016-09-01simplewallet: add magic and public keys to key image export filemoneromooo-monero1-5/+30
This ensures it's hard to mix files up
2016-09-01simplewallet: make the key image export format binarymoneromooo-monero1-18/+5
Saves on space, and on some pointless hex conversions
2016-09-01Merge pull request #1022Riccardo Spagni2-6/+5
b8c03a5 Remove blocks_per_sync limits (Howard Chu)
2016-09-01Merge pull request #1027Riccardo Spagni1-0/+2
85dc0ce wallet: sanity check on histogram response (moneromooo-monero)
2016-09-01Merge pull request #1021Riccardo Spagni2-2/+2
1d5ba65 Fix incorrect help usage for the threads option to start_mining (Quanah Gibson-Mount)
2016-09-01Merge pull request #1018Riccardo Spagni6-11/+18
6cf8ca2 core: faster find_blockchain_supplement (moneromooo-monero)
2016-09-01Merge pull request #1016Riccardo Spagni1-1/+3
3112e24 wallet: interpret 0 fee multiplier as default for sweep_all too (moneromooo-monero)
2016-09-01Merge pull request #1012Riccardo Spagni1-1/+4
c2941cb Show correct amount of days behind/ahead while syncing (tobiasw2)
2016-09-01Merge pull request #1007Riccardo Spagni2-4/+12
1de812a cmake: merge libs via virtual object libraries (redfish) a7498ad cmake: comply with the new policy CMP0026 (redfish)
2016-09-01wallet: sanity check on histogram responsemoneromooo-monero1-0/+2
2016-08-31core: faster find_blockchain_supplementmoneromooo-monero6-11/+18
Since this queries block heights for blocks that may or may not exist, queries for non existing blocks would throw an exception, and that would slow down the loop a lot. 7 seconds to go through a 30 hash list. Fix this by adding an optional return block height to block_exists and using this instead. Actual errors will still throw an exception. This also cuts down on log exception spam.
2016-08-30cmake: merge libs via virtual object librariesredfish2-4/+12
CMake issued a warming about policy CMP0026: access of LOCATION target property at config time was disallowed. Offending code was the code that merged static libraries to generate libwallet_merged.a. This patch does that same merge task in a much simpler way. And, since it doesn't violate the policy, the warning went away.
2016-08-31Remove blocks_per_sync limitsHoward Chu2-6/+5
The code used to cap at 5000 blocks per sync. It also treated 0 as 1. Remove these checks; if specified as 0 do no periodic syncs at all. Then the user is responsible for syncing in some external process.
2016-08-30Fix incorrect help usage for the threads option to start_miningQuanah Gibson-Mount2-2/+2
2016-08-30Show correct amount of days behind/ahead while syncingtobiasw21-1/+4
2016-08-30wallet: interpret 0 fee multiplier as default for sweep_all toomoneromooo-monero1-1/+3
2016-08-30Merge pull request #1014Riccardo Spagni1-1/+3
1cdba42 db_lmdb: fix reorg with "halfway rct" coinbase outputs (moneromooo-monero)
2016-08-29db_lmdb: fix reorg with "halfway rct" coinbase outputsmoneromooo-monero1-1/+3
2016-08-29wallet: fix not finding enough rct fake outputsmoneromooo-monero1-3/+8
If picking coinbase outputs, those are locked for a longer time than other outputs, so we ask for more of those
2016-08-29More for PR#999Howard Chu1-1/+1
2016-08-29wallet_rpc_server: return payment id in make_integrated_address RPCmoneromooo-monero2-0/+3
It is useful, especially when requesting a random one
2016-08-29Merge pull request #1002Riccardo Spagni1-1/+6
91ca0b4 core: allow empty global indices for txes with empty vout (moneromooo-monero)
2016-08-29core: allow empty global indices for txes with empty voutmoneromooo-monero1-1/+6
2016-08-28Merge pull request #999Riccardo Spagni1-13/+14
dc411ea Change default db-sync-mode to fast, not fastest (Howard Chu)
2016-08-28blockchain: testnet heights for v3, v4, and v5moneromooo-monero1-0/+4
2016-08-28ringct: remove unused codemoneromooo-monero1-245/+0
2016-08-28ringct: pass structure by const ref, not valuemoneromooo-monero2-2/+2
2016-08-28ringct: use memcpy/memset instead of handwritten loop where appropriatemoneromooo-monero1-29/+11
2016-08-28ringct: remove spurious copiesmoneromooo-monero1-24/+4
2016-08-28rct: faster Cryptonote/rct conversionsmoneromooo-monero1-8/+8
2016-08-28wallet: fix some "may be used uninitialized" warningsmoneromooo-monero3-26/+25
The compiler can't always work out the _found booleans are set iff the value is initialized.
2016-08-28wallet: do not generate 0 changemoneromooo-monero1-3/+6
2016-08-28core: use full rct signatures if just one inputmoneromooo-monero1-1/+4
It is slightly smaller, but requires all rings to have the real input on the same index, so can only be used for single input txes.
2016-08-28rct: early out on failure on verRangemoneromooo-monero1-3/+5
2016-08-28wallet: do not ask for duplicate histogramsmoneromooo-monero1-0/+3
2016-08-28wallet: transfer_selected_rct now also selects fake outsmoneromooo-monero4-174/+95
2016-08-28increase minimum mixin to 4 on hard fork 5moneromooo-monero1-2/+3
2016-08-28core: allow v1 txes after HF 5 when sweeping unmixable outputsmoneromooo-monero2-16/+19
2016-08-28ringct: use Cryptonote serialization to hash non prunable datamoneromooo-monero1-21/+9
2016-08-28New "Halfway RingCT" outputs for coinbase transactionsmoneromooo-monero9-25/+92
When RingCT is enabled, outputs from coinbase transactions are created as a single output, and stored as RingCT output, with a fake mask. Their amount is not hidden on the blockchain itself, but they are then able to be used as fake inputs in a RingCT ring. Since the output amounts are hidden, their "dustiness" is not an obstacle anymore to mixing, and this makes the coinbase transactions a lot smaller, as well as helping the TXO set to grow more slowly. Also add a new "Null" type of rct signature, which decreases the size required when no signatures are to be stored, as in a coinbase tx.
2016-08-28rct: log why verification failsmoneromooo-monero1-9/+13
and remove some unnecessary variables in the checking code
2016-08-28rct: serialize txnFee as varintmoneromooo-monero1-1/+1
2016-08-28rct amount key modified as per luigi1111's recommendationsmoneromooo-monero13-117/+68
This allows the key to be not the same for two outputs sent to the same address (eg, if you pay yourself, and also get change back). Also remove the key amounts lists and return parameters since we don't actually generate random ones, so we don't need to save them as we can recalculate them when needed if we have the correct keys.
2016-08-28rct: rework v2 txes into prunable and non prunable datamoneromooo-monero6-51/+112
Nothing is pruned, but this allows easier changes later.
2016-08-28rct: rework the verification preparation processmoneromooo-monero5-196/+191
The whole rct data apart from the MLSAGs is now included in the signed message, to avoid malleability issues. Instead of passing the data that's not serialized as extra parameters to the verification API, the transaction is modified to fill all that information. This means the transaction can not be const anymore, but it cleaner in other ways.
2016-08-28rct: change the simple flag to a typemoneromooo-monero6-23/+44
for future expansion
2016-08-28rct: avoid the need for the last II elementShen Noether5-51/+53
This element is used in the generation of the MLSAG, but isn't needed in verification. Also misc changes in the cryptonote code to match, by mooo.
2016-08-28wallet: do not store signatures in the wallet cachemoneromooo-monero9-30/+89
Saves some substantial space. Also avoid calculating tx hashes we don't need.
2016-08-28core: add some locking around pool usemoneromooo-monero2-1/+4
2016-08-28wallet2: factor m_spent changesmoneromooo-monero2-26/+31
Makes it easier to track what is going on.
2016-08-28wallet: always use new algorithm for RPC transfersmoneromooo-monero2-7/+2
This ensures we get rct transactions when appropriate
2016-08-28rct: do not serialize senderPk - it is not used anymoremoneromooo-monero2-2/+2
2016-08-28wallet: use the prefered rct case only when enough rct outs existmoneromooo-monero2-1/+27
2016-08-28wallet: do not try to use rct txes a few blocks before the forkmoneromooo-monero3-22/+31
2016-08-28tx_pool: log why a transaction was rejected for version checksmoneromooo-monero1-0/+3
2016-08-28change fork settings to allow pre-rct txes for one more fork cyclemoneromooo-monero3-5/+10
2016-08-28simplewallet: better check_tx_key feedbackmoneromooo-monero1-2/+20
Print number of confirmations if the tx is in the blockchain, or a warning if it's in the pool.
2016-08-28rct: make the amount key derivable by a third party with the tx keymoneromooo-monero9-72/+105
Scheme design from luigi1114.
2016-08-28rct: do not serialize public keys in outPkmoneromooo-monero7-33/+85
They can be reconstructed from vout
2016-08-28wallet2_api: zero amounts are now allowed with rctmoneromooo-monero1-6/+0
2016-08-28wallet2_api: update on_money_{received,spent} prototypes for rct changesmoneromooo-monero1-4/+2
2016-08-28rpc: send global indices along with blocks/transacions on refreshmoneromooo-monero4-35/+78
This plugs a privacy leak, where the wallet tells the daemon which transactions contain outputs for the wallet by asking for additional information for that particular transaction. As a nice bonus, this actually makes refresh slightly faster.
2016-08-28core: always use the new simple rct variantmoneromooo-monero1-1/+1
2016-08-28wallet: better tx input selectionmoneromooo-monero2-29/+77
We try to avoid related inputs, when possible
2016-08-28rct: use the already defined H where possiblemoneromooo-monero1-2/+1
Found by luigi1111w
2016-08-28wallet: handle 0 change properlymoneromooo-monero1-7/+8
With RCT, we allow 0 size outputs, to try and encourage txes with two inputs and two outputs. Consolidation would then have two non zero inputs, one zero output, and one larger output.
2016-08-28port get_tx_key/check_tx_key to rctmoneromooo-monero9-32/+177
2016-08-28integrate simple rct apimoneromooo-monero8-175/+329
2016-08-28serialization: add override for serializing boolmoneromooo-monero1-0/+6
2016-08-28ringct: optimization/cleanup of hash functionsShen Noether3-22/+45
2016-08-28ringct: "simple" ringct variantShen Noether6-3/+262
Allows the fake outs to be in different positions for each ring. For rct inputs only.
2016-08-28wallet: rct specific output selectionmoneromooo-monero2-3/+125
Before the normal selection, we attempt to find either one or two suitable outputs to use as inputs to the rct tx. The intent is that most rct txes will have one or two inputs, and we want all to look the same if possible. When two outputs are needed, we try to find a pair which are not related (ie, by being from the same or similar block height).
2016-08-28wallet: make sweep_all work with rct txes toomoneromooo-monero1-7/+21
2016-08-28mixable transactions must be rct for v3moneromooo-monero4-6/+33
2016-08-28wallet: factor transfer_rct code with transfer codemoneromooo-monero4-267/+42
The "transfer" simplewallet command is renamed to "transfer_original". "transfer_new" is renamed "transfer", "transfer_rct" is removed, and the new "transfer" now selects rct or non rct transactions based on the current block height.
2016-08-28Condition v2 txes on v3 hard forkmoneromooo-monero2-1/+12
2016-08-28move the rct commitments to the output_amounts databasemoneromooo-monero7-190/+62
Since these are needed at the same time as the output pubkeys, this is a whole lot faster, and takes less space. Only outputs of 0 amount store the commitment. When reading other outputs, a fake commitment is regenerated on the fly. This avoids having to rewrite the database to add space for fake commitments for existing outputs. This code relies on two things: - LMDB must support fixed size records per key, rather than per database (ie, all records on key 0 are the same size, all records for non 0 keys are same size, but records from key 0 and non 0 keys do have different sizes). - the commitment must be directly after the rest of the data in outkey and output_data_t.
2016-08-28rct: add the tx prefix hash into the MLSAGmoneromooo-monero1-3/+4
to protect the non-signatures parts of the tx from tampering.
2016-08-28ringct: fix size unit mismatch calling keccakmoneromooo-monero1-1/+1
2016-08-28ringct: do not serialize what can be reconstructedmoneromooo-monero6-50/+132
The mixRing (output keys and commitments) and II fields (key images) can be reconstructed from vin data. This saves some modest amount of space in the tx.
2016-08-28Use the supplied hard fork version in validate_miner_transactionmoneromooo-monero1-1/+1
rather than using the current one. No functional changes, but may save some bugs in the future.
2016-08-28wallet: update spent status when an accepted tx disappearsmoneromooo-monero1-0/+19
2016-08-28wallet: reset output spent status on blockchain reorgmoneromooo-monero2-11/+61
If the blockchain gets reorganized, all outputs spent in the part of the blockchain that's blown away need to be reset to unspent (they may end up spent again on the blocks that replace the blocks that are removed, however).
2016-08-28ringct: catch errors from ge_frombytes_vartimemoneromooo-monero1-11/+12
2016-08-28ringct: add missing size check for ecdhInfomoneromooo-monero1-0/+1
2016-08-28ringct: change asserts to return false for boolean functionsmoneromooo-monero1-10/+10
2016-08-28add rct to the protocolmoneromooo-monero18-239/+1182
It is not yet constrained to a fork, so don't use on the real network or you'll be orphaned or rejected.
2016-08-28db_lmdb: update reset for recent db changesmoneromooo-monero1-0/+10
- we need to drop the new m_tx_indices database - we reset the version to current version This fixes the core tests failing to initialize.
2016-08-28ringct: add functions to commit to an amountmoneromooo-monero2-0/+21
One to commit to an amount with zero key (for use with fake commitments for pre-rct outputs), and one with an arbitrary key (for rct outputs).
2016-08-28make rct tx serialization workmoneromooo-monero3-28/+104
It may be suboptimal, but it's a pain to have to rebuild everything when some of this changes. Also, no clue why there seems to be two different code paths for serializing a tx...
2016-08-28crypto: error out where appropriatemoneromooo-monero1-2/+2
2016-08-28ringct: allow no outputs, and add tests for this and feesmoneromooo-monero1-2/+0
2016-08-28ringct: make fee optionalmoneromooo-monero1-2/+9
2016-08-28ringct: txn fee stuffShen Noether3-13/+24
2016-08-28ringct: new {gen,decode}Rct APIs for conveniencemoneromooo-monero2-11/+27
A new version of genRct takes the mixRing as parameter, instead of the inPk. inPk are part of the mixRing, and it is cleaner to pass the mixRing data than to fetch it from the RingCT code. A new version of decodeRct also returns the mask. Also, failure to decode throws, so errors are properly detected.
2016-08-28ringct: add more convenience functionsmoneromooo-monero1-4/+14
2016-08-28core: link against libringctmoneromooo-monero1-0/+1
2016-08-28core: new /getrandom_rctouts.bin binary RPC callmoneromooo-monero7-0/+192
to get random ringct outputs to mix with
2016-08-28ringct: add convenience functions to bridge ringct and cryptonotemoneromooo-monero1-0/+5
2016-08-28blockchain_db: add functions for adding/removing/getting rct commitmentsmoneromooo-monero3-0/+153
2016-08-28ringct: restore verRange check in debug modemoneromooo-monero1-1/+1
2016-08-28ringct: add check for destinations/amount size being equalmoneromooo-monero1-0/+1
2016-08-28ringct: fix off by 1 in mixin usagemoneromooo-monero1-3/+3
2016-08-28ringct: simplify random key generationmoneromooo-monero1-7/+2
2016-08-28ringct: cosmetic fixesShen Noether4-46/+9
Ported from Shen's RingCT repo
2016-08-28ringct: changes to hashToPointSimple to calcualte H2 valuesShen Noether1-0/+5
Ported from Shen's RingCT repo
2016-08-28ringct: compare keys with bitwise equality, not crypto opsShen Noether1-7/+6
Ported from Shen's RingCT repo
2016-08-28ringct: fix size argument to cn_fast_hashShen Noether1-1/+1
Ported from Shen's RingCT repo
2016-08-28Fix sc_0 to skGen in ProveRangeShen Noether1-1/+1
2016-08-28ringct: add a few consts where appropriatemoneromooo-monero2-6/+6
2016-08-28tests: more ringct range proof testsmoneromooo-monero1-1/+1
2016-08-28rct: add serialization machinery to rct typesmoneromooo-monero2-10/+61
2016-08-28serialization: declare do_serialize specializations before usemoneromooo-monero2-1/+6
This lets my gcc picks those instead of the generic template where appropriate (and then fail since std::vector<something> does not have a serialize method.
2016-08-28Added note on generating H2Shen Noether1-1/+2
2016-08-28Fixed missing last index H2Shen Noether1-1/+2
2016-08-28remove original Cryptonote blockchain_storage blockchain formatmoneromooo-monero21-2959/+7
2016-08-28ringct: lock access to the PRNGmoneromooo-monero1-2/+2
2016-08-28ringct: add simple input validationmoneromooo-monero2-32/+74
Throw when inputs aren't the expected size.
2016-08-28ringct: add convenience operators to keymoneromooo-monero1-0/+4
2016-08-28ringct: import of Shen Noether's ring confidential transactionsmoneromooo-monero15-13/+2410
2016-08-28Change default db-sync-mode to fast, not fastestHoward Chu1-13/+14
2016-08-26Merge pull request #991Riccardo Spagni1-4/+12
f88029e db_lmdb: do not try to modify the database in read only mode (moneromooo-monero)
2016-08-26db_lmdb: do not try to modify the database in read only modemoneromooo-monero1-4/+12
2016-08-26Merge pull request #984Riccardo Spagni2-2/+5
78035d2 Fix fake 'network synchronized, begin using' messages (Thomas Winget)
2016-08-26Merge pull request #982Riccardo Spagni1-1/+1
65238d2 fix #691 removed help about leaving wallet name empty on --generate-new-wallet (guzzi_jones)
2016-08-26Merge pull request #978Riccardo Spagni2-4/+12
99dd572 libwallet_api: tests: checking for result while opening wallet (Ilya Kitaev) bcf7b67 libwallet_api: Wallet::amountFromString fixed (Ilya Kitaev) 32bc7b4 libwallet_api: helper method to return maximumAllowedAmount (Ilya Kitaev) cbe534d libwallet_api: tests: removed logged passwords (Ilya Kitaev) b1a5a93 libwallet_api: do not store wallet on close if status is not ok (Ilya Kitaev)
2016-08-26Merge pull request #976Riccardo Spagni1-1/+8
c2f4e16 simplewallet: default to max-concurrency 1 on MacOS X (moneromooo-monero)
2016-08-23Fix fake 'network synchronized, begin using' messagesThomas Winget2-2/+5
2016-08-24fix #691 removed help about leaving wallet name empty on --generate-new-walletguzzi_jones1-1/+1
2016-08-23libwallet_api: Wallet::amountFromString fixedIlya Kitaev1-1/+1
2016-08-23libwallet_api: helper method to return maximumAllowedAmountIlya Kitaev2-0/+6
2016-08-22Merge pull request #972Riccardo Spagni1-1/+1
2c5e68f cmake: fix typo in handling of STACK_TRACE (redfish)
2016-08-22Merge pull request #970Riccardo Spagni1-0/+3
25f529a wallet: store key images after importing them (moneromooo-monero)
2016-08-22Merge pull request #968Riccardo Spagni1-0/+1
9cca53a wallet: fix build on Mac and Windows (missing include) (moneromooo-monero)
2016-08-22libwallet_api: do not store wallet on close if status is not okIlya Kitaev1-3/+5
2016-08-21simplewallet: default to max-concurrency 1 on MacOS Xmoneromooo-monero1-1/+8
A suspected bug in pthread/kernel, though might be that I messed something up too... This might rope in more platforms though.
2016-08-19cmake: fix typo in handling of STACK_TRACEredfish1-1/+1
This fixes the log output not getting redirected to log file.
2016-08-17wallet: store key images after importing themmoneromooo-monero1-0/+3
It avoids rescan_spent resetting spent status, for example.
2016-08-17wallet: fix build on Mac and Windows (missing include)moneromooo-monero1-0/+1
Reported by RaskaRuby, tested by iDunk5400.
2016-08-16simplewallet: do not suggest removing cache if the password was wrongmoneromooo-monero1-1/+3
2016-08-12daemon: print time to next forkmoneromooo-monero5-2/+50
2016-08-11Merge pull request #948Riccardo Spagni15-77/+342
11dc091 Fake outs set is now decided by the wallet (moneromooo-monero) 1593553 new unlocked parameter to output_histogram (moneromooo-monero)
2016-08-11Fake outs set is now decided by the walletmoneromooo-monero12-59/+301
This plugs a privacy leak from the wallet to the daemon, as the daemon could previously see what input is included as a transaction input, which the daemon hadn't previously supplied. Now, the wallet requests a particular set of outputs, including the real one. This can result in transactions that can't be accepted if the wallet happens to select too many outputs with non standard unlock times. The daemon could know this and select another output, but the wallet is blind to it. It's currently very unlikely since I don't think anything uses non default unlock times. The wallet requests more outputs than necessary so it can use spares if any of the returns outputs are still locked. If there are not enough spares to reach the desired mixin, the transaction will fail.
2016-08-11Merge pull request #953Riccardo Spagni1-2/+1
240864f db_lmdb: errors dropping hf starting height db on reset are not fatal (moneromooo-monero)
2016-08-11Merge pull request #952Riccardo Spagni2-4/+9
709c724 Better fix (#4) (hyc) d2644c1 fix restore-deterministic height (luigi1111)
2016-08-11Merge pull request #949Riccardo Spagni2-69/+64
da1007f simplewallet: make the refresh thread into more generic idle thread (moneromooo-monero)
2016-08-11Merge pull request #947Riccardo Spagni1-1/+2
663fc32 wallet2: if importing key images fails, print failure index (moneromooo-monero)
2016-08-11Merge pull request #943Riccardo Spagni4-53/+106
f0c0a3f Fix #864 Squashed commit of the following: commit 9af9e4223b58bbb65a3519af2c2bfc273cbd23d6 fixed some formatting commit c7920e1cf88ff46eb9294101344d9a567f22e2da Merge: 97eb28b 1da1c68 fix#864 fix using boolean commit 97eb28ba5dd49ddde8c8785f39b24d955e5de31c Fix #864 boolean value used to verify on new wallet commit 1da1c68bd3a9a373c70482b6e6e95251096149f1 fix #864 changed to boolean to prompt for verify commit 5bee96652434762d2c91ce31a1b1c9f169446ddc fix 864; made variable names easier for understanding branching. commit 45715960d30293f781b2ff9e5e647c2ec893f4a3 fix #864; allow password to be entered twice for new wallets for verification. fix #864 password entry verification; ammended boolean fix #864 ; default constructor for password_container should set verify=true (guzzi_jones)
2016-08-10db_lmdb: errors dropping hf starting height db on reset are not fatalmoneromooo-monero1-2/+1
This db is now dropped unconditionally, so may or may not be there in the first place.
2016-08-09Better fix (#4)hyc2-4/+9
2016-08-09fix restore-deterministic heightluigi11111-2/+2
Simplewallet improperly skipped the restore from height code if restoring a deterministic wallet AND not specifying a wallet file in the command line. The other generate options require a wallet file as an argument, which prevents "ask_wallet_create_if_needed()" from being called, which in turn causes "m_generate_new" to remain unset. Specifying a wallet file at launch with --restore-deterministic emulated this behavior.
2016-08-07simplewallet: make the refresh thread into more generic idle threadmoneromooo-monero2-69/+64
2016-08-04wallet2: if importing key images fails, print failure indexmoneromooo-monero1-1/+2
2016-08-01new unlocked parameter to output_histogrammoneromooo-monero9-18/+41
This constrains the number of instances of any amount to the unlocked ones (as defined by the default unlock time setting: outputs with non default unlock time are not considered, so may be counted as unlocked even if they are not actually unlocked).
2016-08-01Fix #864guzzi_jones4-53/+106
Squashed commit of the following: commit 9af9e4223b58bbb65a3519af2c2bfc273cbd23d6 fixed some formatting commit c7920e1cf88ff46eb9294101344d9a567f22e2da Merge: 97eb28b 1da1c68 fix#864 fix using boolean commit 97eb28ba5dd49ddde8c8785f39b24d955e5de31c Fix #864 boolean value used to verify on new wallet commit 1da1c68bd3a9a373c70482b6e6e95251096149f1 fix #864 changed to boolean to prompt for verify commit 5bee96652434762d2c91ce31a1b1c9f169446ddc fix 864; made variable names easier for understanding branching. commit 45715960d30293f781b2ff9e5e647c2ec893f4a3 fix #864; allow password to be entered twice for new wallets for verification. fix #864 password entry verification; ammended boolean fix #864 ; default constructor for password_container should set verify=true
2016-07-28cmake: cleanup logic that sets flags per target/subdirredfish1-0/+12
The previous logic that used a COMMON_*_FLAGS intermediate variable and then re-assigned CMAKE_*_FLAGS before including each subdirectory was confusing and ugly. This PR is the right way to do it. This commit is purely refactoring: built binaries unchanged.
2016-07-27Merge pull request #937Riccardo Spagni3-7/+11
0f990d0 cmake,common: flag for stack trace (redfish)
2016-07-27Merge pull request #936Riccardo Spagni2-15/+32
4618873 tests: fix a bitflag test typo (moneromooo-monero) 89e68d7 unit_tests: check adding checkpoints succeeded (moneromooo-monero) 121165f db_lmdb: add some missing api call checks (moneromooo-monero) 22d8344 core_rpc_server: fix gray/white peer list mixup (moneromooo-monero)
2016-07-27cmake,common: flag for stack traceredfish3-7/+11
By default the flag is enabled whenever libunwind is found on the system, with the exception of static build on OSX (for which we can't install the throw hook #932 due to lack of support for --wrap in OSX ld64 linker).
2016-07-26db_lmdb: add some missing api call checksmoneromooo-monero1-14/+31
2016-07-26core_rpc_server: fix gray/white peer list mixupmoneromooo-monero1-1/+1
2016-07-26Merge pull request #928Riccardo Spagni8-1/+364
ebf97d7 wallet: new {ex,im}port_key_images commands and RPC calls (moneromooo-monero)
2016-07-25hardfork: fix off by one in rescaning fork state after restartmoneromooo-monero1-3/+8
This code should die anyway.
2016-07-24wallet: new {ex,im}port_key_images commands and RPC callsmoneromooo-monero8-1/+364
They are used to export a signed set of key images from a wallet with a private spend key, so an auditor with the matching view key may see which of those are spent, and which are not.
2016-07-23cmake: wallet: libunbound is not always staticredfish1-22/+4
It is not clear why libunbound was added to this in the first place, since it wasn't here before and #915 doesn't seem to introduce any new dependency on it. Tested build with STATIC=OFF (with and without libunbound-dev libunbound8 installed) and STATIC=ON, on Ubuntu Trusty, Debian Jessie, and Arch Linux. For static builds, beware of #926 and #907. If this hack was introduced to make it build on some other system (Windows? OS X?), then it will have to be dealt with, but not this way.
2016-07-23Merge pull request #923Riccardo Spagni1-0/+1
8312887 simplewallet: suggest removing cache when loading fails (moneromooo-monero)
2016-07-23Merge pull request #916Riccardo Spagni5-54/+243
b89b963 wallet: add unconfirmed incoming txes from the txpool (moneromooo-monero)
2016-07-23Merge pull request #915Riccardo Spagni5-30/+251
d7597c5 refreshing wallet even if error happened (Ilya Kitaev) 6d32a3d wallet_api: async init, Wallet::connected status, log level (Ilya Kitaev) 193d251 libwallet_api cmake: conditionally creating libwallet_merged2 only for STATIC build (Ilya Kitaev) 10c06dd wallet_api: segfault on refresh fixed (Ilya Kitaev) 9d2cb4f WalletListener functionality (Ilya Kitaev) d27b883 hack to successfull linking for MSYS2 (Ilya Kitaev) 083380c Transaction fee multiplier aka priority integraged (Ilya Kitaev) 00ed12b Wallet::paymentIdValid (Ilya Kitaev)
2016-07-23Merge pull request #910Riccardo Spagni1-0/+2
080a606 simplewallet: revert to foreground refresh at startup (moneromooo-monero)
2016-07-22simplewallet: suggest removing cache when loading failsmoneromooo-monero1-0/+1
2016-07-20wallet: add unconfirmed incoming txes from the txpoolmoneromooo-monero5-54/+243
Shown in show_transfers simplewallet command, and get_transfers RPC command, if req.pool is true.
2016-07-20simplewallet: revert to foreground refresh at startupmoneromooo-monero1-0/+2
Background refresh is confusing to users at startup.
2016-07-20Merge pull request #914Riccardo Spagni1-2/+2
87b1153 wallet2_api: use uint64_t for amounts (moneromooo-monero)
2016-07-20Merge pull request #911Riccardo Spagni8-155/+8
d7b681c remove hf_starting_height db (moneromooo-monero)
2016-07-20Merge pull request #904Riccardo Spagni1-9/+29
f07f120 cmake: don't try to link with atomic on Apple (redfish) 19349d7 cmake: ARM: clang: make warning non-fatal: inline asm (redfish) f3e09f3 cmake: link with -latomic for clang (redfish) f4b35ae cmake: include -ldl via cmake built-in var (redfish) fa85cd8 common: stack trace: make clang happy with func ptrs (redfish) 4dce26b cmake: do not pass -stdlib=c++ to clang >=3.7 (redfish)
2016-07-20Merge pull request #902Riccardo Spagni7-18/+84
014f3a0 Add a daemon RPC version, and make simplewallet check it (moneromooo-monero)
2016-07-20Merge pull request #900Riccardo Spagni2-5/+3
78cc10f daemon: fix ban seconds being misinterpreted as absolute (moneromooo-monero) 34ecfdb rpc: fix get_bans and set_bans RPC names, they were missing a _ (moneromooo-monero)
2016-07-20Merge pull request #899Riccardo Spagni1-1/+8
a95a2cb wallet_rpc_server: add payment id from integrated addresses to extra (moneromooo-monero)
2016-07-20Merge pull request #897Riccardo Spagni1-14/+0
ce6b831 daemonizer: posix: keep parent's working dir and umask (redfish)
2016-07-19wallet: add command and RPC to sign/verify datamoneromooo-monero8-1/+194
Signing is done using the spend key, since the view key may be shared. This could be extended later, to let the user choose which key (even a per tx key). simplewallet's sign/verify API uses a file. The RPC uses a string (simplewallet can't easily do strings since commands receive a tokenized set of arguments).
2016-07-18refreshing wallet even if error happenedIlya Kitaev2-6/+18
2016-07-18wallet_api: async init, Wallet::connected status, log levelIlya Kitaev4-18/+91
2016-07-18libwallet_api cmake: conditionally creating libwallet_merged2 only forIlya Kitaev2-9/+17
STATIC build
2016-07-18wallet_api: segfault on refresh fixedIlya Kitaev2-5/+9
2016-07-18WalletListener functionalityIlya Kitaev3-13/+105
2016-07-18hack to successfull linking for MSYS2Ilya Kitaev1-2/+6
2016-07-18Transaction fee multiplier aka priority integragedIlya Kitaev3-4/+25
2016-07-18Wallet::paymentIdValidIlya Kitaev2-0/+7
2016-07-17wallet2_api: use uint64_t for amountsmoneromooo-monero1-2/+2
2016-07-13remove hf_starting_height dbmoneromooo-monero8-155/+8
It's not really needed, it used to be an optimization for when that code was not using the db and needed to recalculate things fast on startup.
2016-07-10common: stack trace: make clang happy with func ptrsredfish1-9/+29
Tested that it builds with: gcc 6.1.1, STATIC=OFF,i686 gcc 6.1.1, STATIC=OFF,armv7h clang 3.8, STATIC=OFF,i686 clang 3.8, STATIC=OFF,armv7h gcc 6.1.1, STATIC=ON,i686 clang 3.8, STATIC=ON,i686 Also tested that stack trace is generated fine on exception on: i686, gcc 6.1.1, STATIC=OFF (didn't bother testing all the other platforms/configs) This should fix the build problem on OSX (#871, #901), but I don't have OSX, so I could only test Clang on Linux.
2016-07-10Add a daemon RPC version, and make simplewallet check itmoneromooo-monero7-18/+84
If the version is different, simplewallet will refuse to use that daemon, unless --allow-mismatched-daemon-version is used.
2016-07-10daemon: fix ban seconds being misinterpreted as absolutemoneromooo-monero1-3/+1
Absolute to relative conversion is already done by the callee.
2016-07-10rpc: fix get_bans and set_bans RPC names, they were missing a _moneromooo-monero1-2/+2
2016-07-10wallet_rpc_server: add payment id from integrated addresses to extramoneromooo-monero1-1/+8
2016-07-09daemonizer: posix: keep parent's working dir and umaskredfish1-14/+0
Keep the working directory (and umask) inherited from the parent. Otherwise, it's impossible to control the working directory of the daemon (from systemd, for example). Furthermoer, bitmonerod attempts to create logging directories and files *in current working directory*. This fails due to permission denied and generates a (caught, nonfatal) exception. Below is the strace with this patch applied (so, no `chdir("/")`), showing successful opens at `log/` relative path. Without this patch they fail (sorry, didn't save the trace). ``` 28911 getcwd("/.../bitmonero", 128) = 25 28911 stat64("/var/lib/bitmonero/.bitmonero", {st_mode=S_IFDIR|0755, st_size=4096, ...}) = 0 28911 stat64("/etc/bitmonerod.conf", {st_mode=S_IFREG|0644, st_size=244, ...}) = 0 28911 open("/etc/bitmonerod.conf", O_RDONLY|O_LARGEFILE) = 3 28911 open("/var/log/bitmonero/bitmonero.log", O_WRONLY|O_CREAT|O_APPEND|O_LARGEFILE, 0666) = 3 28911 stat64("log", {st_mode=S_IFDIR|0700, st_size=4096, ...}) = 0 28911 stat64("log/dbg", {st_mode=S_IFDIR|0700, st_size=4096, ...}) = 0 28911 open("log/dbg/main.log", O_WRONLY|O_CREAT|O_TRUNC|O_LARGEFILE, 0666) = 4 ``` The reasoning of chdir("/") in order to prevent the daemon from holding a filesystem in busy state is not compelling at all: the choice of working directory for the daemon is the user's business not the daemon's.
2016-07-07wallet2_api: make this build (smatch needs .str() for /=)moneromooo-monero1-1/+1
2016-07-06Merge pull request #884Riccardo Spagni1-0/+5
c2ad9ca allow peers without port (moneromooo-monero)