| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
c6d38718 core: include a dummy encrypted payment id when no payment is used (moneromooo-monero)
b7441c4a core, wallet: remember original text version of destination address (moneromooo-monero)
a9b1c04a crptonote_core: do not error out sending unparsable extra field (moneromooo-monero)
|
|
07cb574c ringct: remove duplicate rv.mixRing = mixRing; in genRctSimple (stoffu)
|
|
0a29660f message_store: init me field (moneromooo-monero)
|
|
584126d1 i18n: filter LANG/LC_LANG for valid characters, and handle @ (moneromooo-monero)
|
|
a67b77a9 blockchain: don't propagate exception past dtor (moneromooo-monero)
|
|
For better transaction uniformity, even though this wastes space.
|
|
|
|
extra is arbitrary, and the user may well want to send custom data
|
|
51b0625e simplewallet: improve punctuation in user visible string (selsta)
|
|
464097e5 blockchain_ancestry: allow getting ancestry of a single output (moneromooo-monero)
a6216d1a blockchain_db: allow getting output keys without commitment (moneromooo-monero)
|
|
1ef79b43 simplewallet: disable long payment ids by default (moneromooo-monero)
|
|
0debe7d7 wallet2: remember which output keys map to which key images (moneromooo-monero)
|
|
15904610 simplewallet: remove extra colon in a few calls to input_secure_line (stoffu)
247dab73 simplewallet: avoid conversion to string in input_secure_line (stoffu)
bf9ef7ad simplewallet: factor yesno hint into input_line (stoffu)
|
|
|
|
|
|
|
|
|
|
This involved a reorg of the code, to factor and speedup some bits,
as well as using the cache for all modes, and making both modes
usable in the same run.
|
|
Since the commitment has to be calculated for non rct outputs,
it slows down a lot unnecessarily if we don't need it
|
|
unless --long-payment-id-support is used
|
|
This allows filling in transfer_details when a cold signed tx
gets seen in a block next
|
|
|
|
c1081091 simplewallet: Show new address after going multisig (rbrunner7)
|
|
53fcd159 simplewallet: don't subtract 1 to estimate blockchain height (moneromooo-monero)
|
|
13785ec9 wallet api/device: set estimated restore height if none is provided (selsta)
|
|
5ee6f037 blockchain: fix wrong hf version when popping multiple blocks (moneromooo-monero)
634d359a blockchain: use the version passed as parameter, not a new one (moneromooo-monero)
94a375d5 hardfork: remove batch transactions setup (moneromooo-monero)
|
|
d1b3990d p2p: don't stop the idle thread when no gray peers are found (moneromooo-monero)
|
|
9092fc4b wallet: do not display daemon controlled text if untrusted (moneromooo-monero)
|
|
65ce387c daemon: add a +hex option to print_block (moneromooo-monero)
|
|
8bd71677 simplewallet: remove ability to transfer with detached short payment ids (moneromooo-monero)
|
|
6f2081f8 cryptonote_core: revert extra_tx_map (moneromooo-monero)
|
|
d7354c78 wallet_rpc_server: add all field to export_key_images (moneromooo-monero)
|
|
5e10dee3 simplewallet: fix show_transfers colouring, and add red for failed (moneromooo-monero)
|
|
7c58421c blockchain_blackball: make log file name consistent with executable (stoffu)
|
|
de9dcdd1 wallet2: finalize_multisig now rejects non N-1/N multisig wallets (moneromooo-monero)
|
|
a5ffc2d5 Remove boost::lexical_cast for uuid and unused uuid function (Lee Clagett)
|
|
99765b21 Remove unused hash in export_key_images (doy-lee)
|
|
c5e0539c device/trezor: store tx_prefix_hash in tx key aux (Dusan Klinec)
|
|
b8342dd5 blockchain: fix block rate check for empty blockchains (moneromooo-monero)
|
|
841a6acd wallet2: fix accessing unwound stack on exception (moneromooo-monero)
|
|
d24c325c daemon: print human friendly timestamp too (moneromooo-monero)
|
|
808a1f1e wallet2: cut down on the number of useless derivation threads (moneromooo-monero)
|
|
008647d7 blockchain_db: speedup tx output gathering (moneromooo-monero)
|
|
60b35c91 Add --restore-date param (Howard Chu)
|
|
219548f2 Sync hashchain bug fixed (naughtyfox)
|
|
611db08a Wallet: Initialize members without default ctor. (Tadeas Moravec)
|
|
85665003 epee: better network buffer data structure (moneromooo-monero)
|
|
aaafa8a9 ringct: avoid repeated point conversion (moneromooo-monero)
|
|
If there are more valid characters, add them in, I did not find
an actual list.
|
|
|
|
050ee521 wallet_api: fix usage of LOG_ERROR (moneromooo-monero)
|
|
434a147b blocks: fix checkpoint code generation on OpenBSD (moneromooo-monero)
|
|
68f095f0 message_store: fix error message adding const char * with offset (moneromooo-monero)
|
|
Coverity 190651
|
|
Coverity 190660
|
|
|
|
get_output_key method is commonly used when working with txs and their key images. Because the method is not const, passing blockchain object though const& or pointers to const is not possible in this context. This is especially problematic in external projects (e.g., projects in moneroexamples) that use monero C++ api to operate on the blockchain and txs.
Thus, having get_output_key method will simplify moving blockchain object around through const references and pointers to const objects.
|
|
2d7b0236 wallet2: clear all payments on soft rescan_bc (moneromooo-monero)
|
|
93c59b29 perf_timer: check allowed categories before logging (moneromooo-monero)
6a507dab perf_timer: add a way to get and reset the current time (moneromooo-monero)
c1581a5b perf_timer: only log to file (moneromooo-monero)
|
|
570dd369 p2p: use vector instead of list for peer lists (moneromooo-monero)
|
|
5464725a protocol: change standby mode to not wait sleeping (moneromooo-monero)
85807dfb add a once_a_time_milliseconds class (moneromooo-monero)
|
|
a13eb0a1 epee: speed up string matching a bit (moneromooo-monero)
3a3858dc epee: avoid string allocation when parsing a pod from string (moneromooo-monero)
|
|
|
|
|
|
in case it returns 0, and other uses don't, plus it's a estimation anyway.
|
|
Since we keep track of the hf version in the db, we pick it up
from there instead of doing the full reorg call, which is quite
expensive
|
|
|
|
This is now default, so it spares us the warnings
|
|
It can get heavy for large wallets
|
|
|
|
b56b5b5 ignore child process when exec (jtgrassie)
|
|
0e2f5cb perf_timer: make all logs Info level (moneromooo-monero)
|
|
25e5a85 singleton: fix missing *this return value in operator= (monermooo-monero)
|
|
dbbb3ce cryptonote: don't serialize for blob size if already known (moneromooo-monero)
|
|
1d892ec simplewallet: donate command validate amount (selsta)
|
|
6644b9b blockchain_db: remove a couple unused functions (moneromooo-monero)
ce594f5 blockchain_db: allocate known size vector only once (moneromooo-monero)
8332698 db_lmdb: inline check_open, it's trivial and called everywhere (moneromooo-monero)
5511563 db_lmdb: avoid pointless division (moneromooo-monero)
d1efe3d cryptonote: set tx hash on newly parsed txes when known (moneromooo-monero)
9cc68a2 tx_pool: add a few std::move where it can make a difference (moneromooo-monero)
|
|
e37154a build: protobuf dependency fixes, libusb build (ph4r05)
|
|
1505dd3 util: set MONERO_DEFAULT_LOG_CATEGORY (moneromooo-monero)
db57374 util: use fcntl instead of flock, for compatibility (moneromooo-monero)
|
|
9e64a71 blockchain: call deinit in dtor (moneromooo-monero)
|
|
5a76933 Add glibc back compat code (TheCharlatan)
|
|
affff94 blockchain: fix race between two external mining threads (moneromooo-monero)
|
|
e6f026e Simplewallet: Unify usage messages. (tmoravec)
|
|
707c2f8 Remove -Werror (moneromooo-monero)
|
|
|
|
|
|
It seemed like a good idea at the time
|
|
|
|
|
|
Its od outputs small decimals with leading 0, which means octal in C
|
|
While the lookups are faster, the zeroCommit calls have to be
done again when storing the new outputs in the db, which ends
up making the whole thing slower after all, and the ways this
can be cached aren't very nice code wise, so let's forget it
since the gains aren't very large anyway.
|
|
To use if you want all key images, not just the ones for
recently imported outputs
|
|
Help messages describe the commands usage. When users run the command
with wrong arguments, it usually helpfully offers the usage, too.
Unfortunately, these two usage messages were duplicated in the code and
started to get out of sync.
Fixing with constant strings.
|
|
avoids pointless allocs and memcpy
|
|
Also add the type back, as it was somehow weirdly split into
two different fields, one being a union...
|
|
|
|
|
|
|
|
|
|
|
|
- tx_prefix_hash is required in the key derivation for decryption of the tx keys
|
|
|
|
- docker protobuf dependencies, cross-compilation
- device/trezor protobuf build fixes, try_compile
- libusb built under all platforms, used by trezor for direct connect
|
|
We know all the data we'll want for getblocks.bin is contiguous
|
|
|
|
|
|
Estimate restore height from given date
Check date format early, error out early if invalid
|
|
|
|
Found by Coverity (188336 in Anonimal's Coverity account).
|
|
|
|
|
|
6456cb41 Bulletproof: Initialize members in default construtor. (Tadeas Moravec)
|
|
ab783b17 easylogging++: ensure logger is initialized before main (moneromooo-monero)
9b69a0ae daemon: print monero version at startup when calling a detached daemon (moneromooo-monero)
4d71d463 mlocker: remove early page size log (moneromooo-monero)
|
|
0c5dd316 cryptonote: add a set_null for transaction_prefix (moneromooo-monero)
|
|
aba9a9c2 daemon: stop miner before we bring the whole thing down (moneromooo-monero)
|
|
ac665418 ringct: fix dummy bulletproofs on ledger in fake mode (moneromooo-monero)
|
|
e98ae34e core: fix adding new pre-hoh block when a tx is already in the pool (moneromooo-monero)
|
|
756684bb blockchain: avoid unnecessary DB lookups when syncing (moneromooo-monero)
|
|
5ca4994c rpc: speed up the common get_output_distribution case while syncing (moneromooo-monero)
|
|
dc1c1252 add command pop_blocks (Jason Wong)
|
|
a48f2dab blockchain_prune_known_spent_data: blackball file is now optional (moneromooo-monero)
17b45725 Outputs where all amounts are known spent can now be pruned (moneromooo-monero)
|
|
2be31b4c blockchain_blackball: spot when all outputs of an amount are spent (moneromooo-monero)
|
|
9b5efad2 simplewallet: enable donation on testnet/stagenet for easier testing (stoffu)
|
|
d71f89e2 device/trezor: device/trezor: correct device initialization, status check (Dusan Klinec)
65b9bca7 device/trezor: python2 compatibility - bundle dependencies (Dusan Klinec)
9cf636af device/trezor: ask for KI sync on first refresh (Dusan Klinec)
d21dad70 device: enable to use multiple independent device wallets (Dusan Klinec)
318cc784 device/trezor: passphrase entry on host (Dusan Klinec)
|
|
3dba7f25 protocol: option to pad transaction relay to the next kB (moneromooo-monero)
|
|
|
|
and make them not default at log level 1
|
|
They'll get duplicated otherwise
|
|
|
|
while there, disable both operator= and copy ctor, since they
are not supposed to be around for a singleton
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
in particular with NFS
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Otherwise it'd end up with whatever was included last
|
|
This ensures the io service that runs in another thread cannot
access data after it's deleted
|
|
- checks if the device is in the correct usable state
- implements check for the v2.0.9 firmware which does not support payment IDs
- simple transacttion check, payment id fmt consistency
- minor fixes, refactoring, webusb session counting fix
|
|
|
|
When doing a first refresh on HW-token based wallet KI sync is required if money were received. Received money may indicate wallet was already used before the restore I.e., some transaction could have been already sent from the wallet. The spent UTXO would not be detected as spent which could lead to double spending errors on submitting a new transaction.
Thus if the wallet is HW-token based with the cold signing protocol and the first refresh detected received money the user is asked to perform the key image sync.
|
|
- adds a new option `--hw-device-deriv-path` to the simple wallet. Enables to specify wallet derivation path / wallet code (path avoided so it can be misinterpreted as a file path).
- devices can use different derivation mechanisms. Trezor uses standard SLIP-10 mechanism with fixed SLIP-44 prefix for Monero
- Trezor: when empty, the default derivation mechanism is used with 44'/128'/0'. When entered the derivation path is 44'/128'/PATH.
- Trezor: the path is always taken as elements are hardened (1<<31 bit turned on)
|
|
243f010e rpc: mask values that are nobody else's business in restricted RPC (moneromooo-monero)
|
|
506472e0 protocol: fix use after free when dropping a connection (moneromooo-monero)
|
|
aee7a4e3 wallet_rpc_server: do not use RPC data if the call failed (moneromooo-monero)
1a0733e5 windows_service: fix memory leak (moneromooo-monero)
0dac3c64 unit_tests: do not rethrow a copy of an exception (moneromooo-monero)
5d9915ab cryptonote: fix get_unit for non default settings (moneromooo-monero)
d4f50cb1 remove some unused code (moneromooo-monero)
61163971 a few minor (but easy) performance tweaks (moneromooo-monero)
30023074 tests: slow_memmem now returns size_t (moneromooo-monero)
|
|
c28e3d2d rctOps: add braces to suppress warnings (stoffu)
|
|
|
|
b0d9d605 cn_deserialize: allow parsing partially valid tx extra (moneromooo-monero)
|
|
b5573fc2 wallet2: resume processing when tx extra is partially broken (stoffu)
|
|
56e616e8 wallet2: add n_vouts to capture list (moneromooo-monero)
|
|
6bfcc573 scoped_message_writer: protect all std::cout usage from readline (moneromooo-monero)
|
|
9c923bad epee: fix network packet header field endianness (moneromooo-monero)
ec1a62b5 move int-util.h to epee (moneromooo-monero)
|
|
96e6b439 blockchain_stats: don't use gmtime_r on Windows (moneromooo-monero)
|
|
517f25ef rpc: add version to get_info (Jethro Grassie)
|
|
c25260f5 protocol: fix incorrect tx hash in log (moneromooo-monero)
|
|
|
|
fc99f177 lmdb: fix gcc 7.3.0 'implicit-fallthrough' warning (xiphon)
|
|
60f36386 Avoid unnecessary temp block and copy ctor (moneromooo-monero)
|
|
3998a937 Enhance help text for print_ring. (Tadeas Moravec)
3900fb77 Enhance help text for incoming_transfers. (Tadeas Moravec)
|
|
6f2497bc Don't cache nettype in core_rpc_server use m_core (doy-lee)
|
|
bd98e99c Removed a lot of unnecessary includes (Martijn Otto)
|
|
2b3595d0 various: do not propagate exception through dtor (moneromooo-monero)
|
|
6732fc7f Fix issue 4793 - M/N multisig transaction signature (naughtyfox)
|
|
To ensure that the binaries compiled by gitian run across many linux
distributions, enforce 2.17 as the minimum libc version supported.
|
|
|
|
Fixing a build warning on g++ 7.3.0
|
|
So people who want a timstamp get a timestamp
|
|
Since it's all inline, I suspect the compiler will merge the
duplicate stores anyway.
|
|
This avoids the miner erroring out trying to submit blocks
to a core that's already shut down (and avoids pegging
the CPU while we're busy shutting down).
|
|
Ledger does some basic checks on them
|
|
- simple device callback object added. Device can request passphrase/PIN entry via the callback or notify user some action is required
- callback is routed to wallet2, which routes the callback to i_wallet_callback so CLI or GUI wallets can support passphrase entry for HW tokens
- wallet: device open needs wallet callback first - passphrase protected device needs wallet callback so user can enter passphrase
|
|
add new public method to Blockchain and update according to code review
update after review: better lock/unlock, try catch and coding style
|
|
If not present, the tool will scan the blockchain, since scanning
for this is fairly fast.
|
|
Only for pre rct for obvious reasons.
Note: DO NOT use a known spent list which includes outputs
which are not known spent. If the list includes any output
that's just strongly thought to be spent, but not provably
so, you risk finding yourself unable to sync past the point
where that output is spent.
I estimate only 200 MB saved on current mainnet though,
unless the new blackballing rule unearths a good amount of
large-amount-set extra spent outs.
|
|
Some of the inputs for block in a span will be from other earlier
blocks in that span. Keep track of those outputs so we don't have
to look them up again after those early blocks are added to the
blockchain.
|
|
|
|
|
|
for show_transfers
Followup on #4728
|
|
fc98f7a0 rpc: speedup get_outs.bin (moneromooo-monero)
|
|
|
|
2c7195d8 bulletproofs: avoid std::vector allocations for slice (moneromooo-monero)
|
|
c5ee14ae json_archive: initialize inner_array_size in ctor (moneromooo-monero)
|
|
dffec258 db_lmdb: error out if the db needs migration in read only mode (moneromooo-monero)
|
|
b9b307d1 rpc: speedup get_output_distribution (moneromooo-monero)
|
|
2ffe53d9 device/trezor: webusb transport added, cmake fixes (Dusan Klinec)
|
|
1a4d1603 wallet2: remove redundant chacha key generation in store_keys (stoffu)
|
|
|
|
- webusb transport based on libusb added. Provides direct access to Trezor via USB, no need for Trezor bridge.
- trezor protocol message handler improved, no recursion used. Ready for upcoming integration tests.
- libusb (for docker) bumped from v1.0.9 to v1.0.22, newer version required for webusb transport, for device enumeration.
- cmake improvements and fixes. Cmake Trezor checks are moved to a dedicated CheckTrezor.cmake file. In case of a problem Trezor is excluded from build.
- ifdefs made consistent to Ledger.
- UDP Transport enumeration disabled by default in release mode
|
|
|
|
|
|
Found by codacy.com
|
|
Found by codacy.com
|
|
Found by codacy.com
|
