| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
87b5ede9 miner: fix ignoring battery from command line (moneromooo-monero)
|
|
c97d1bd3 wallet: return unlock_time in get_transfers (moneromooo-monero)
|
|
|
|
This was broken by the reorg fix, since we now have to add blocks
regardless of their starting height. We now check whether we know
the parent for the first block in the next span, or whether it was
requested. If neither, it's an orphan. If it is not known, but was
requested, we wait to get that block.
|
|
|
|
|
|
|
|
Why this was initialized properly before I have no idea, but
it is not anymore. Fix it, which fixes syncing in release mode.
|
|
635929ea protocol: add checks for top block hard fork version (moneromooo-monero)
7482253a epee: fixup KV_SERIALIZE_OPT to work in more cases (moneromooo-monero)
|
|
We won't even talk to a peer which claims a wrong version
for its top block. This will avoid syncing to known bad
peers in the first place.
Also add IP fails when failing to verify a block.
|
|
This fixes nodes not being able to connect to nodes which use
recent code. While there, init peer_id too.
|
|
a839a6fa Wallet API: add tx unlock time (Jaquee)
|
|
61770ec2 change mixin to ring size in user visible places (moneromooo-monero)
|
|
|
|
7f7d42f8 core: fix invalid memory access creating tx (moneromooo-monero)
|
|
5d91b26c blockchain: skip checking tx semantics in embedded block hash range (moneromooo-monero)
|
|
|
|
c93b7692 blockchain_import: much faster when verifying with cryptonote::core (moneromooo-monero)
38756d00 core: new API to disable DNS checkpoint lookups (moneromooo-monero)
|
|
e31aac80 walletAPI: add getRefreshFromBlockHeight() (Jaquee)
48c0cb1b wallet api: pause refresh while commiting tx (Jaquee)
f233c01c CMakeLists.txt - ios/xcode fix (Jaquee)
|
|
|
|
|
|
Quick test with the first 56569 blocks from mainnet
version verify batch time
old 0 200 1:16
new 0 200 0:57
old 0 5000 0:53
new 0 5000 0:51
old 1 200 est > 1h
new 1 200 10:21
old 1 5000 est > 1h
new 1 5000 8:27
|
|
|
|
02f13d6c Fix handling of strings & simplify summation of spendkeys (JollyMort)
40fc9d7b Add option to join multisig wallet pieces together (JollyMort)
|
|
158c3ecf core: thread most of handle_incoming_tx (moneromooo-monero)
f57ee382 cryptonote_protocol: retry stale spans early (moneromooo-monero)
90df52e1 cryptonote_protocol: light cleanup (moneromooo-monero)
84e23156 cryptonote_protocol: avoid spurious SYNCHRONIZED OK messages (moneromooo-monero)
5be43fcd cryptonote_protocol_handler: sync speedup (moneromooo-monero)
|
|
328bebbe daemon: some more include cleanup (moneromooo-monero)
|
|
4d873046 blockchain: add testnet v6 fork height at 971400 (moneromooo-monero)
|
|
1c9196b0 cryptonote_protocol: fix days behind calc on testnet (moneromooo-monero)
|
|
600353e2 fix wallet callback signatures (m2049r)
|
|
214fd81e some include cleanup (moneromooo-monero)
|
|
5dd722be core: add a message when loading checkpoints at init time (moneromooo-monero)
|
|
14ec6ed8 tx_pool: remove obsolete unused m_config_folder field (moneromooo-monero)
|
|
d37e8f88 daemon: add average seconds per block in bc_dyn_stats (moneromooo-monero)
|
|
878205f1 core: fix lock ordering bug at init time (moneromooo-monero)
|
|
c6ba7d11 p2p: move m_in_timedsync from connection_context to p2p_connection_context (moneromooo-monero)
|
|
04ebfbfe p2p: close connections when exiting (moneromooo-monero)
9a10148c p2p: fix thread leak (moneromooo-monero)
|
|
d8becf2e blockchain: fix cryptonight buffer leak on exit (moneromooo-monero)
91aa90fc blockchain: ensure all blocks get their longhash precalculated (moneromooo-monero)
ff4bcaed blockchain: pass correct height to get_block_longhash (moneromooo-monero)
|
|
06aea2cf move get_proof_of_trust_hash from util.h to p2p_protocol_defs.h (moneromooo-monero)
|
|
41f935dd network_throttle: remove unneeded heap allocations (moneromooo-monero)
|
|
525975ac wallet-cli: Minor improvement to help output (Erik de Castro Lopo)
|
|
cb0b5594 Move OpenAlias console input back from libs (moneromooo-monero)
|
|
340feede core: randomly shuffle outputs (moneromooo-monero)
|
|
0c57df97 wallet2: fix temporarily missing incoming tx when being mined (moneromooo-monero)
|
|
dc0b312f wallet_rpc_server: optionally return tx blobs on transfer calls (moneromooo-monero)
5eb79983 epee: add a KV_SERIALIZE variant for optional parameters (moneromooo-monero)
|
|
f1b76c84 cryptonote_protocol: Set send_idle_time in connection_info correctly (rbrunner7)
|
|
53af9768 blockchain: one off warning when seeing a block with unknown version (moneromooo-monero)
|
|
16a55347 simplewallet: show payment ids on sign_transfer (moneromooo-monero)
|
|
599436a4 mlog: default to msgwriter logs only for log level 1 (moneromooo-monero)
58f3fc68 Make msgwriter logs go to file only (moneromooo-monero)
|
|
23909bb0 Make successful transfer log message more informative (JollyMort)
|
|
a5031a7d core: forbid duplicate ring members from v6 (moneromooo-monero)
|
|
2fac03e6 Update monerod systemd service file (Erik de Castro Lopo)
51efb217 daemon: Add ability to write a PID file (Erik de Castro Lopo)
|
|
35d68b2c Fix spelling errors (Erik de Castro Lopo)
|
|
125f823b Add on_get_alt_blocks_hashes RPC call (moneroexamples)
|
|
94717021 fix on_battery_power for linux (Ryan Mehta)
|
|
464afd4d Ensure DNSResolver destructor runs on exit (Howard Chu)
|
|
|
|
|
|
Connections can be dropped by the net_node layer,
unbeknownst to cryptonote_protocol, which would then
not flush any spans scheduled to that connection,
which would cause it to be only downloaded again
once it becomes the next span (possibly after a small
delay if it had been requested less than 5 seconds
ago).
|
|
|
|
|
|
A block queue is now placed between block download and
block processing. Blocks are now requested only from one
peer (unless starved).
Includes a new sync_info coommand.
|
|
|
|
|
|
When scanning the txpool without having first updated the
blockchain, the tx would be seen as neither in the txpool
nor the chain, and removed, so it'd only reappear once the
chain is refreshed, and the tx seen in a block.
|
|
Integrated addresses are shown when an encrypted payment id is used
|
|
|
|
|
|
|
|
also show it in simplewallet's show_transfer
|
|
|
|
This will keep leak traces less noisy, as those were one off
allocations that were technically leaking.
|
|
It's got no place in the base class as it's P2P specific field
|
|
|
|
|
|
This uses DNS, which can take a while, so it's useful to know
this is the culprit when loading pauses
|
|
|
|
If the txes are bad, this'll be picked up by the block hash mismatch
since the tx merkle root is part of the block hash.
|
|
|
|
|
|
|
|
This ensures they don't leak if they were in the middle of an
async operation.
|
|
Asks user for all the data required to merge secret keys from multisig wallets into one master wallet, which then gets full control of the multisig wallet. The resulting wallet will be the same as any other regular wallet.
|
|
|
|
|
|
If the number of blocks to check was not a multiple of the
number of preparation threads, the last few blocks would
not be included in the threaded long hash calculation.
Those would still get calculated when the block gets added
to the chain, however, so this was only a tiny performance
hit, rather than a security bug.
|
|
|
|
This avoids having to include p2p_protocol_defs.h in util.h,
as util.h is used a lot, and p2p_protocol_defs.h includes
a lot of other things that most users don't need.
|
|
|
|
Library code should definitely not ask for console input unless
it's clearly an input function. Delegating the user interaction
part to the caller means it can now be used by a GUI, or have a
decision algorithm better adapted to a particular caller.
|
|
also add do_not_relay flag to them, so it now becomes possible
to create a tx without sending it yet
|
|
They used to be sorted by amount, which was fine before rct,
but is now suboptimal, since amounts are not known anymore.
In particular, it would give a recipient knowledge of whether
change was higher or lower than the amount received.
|
|
|
|
|
|
This was the case for monero-wallet-cli already, but not for
monerod, which was making it pretty spammy as it was duplicating
intended output. Since my original intent was to ensure logs
included command output for debugging, this achieves both.
|
|
"Payment successfully sent" can be misleading if the TX isn't confirmed and drops from TX-pool.
|
|
This avoids someone adding what amounts to mixin 0 rings in
practice, as there is no other good reason to allow this.
|
|
The PID file will only be written if the daemon is called with the
`--detach` command line argument and a `--pidfile /some/file/path`
argument.
|
|
6955976b Add various readline related fixes (Jethro Grassie)
|
|
c3bb6bec daemon: fix status in command line mode if using restricted rpc (moneromooo-monero)
|
|
f5f985c0 miner: fix background mining options parsing (moneromooo-monero)
|
|
33d17c37 Don't hardcode /tmp (Howard Chu)
|
|
8db68a57 Fix #2164 histogram output (Howard Chu)
|
|
02d66db4 tx_pool: initialize padding in txpool meta structure (moneromooo-monero)
0722aea3 cryptonote_core: initialize checkpoint flag (moneromooo-monero)
|
|
5cea3552 simplewallet: lock idle scope when sweeping (moneromooo-monero)
|
|
|
|
They were set as uint8_t, which boost was apparently treating
as a character type, rather than a numeric type
|
|
|
|
When there are more than 50txs, the timestamp for the last
bin was printed incorrectly. Subtracting "now" was omitted by mistake
in 3fc22e7b78ab1dd409de4f3e8f5bff27be19735b
|
|
- Add missing unbind key
- Fix colored messages
- Add command completion
- Preserve last command input
- Fix cursor position issues
- Fix trailing whitespace in commands
- Synchronize set_prompt
|
|
fix ac/battery linux
|
|
|
|
|
|
f98bf48b Minor cleanup: tab vs. space + logs messages (binaryFate)
|
|
3b599d2b wallet2: get current height from the daemon on creation (moneromooo-monero)
d3bb72ff wallet2: fix infinite loop on future refresh height (moneromooo-monero)
32754784 wallet: fix refresh_from_height setting on new wallet (moneromooo-monero)
|
|
5a09d79c Fix #2120: return per-tx amount in transfer_split RPC call. (binaryFate)
|
|
b592cb3f Fix on_transfer RPC incorrect logging info (Mike C)
|
|
76043b17 monero-wallet-cli: hang on exit in readline code (#2117) (moneromooo-monero)
a73a42a6 monero-wallet-cli: hang on exit in readline code (#2117) (moneromooo-monero)
be9d4f04 Fix multiline wallet cli output with readline (Jethro Grassie)
|
|
7d2c89b6 Add french translation (Guillaume LE VAILLANT)
3255887f simplewallet: typo fixes (Guillaume LE VAILLANT)
|
|
bdab3436 Fix mismatch of parameter name between header file and implementation for set_user_options() (Julien Klepatch)
|
|
bb708ab8 electrum-words: fix seed mistakenly thought to be old style (moneromooo-monero)
|
|
|
|
|
|
This ensures the chain and related structures can't change
while we're using them
|
|
Plugs a noisy but benign memory leak
|
|
Since I had to add an ID to the derived classes anyway,
this can be used instead. This removes an apparently
pointless warning from CLANG too.
|
|
|
|
|
|
Use current time to estimate current height only if the daemon
cannot be queried.
|
|
If the refresh height is in the future, the current code will
loop till the actual height reaches this. Fix it by bailing out
if we receive only three hashes, which is what we set in the
call parameters.
|
|
The previous patch was based on a wrong premise (that the
daemon height was 0 because the daemon calling code wasn't
yet initialized). In fact, current height approximation
was not setup for testnet. Fix this.
|
|
monero-wallet-cli commands which have multine output sometimes causes
issues with the readline support. This patch fixes show_transfers,
payments and incoming_transfers.
|
|
e4da88a2 Fixed typo in rpc/core_rpc_server.cpp (Julien Klepatch)
|
|
07c4276c Don't issue a new timedsync while one is already in progress (Howard Chu)
cf3a376c Don't timeout a slow operation that's making progress (Howard Chu)
340830de Fix PR#2039 (Howard Chu)
|
|
|
|
|
|
set_user_options()
|
|
It'd see "empty" words due to extraneous spaces
|
|
|
|
|
|
|
|
not the actual tx secret key
|
|
4e13ab30 wallet_api: fix missing transaction parameter in callback (moneromooo-monero)
|
|
235df7f4 blockchain_db: add a txpool tx getter which returns existence (moneromooo-monero)
|
|
b2319a03 simplewallet: new command to generate a random payment id (moneromooo-monero)
|
|
1dd52415 Fix #1991 asm multiply again (Howard Chu)
|
|
ac0714dc add simplewallet --generate-new-wallet arg checks (Michael Shick)
|
|
e1f3dfcc Add readline support to cli (jethro)
|
|
71f8249a Prevent crash if performing certain actions before wallet is initialized (Robby Weinberg)
|
|
3fc22e7b Add histogram to poolstats (Howard Chu)
d09620b0 Fix PR#2039 (Howard Chu)
|
|
6fc2dc39 cryptonote_protocol_handler: fix crash in debug log (moneromooo-monero)
|
|
This PR adds readline support to the daemon and monero-wallet-cli. Only
GNU readline is supported (e.g. not libedit) and there are cmake checks
to ensure this.
There is a cmake variable, Readline_ROOT_DIR that can specify a
directory to find readline, otherwise some default paths are searched.
There is also a cmake option, USE_READLINE, that defaults to ON. If set
to ON, if readline is not found, the build continues but without
readline support.
One negative side effect of using readline is that the color prompt in
the wallet-cli now has no color and just uses terminal default. I know
how to fix this but it's quite a big change so will tackle another time.
|
|
1b75ad91 Add OSX background mining (jethro)
|
|
072102cf abstracted nework addresses (moneromooo-monero)
|
|
|
|
A timedsync is issued every minute on a connection, but the input
tineout is 2 minutes. This means a new sync request could be issued
while a slow sync request was already in progress. The additional
request will further clog the network on a slow connection, and
cause a premature timeout.
|
|
It was unused, so harmless
Reported by erikd on IRC
|
|
Avoids exception spam for the "nope, not found" case
|
|
This is trivial, but often requested, and possibly hard to do
in Windows. That makes it more user friendly.
|
|
Tweak temp variables and constraints. Was working before if not inlined
but newer gcc tends to inline it.
|
|
Implements miner::get_system_times, miner::get_process_time and
miner::on_battery_power for OSX so that background mining works on OSX.
|
|
Add fail-fast paths that reduce frustration around the misuse of
--wallet-file combined with --restore-deterministic-wallet. Flow now
gives more descriptive errors and avoids having users type in their
whole seed before the failure condition is noticed.
|
|
|
|
|
|
|
|
6bcd3b2d fix get_upper_transaction rename (schnerchi)
|
|
d17c0fc2 Don't copy blockchain for coinbase_tx_sum (Howard Chu)
|
|
31417d57 tx_pool: add missing blockchain lock in add_tx (moneromooo-monero)
|
|
Since we're just counting txs, there's no reason to deserialize all the blobs.
|
|
Changed Blockchain::for_all_blocks() to for_blocks_range()
Operate on blockchain in-place instead of building a copy first.
|
|
|
|
|
|
05f3dcf7 simplewallet: fix refresh height for new wallets (moneromooo-monero)
|
|
740bc24c Wallet API: Set seed lang when recovering form keys (Jaquee)
|
|
4b932ff3 changed crypto to cncrypto so it generated libcncrypto (Gentian)
|
|
89e20bb9 Fix typo (xmr-eric)
|
|
89b2f306 tests: fix invalid key image test (moneromooo-monero)
a374a522 wallet2: check key image validity domain in import_key_images (moneromooo-monero)
|
|
dd8e3266 shared libs build (i.e. make debug) (stoffu)
|
|
a5739201 Update sync time copy (xmr-eric)
|
|
e2529347 Correct spelling of 'get_upper_transaction_size_limit' (Nano Akron)
3029d0ef Remove the 1.25x multiplier in max transaction size in just the wallet (Nano Akron)
|
|
8ac2496c corrected typo in help regarding min-outputs-* (stoffu)
|
|
6cb1ad1f wallet fix: ensure iterator to be valid (stoffu)
|
|
0a182576 node_rpc_proxy: fix earliest fork height query for unknown forks (moneromooo-monero)
391c918d wallet2: fix sweep_unmixable assuming wrong minimum mixin at v5 (moneromooo-monero)
|
|
b52abd13 Move txpool to the database (moneromooo-monero)
|
|
With the recent change to wallet creation code, the code was
calling to the daemon before the wallet's daemon address was
initialized, and thus failing. This was causing all new wallets
to refresh from 0 instead of just fetching early block hashes.
|
|
All code which was using ip and port now uses a new IPv4 object,
subclass of a new network_address class. This will allow easy
addition of I2P addresses later (and also IPv6, etc).
Both old style and new style peer lists are now sent in the P2P
protocol, which is inefficient but allows peers using both
codebases to talk to each other. This will be removed in the
future. No other subclasses than IPv4 exist yet.
|
|
|
|
Integration could go further (ie, return_tx_to_pool calls should
not be needed anymore, possibly other things).
poolstate.bin is now obsolete.
|
|
|
|
fix a cmakelist
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
The bump to minimum mixin 4 was moved from v5 to v6
|
|
bbf4c210 Wallet API: add spend/view key getters (Jaquee)
|
|
12fff108 Change Old_English to English_Old - 'Old English' is actually a language (Nano Akron)
533187f0 Change all wallet language names into native names (and scripts) (Nano Akron)
|
