aboutsummaryrefslogtreecommitdiff
path: root/src/wallet (follow)
AgeCommit message (Collapse)AuthorFilesLines
2020-01-16Merge pull request #6144Alexander Blair2-7/+33
0e0351c4 wallet_rpc_server: add count parameter to create_address (Matt Smith)
2020-01-11Merge pull request #6112Alexander Blair1-32/+33
7c1d31b0 build: fix IOS, build blockchain_db and rpc, skip wallet_rpc_server (xiphon)
2020-01-11Merge pull request #6105Alexander Blair5-0/+72
0de8a0d3 wallet_rpc_server: new estimate_tx_size_and_weight RPC (moneromooo-monero)
2019-12-12Merge pull request #6057luigi11112-3/+23
3b8dcc2 wallet2: make keys unlocker reentrant (moneromooo-monero)
2019-11-22wallet_rpc_server: add count parameter to create_addressMatt Smith2-7/+33
2019-11-16Merge pull request #6135luigi11111-1/+1
09f59ec wallet: set non-empty error string on connection failure (xiphon)
2019-11-14wallet: set non-empty error string on connection failurexiphon1-1/+1
2019-11-09build: fix IOS, build blockchain_db and rpc, skip wallet_rpc_serverxiphon1-32/+33
2019-11-06wallet_rpc_server: new estimate_tx_size_and_weight RPCmoneromooo-monero5-0/+72
2019-11-04wallet2: fix pool txes not being flushed when minedmoneromooo-monero1-1/+1
2019-11-01wallet: reuse cached height when set after refreshmoneromooo-monero2-0/+11
Refreshing sets cached height, which is otherwise got by calling get_info. Since get_info is called upon needing to display a prompt after a command has finished, it can be used to determine how much time a given command took to run if the cache timeout lapses while the command runs. Refreshing caches the height as a side effect, so get_info will never be called as a result of displaying a prompt after refreshing (and potentially leaking how much time it took to process a set of transactions, therefore leaking whether we got some monero in them).
2019-11-01wallet2: fix is_synced checking target height, not heightmoneromooo-monero1-1/+1
Target height would be appropriate for the daemon, which syncs off other daemons, but the wallet syncs off the daemon it's connected to, and its target is the daemon's current height.
2019-11-01wallet: fix another facet of "did I get some monero" information leakmoneromooo-monero3-13/+40
We get new pool txes before processing any tx, pool or not. This ensures that if we're asked for a password, this does not cause a measurable delay in the txpool query after the last block query.
2019-11-01wallet2: do not send an unnecessary last getblocks.bin call on refreshmoneromooo-monero2-7/+17
The "everything refreshed" state was detected when a refresh call did not return any new blocks. This can be detected without that extra "empty" call by comparing the claimed node height to the height of the last block retrieved. Doing this avoids that last call, saves some bandwidth, and makes the common refresh case use only one call rather than two. As a side effect, it prevents an information leak reported by Tramèr et al: if the wallet retrieves a set of blocks which includes an output sent to the refreshing wallet, the wallet will prompt the user for the password to decode the amount and calculate the key image for the new output, and this will delay subsequent calls to getblocks.bin, allowing a passive adversary to note the delay and deduce when the wallet receives at least one output. This can still happen if the wallet downloads more than 1000 blocks, since this will be split in several calls, but then the most the adversary can tell is which 1000 block section the user received some monero (the adversary can estimate the heights of the blocks by calculating how many "large" transfers are done, which will be sections of blocks, the last of which will usually be below 1000, but the size of the data should allow the actual number of blocks sent to be determined fairly accurately). This timing trick still be used via the subsequent scan for incoming txes in the txpool, which will be fixed later.
2019-11-01wallet2: do not repeatedly ask for pool txes sent to usmoneromooo-monero1-5/+0
This lets a passive attacker with access to the network link between node and wallet perform traffic analysis to deduce when an idle wallet receives a transaction. Reported by Tramèr et al.
2019-10-29wallet2: make keys unlocker reentrantmoneromooo-monero2-3/+23
protects against having your keys mangled
2019-10-27wallet: do not warn if the rpc cost was freemoneromooo-monero1-1/+1
2019-10-25Merge pull request #6019luigi11111-2/+2
d60c1b6 changed 'batttery' to 'battery' (jakehemmerle)
2019-10-25Merge pull request #6014luigi11111-0/+5
93e7426 wallet2: error out when we need a daemon password but have no prompt function (moneromooo-monero)
2019-10-25Merge pull request #6013luigi11111-0/+1
635401b wallet2: fix the logged number of detached transfers (moneromooo-monero)
2019-10-25simplewallet: add public_nodes commandmoneromooo-monero2-0/+23
Lists nodes exposing their RPC port for public use
2019-10-25daemon, wallet: new pay for RPC use systemmoneromooo-monero11-324/+1001
Daemons intended for public use can be set up to require payment in the form of hashes in exchange for RPC service. This enables public daemons to receive payment for their work over a large number of calls. This system behaves similarly to a pool, so payment takes the form of valid blocks every so often, yielding a large one off payment, rather than constant micropayments. This system can also be used by third parties as a "paywall" layer, where users of a service can pay for use by mining Monero to the service provider's address. An example of this for web site access is Primo, a Monero mining based website "paywall": https://github.com/selene-kovri/primo This has some advantages: - incentive to run a node providing RPC services, thereby promoting the availability of third party nodes for those who can't run their own - incentive to run your own node instead of using a third party's, thereby promoting decentralization - decentralized: payment is done between a client and server, with no third party needed - private: since the system is "pay as you go", you don't need to identify yourself to claim a long lived balance - no payment occurs on the blockchain, so there is no extra transactional load - one may mine with a beefy server, and use those credits from a phone, by reusing the client ID (at the cost of some privacy) - no barrier to entry: anyone may run a RPC node, and your expected revenue depends on how much work you do - Sybil resistant: if you run 1000 idle RPC nodes, you don't magically get more revenue - no large credit balance maintained on servers, so they have no incentive to exit scam - you can use any/many node(s), since there's little cost in switching servers - market based prices: competition between servers to lower costs - incentive for a distributed third party node system: if some public nodes are overused/slow, traffic can move to others - increases network security - helps counteract mining pools' share of the network hash rate - zero incentive for a payer to "double spend" since a reorg does not give any money back to the miner And some disadvantages: - low power clients will have difficulty mining (but one can optionally mine in advance and/or with a faster machine) - payment is "random", so a server might go a long time without a block before getting one - a public node's overall expected payment may be small Public nodes are expected to compete to find a suitable level for cost of service. The daemon can be set up this way to require payment for RPC services: monerod --rpc-payment-address 4xxxxxx \ --rpc-payment-credits 250 --rpc-payment-difficulty 1000 These values are an example only. The --rpc-payment-difficulty switch selects how hard each "share" should be, similar to a mining pool. The higher the difficulty, the fewer shares a client will find. The --rpc-payment-credits switch selects how many credits are awarded for each share a client finds. Considering both options, clients will be awarded credits/difficulty credits for every hash they calculate. For example, in the command line above, 0.25 credits per hash. A client mining at 100 H/s will therefore get an average of 25 credits per second. For reference, in the current implementation, a credit is enough to sync 20 blocks, so a 100 H/s client that's just starting to use Monero and uses this daemon will be able to sync 500 blocks per second. The wallet can be set to automatically mine if connected to a daemon which requires payment for RPC usage. It will try to keep a balance of 50000 credits, stopping mining when it's at this level, and starting again as credits are spent. With the example above, a new client will mine this much credits in about half an hour, and this target is enough to sync 500000 blocks (currently about a third of the monero blockchain). There are three new settings in the wallet: - credits-target: this is the amount of credits a wallet will try to reach before stopping mining. The default of 0 means 50000 credits. - auto-mine-for-rpc-payment-threshold: this controls the minimum credit rate which the wallet considers worth mining for. If the daemon credits less than this ratio, the wallet will consider mining to be not worth it. In the example above, the rate is 0.25 - persistent-rpc-client-id: if set, this allows the wallet to reuse a client id across runs. This means a public node can tell a wallet that's connecting is the same as one that connected previously, but allows a wallet to keep their credit balance from one run to the other. Since the wallet only mines to keep a small credit balance, this is not normally worth doing. However, someone may want to mine on a fast server, and use that credit balance on a low power device such as a phone. If left unset, a new client ID is generated at each wallet start, for privacy reasons. To mine and use a credit balance on two different devices, you can use the --rpc-client-secret-key switch. A wallet's client secret key can be found using the new rpc_payments command in the wallet. Note: anyone knowing your RPC client secret key is able to use your credit balance. The wallet has a few new commands too: - start_mining_for_rpc: start mining to acquire more credits, regardless of the auto mining settings - stop_mining_for_rpc: stop mining to acquire more credits - rpc_payments: display information about current credits with the currently selected daemon The node has an extra command: - rpc_payments: display information about clients and their balances The node will forget about any balance for clients which have been inactive for 6 months. Balances carry over on node restart.
2019-10-24changed 'batttery' to 'battery'Jake Hemmerle1-2/+2
2019-10-23wallet2: error out when we need a daemon password but have no prompt functionmoneromooo-monero1-0/+5
2019-10-23wallet2: fix the logged number of detached transfersmoneromooo-monero1-0/+1
2019-10-16Merge pull request #5959luigi11111-5/+5
4d22317 wallet2: don't delete file that may not exist (selsta)
2019-10-16Merge pull request #5952luigi11112-1/+41
93d5cf2 wallet2: add ignore-outputs-{above/below} option (stoffu)
2019-10-14Merge pull request #5940luigi11111-0/+7
6b4bc0d RPC on_transfer_split error consistent with on_transfer if no tx sent (binaryFate)
2019-10-14wallet_rpc_server: don't report integrated addresses for 0 payment IDmoneromooo-monero1-2/+5
These are dummy ones
2019-10-14wallet: remove long payment ID sending supportmoneromooo-monero3-34/+3
2019-10-14wallet2: ignore received unencrypted payment IDs (but warn hard)moneromooo-monero2-7/+19
2019-10-08Merge pull request #5915luigi11111-1/+1
8330e77 monerod can now sync from pruned blocks (moneromooo-monero)
2019-10-04wallet2: don't delete file that may not existselsta1-5/+5
2019-10-02wallet2: add ignore-outputs-{above/below} optionstoffu2-1/+41
https://github.com/aeonix/aeon/pull/131
2019-09-30Merge pull request #5939luigi11111-0/+2
9baf2a7 build: link wallet_merged against blockchain_db and hardforks obj (xiphon)
2019-09-30Merge pull request #5894luigi11111-0/+4
c89f7ef wallet2_api: fix load unsigned tx from file error propagation (xiphon)
2019-09-30Merge pull request #5893luigi11111-0/+6
Coverity fixes [3a81639, 1bd962d, 2825f07, d099658, d46f701, cd57a10] (anonimal)
2019-09-28RPC on_transfer_split error consistent with on_transfer if no tx sentbinaryFate1-0/+7
2019-09-28build: link wallet_merged against blockchain_db and hardforks objxiphon1-0/+2
2019-09-27monerod can now sync from pruned blocksmoneromooo-monero1-1/+1
If the peer (whether pruned or not itself) supports sending pruned blocks to syncing nodes, the pruned version will be sent along with the hash of the pruned data and the block weight. The original tx hashes can be reconstructed from the pruned txes and theur prunable data hash. Those hashes and the block weights are hashes and checked against the set of precompiled hashes, ensuring the data we received is the original data. It is currently not possible to use this system when not using the set of precompiled hashes, since block weights can not otherwise be checked for validity. This is off by default for now, and is enabled by --sync-pruned-blocks
2019-09-24Merge pull request #5877luigi11112-6/+5
2cd4fd8 Changed the use of boost:value_initialized for C++ list initializer (JesusRami) 4ad191f Removed unused boost/value_init header (whyamiroot) 928f4be Make null hash constants constexpr (whyamiroot)
2019-09-17wallet: add edit_address_book RPCmoneromooo-monero5-1/+153
2019-09-14Merge pull request #5861luigi11111-0/+16
f0356f7 wallet2: enable ignoring fractional outputs also when sweeping (stoffu)
2019-09-14Merge pull request #5899luigi11112-4/+4
7d3bba5 wallet2_api: add missing parameter (selsta)
2019-09-14Merge pull request #5871luigi11112-1/+12
3407743 wallet_rpc_server: add locked field to get_transfers/get_{bulk_,}_payments (moneromooo-monero)
2019-09-14Merge pull request #5870luigi11111-0/+1
83ca764 wallet_rpc_server: call deinit on exit (moneromooo-monero)
2019-09-14Merge pull request #5866luigi11112-2/+49
21f6c80 rpc: move a leftover light wallet RPC out of daemon RPC (moneromooo-monero)
2019-09-10wallet2: enable ignoring fractional outputs also when sweepingstoffu1-0/+16
2019-09-09wallet2_api: add missing parameterselsta2-4/+4
2019-09-08Merge pull request #5855luigi11114-49/+79
2ec455d wallet: fix mismatch between two concepts of 'balance' (moneromooo-monero)
2019-09-08Merge pull request #5850luigi11111-3/+1
c4da1a2 wallet2: fix unset_ring tx retrieval checks (moneromooo-monero)
2019-09-08Merge pull request #5847luigi11111-1/+1
894cc81 wallet2: fix cold signing losing tx keys (moneromooo-monero)
2019-09-08Merge pull request #5843luigi11111-1/+1
9f68669 blockchain_blackball: add --historical-stat which prints historical stats of spent ratio (stoffu) 2425f27blockchain_blackball: use is_output_spent instead of ringdb.blackballed for spentness test (stoffu) 50813c1 ringdb: fix bug in blackballing (stoffu)
2019-09-09wallet2_api: fix load unsigned tx from file error propagationxiphon1-0/+4
2019-09-06wallet2: resolve CID 203918 null pointer deference (NULL_RETURNS)anonimal1-0/+6
2019-09-05wallet: fix mismatch between two concepts of "balance"moneromooo-monero4-49/+79
One considers the blockchain, while the other considers the blockchain and some recent actions, such as a recently created transaction which spend some outputs, but isn't yet mined. Typically, the "balance" command wants the latter, to reflect the recent action, but things like proving ownership wants the former. This fixes a crash in get_reserve_proof, where a preliminary check and the main code used two concepts of "balance".
2019-09-05wallet_rpc_server: add locked field to get_transfers/get_{bulk_,}_paymentsmoneromooo-monero2-1/+12
Much easier to work with than the raw unlock_time field
2019-09-04Merge pull request #5822luigi11111-0/+2
839fc62 reject setting lookahead major or minor to 0 (moneromoo-monero)
2019-09-02Removed unused boost/value_init headerLev Sizov1-1/+0
2019-09-02Changed the use of boost:value_initialized for C++ list initializerJesus Ramirez2-5/+5
2019-08-28simplewallet: lock console on inactivitymoneromooo-monero2-0/+12
2019-08-28wallet_rpc_server: call deinit on exitmoneromooo-monero1-0/+1
2019-08-28rpc: move a leftover light wallet RPC out of daemon RPCmoneromooo-monero2-2/+49
2019-08-27Merge pull request #5609luigi11111-0/+11
1dc3b1a wallet: add --extra-entropy command line flag (moneromooo-monero)
2019-08-27Merge pull request #5559luigi11112-1/+5
33e91e1 wallet, rpc: add a release field to get_version (moneromooo-monero)
2019-08-26wallet, rpc: add a release field to get_versionmoneromooo-monero2-1/+5
It does not leak much since you can make a fair guess by RPC version already, and some people want to avoid non release clients when using third parties' nodes (because they'd never lie about it)
2019-08-24wallet2: fix unset_ring tx retrieval checksmoneromooo-monero1-3/+1
2019-08-23wallet2: fix cold signing losing tx keysmoneromooo-monero1-1/+1
2019-08-22Wallet: Option to export data to ASCIITadeas Moravec2-21/+120
New CLI wallet variable: export-format with options "binary" (the default), or "ascii". "Binary" behaves as before, "ascii" forces the wallet to convert data to ASCII using base64. Reading files from the disk tries to auto detect what format has been used (using a magic string added when exporting the data). Implements https://github.com/monero-project/monero/issues/2859
2019-08-22ringdb: fix bug in blackballingstoffu1-1/+1
2019-08-22wallet: add --extra-entropy command line flagmoneromooo-monero1-0/+11
It lets the user add custom entropy to the PRNG. It does this by hashing the new data and xoring the resulting hash with the PRNG state.
2019-08-21Merge pull request #5778luigi11113-35/+41
8703aa5 MMS: Use chans instead of normal addresses for auto-config (rbrunner7)
2019-08-21Merge pull request #5750luigi11112-3/+3
884df82 wallet: provide original address for outgoing transfers (xiphon)
2019-08-21Merge pull request #5722luigi11112-3/+3
8be5fea simplewallet: optional all flag to export_outputs/export_key_images (moneromooo-monero)
2019-08-20MMS: Use chans instead of normal addresses for auto-configrbrunner73-35/+41
2019-08-19Merge pull request #5727luigi11111-2/+2
7b9a420 Replace std::random_shuffle with std::shuffle (tomsmeding)
2019-08-19Merge pull request #5718luigi11111-1/+4
c8709fe wallet: do not print log settings when unset (moneromooo-monero) 7b18e83 unit_tests: check return values on test data parsing (moneromooo-monero)
2019-08-19reject setting lookahead major or minor to 0moneromooo-monero1-0/+2
2019-08-17Merge pull request #5518luigi11113-48/+79
def703a wallet_api: add multi destination tx support (selsta)
2019-08-16wallet_api: add multi destination tx supportselsta3-48/+79
2019-08-15Merge pull request #5673luigi11111-8/+17
097cca5 wallet_api: catch getTxKey exception (ph4r05)
2019-08-15Merge pull request #5672luigi11111-0/+1
b2bfcab wallet2: fix change subaddress mixup when sending pre rct outputs (moneromooo-monero)
2019-08-15Merge pull request #5662luigi11111-3/+11
64fb0f8 device: tx_key caching fixed, store recovered txkey (ph4r05)
2019-08-15Replace std::random_shuffle with std::shuffleTom Smeding1-2/+2
According to [1], std::random_shuffle is deprecated in C++14 and removed in C++17. Since std::shuffle is available since C++11 as a replacement and monero already requires C++11, this is a good replacement. A cryptographically secure random number generator is used in all cases to prevent people from perhaps copying an insecure std::shuffle call over to a place where a secure one would be warranted. A form of defense-in-depth. [1]: https://en.cppreference.com/w/cpp/algorithm/random_shuffle
2019-08-14Merge pull request #5487luigi11111-0/+2
df83ed7 consensus: from v12, enforce >= 2 outputs (moneromooo-monero)
2019-08-14Merge pull request #5478luigi11111-3/+2
7d9b7fe functional_tests: add validate_address tests (moneromooo-monero)
2019-08-14Merge pull request #4851luigi11111-1/+3
155475d Add IPv6 support (KeeJef/tewinget)
2019-07-31Add IPv6 supportThomas Winget1-1/+3
new cli options (RPC ones also apply to wallet): --p2p-bind-ipv6-address (default = "::") --p2p-bind-port-ipv6 (default same as ipv4 port for given nettype) --rpc-bind-ipv6-address (default = "::1") --p2p-use-ipv6 (default false) --rpc-use-ipv6 (default false) --p2p-require-ipv4 (default true, if ipv4 bind fails and this is true, will not continue even if ipv6 bind successful) --rpc-require-ipv4 (default true, description as above) ipv6 addresses are to be specified as "[xx:xx:xx::xx:xx]:port" except in the cases of the cli args for bind address. For those the square braces can be omitted.
2019-07-29functional_tests: add validate_address testsmoneromooo-monero1-3/+2
2019-07-28Fixed error preventing build of monero-guiNejcraft1-1/+3
get_attribute expects 2 values instead of 1
2019-07-24Merge pull request #5600luigi11112-7/+13
dd58057 Remember RPC version on initial connect (hyc)
2019-07-24Merge pull request #5594luigi11115-0/+53
f074b6b device: show address on device display (ph4r05)
2019-07-24Merge pull request #5576luigi11112-4/+0
577324a wallet_manager: omit redundant disconnect, drop unused variable (xiphon)
2019-07-24Merge pull request #5534luigi11113-0/+28
4c66614 expose set/get walletcache attribute functionality in wallet api (selsta)
2019-07-24Merge pull request #5514luigi11111-2/+2
e4d100b wallet2: don't wait a day before using new version fees (moneromooo-monero)
2019-07-24Merge pull request #5513luigi11114-6/+16
bc94ba4 wallet: distinguish between empty and absent attributes (moneromooo-monero)
2019-07-24Merge pull request #5502luigi11111-3/+0
25a7cfd add a few checks where it seems appropriate (moneromooo-monero) 1a66a86 remove unused code (moneromooo-monero)
2019-07-24Merge pull request #5457luigi11111-2/+0
3b9ce45 wallet_rpc_server: remove unused variable (moneromooo-monero)
2019-07-10wallet: provide original address for outgoing transfersxiphon2-3/+3
2019-07-09wallet_rpc_server: fix get_bulk_payments with short payment idsmoneromooo-monero1-0/+5
2019-07-02simplewallet: optional all flag to export_outputs/export_key_imagesmoneromooo-monero2-3/+3
2019-07-01wallet: do not print log settings when unsetmoneromooo-monero1-1/+4
Coverity 199721
2019-06-19wallet_api: catch getTxKey exceptionDusan Klinec1-8/+17
- getTxKey method throws an exception, e.g., when user declines txKey export
2019-06-19wallet2: fix change subaddress mixup when sending pre rct outputsmoneromooo-monero1-0/+1
2019-06-17device: show address on device displayDusan Klinec5-0/+53
- Trezor: support for device address display (subaddress, integrated address) - Wallet::API support added - Simplewallet: - address device [<index>] - address new <label> // shows address on device also - integrated_address [device] <payment_id|address> // new optional "device" arg to display also on the device
2019-06-17device: tx_key caching fixed, store recovered txkeyDusan Klinec1-3/+11
2019-06-02Remember RPC version on initial connectHoward Chu2-7/+13
Don't keep asking for it on an intact connection Wallet is too chatty over the wire
2019-06-01Merge pull request #5561Riccardo Spagni2-52/+10
9bfa4c20 Fix allow any cert mode in wallet rpc when configured over rpc (Lee Clagett) 3544596f Add ssl_options support to monerod's rpc mode. (Lee Clagett) c9aaccf3 Fix configuration bug; wallet2 --daemon-ssl-allow-any-cert now works. (Lee Clagett)
2019-05-27wallet_manager: omit redundant disconnect, drop unused variablexiphon2-4/+0
2019-05-22Fix allow any cert mode in wallet rpc when configured over rpcLee Clagett1-1/+5
2019-05-22Add ssl_options support to monerod's rpc mode.Lee Clagett1-50/+1
2019-05-21Fix configuration bug; wallet2 --daemon-ssl-allow-any-cert now works.Lee Clagett1-1/+4
2019-05-16wallet: add unlock_time details to show_transfersmoneromooo-monero3-4/+4
also add a note when receiving the tx, because the user might not notice the "XXX blocks to unlock" in the balance.
2019-05-14Merge pull request #5538luigi11112-2/+2
615f287 wallet: fix certificate fingerprint length check (moneromooo-monero)
2019-05-11wallet: fix certificate fingerprint length checkmoneromooo-monero2-2/+2
Fixed by crCr62U0
2019-05-10expose set/get walletcache attribute functionality in wallet apidsc3-0/+28
2019-05-10wallet_rpc_server: use original addresses in destinations in get_transfersmoneromooo-monero1-1/+9
And add them for pending transfers, where they were missing
2019-05-07Merge pull request #5508Riccardo Spagni1-4/+2
1c44e658 wallet2: reject standalone short payment IDs in monero: URI API (moneromooo-monero)
2019-05-07Merge pull request #5503Riccardo Spagni1-4/+4
ccc1e311 wallet_rpc_server: reject standalone short payment id in address book (moneromooo-monero)
2019-05-07Merge pull request #5501Riccardo Spagni1-2/+5
b4ca72dd wallet2: fix infinite loop picking outputs in corner case (moneromooo-monero)
2019-05-02wallet2: don't wait a day before using new version feesmoneromooo-monero1-2/+2
30 blocks should be more than enough to drain the txpool of transactions made with the old fee scheme
2019-05-02wallet: distinguish between empty and absent attributesmoneromooo-monero4-6/+16
2019-05-02Merge pull request #5493Riccardo Spagni2-0/+15
5e0da6fb change SSL certificate fingerprint whitelisting from SHA1 to SHA-256 (moneromooo-monero)
2019-05-02Merge pull request #5491Riccardo Spagni1-2/+4
98fb98f9 wallet_rpc_server: adding missing return on error in set_daemon (moneromooo-monero) 9074c0d8 wallet_rpc_server: return false on error in set_log_categories (moneromooo-monero) 968848a7 wallet_rpc_server: fix crash in validate_address if no wallet is loaded (moneromooo-monero)
2019-05-02Merge pull request #5489Riccardo Spagni1-3/+13
64983fce wallet2: default to trying to keep 5 outputs of 2+ monero (moneromooo-monero)
2019-05-01wallet2: reject standalone short payment IDs in monero: URI APImoneromooo-monero1-4/+2
2019-04-30wallet_rpc_server: reject standalone short payment id in address bookmoneromooo-monero1-4/+4
2019-04-29remove unused codemoneromooo-monero1-3/+0
2019-04-29wallet2: fix infinite loop picking outputs in corner casemoneromooo-monero1-2/+5
If we have fewer outputs available on the chain than what we require, but the output we're spending already has a ring, it would loop picking outputs randomly, but never find enough. Also tune logs for better debugging this kind of thing.
2019-04-26change SSL certificate fingerprint whitelisting from SHA1 to SHA-256moneromooo-monero2-0/+15
SHA1 is too close to bruteforceable
2019-04-25wallet_rpc_server: adding missing return on error in set_daemonmoneromooo-monero1-0/+1
2019-04-25wallet_rpc_server: return false on error in set_log_categoriesmoneromooo-monero1-1/+1
Reported by SmajeNz0
2019-04-25wallet_rpc_server: fix crash in validate_address if no wallet is loadedmoneromooo-monero1-1/+2
Reported by SmajeNz0
2019-04-24Merge pull request #5486Riccardo Spagni1-0/+2
4be18df3 tx_sanity_check: relax uniqueness check a bit (moneromooo-monero) b386ae57 wallet2: add missing "sanity check failed" reason message (moneromooo-monero)
2019-04-24Merge pull request #5485Riccardo Spagni1-2/+2
c519d1df wallet2: fix wrong change being recorded in sweep_all (moneromooo-monero)
2019-04-24Merge pull request #5477Riccardo Spagni1-1/+1
97e1c927 wallet: fix key image computation signaling to the device (Dusan Klinec)
2019-04-24wallet2: default to trying to keep 5 outputs of 2+ moneromoneromooo-monero1-3/+13
In the case where previously a second unneeded output would be added to a transaction. This should help *some* of the cases where outputs are slowly being consolidated, leading to the whole balance being locked when sending monero.
2019-04-23consensus: from v12, enforce >= 2 outputsmoneromooo-monero1-0/+2
2019-04-23wallet2: add missing "sanity check failed" reason messagemoneromooo-monero1-0/+2
2019-04-23wallet2: fix wrong change being recorded in sweep_allmoneromooo-monero1-2/+2
leading to the sanity check triggering
2019-04-22wallet: fix key image computation signaling to the deviceDusan Klinec1-1/+1
2019-04-20wallet_rpc_server: add block_height and frozen to incoming_transfersmoneromooo-monero2-1/+7
2019-04-18Merge pull request #5389Riccardo Spagni2-60/+72
588e6700 simplewallet: fix output representation offset (moneromooo-monero) 35e0a968 wallet2: "output lineup" fake out selection (moneromooo-monero)
2019-04-18Merge pull request #5458Riccardo Spagni2-1/+4
84047cb7 wallet_rpc_server: add unlocked field to incoming_transfers output (moneromooo-monero)
2019-04-18simplewallet: fix output representation offsetmoneromooo-monero1-2/+2
2019-04-18wallet2: "output lineup" fake out selectionmoneromooo-monero2-60/+72
Based on python code by sarang: https://github.com/SarangNoether/skunkworks/blob/outputs/outputs/simulate.py
2019-04-17wallet_rpc_server: add unlocked field to incoming_transfers outputmoneromooo-monero2-1/+4
2019-04-17wallet_rpc_server: remove unused variablemoneromooo-monero1-2/+0
2019-04-16wallet_rpc_server: set suggested_confirmations_threshold for pool txesmoneromooo-monero1-5/+3
2019-04-16wallet_rpc_server: add set_log_level/set_log_categoriesmoneromooo-monero4-1/+82
2019-04-16Merge pull request #5445Riccardo Spagni4-60/+115
b18f0b10 wallet: new --offline option (moneromooo-monero)
2019-04-16Merge pull request #5446Riccardo Spagni1-5/+1
7d79222f daemon: remove debug info (moneromooo-monero) 8fec0f98 functional_tests: add sweep_single test (moneromooo-monero) 9880d61b wallet_rpc_server: remove unused code (moneromooo-monero) 8a61b33d rpc: omit irrelevant fields for pool txes in gettransactions (moneromooo-monero) 56508524 rpc: add relayed in get_transaction output (moneromooo-monero) 82e510f1 rpc: set default log category in core_rpc_server.h (moneromooo-monero)
2019-04-16Merge pull request #5434Riccardo Spagni1-0/+1
ccb996af rpc: new sanity check on relayed transactions (moneromooo-monero)
2019-04-16Merge pull request #5429Riccardo Spagni2-41/+57
bcb86ae6 wallet_rpc_server: fix inconsistent wallet caches on reload (moneromooo-monero)
2019-04-16Merge pull request #5422Riccardo Spagni1-1/+1
2c221d1b wallet2: update estimate_rct_tx_size for smaller rct proofs (moneromooo-monero)
2019-04-16Merge pull request #5418Riccardo Spagni4-9/+13
374f388d wallet_rpc_server: add a all flag to export_outputs (moneromooo-monero)
2019-04-15wallet: new --offline optionmoneromooo-monero4-60/+115
It will avoid connecting to a daemon (so useful for cold signing using a RPC wallet), and not perform DNS queries.
2019-04-15wallet_rpc_server: remove unused codemoneromooo-monero1-5/+1
2019-04-15Merge pull request #5396Riccardo Spagni2-3/+10
b40392fb wallet2: add --no-dns flag (moneromooo-monero)
2019-04-15Merge pull request #5395Riccardo Spagni1-7/+9
15f27c80 wallet2: support multi out txes without change in sanity check (moneromooo-monero)
2019-04-15Merge pull request #5392Riccardo Spagni1-4/+4
a2195b9b crypto: replace rand<T>()%N idiom with unbiased rand_idx(N) (stoffu)
2019-04-15Merge pull request #5355Riccardo Spagni6-10/+64
c68fe787 device/trezor: add button pressed request (Dusan Klinec) 827f52ad wallet: API changes to enable passphrase entry (Dusan Klinec)
2019-04-12rpc: new sanity check on relayed transactionsmoneromooo-monero1-0/+1
This will weed out some transactions with silly rings
2019-04-12wallet_rpc_server: fix inconsistent wallet caches on reloadmoneromooo-monero2-42/+58
Loading the same wallet as the currently loaded one would autosave the current state after loading it, leading to some kind of rollback effect. We now save before loading to avoid this. If loading fails, it means the current wallet will be saved (or maybe not, depending on where the failure occurs: most of the sanity checks occur before saving). There is a new autosave_current flag to open/restore calls so the (enabled by default) autosave can be skipped.
2019-04-11wallet2: update estimate_rct_tx_size for smaller rct proofsmoneromooo-monero1-1/+1
2019-04-11Merge pull request #5388Riccardo Spagni4-11/+61
0be5b2ee simplewallet: new unset_ring command (moneromooo-monero)
2019-04-11Merge pull request #5382Riccardo Spagni4-19/+55
c12b43cb wallet: add number of blocks required for the balance to fully unlock (moneromooo-monero) 3f1e9e84 wallet2: set confirmations to 0 for pool txes in proofs (moneromooo-monero) 36c037ec wallet_rpc_server: error out on getting the spend key from a hot wallet (moneromooo-monero) cd1eaff2 wallet_rpc_server: always fill out subaddr_indices in get_transfers (moneromooo-monero)
2019-04-11Merge pull request #5374Riccardo Spagni4-0/+74
a2561653 wallet: new option to start background mining (moneromooo-monero)
2019-04-11simplewallet: new net_stats commandmoneromooo-monero2-0/+13
displays total sent and received bytes
2019-04-10wallet_rpc_server: add a all flag to export_outputsmoneromooo-monero4-9/+13
if we don't want to export new outputs only
2019-04-07Enabling daemon-rpc SSL now requires non-system CA verificationLee Clagett2-17/+29
If `--daemon-ssl enabled` is set in the wallet, then a user certificate, fingerprint, or onion/i2p address must be provided.
2019-04-07device/trezor: add button pressed requestDusan Klinec4-0/+27
2019-04-07Require manual override for user chain certificates.Lee Clagett1-0/+5
An override for the wallet to daemon connection is provided, but not for other SSL contexts. The intent is to prevent users from supplying a system CA as the "user" whitelisted certificate, which is less secure since the key is controlled by a third party.
2019-04-07Pass SSL arguments via one class and use shared_ptr instead of referenceLee Clagett3-31/+55
2019-04-06Change default SSL to "enabled" if user specifies fingerprint/certificateLee Clagett2-7/+17
Currently if a user specifies a ca file or fingerprint to verify peer, the default behavior is SSL autodetect which allows for mitm downgrade attacks. It should be investigated whether a manual override should be allowed - the configuration is likely always invalid.
2019-04-06Change SSL certificate file list to OpenSSL builtin load_verify_locationLee Clagett4-40/+19
Specifying SSL certificates for peer verification does an exact match, making it a not-so-obvious alias for the fingerprints option. This changes the checks to OpenSSL which loads concatenated certificate(s) from a single file and does a certificate-authority (chain of trust) check instead. There is no drop in security - a compromised exact match fingerprint has the same worse case failure. There is increased security in allowing separate long-term CA key and short-term SSL server keys. This also removes loading of the system-default CA files if a custom CA file or certificate fingerprint is specified.
2019-04-06Merge pull request #5350Riccardo Spagni2-36/+23
050bb337 wallet2: factor the watchonly/multisig/etc fields on creation (moneromooo-monero)
2019-04-06Merge pull request #5347Riccardo Spagni2-1/+24
d45b85e1 wallet2: skip derivation precalc for blocks we know we'll skip (moneromooo-monero)
2019-04-06Merge pull request #5346Riccardo Spagni1-3/+1
c84ea299 cryptonote_basic: some more minor speedups (moneromooo-monero) e40eb2ad cryptonote_basic: speedup calculate_block_hash (moneromooo-monero) 547a9708 cryptonote: block parsing + hash calculation speedup (moneromooo-monero) 11604b6d blockchain: avoid unneeded block copy (moneromooo-monero) 8461df04 save some database calls when getting top block hash and height (moneromooo-monero) 3bbc3661 Avoid repeated (de)serialization when syncing (moneromooo-monero)
2019-04-06Merge pull request #5345Riccardo Spagni2-4/+12
678262ab wallet_rpc_server: allow english/local language names in create_wallet (moneromooo-monero)
2019-04-06Merge pull request #5343Riccardo Spagni1-4/+4
cafa15b9 wallet2: set confirmations to 0 for pool txes in proofs (moneromooo-monero)
2019-04-06Merge pull request #5340Riccardo Spagni1-1/+1
16eda54b wallet: use original user address if we have a short payment id (moneromooo-monero)
2019-04-05wallet: API changes to enable passphrase entryDusan Klinec4-10/+37
2019-04-04wallet: new option to start background miningmoneromooo-monero4-0/+74
The setup-background-mining option can be used to select background mining when a wallet loads. The user will be asked the first time the wallet is created.
2019-04-04wallet2: add --no-dns flagmoneromooo-monero2-3/+10
2019-04-04crypto: replace rand<T>()%N idiom with unbiased rand_idx(N)stoffu1-4/+4
2019-04-03wallet2: support multi out txes without change in sanity checkmoneromooo-monero1-7/+9
2019-04-02libwallet_merged: add missing net targetselsta1-0/+1
2019-04-02simplewallet: new unset_ring commandmoneromooo-monero4-11/+61
Useful when debugging, though not much for users
2019-04-02api/wallet: fix some wrong namespacestoffu1-2/+2
2019-04-01wallet: add number of blocks required for the balance to fully unlockmoneromooo-monero4-20/+56
2019-04-01wallet2: set confirmations to 0 for pool txes in proofsmoneromooo-monero1-4/+4
It makes more sense than (uint64_t)-1, which is going to look like very much confirmed when not checking in_pool
2019-04-01wallet_rpc_server: error out on getting the spend key from a hot walletmoneromooo-monero1-1/+7
2019-04-01wallet_rpc_server: always fill out subaddr_indices in get_transfersmoneromooo-monero1-0/+2
It was not filled out for in and pool types
2019-04-01Merge pull request #5319Riccardo Spagni5-9/+104
f825055d wallet_rpc_server: error out on getting the spend key from a hot wallet (moneromooo-monero) 67aa4adc wallet_rpc_server: add a set_daemon RPC (moneromooo-monero) 705acbac wallet2: init some variables to default values if loading old wallets (moneromooo-monero) f82bc29e wallet_rpc_server: always fill out subaddr_indices in get_transfers (moneromooo-monero) 01efdc6a wallet_rpc_server: set confirmations to 0 for pending/pool txes (moneromooo-monero)
2019-04-01wallet_rpc_server: error out on getting the spend key from a hot walletmoneromooo-monero1-1/+7
2019-04-01wallet_rpc_server: add a set_daemon RPCmoneromooo-monero5-7/+91
2019-04-01wallet2: init some variables to default values if loading old walletsmoneromooo-monero1-0/+3
2019-04-01wallet_rpc_server: always fill out subaddr_indices in get_transfersmoneromooo-monero1-0/+2
It was not filled out for in and pool types
2019-04-01wallet_rpc_server: set confirmations to 0 for pending/pool txesmoneromooo-monero1-1/+1
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-15 14:59:13 +0000