| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
ad4649ac Enable verifying wallet password with having to load wallet. (m2049r)
|
|
67ce4910 wallet2: store testnet bool in keys file (Jaquee)
|
|
c97d1bd3 wallet: return unlock_time in get_transfers (moneromooo-monero)
|
|
a839a6fa Wallet API: add tx unlock time (Jaquee)
|
|
|
|
e31aac80 walletAPI: add getRefreshFromBlockHeight() (Jaquee)
48c0cb1b wallet api: pause refresh while commiting tx (Jaquee)
f233c01c CMakeLists.txt - ios/xcode fix (Jaquee)
|
|
600353e2 fix wallet callback signatures (m2049r)
|
|
525975ac wallet-cli: Minor improvement to help output (Erik de Castro Lopo)
|
|
cb0b5594 Move OpenAlias console input back from libs (moneromooo-monero)
|
|
0c57df97 wallet2: fix temporarily missing incoming tx when being mined (moneromooo-monero)
|
|
dc0b312f wallet_rpc_server: optionally return tx blobs on transfer calls (moneromooo-monero)
5eb79983 epee: add a KV_SERIALIZE variant for optional parameters (moneromooo-monero)
|
|
|
|
|
|
|
|
When scanning the txpool without having first updated the
blockchain, the tx would be seen as neither in the txpool
nor the chain, and removed, so it'd only reappear once the
chain is refreshed, and the tx seen in a block.
|
|
|
|
|
|
also show it in simplewallet's show_transfer
|
|
|
|
|
|
Library code should definitely not ask for console input unless
it's clearly an input function. Delegating the user interaction
part to the caller means it can now be used by a GUI, or have a
decision algorithm better adapted to a particular caller.
|
|
also add do_not_relay flag to them, so it now becomes possible
to create a tx without sending it yet
|
|
|
|
f98bf48b Minor cleanup: tab vs. space + logs messages (binaryFate)
|
|
3b599d2b wallet2: get current height from the daemon on creation (moneromooo-monero)
d3bb72ff wallet2: fix infinite loop on future refresh height (moneromooo-monero)
32754784 wallet: fix refresh_from_height setting on new wallet (moneromooo-monero)
|
|
5a09d79c Fix #2120: return per-tx amount in transfer_split RPC call. (binaryFate)
|
|
|
|
|
|
Use current time to estimate current height only if the daemon
cannot be queried.
|
|
If the refresh height is in the future, the current code will
loop till the actual height reaches this. Fix it by bailing out
if we receive only three hashes, which is what we set in the
call parameters.
|
|
The previous patch was based on a wrong premise (that the
daemon height was 0 because the daemon calling code wasn't
yet initialized). In fact, current height approximation
was not setup for testnet. Fix this.
|
|
|
|
4e13ab30 wallet_api: fix missing transaction parameter in callback (moneromooo-monero)
|
|
It was unused, so harmless
Reported by erikd on IRC
|
|
|
|
6bcd3b2d fix get_upper_transaction rename (schnerchi)
|
|
|
|
740bc24c Wallet API: Set seed lang when recovering form keys (Jaquee)
|
|
4b932ff3 changed crypto to cncrypto so it generated libcncrypto (Gentian)
|
|
89b2f306 tests: fix invalid key image test (moneromooo-monero)
a374a522 wallet2: check key image validity domain in import_key_images (moneromooo-monero)
|
|
e2529347 Correct spelling of 'get_upper_transaction_size_limit' (Nano Akron)
3029d0ef Remove the 1.25x multiplier in max transaction size in just the wallet (Nano Akron)
|
|
6cb1ad1f wallet fix: ensure iterator to be valid (stoffu)
|
|
|
|
|
|
fix a cmakelist
|
|
|
|
|
|
|
|
|
|
The bump to minimum mixin 4 was moved from v5 to v6
|
|
bbf4c210 Wallet API: add spend/view key getters (Jaquee)
|
|
|
|
It sweeps all outputs below the given threshold
This is available via the existing sweep_all RPC, by setting
amount_threshold the desired amount (in atomic units)
|
|
a6d5bb75 wallet2: refer to triangular distribution for recent zone in comment (moneromooo-monero)
ac1aba90 wallet2: bias fake outs more towards recent outputs (moneromooo-monero)
|
|
7f4beaa4 wallet2: fix removal of wrong txes from unconfirmed_payments (moneromooo-monero)
|
|
a7d78dda wallet2: fix --generate-from-json in RPC mode (moneromooo-monero)
|
|
89d70756 wallet2: fix spurious output splitting when not merging destinations (moneromooo-monero)
|
|
10e137be wallet2: mention escaping/quoting --password in help string (moneromooo-monero)
|
|
It was wrongly refering to equiprobable distribution, which I think
I'd originally done, but forgot to update the comment after changing
to triangular
Reported by smooth on IRC
|
|
Two recent papers quantified the real usage bias for the
real output in a ring being the true one, and shows that
the current biasing is much too weak.
While we wait for a better solution, we increase the ratio
of recent-to-total fake outputs, as well as decrease the
time window for recent outputs, so that half the fake outs
are selected within the last 1.8 day. Value plucked from
figure 10, page 11 of An Empirical Analysis of Linkability
in the Monero Blockchain, 2017, Miller et al.
This is also arbitrary, of course, but serves as a stopgap
till a better selection algorithm is chosen.
|
|
unconfirmed_payments changed from having the txid as key to
the payment id, and this was not changed to match.
|
|
The daemon address was initialized too late
|
|
Reviewed and squashed. Open/Create is only allowed if no walletfile
was specified at startup.
|
|
0a7885bf Wallet API: fix Cold signing split tx (Jaquee)
|
|
f5bd3465 IOS CMAKE build settings (Jaquee)
d8a88d05 add IOS CMAKE toolchain (Jaquee)
|
|
|
|
|
|
|
|
|
|
If using a large input and many destinations, the code would
generate as many outputs as it could using that input, even if
it would bring the resulting tx above the max tx size.
|
|
With the change from the original transfer method to the new
algorithm, payments to the same destination were merged. It
seemed like a good idea, optimizing space. However, it is a
useful tool for people who want to split large outputs into
several smaller ones (ie, service providers making frequent
payments, and who do not like a large chunk of their balance
being locked for 10 blocks after each payment).
Default to off, which is a change from the previous behavior.
|
|
When a single input is enough to satisfy a transfer, the code would
previously try to add a second input, to match the "canonical" makeup
of a transaction with two inputs and two outputs. This would cause
wallets to slowly merge outputs till all the monero ends up in a
single output, which causes trouble when making two transactions
one after the other, since change is locked for 10 blocks, and an
increasing portion of the remaining balance would end up locked on
each transaction.
There are two new settings (min-output-count and min-output-value)
which can control when to stop adding such unneeded second outputs.
The idea is that small "dust" outputs will still get added, but
larger ones will not.
Enable with, eg:
set min-output-count 10
set min-output-value 30
to avoid using an unneeded second output of 30 monero or more, if
there would be less than 10 such outputs left.
This does not invalidate any other reason why such outputs would
be used (ie, when they're really needed to satisfy a transfer, or
when randomly picked in the normal course of selection). This may
be improved in the future.
|
|
a8646b09 Wallet API: add hard fork info functions (Jaquee)
|
|
8bbcbcfb wallet rpc: enable solo mining (stoffu)
|
|
|
|
Includes a new RPC to get tx pool hashes fast.
|
|
995969b1 wallet: fix set_log not handling 0,xxx style settings (moneromooo-monero)
|
|
350e99ae wallet2: cache which pool txes were scanned already (moneromooo-monero)
|
|
c1e9ccc7 wallet2: speed up transactions using remote nodes (moneromooo-monero)
|
|
|
|
This massively speeds up the wallet updating the pool on mainnet,
where the tx backlog is more than 500 txes.
|
|
Waiting would mean the fee used is 1x base, but the base will
have suddenly dropped
|
|
Asking for a full histogram from a remote node (since it's
untrusted) is pretty slow, and spams the remote node, so
we replace it by only adding a second input if we have rct
ones, which are for all intents and purposes always mixable.
|
|
|
|
df810a82 wallet-rpc bugfix: get_transfer_by_txid previously checking against payment id (kenshi84)
|
|
|
|
|
|
e9175cec wallet_rpc_server: make a few RPCs unavailable in restricted mode (moneromooo-monero)
|
|
d0238313 use const references in catch blocks (moneromooo-monero)
|
|
3fa59755 wallet2: call is_key_image_spent in blocks in rescan_spent (moneromooo-monero)
9d134e86 wallet_rpc_server: add a rescan_spent RPC (moneromooo-monero)
|
|
Address book modification, setting tx nodes, importing key images
|
|
|
|
This is a potentially long lasting daemon RPC call
|
|
|
|
|
|
3396a9f2 Add intervening v5 fork for increased min block size (moneromooo-monero)
|
|
Minimum mixin 4 and enforced ringct is moved from v5 to v6.
v5 is now used for an increased minimum block size (from 60000
to 300000) to cater for larger typical/minimum transaction size.
The fee algorithm is also changed to decrease the base per kB
fee, and add a cheap tier for those transactions which we do
not care if they get delayed (or even included in a block).
|
|
|
|
4b48565c wallet: add password command (moneromooo-monero)
|
|
223fe5bb wallet: fix get_tranfers with multiple incoming txes with same pid (moneromooo-monero)
|
|
Also tweak wallet2 password code to verify password without
saying it's a new wallet, because it's assuming things.
|
|
|
|
This reverts commit d47dac9a88ddd46b88850a899311363b3261c89e.
Callers actually expect the key to be payment id, so this
needs a lot more changes (like storing payment ids in the
structure, and possibly also to other existing structures
which do the same thing).
|
|
|
|
|
|
db1c7d80 wallet api: add missing mining options (Jaquee)
|
|
2c468dd4 allow user I/O in millinero, micronero, nanonero, piconero (moneromooo-monero)
|
|
d47dac9a wallet: fix insertion of pool transactions (moneromooo-monero)
|
|
7a44f38a Add support for the wallet to refresh pruned blocks (moneromooo-monero)
da18898f ringct: do not require range proof in decodeRct/decodeRctSimple (moneromooo-monero)
b49c6ab4 rpc: add a default category for daemon rpc (moneromooo-monero)
f113b92b core: add functions to serialize base tx info (moneromooo-monero)
6fd4b827 node_rpc_proxy: allow caching daemon RPC version (moneromooo-monero)
b5c74e40 wallet: invalidate node proxy cache when reconnecting (moneromooo-monero)
|
|
b8a08f19 wallet: fix --log-file not working (moneromooo-monero)
|
|
53105743 Wallet API: Add support for daemon rpc login (Jaquee)
|
|
|
|
|
|
They were inserted using payment id as key, not txid
|
|
|
|
|
|
|
|
|
|
|
|
|
|
ada6a8a2 wallet_rpc_server: new --trusted-daemon flag (moneromooo-monero)
|
|
and remove trusted_daemon fields from transfer RPCs,
it is much friendlier on users
|
|
|
|
|
|
|
|
|
|
26bd7aac wallet_api: fix logging init via api (moneromooo-monero)
|
|
5a3b1e98 wallet2: fix failure to send (relatedness check in wrong case) (moneromooo-monero)
|
|
A relatedness check was meant to be done in the case of adding
an extra output if just one was enough. This was mistakenly
added to the "preferred output" case.
|
|
|
|
|
|
|
|
ce7fcbb4 Add server auth to monerod, and client auth to wallet-cli and wallet-rpc (Lee Clagett)
|
|
bceaf4b7 wallet2: fix transactions not considering rct inputs (moneromooo-monero)
|
|
7549116e Wallet API: Easylogger wrapper for gui (Jaquee)
|
|
|
|
4efc926d Wallet API: Catch error from tools::is_local_address (Jaquee)
|
|
I broke this very recently in 2bf029be172a47ace8134143e1320fdb10d3ea44
and didn't notice in time
|
|
|
|
|
|
|
|
|
|
|
|
Makes it possible for GUI to reinit with new daemon without closing and reopening wallet.
|
|
4f5b130d wallet_rpc_server: add address book RPC calls (moneromooo-monero)
|
|
f97526e6 simplewallet: option to always ask password for any crytical operations (kenshi84)
|
|
|
|
|
|
fba9332d Changed console output for transaction from L0 to L1 (NanoAkron)
|
|
2bf029be wallet2: fix corner case failing to send a second output (moneromooo-monero)
|
|
9bd9906e Factor is_address_local code into a tools function (moneromooo-monero)
|
|
69d2ad39 wallet_rpc_server: fix logs going to the wrong file (moneromooo-monero)
|
|
99f58437 Fix invalid + of std::string and int (Timothy D. Prime)
|
|
c02e1cb9 Updates to epee HTTP client code - http_simple_client now uses std::chrono for timeouts - http_simple_client accepts timeouts per connect / invoke call - shortened names of epee http invoke functions - invoke command functions only take relative path, connection is not automatically performed (Lee Clagett)
|
|
0644eed7 Remove boost/foreach.cpp includes (Miguel Herranz)
36dd3e23 Replace BOOST_REVERSE_FOREACH with ranged for (Miguel Herranz)
629e3101 Replace BOOST_FOREACH with C++11 ranged for (Miguel Herranz)
|
|
774a213 Wallet API: Create wallet from keys (Jaqueeee)
|
|
|
|
|
|
|
|
If a rct transaction can be made with just one input, a second
output will be added. This output will be the smallest amount
output available. However, if this output is a non rct output
with less available fake outs than requested, the transaction
will be rejected. We now check the histogram to only consider
outputs with enough available fake outs in the first place.
|
|
|
|
|
|
|
|
These warnings were emitted by clang++, and they are real bugs.
src/rpc/core_rpc_server.cpp:208:58: warning: adding 'uint64_t'
(aka 'unsigned long') to a string does not append to the string
[-Wstring-plus-int]
res.status = "Error retrieving block at height " + height;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
The obvious intent is achieved by using std::to_string().
|
|
- http_simple_client now uses std::chrono for timeouts
- http_simple_client accepts timeouts per connect / invoke call
- shortened names of epee http invoke functions
- invoke command functions only take relative path, connection
is not automatically performed
|
|
feed6175 fixed typo: monero-wallet-cli,log (kenshi84)
|
|
|
|
|
|
|
|
20f71527 wallet2: fix sending a rct tx with a single output available (moneromooo-monero)
|
|
This would have tried to send a second output to make the tx
look like the 2/2 ideal, but it would not fail to find one
because picking an output from preferred_inputs priority list
did not remove it from the unused tranfer/dust outputs, so
it would try to send the same output twice.
While there, I also added a check to avoid sending a second
input if it's related to the first. Better 1/2 than linking
inputs, I think.
|
|
17246d05 wallet: print exception message on get_random_outs_error (moneromooo-monero)
|
|
|
|
|
|
Mostly getinfo and get_hard_fork_info, which are called
pretty often. This speeds up transfers as a bonus.
|
|
This avoids indirectly leaking the real output to the daemon,
and is faster.
This will still happen for more complex cases, especially
when cancelling a tx and "re-rolling" it.
|
|
16b8b66a specify restore height by YYYY-MM-DD format (kenshi84)
|
|
|
|
This replaces the epee and data_loggers logging systems with
a single one, and also adds filename:line and explicit severity
levels. Categories may be defined, and logging severity set
by category (or set of categories). epee style 0-4 log level
maps to a sensible severity configuration. Log files now also
rotate when reaching 100 MB.
To select which logs to output, use the MONERO_LOGS environment
variable, with a comma separated list of categories (globs are
supported), with their requested severity level after a colon.
If a log matches more than one such setting, the last one in
the configuration string applies. A few examples:
This one is (mostly) silent, only outputting fatal errors:
MONERO_LOGS=*:FATAL
This one is very verbose:
MONERO_LOGS=*:TRACE
This one is totally silent (logwise):
MONERO_LOGS=""
This one outputs all errors and warnings, except for the
"verify" category, which prints just fatal errors (the verify
category is used for logs about incoming transactions and
blocks, and it is expected that some/many will fail to verify,
hence we don't want the spam):
MONERO_LOGS=*:WARNING,verify:FATAL
Log levels are, in decreasing order of priority:
FATAL, ERROR, WARNING, INFO, DEBUG, TRACE
Subcategories may be added using prefixes and globs. This
example will output net.p2p logs at the TRACE level, but all
other net* logs only at INFO:
MONERO_LOGS=*:ERROR,net*:INFO,net.p2p:TRACE
Logs which are intended for the user (which Monero was using
a lot through epee, but really isn't a nice way to go things)
should use the "global" category. There are a few helper macros
for using this category, eg: MGINFO("this shows up by default")
or MGINFO_RED("this is red"), to try to keep a similar look
and feel for now.
Existing epee log macros still exist, and map to the new log
levels, but since they're used as a "user facing" UI element
as much as a logging system, they often don't map well to log
severities (ie, a log level 0 log may be an error, or may be
something we want the user to see, such as an important info).
In those cases, I tried to use the new macros. In other cases,
I left the existing macros in. When modifying logs, it is
probably best to switch to the new macros with explicit levels.
The --log-level options and set_log commands now also accept
category settings, in addition to the epee style log levels.
|
|
d561f4ad enable clang checks that were disabled (Chris Vickio)
0aefb2f6 remove std::move from return statements (pessimizing-move warning) (Chris Vickio)
629d5b76 change counter from bool to int (deprecated-increment-bool warning) (Chris Vickio)
fb76d439 add extra braces around subobjects (missing-braces warning) (Chris Vickio)
3b6d5f25 make struct/class declarations consistent (mismatched-tags warning) (Chris Vickio)
fcf66925 remove unused fields from network_throttle (unused-private-field warning) (Chris Vickio)
296f8c16 inline unused function (for unused-function warning) (Chris Vickio)
|
|
d276a165 wallet2: use at least two rct inputs if possible (moneromooo-monero)
|
|
dea53962 fix timeout in check_connection (Jaquee)
|
|
c9f13c5e wallet2: fix tx reroll not updating fee is going up a kB step (moneromooo-monero)
|
|
1d317981 Wallet API: add key image import/export functions (Jaquee)
|
|
46550c0b Wallet API: add rescanSpent() (Jaquee)
|
|
|
|
|
|
If we'd make a rct tx with just one input, we try to add
a second one to match the 2/2 ideal. This means more txes
use that template (and are thus using a larger anonymity
set), and it coalesces outputs "for free". We use the
smallest amount outputs in priority for this, so we can
"clean" the wallet at the same time.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
a081b39c Move key image export/import functions to wallet2 (Jaquee)
|
|
db56a03f Wallet2 + API: Callbacks for unconfirmed transfers (Jaquee)
|
|
0d3918e1 Wallet api: Update trustedDaemon when daemon is changed (Jaquee)
dbb838f4 GUI cold signing (Jaquee)
afb85a02 Wallet API: functions for supporting/creating view only wallets (Jaquee)
|
|
79b4e1f9 Cold signing: make sure short payment id isnt encrypted twice (Jaquee)
|
|
5eed5b05 Wallet API: functions for supporting/creating view only wallets (Jaquee)
|
|
d81cb087 Added (not yet enabled) HTTP client authentication (Lee Clagett)
|
