| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
|
|
f9a9d2ee2 wallet2: wait for propagation timeout before marking tx as failed (xiphon)
|
|
|
|
|
|
|
|
- index out of bounds when importing outputs
- accessing invalid CLSAG data
|
|
de9a9fb update error message 'No unlocked balance in the specified account' (woodser)
|
|
|
|
ef4325f wallet2: fix tx sanity check triggering on pre-rct outputs (monermooo-monero)
|
|
|
|
|
|
4e44306 enable CLSAG support for Trezor client (ph4r05)
|
|
|
|
6a37da8 threadpool: guard against exceptions in jobs, and armour plating (moneromooo-monero)
|
|
|
|
Those would, if uncaught, exit run and leave the waiter to wait
indefinitely for the number of active jobs to reach 0
|
|
|
|
|
|
They are allowed from v12, and MLSAGs are rejected from v13.
|
|
07442a605 Fix build with Boost 1.74 (moneromooo-monero)
|
|
20f603c6b Fix broken multisig pubkey sorting (Jason Rhinelander)
|
|
85899230d simplewallet: allow setting tx keys when sending to a subaddress (moneromooo-monero)
e916201f1 wallet2: fix setting tx keys when another is already set (moneromooo-monero)
|
|
db5d6e460 wallet2: fix wrong name when checking RPC cost (moneromooo-monero)
|
|
7175dcb10 replace most boost serialization with existing monero serialization (moneromooo-monero)
|
|
This reverts commit 921dd8dde5d381052d0aa2936304a3541a230c55.
|
|
This reduces the attack surface for data that can come from
malicious sources (exported output and key images, multisig
transactions...) since the monero serialization is already
exposed to the outside, and the boost lib we were using had
a few known crashers.
For interoperability, a new load-deprecated-formats wallet
setting is added (off by default). This allows loading boost
format data if there is no alternative. It will likely go
at some point, along with the ability to load those.
Notably, the peer lists file still uses the boost serialization
code, as the data it stores is define in epee, while the new
serialization code is in monero, and migrating it was fairly
hairy. Since this file is local and not obtained from anyone
else, the marginal risk is minimal, but it could be migrated
later if needed.
Some tests and tools also do, this will stay as is for now.
|
|
76c16822d wallet2_api: implement runtime proxy configuration (xiphon)
|
|
3d6bc0a68 wallet2: throw a error on wallet initialization failure (xiphon)
|
|
ef694d028 fix warning by removing std::move() on temporary http_client object (woodser)
|
|
eda167585 wallet_rpc_server: use unlock_time in suggested confirmations calc (moneromooo-monero)
|
|
921dd8dde Use domain-separated ChaCha20 for in-memory key encryption (Sarang Noether)
|
|
Thanks iDunk for testing
|
|
The tx key derivation is different then
|
|
|
|
include all public proof parameters in Schnorr challenges, along with hash function domain separators. Includes new randomized unit tests.
|
|
insert doesn't actually insert if another element with the
same key is already in the map
|
|
The sort predicate is a boolean ordered-before value, but these are
returning the memcmp value directly, and thus returns true whenever the
pubkeys aren't equal. This means:
- it isn't actually sorting.
- it can (and does) segfault for some inputs.
|
|
|
|
|
|
|
|
8656a8c9f remove double includes (sumogr)
|
|
5ef0607da Update copyright year to 2020 (SomaticFanatic)
|
|
94befec fix typo in pick_preferred_rct_inputs (Parean)
|
|
c17fe81 wallet2: fix multisig data clearing stomping on a vector (moneromooo-monero)
|
|
82d21f5 easylogging++: sanitize log payload (moneromooo-monero)
7d0b7e8 [master] MMS: New 'config_checksum' subcommand (rbrunner7)
|
|
86cf811 simplewallet: don't complain about incoming payment ids on change (moneromooo-monero)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
42e1484 wallet2: fix keys file deserialization exception handling (xiphon)
|
|
Update copyright year to 2020
|
|
7a8c1ee wallet2: fix subaddress expansion when receiving monero (moneromooo-monero)
|
|
e7d0105 message_store: don't print an error when there is no mms file (moneromooo-monero)
|
|
4f489fa wallet2: check_connection return false on get_version status != OK (xiphon)
|
|
8b655de simplewallet: report timestamp based expected unlock time on balance (moneromooo-monero)
|
|
613071f use memwipe on secret k/alpha values (moneromooo-monero)
|
|
|
|
e509ede trezor: adapt to new passphrase mechanism (ph4r05)
|
|
|
|
- choice where to enter passphrase is now made on the host
- use wipeable string in the comm stack
- wipe passphrase memory
- protocol optimizations, prepare for new firmware version
- minor fixes and improvements
- tests fixes, HF12 support
|
|
It confuses people
|
|
|
|
|
|
09abca7 wallet_api: checkUpdate - optional version and buildtag params (xiphon)
|
|
- Add abstract_http_client.h which http_client.h extends.
- Replace simple_http_client with abstract_http_client in wallet2,
message_store, message_transporter, and node_rpc_proxy.
- Import and export wallet data in wallet2.
- Use #if defined __EMSCRIPTEN__ directives to skip incompatible code.
|
|
Reported by UkoeHB_ and sarang
|
|
69b5992 simplewallet: new 'address one-off <major> <minor>' command (moneromooo-monero)
|
|
|
|
81c5943 Remove temporary std::string creation in some hex->bin calls (vtnerd)
5fcc23a Move hex->bin conversion to monero copyright files and with less includes (vtnerd)
3387f0e Reduce template bloat in hex->bin for ZMQ json (vtnerd)
|
|
80d5320 Hash domain separation (SarangNoether)
|
|
cc18926 wallet2_api: wallet recovery - seed offset passphrase support (xiphon)
|
|
1a6e7bd wallet2: mention --daemon-ssl-allow-any-cert in --proxy error msg (xiphon)
|
|
|
|
|
|
|
|
2e9d1e6 wallet2: fix store-tx-info loading (moneromooo-monero)
|
|
dab604e wallet2_api: implement estimateTransactionFee (xiphon)
|
|
9c1f970b wallet2: remember daemon address overrides when loading a new wallet (moneromooo-monero)
|
|
50e59cfa wallet2: reject zero keys in json input (moneromooo-monero)
|
|
ffe7165e wallet: reroll fake outs selection on local tx_sanity_check failure (xiphon)
|
|
0349347e ringdb: use a different iv for key and data in rings table (moneromooo-monero)
7b882087 simplewallet: reword mixin in user message in terms of ring size (moneromooo-monero)
f507a43a wallet2: do not remove known rings when a tx fails (moneromooo-monero)
|
|
a6c24412 wallet: fix exceptions getting the hash of a pruned tx (moneromooo-monero)
|
|
|
|
|
|
f717d593 wallet2: guard against race with multiple decrypt_keys users (moneromooo-monero)
|
|
ae84ec90 wallet-cli/rpc: allow sweep_all to use outputs in all subaddresses within an account (stoffu)
|
|
5cbb17b9 wallet2: fix hang in wallet refresh (moneromooo-monero)
|
|
ef95a76d remove unused variable 'ptx' from on_describe_transfer() (woodser)
|
|
316ab7b wallet2: better error when restoring a wallet with the wrong keys (moneromooo-monero)
|
|
096a9db Wallet: Distingush amounts for a single subaddress (tmoravec)
|
|
|
|
|
|
4b384003 wallet2: don't try to lock an empty filename (moneromooo-monero)
|
|
b328de6b wallet_rpc_server: add tx weight in transfer commands responses (moneromooo-monero)
|
|
d64e5aa7 wallet: allow message sign/verify for subaddresses (moneromooo-monero)
|
|
b90c4bc3 rpc: error out from get_info if the proxied call errors out (moneromooo-monero)
fa16df99 make_test_signature: exit nicely on top level exception (moneromooo-monero)
054b2621 node_rpc_proxy: init some new rpc payment fields in invalidate (moneromooo-monero)
d0faae2a rpc: init a few missing client_info members (moneromooo-monero)
d56a483a rpc: do not propagate exceptions out of a dtor (moneromooo-monero)
3c849188 rpc: always set the update field in update on sucess (moneromooo-monero)
|
|
|
|
|
|
3b419333 wallet: don't issue node rpc proxy requests in '--offline' mode (xiphon)
|
|
The backward compatibility code was always setting it to 1
in modern wallets since store_tx_keys was not present and thus
assumed to be 1 by default.
Reported by SeventhAlpaca
|
|
0e0351c4 wallet_rpc_server: add count parameter to create_address (Matt Smith)
|
|
Because the user might do this for reasons unknown.
Values beyond l-1 will be reduced, so are accepted.
Reported by who-biz.
|
|
|
|
7c1d31b0 build: fix IOS, build blockchain_db and rpc, skip wallet_rpc_server (xiphon)
|
|
0de8a0d3 wallet_rpc_server: new estimate_tx_size_and_weight RPC (moneromooo-monero)
|
|
Adding a new `amounts` field ot the output of `get_transfers` RPC
method. This field specifies individual payments made to a single
subaddress in a single transaction, e.g., made by this command:
transfer <addr1> <amount1> <addr1> <amount2>
|
|
This is technically a record encrypted in two pieces,
so the iv needs to be different.
Some backward compatibility is added to read data written
by existing code, but new data is written with the new code.
|
|
Even if it fails, the ring composition is known to a potential
adversary, and so we should reuse the same ring next time
|
|
|
|
|
|
If more than one thread wants to make sure of the spend secret key,
then we decrypt on the first caller and reencrypt on the last caller,
otherwise we could use an invalid secret key.
|
|
account
|
|
If the hashes received would move the current blockchain past the
stop point, the short history would not be updated, since we do
not expect another loop, but the daemon might return earlier hashes,
causing the end index to not be enough to reach the threshold and
this require another loop, which will download the same hashes and
cause an infinite loop.
|
|
3b8dcc2 wallet2: make keys unlocker reentrant (moneromooo-monero)
|
|
|
|
|
|
The cache time would take care of these, but it's cleaner that way
Coverity 205412
|
|
|
|
|
|
09f59ec wallet: set non-empty error string on connection failure (xiphon)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Refreshing sets cached height, which is otherwise got by calling
get_info. Since get_info is called upon needing to display a prompt
after a command has finished, it can be used to determine how much
time a given command took to run if the cache timeout lapses while
the command runs. Refreshing caches the height as a side effect, so
get_info will never be called as a result of displaying a prompt
after refreshing (and potentially leaking how much time it took to
process a set of transactions, therefore leaking whether we got
some monero in them).
|
|
Target height would be appropriate for the daemon, which syncs
off other daemons, but the wallet syncs off the daemon it's
connected to, and its target is the daemon's current height.
|
|
We get new pool txes before processing any tx, pool or not.
This ensures that if we're asked for a password, this does not
cause a measurable delay in the txpool query after the last
block query.
|
|
The "everything refreshed" state was detected when a refresh call did
not return any new blocks. This can be detected without that extra
"empty" call by comparing the claimed node height to the height of
the last block retrieved. Doing this avoids that last call, saves
some bandwidth, and makes the common refresh case use only one call
rather than two.
As a side effect, it prevents an information leak reported by
Tramèr et al: if the wallet retrieves a set of blocks which includes
an output sent to the refreshing wallet, the wallet will prompt the
user for the password to decode the amount and calculate the key
image for the new output, and this will delay subsequent calls to
getblocks.bin, allowing a passive adversary to note the delay and
deduce when the wallet receives at least one output.
This can still happen if the wallet downloads more than 1000 blocks,
since this will be split in several calls, but then the most the
adversary can tell is which 1000 block section the user received
some monero (the adversary can estimate the heights of the blocks
by calculating how many "large" transfers are done, which will be
sections of blocks, the last of which will usually be below 1000,
but the size of the data should allow the actual number of blocks
sent to be determined fairly accurately).
This timing trick still be used via the subsequent scan for incoming
txes in the txpool, which will be fixed later.
|
|
This lets a passive attacker with access to the network link
between node and wallet perform traffic analysis to deduce
when an idle wallet receives a transaction.
Reported by Tramèr et al.
|
|
protects against having your keys mangled
|
|
|
|
d60c1b6 changed 'batttery' to 'battery' (jakehemmerle)
|
|
93e7426 wallet2: error out when we need a daemon password but have no prompt function (moneromooo-monero)
|
|
635401b wallet2: fix the logged number of detached transfers (moneromooo-monero)
|
|
Lists nodes exposing their RPC port for public use
|
|
Daemons intended for public use can be set up to require payment
in the form of hashes in exchange for RPC service. This enables
public daemons to receive payment for their work over a large
number of calls. This system behaves similarly to a pool, so
payment takes the form of valid blocks every so often, yielding
a large one off payment, rather than constant micropayments.
This system can also be used by third parties as a "paywall"
layer, where users of a service can pay for use by mining Monero
to the service provider's address. An example of this for web
site access is Primo, a Monero mining based website "paywall":
https://github.com/selene-kovri/primo
This has some advantages:
- incentive to run a node providing RPC services, thereby promoting the availability of third party nodes for those who can't run their own
- incentive to run your own node instead of using a third party's, thereby promoting decentralization
- decentralized: payment is done between a client and server, with no third party needed
- private: since the system is "pay as you go", you don't need to identify yourself to claim a long lived balance
- no payment occurs on the blockchain, so there is no extra transactional load
- one may mine with a beefy server, and use those credits from a phone, by reusing the client ID (at the cost of some privacy)
- no barrier to entry: anyone may run a RPC node, and your expected revenue depends on how much work you do
- Sybil resistant: if you run 1000 idle RPC nodes, you don't magically get more revenue
- no large credit balance maintained on servers, so they have no incentive to exit scam
- you can use any/many node(s), since there's little cost in switching servers
- market based prices: competition between servers to lower costs
- incentive for a distributed third party node system: if some public nodes are overused/slow, traffic can move to others
- increases network security
- helps counteract mining pools' share of the network hash rate
- zero incentive for a payer to "double spend" since a reorg does not give any money back to the miner
And some disadvantages:
- low power clients will have difficulty mining (but one can optionally mine in advance and/or with a faster machine)
- payment is "random", so a server might go a long time without a block before getting one
- a public node's overall expected payment may be small
Public nodes are expected to compete to find a suitable level for
cost of service.
The daemon can be set up this way to require payment for RPC services:
monerod --rpc-payment-address 4xxxxxx \
--rpc-payment-credits 250 --rpc-payment-difficulty 1000
These values are an example only.
The --rpc-payment-difficulty switch selects how hard each "share" should
be, similar to a mining pool. The higher the difficulty, the fewer
shares a client will find.
The --rpc-payment-credits switch selects how many credits are awarded
for each share a client finds.
Considering both options, clients will be awarded credits/difficulty
credits for every hash they calculate. For example, in the command line
above, 0.25 credits per hash. A client mining at 100 H/s will therefore
get an average of 25 credits per second.
For reference, in the current implementation, a credit is enough to
sync 20 blocks, so a 100 H/s client that's just starting to use Monero
and uses this daemon will be able to sync 500 blocks per second.
The wallet can be set to automatically mine if connected to a daemon
which requires payment for RPC usage. It will try to keep a balance
of 50000 credits, stopping mining when it's at this level, and starting
again as credits are spent. With the example above, a new client will
mine this much credits in about half an hour, and this target is enough
to sync 500000 blocks (currently about a third of the monero blockchain).
There are three new settings in the wallet:
- credits-target: this is the amount of credits a wallet will try to
reach before stopping mining. The default of 0 means 50000 credits.
- auto-mine-for-rpc-payment-threshold: this controls the minimum
credit rate which the wallet considers worth mining for. If the
daemon credits less than this ratio, the wallet will consider mining
to be not worth it. In the example above, the rate is 0.25
- persistent-rpc-client-id: if set, this allows the wallet to reuse
a client id across runs. This means a public node can tell a wallet
that's connecting is the same as one that connected previously, but
allows a wallet to keep their credit balance from one run to the
other. Since the wallet only mines to keep a small credit balance,
this is not normally worth doing. However, someone may want to mine
on a fast server, and use that credit balance on a low power device
such as a phone. If left unset, a new client ID is generated at
each wallet start, for privacy reasons.
To mine and use a credit balance on two different devices, you can
use the --rpc-client-secret-key switch. A wallet's client secret key
can be found using the new rpc_payments command in the wallet.
Note: anyone knowing your RPC client secret key is able to use your
credit balance.
The wallet has a few new commands too:
- start_mining_for_rpc: start mining to acquire more credits,
regardless of the auto mining settings
- stop_mining_for_rpc: stop mining to acquire more credits
- rpc_payments: display information about current credits with
the currently selected daemon
The node has an extra command:
- rpc_payments: display information about clients and their
balances
The node will forget about any balance for clients which have
been inactive for 6 months. Balances carry over on node restart.
|
|
|
|
|
|
|
|
4d22317 wallet2: don't delete file that may not exist (selsta)
|
|
93d5cf2 wallet2: add ignore-outputs-{above/below} option (stoffu)
|
|
6b4bc0d RPC on_transfer_split error consistent with on_transfer if no tx sent (binaryFate)
|
|
These are dummy ones
|
|
|
|
|
|
8330e77 monerod can now sync from pruned blocks (moneromooo-monero)
|
|
|
|
https://github.com/aeonix/aeon/pull/131
|
|
9baf2a7 build: link wallet_merged against blockchain_db and hardforks obj (xiphon)
|
|
c89f7ef wallet2_api: fix load unsigned tx from file error propagation (xiphon)
|
|
Coverity fixes [3a81639, 1bd962d, 2825f07, d099658, d46f701, cd57a10] (anonimal)
|
|
|
|
|
|
If the peer (whether pruned or not itself) supports sending pruned blocks
to syncing nodes, the pruned version will be sent along with the hash
of the pruned data and the block weight. The original tx hashes can be
reconstructed from the pruned txes and theur prunable data hash. Those
hashes and the block weights are hashes and checked against the set of
precompiled hashes, ensuring the data we received is the original data.
It is currently not possible to use this system when not using the set
of precompiled hashes, since block weights can not otherwise be checked
for validity.
This is off by default for now, and is enabled by --sync-pruned-blocks
|
|
2cd4fd8 Changed the use of boost:value_initialized for C++ list initializer (JesusRami)
4ad191f Removed unused boost/value_init header (whyamiroot)
928f4be Make null hash constants constexpr (whyamiroot)
|
|
|
|
f0356f7 wallet2: enable ignoring fractional outputs also when sweeping (stoffu)
|
|
7d3bba5 wallet2_api: add missing parameter (selsta)
|
|
3407743 wallet_rpc_server: add locked field to get_transfers/get_{bulk_,}_payments (moneromooo-monero)
|
|
83ca764 wallet_rpc_server: call deinit on exit (moneromooo-monero)
|
|
21f6c80 rpc: move a leftover light wallet RPC out of daemon RPC (moneromooo-monero)
|
|
|
|
|
|
2ec455d wallet: fix mismatch between two concepts of 'balance' (moneromooo-monero)
|
|
c4da1a2 wallet2: fix unset_ring tx retrieval checks (moneromooo-monero)
|
|
894cc81 wallet2: fix cold signing losing tx keys (moneromooo-monero)
|
|
9f68669 blockchain_blackball: add --historical-stat which prints historical stats of spent ratio (stoffu)
2425f27blockchain_blackball: use is_output_spent instead of ringdb.blackballed for spentness test (stoffu)
50813c1 ringdb: fix bug in blackballing (stoffu)
|
|
|
|
|
|
One considers the blockchain, while the other considers the
blockchain and some recent actions, such as a recently created
transaction which spend some outputs, but isn't yet mined.
Typically, the "balance" command wants the latter, to reflect
the recent action, but things like proving ownership wants
the former.
This fixes a crash in get_reserve_proof, where a preliminary
check and the main code used two concepts of "balance".
|
|
Much easier to work with than the raw unlock_time field
|
|
839fc62 reject setting lookahead major or minor to 0 (moneromoo-monero)
|
|
|
|
|
|
|
|
|
|
|
|
1dc3b1a wallet: add --extra-entropy command line flag (moneromooo-monero)
|
|
33e91e1 wallet, rpc: add a release field to get_version (moneromooo-monero)
|
|
It does not leak much since you can make a fair guess by RPC
version already, and some people want to avoid non release
clients when using third parties' nodes (because they'd never
lie about it)
|
|
|
|
|
|
New CLI wallet variable: export-format with options "binary" (the default),
or "ascii". "Binary" behaves as before, "ascii" forces the wallet to convert
data to ASCII using base64.
Reading files from the disk tries to auto detect what format has been
used (using a magic string added when exporting the data).
Implements https://github.com/monero-project/monero/issues/2859
|
|
|
|
It lets the user add custom entropy to the PRNG.
It does this by hashing the new data and xoring the resulting
hash with the PRNG state.
|
|
8703aa5 MMS: Use chans instead of normal addresses for auto-config (rbrunner7)
|
|
884df82 wallet: provide original address for outgoing transfers (xiphon)
|
|
8be5fea simplewallet: optional all flag to export_outputs/export_key_images (moneromooo-monero)
|
|
|
|
7b9a420 Replace std::random_shuffle with std::shuffle (tomsmeding)
|
|
c8709fe wallet: do not print log settings when unset (moneromooo-monero)
7b18e83 unit_tests: check return values on test data parsing (moneromooo-monero)
|
|
|
|
def703a wallet_api: add multi destination tx support (selsta)
|
