aboutsummaryrefslogtreecommitdiff
path: root/src/wallet (follow)
AgeCommit message (Collapse)AuthorFilesLines
2017-12-26wallet-api: added Utils::onStartupstoffu2-0/+6
2017-12-25Merge pull request #3006Riccardo Spagni1-1/+0
7e7b1a82 Revert "return subaddress in get_bulk_payments" (moneromooo-monero)
2017-12-25Revert "return subaddress in get_bulk_payments"moneromooo-monero1-1/+0
This reverts commit b60f48f0e31c17638f771042887b2fffdbad15b4.
2017-12-25Merge pull request #2895Riccardo Spagni2-44/+61
5ad312a1 wallet2: switch to chacha20 instead of chacha8 (moneromooo-monero) 1e5491e9 Add a chacha20 variant to go with chacha8 (moneromooo-monero)
2017-12-25Merge pull request #2938Riccardo Spagni1-1/+13
aaae94f0 wallet2: reinstate the single preferred output selection (moneromooo-monero)
2017-12-25wallet2: switch to chacha20 instead of chacha8moneromooo-monero1-19/+36
Wallet caches and keys files are loaded with chacha8 as needed, but only saved with chacha20. Other data (eg, cold wallet data files, etc) will be incompatible.
2017-12-25Add a chacha20 variant to go with chacha8moneromooo-monero2-25/+25
2017-12-25Merge pull request #2931Riccardo Spagni1-1/+5
04349492 wallet2: error out in get_seed if the language is invalid (moneromooo-monero)
2017-12-25Merge pull request #2926Riccardo Spagni5-1/+235
6b5bd129 Account tagging (stoffu)
2017-12-25Merge pull request #2920Riccardo Spagni4-15/+53
bd5cce07 network_throttle: fix ineffective locking (moneromooo-monero) e0a61299 network_throttle: remove unused xxx static member (moneromooo-monero) 24f584d9 cryptonote_core: remove unused functions with off by one bugs (moneromooo-monero) b1634aa3 blockchain: don't leave dangling pointers in this (moneromooo-monero) 8e60b81c cryptonote_core: fix db leak on error (moneromooo-monero) 213e326c abstract_tcp_server2: log init_server errors as fatal (moneromooo-monero) b51dc566 use const refs in for loops for non tiny types (moneromooo-monero) f0568ca6 net_parse_helpers: fix regex error checking (moneromooo-monero) b49ddc76 check accessing an element past the end of a container (moneromooo-monero) 2305bf26 check return value for generate_key_derivation and derive_public_key (moneromooo-monero) a4240d9f catch const exceptions (moneromooo-monero) 45a1c4c0 add empty container sanity checks when using front() and back() (moneromooo-monero) 56fa6ce1 tests: fix a buffer overread in a unit test (moneromooo-monero) b4524892 rpc: guard against json parsing a non object (moneromooo-monero) c2ed8618 easylogging++: avoid buffer underflow (moneromooo-monero) 187a6ab2 epee: trap failure to parse URI from request (moneromooo-monero) 061789b5 checkpoints: trap failure to load JSON checkpoints (moneromooo-monero) ba2fefb9 checkpoints: pass std::string by const ref, not const value (moneromooo-monero) 38c8f4e0 mlog: terminate a string at last char, just in case (moneromooo-monero) d753d716 fix a few leaks by throwing objects, not newed pointers to objects (moneromooo-monero) fe568db8 p2p: use size_t for arbitrary counters instead of uint8_t (moneromooo-monero) 46d6fa35 cryptonote_protocol: sanity check chain hashes from peer (moneromooo-monero) 25584f86 cryptonote_protocol: print peer versions when unexpected (moneromooo-monero) 490a5d41 rpc: do not try to use an invalid txid in relay_tx (moneromooo-monero)
2017-12-25Merge pull request #2916Riccardo Spagni2-4/+22
a9217641 wallet-rpc: added receiving address to res of get(_bulk)_payments; selective addresses for getaddress (stoffu)
2017-12-25Merge pull request #2902Riccardo Spagni1-1/+0
1741fb5f node_rpc_proxy: remove unused local and time call (moneromooo-monero)
2017-12-25Merge pull request #2899Riccardo Spagni1-0/+1
b60f48f0 return subaddress in get_bulk_payments (Dmitriy Plekhanov)
2017-12-25Merge pull request #2891Riccardo Spagni1-8/+8
3f24e901 wallet2: don't write a .new file when not needed (moneromooo-monero)
2017-12-25Merge pull request #2888Riccardo Spagni1-1/+1
ca18ff64 wallet2: detect spends in txes without a valid public tx key (moneromooo-monero) 6afcd8e3 cn_deserialize: print tx extra fields in partly decoded tx extra (moneromooo-monero)
2017-12-18use const refs in for loops for non tiny typesmoneromooo-monero1-1/+1
2017-12-18check accessing an element past the end of a containermoneromooo-monero4-7/+30
2017-12-18check return value for generate_key_derivation and derive_public_keymoneromooo-monero1-7/+14
2017-12-18add empty container sanity checks when using front() and back()moneromooo-monero2-0/+8
2017-12-18wallet-rpc: added receiving address to res of get(_bulk)_payments; selective ↵stoffu2-4/+22
addresses for getaddress
2017-12-18Account taggingstoffu5-1/+235
2017-12-17change the N-1/N multisig second message signer for authmoneromooo-monero1-10/+9
2017-12-17wallet: factor multisig info parsingmoneromooo-monero3-50/+63
2017-12-17wallet: use raw encrypted data in multisig import/export RPCmoneromooo-monero4-87/+69
2017-12-17wallet: add multisig sign/submit RPCmoneromooo-monero6-108/+465
2017-12-17Match surae's recommendation to derive multisig keysmoneromooo-monero2-18/+19
2017-12-17wallet2: fix slow multisig unit tests with subaddress patchmoneromooo-monero2-8/+47
While there, move the wallet2 ctor to the cpp file as it's a huge amount of init list now, and remove an unused one.
2017-12-17make multisig work with subaddressesmoneromooo-monero2-30/+13
Thanks to kenshi84 for help getting this work
2017-12-17wallet: guard against partly initialized multisig walletmoneromooo-monero4-6/+31
2017-12-17add multisig core test and factor multisig building blocksmoneromooo-monero4-98/+45
2017-12-17N-1/N multisigmoneromooo-monero5-118/+707
2017-12-17multisig address generation RPCmoneromooo-monero6-6/+400
2017-12-17gen_multisig: generates multisig wallets if participants trust each othermoneromooo-monero4-2/+6
2017-12-17wallet2: allow empty wallet filename to avoid saving datamoneromooo-monero1-29/+57
Useful to speed tests up and avoid unnecessary leftover files
2017-12-17Add N/N multisig tx generation and signingmoneromooo-monero8-73/+634
Scheme by luigi1111: Multisig for RingCT on Monero 2 of 2 User A (coordinator): Spendkey b,B Viewkey a,A (shared) User B: Spendkey c,C Viewkey a,A (shared) Public Address: C+B, A Both have their own watch only wallet via C+B, a A will coordinate spending process (though B could easily as well, coordinator is more needed for more participants) A and B watch for incoming outputs B creates "half" key images for discovered output D: I2_D = (Hs(aR)+c) * Hp(D) B also creates 1.5 random keypairs (one scalar and 2 pubkeys; one on base G and one on base Hp(D)) for each output, storing the scalar(k) (linked to D), and sending the pubkeys with I2_D. A also creates "half" key images: I1_D = (Hs(aR)+b) * Hp(D) Then I_D = I1_D + I2_D Having I_D allows A to check spent status of course, but more importantly allows A to actually build a transaction prefix (and thus transaction). A builds the transaction until most of the way through MLSAG_Gen, adding the 2 pubkeys (per input) provided with I2_D to his own generated ones where they are needed (secret row L, R). At this point, A has a mostly completed transaction (but with an invalid/incomplete signature). A sends over the tx and includes r, which allows B (with the recipient's address) to verify the destination and amount (by reconstructing the stealth address and decoding ecdhInfo). B then finishes the signature by computing ss[secret_index][0] = ss[secret_index][0] + k - cc[secret_index]*c (secret indices need to be passed as well). B can then broadcast the tx, or send it back to A for broadcasting. Once B has completed the signing (and verified the tx to be valid), he can add the full I_D to his cache, allowing him to verify spent status as well. NOTE: A and B *must* present key A and B to each other with a valid signature proving they know a and b respectively. Otherwise, trickery like the following becomes possible: A creates viewkey a,A, spendkey b,B, and sends a,A,B to B. B creates a fake key C = zG - B. B sends C back to A. The combined spendkey C+B then equals zG, allowing B to spend funds at any time! The signature fixes this, because B does not know a c corresponding to C (and thus can't produce a signature). 2 of 3 User A (coordinator) Shared viewkey a,A "spendkey" j,J User B "spendkey" k,K User C "spendkey" m,M A collects K and M from B and C B collects J and M from A and C C collects J and K from A and B A computes N = nG, n = Hs(jK) A computes O = oG, o = Hs(jM) B anc C compute P = pG, p = Hs(kM) || Hs(mK) B and C can also compute N and O respectively if they wish to be able to coordinate Address: N+O+P, A The rest follows as above. The coordinator possesses 2 of 3 needed keys; he can get the other needed part of the signature/key images from either of the other two. Alternatively, if secure communication exists between parties: A gives j to B B gives k to C C gives m to A Address: J+K+M, A 3 of 3 Identical to 2 of 2, except the coordinator must collect the key images from both of the others. The transaction must also be passed an additional hop: A -> B -> C (or A -> C -> B), who can then broadcast it or send it back to A. N-1 of N Generally the same as 2 of 3, except participants need to be arranged in a ring to pass their keys around (using either the secure or insecure method). For example (ignoring viewkey so letters line up): [4 of 5] User: spendkey A: a B: b C: c D: d E: e a -> B, b -> C, c -> D, d -> E, e -> A Order of signing does not matter, it just must reach n-1 users. A "remaining keys" list must be passed around with the transaction so the signers know if they should use 1 or both keys. Collecting key image parts becomes a little messy, but basically every wallet sends over both of their parts with a tag for each. Thia way the coordinating wallet can keep track of which images have been added and which wallet they come from. Reasoning: 1. The key images must be added only once (coordinator will get key images for key a from both A and B, he must add only one to get the proper key actual key image) 2. The coordinator must keep track of which helper pubkeys came from which wallet (discussed in 2 of 2 section). The coordinator must choose only one set to use, then include his choice in the "remaining keys" list so the other wallets know which of their keys to use. You can generalize it further to N-2 of N or even M of N, but I'm not sure there's legitimate demand to justify the complexity. It might also be straightforward enough to support with minimal changes from N-1 format. You basically just give each user additional keys for each additional "-1" you desire. N-2 would be 3 keys per user, N-3 4 keys, etc. The process is somewhat cumbersome: To create a N/N multisig wallet: - each participant creates a normal wallet - each participant runs "prepare_multisig", and sends the resulting string to every other participant - each participant runs "make_multisig N A B C D...", with N being the threshold and A B C D... being the strings received from other participants (the threshold must currently equal N) As txes are received, participants' wallets will need to synchronize so that those new outputs may be spent: - each participant runs "export_multisig FILENAME", and sends the FILENAME file to every other participant - each participant runs "import_multisig A B C D...", with A B C D... being the filenames received from other participants Then, a transaction may be initiated: - one of the participants runs "transfer ADDRESS AMOUNT" - this partly signed transaction will be written to the "multisig_monero_tx" file - the initiator sends this file to another participant - that other participant runs "sign_multisig multisig_monero_tx" - the resulting transaction is written to the "multisig_monero_tx" file again - if the threshold was not reached, the file must be sent to another participant, until enough have signed - the last participant to sign runs "submit_multisig multisig_monero_tx" to relay the transaction to the Monero network
2017-12-17wallet: add multisig key generationmoneromooo-monero2-5/+180
Scheme by luigi1111
2017-12-17Merge pull request #2857Riccardo Spagni1-5/+5
7193b89f Scrub keys from memory just before scope end. (moneromooo-monero)
2017-12-17Merge pull request #2877Riccardo Spagni1-1/+1
43f5269f Wallets now do not depend on the daemon rpc lib (moneromooo-monero) bb89ae8b move connection_basic and network_throttle from src/p2p to epee (moneromooo-monero) 4abf25f3 cryptonote_core does not depend on p2p anymore (moneromooo-monero)
2017-12-16Wallets now do not depend on the daemon rpc libmoneromooo-monero1-1/+1
The shared RPC code is now moved off into a separate lib
2017-12-16move includes around to lessen overall loadmoneromooo-monero3-4/+6
2017-12-16Scrub keys from memory just before scope end.moneromooo-monero1-5/+5
Partially implements #74. Securely erases keys from memory after they are no longer needed. Might have a performance impact, which I haven't measured (perf measurements aren't generally reliable on laptops). Thanks to @stoffu for the suggestion to specialize the pod_to_hex/hex_to_pod functions. Using overloads + SFINAE instead generalizes it so other types can be marked as scrubbed without adding more boilerplate.
2017-12-16Merge pull request #2885Riccardo Spagni1-1/+6
a1e3670b catch wallet decrypt false positive (Riccardo Spagni)
2017-12-16Merge pull request #2860Riccardo Spagni3-29/+30
3dffe71b new wipeable_string class to replace std::string passphrases (moneromooo-monero) 7a2a5741 utils: initialize easylogging++ in on_startup (moneromooo-monero) 54950829 use memwipe in a few relevant places (moneromooo-monero) 000666ff add a memwipe function (moneromooo-monero)
2017-12-16wallet2: reinstate the single preferred output selectionmoneromooo-monero1-1/+13
Removing it nullified the min-outputs-{count,value} system, and will not increase the number of attempted transactions in the general case.
2017-12-15wallet2: error out in get_seed if the language is invalidmoneromooo-monero1-1/+5
2017-12-09node_rpc_proxy: remove unused local and time callmoneromooo-monero1-1/+0
2017-12-08return subaddress in get_bulk_paymentsDmitriy Plekhanov1-0/+1
2017-12-08add bulletproofs from v7 on testnetmoneromooo-monero2-8/+11
2017-12-08integrate bulletproofs into moneromoneromooo-monero1-12/+25
2017-12-07wallet2: don't write a .new file when not neededmoneromooo-monero1-8/+8
2017-12-06wallet2: detect spends in txes without a valid public tx keymoneromooo-monero1-1/+1
2017-12-04catch wallet decrypt false positiveRiccardo Spagni1-1/+6
2017-12-02Merge pull request #2833Riccardo Spagni2-20/+34
b0426d4c Fixes #759 Add sanity check on restore height (Cifrado)
2017-12-02Merge pull request #2850Riccardo Spagni1-1/+1
d875a9ff wallet2: detect multiple outputs from a tx to different subaddresses (moneromooo-monero)
2017-12-02Merge pull request #2828Riccardo Spagni1-2/+11
6cbe7bcd wallet2: check generate_key_derivation return value (moneromooo-monero)
2017-11-27new wipeable_string class to replace std::string passphrasesmoneromooo-monero3-29/+30
2017-11-25Merge pull request #2824Riccardo Spagni13-39/+102
51895fd7 split wallet and wallet_api (moneromooo-monero)
2017-11-25Merge pull request #2823Riccardo Spagni3-27/+47
0d149f70 Add out-of-bound exceptions and handle them in RPC (Michał Sałaban)
2017-11-25Merge pull request #2807Riccardo Spagni1-1/+1
61712384 daemon & simplewallet: don't set max-concurrency when unspecified (stoffu)
2017-11-25Merge pull request #2806Riccardo Spagni1-1/+3
da706b61 Fix false GCC warning '‘*((void*)& subaddr_account +4)’ may be used unitialized' (binaryFate)
2017-11-25Merge pull request #2800Riccardo Spagni1-102/+94
0b726be7 wallet2: minimize the number of construct_tx calls (moneromooo-monero) 9d505d26 wallet2: cleanup some debug logs (moneromooo-monero)
2017-11-25Merge pull request #2797Riccardo Spagni1-10/+14
7e387fb1 wallet2: only add a dummy 0 output if there's one output otherwise (moneromooo-monero)
2017-11-25Merge pull request #2368Riccardo Spagni8-0/+384
b0b7e0f0 Spend proof without txkey (stoffu)
2017-11-25Merge pull request #2788Riccardo Spagni5-3/+158
9739da1e wallet_rpc_server: new relay_tx command (moneromooo-monero) 01dc8297 wallet: transfer RPC can now return tx metadata (pending_tx) (moneromooo-monero) 83fa9047 serialization: add std::set and std::unordered_set serialization (moneromooo-monero)
2017-11-24wallet_rpc_server: new relay_tx commandmoneromooo-monero4-0/+72
It takes a full tx+metadata hex string as input
2017-11-24wallet: transfer RPC can now return tx metadata (pending_tx)moneromooo-monero3-3/+86
2017-11-21wallet2: detect multiple outputs from a tx to different subaddressesmoneromooo-monero1-1/+1
2017-11-21Spend proof without txkeystoffu8-0/+384
2017-11-21fix for tx proof: use exception instead of error_str when signature gen failedstoffu6-23/+9
2017-11-20Merge pull request #2768Riccardo Spagni2-5/+10
ef941855 Wallet RPC: Add prompt-for-password flag (Tim L)
2017-11-18Tx proof (revised):stoffu11-171/+770
- refactoring: proof generation/checking code was moved from simplewallet.cpp to wallet2.cpp - allow an arbitrary message to be signed together with txid - introduce two types (outbound & inbound) of tx proofs; with the same syntax, inbound is selected when <address> belongs to this wallet, outbound otherwise. see GitHub thread for more discussion - wallet RPC: added get_tx_key, check_tx_key, get_tx_proof, check_tx_proof - wallet API: moved WalletManagerImpl::checkPayment to Wallet::checkTxKey, added Wallet::getTxProof/checkTxProof - get_tx_key/check_tx_key: handle additional tx keys by concatenating them into a single string
2017-11-17Fixes #759 Add sanity check on restore heightCifrado2-20/+34
2017-11-16split wallet and wallet_apimoneromooo-monero13-39/+102
This speeds up building a lot when wallet2.h (or something it includes) changes, since all the API includes wallet2.h
2017-11-16wallet2: check generate_key_derivation return valuemoneromooo-monero1-2/+11
2017-11-16daemon & simplewallet: don't set max-concurrency when unspecifiedstoffu1-1/+1
2017-11-15Wallet RPC: Add prompt-for-password flagTim L2-5/+10
2017-11-15wallet2: minimize the number of construct_tx callsmoneromooo-monero1-95/+90
2017-11-15wallet2: cleanup some debug logsmoneromooo-monero1-7/+4
2017-11-15Add out-of-bound exceptions and handle them in RPCMichał Sałaban3-27/+47
2017-11-15simplewallet: wrong ns for input_line in sweep_single (fix #2634)stoffu2-2/+1
2017-11-15Merge pull request #2773Riccardo Spagni1-13/+12
ffe5b857 Correct totals computation (Michał Sałaban)
2017-11-15Merge pull request #2772Riccardo Spagni1-1/+1
5d92c7cc wallet2: typo fix in error message (moneromooo-monero)
2017-11-15Merge pull request #2634Riccardo Spagni5-0/+167
b738f4b5 wallet: add sweep_single command (stoffu)
2017-11-15Merge pull request #2628Riccardo Spagni1-42/+19
7cb303a4 wallet2: simplify incoming tx processing code (moneromooo-monero)
2017-11-15wallet: add sweep_single commandstoffu5-0/+167
2017-11-15wallet2 bugfix: loading old m_unconfirmed_paymentsstoffu1-3/+2
2017-11-14More missed readline dependencies thru scoped_message_writerHoward Chu2-5/+2
2017-11-14Fix 437421ce42f1deaa7ec3f28c0c17aff519f1230dHoward Chu1-1/+1
Missing an error argument for an exception
2017-11-14CMake: include RPC when building GUI depsanonimal1-33/+30
2017-11-14Merge pull request #2739Riccardo Spagni1-10/+17
99f398a2 wallet2: avoid growing the short history when refreshing in a loop (moneromooo-monero)
2017-11-14Merge pull request #2736Riccardo Spagni7-124/+113
0d9c0db9 Do not build against epee_readline if it was not built (Howard Chu) 178014c9 split off readline code into epee_readline (moneromooo-monero) a9e14a19 link against readline only for monerod and wallet-wallet-{rpc,cli} (moneromooo-monero) 437421ce wallet: move some scoped_message_writer calls from the libs (moneromooo-monero) e89994e9 wallet: rejig to avoid prompting in wallet2 (moneromooo-monero) ec5135e5 move input_line from command_line to simplewallet (moneromooo-monero) 082db75f move cryptonote command line options to cryptonote_core (moneromooo-monero)
2017-11-14Merge pull request #2629Riccardo Spagni1-0/+2
383ff4f6 remove "using namespace std" from headers (moneromooo-monero)
2017-11-14wallet2: avoid growing the short history when refreshing in a loopmoneromooo-monero1-10/+17
2017-11-14Do not build against epee_readline if it was not builtHoward Chu1-1/+1
2017-11-14split off readline code into epee_readlinemoneromooo-monero1-0/+1
2017-11-14wallet: move some scoped_message_writer calls from the libsmoneromooo-monero5-85/+76
2017-11-14wallet: rejig to avoid prompting in wallet2moneromooo-monero3-40/+37
wallet2 is a library, and should not prompt for stdin. Instead, pass a function so simplewallet can prompt on stdin, and a GUI might display a window, etc.
2017-11-14remove "using namespace std" from headersmoneromooo-monero1-0/+2
It's nasty, and actually breaks on Solaris, where if.h fails to build due to: struct map *if_memmap;
2017-11-14Merge pull request #2756Riccardo Spagni1-0/+0
0bf09154 Fix file permission issue (Tim L)
2017-11-14Merge pull request #2755Riccardo Spagni1-2/+2
d70515fc Used declared default refresh status as default rather than it's current value (Maxime THIEBAUT)
2017-11-14Merge pull request #2745Riccardo Spagni1-1/+0
6cf33446 Remove wallet dependency on p2p (moneromooo-monero)
2017-11-14Merge pull request #2727Riccardo Spagni1-1/+14
9d6c6c5d wallet2: do not bother downloading block hashes below last checkpoint (moneromooo-monero)
2017-11-14wallet2: simplify incoming tx processing codemoneromooo-monero1-42/+19
2017-11-14Merge pull request #2624Riccardo Spagni3-16/+17
2677ade5 simplewallet: forbid 0 ring size (moneromooo-monero) da8b60cb simplewallet: reject attempts to use too low mixin early (moneromooo-monero)
2017-11-14Merge pull request #2701Riccardo Spagni2-2/+4
867b67c4 Wallet API: override update subdir when built from src (Jaquee)
2017-11-14Merge pull request #2697Riccardo Spagni2-24/+49
d269bff2 wallet2: use a vector, not a list, for selected_transfers (moneromooo-monero)
2017-11-14simplewallet: reject attempts to use too low mixin earlymoneromooo-monero3-16/+17
This yields a clear error message rather then some possibly confusing more technical errors down the line
2017-11-14Merge pull request #2661Riccardo Spagni1-5/+21
ac4018a7 wallet2: workaround for lightwallet before supporting subaddress (followup #2656) (kenshi84)
2017-11-14Merge pull request #2633Riccardo Spagni1-2/+11
ad96c478 wallet-cli: added --generate-from-spend-key option (stoffu)
2017-11-14Merge pull request #2509Riccardo Spagni6-40/+94
ccf53a56 track double spending in the txpool (moneromooo-monero)
2017-11-14Fix false GCC warning '‘*((void*)& subaddr_account +4)’ may be used ↵binaryFate1-1/+3
unitialized'
2017-11-14wallet-cli: added --generate-from-spend-key optionstoffu1-2/+11
2017-11-13wallet2: use a vector, not a list, for selected_transfersmoneromooo-monero2-24/+49
Friendlier on memory/speed, we know in advance the max amount of items, which are small and constant size, and there's a lot of list walking involved.
2017-11-13wallet2: only add a dummy 0 output if there's one output otherwisemoneromooo-monero1-10/+14
2017-11-08Correct totals computationMichał Sałaban1-13/+12
2017-11-07wallet2: typo fix in error messagemoneromooo-monero1-1/+1
2017-11-06wallet2 bugfix: supply missing subaddr_account arg to balance() and unlocked ↵stoffu1-4/+4
balance()
2017-11-06track double spending in the txpoolmoneromooo-monero6-40/+94
Transactions in the txpool are marked when another transaction is seen double spending one or more of its inputs. This is then exposed wherever appropriate. Note that being marked with this "double spend seen" flag does NOT mean this transaction IS a double spend and will never be mined: it just means that the network has seen at least another transaction spending at least one of the same inputs, so care should be taken to wait for a few confirmations before acting upon that transaction (ie, mostly of use for merchants wanting to accept unconfirmed transactions).
2017-11-06Merge pull request #2605Riccardo Spagni5-1/+125
b370ef54 Wallet: Descriptions through new commands 'set_description', 'get_description' (rbrunner7)
2017-11-06Merge pull request #2546Riccardo Spagni4-10/+64
b2d416f2 Distinguish "not enough money" and "not enough unlocked money" (binaryFate)
2017-11-03Fix file permission issueTim L1-0/+0
This branch fixes a file permission issue introduced by https://github.com/monero-project/monero/commit/69c37200aa87f100f731e755bdca7a0dc6ae820a
2017-11-03Used declared default refresh status as default rather than it's current valueMaxime THIEBAUT1-2/+2
2017-11-02Remove wallet dependency on p2pmoneromooo-monero1-1/+0
2017-11-01Merge pull request #2703Riccardo Spagni5-25/+24
d0463312 fix libwallet api test after api change (Jaquee) a46c1eed Wallet2: Don't throw when subaddress label doesn't exist (Jaquee) 086b7db2 Wallet API: default values for account and subaddr index (Jaquee)
2017-10-31Merge pull request #2723Riccardo Spagni1-1/+1
69c37200 RPC Add cross origin resource sharing support (Tim L)
2017-10-31Merge pull request #2711Riccardo Spagni3-96/+100
fab3b722 Add more specific RPC error codes (Michał Sałaban)
2017-10-31Merge pull request #2718Riccardo Spagni1-2/+2
626e8078 wallet2: fix show_transfers missing multiple incoming outputs (moneromooo-monero)
2017-10-31Merge pull request #2705Riccardo Spagni1-1/+1
44f14638 wallet2: fix tx size estimator for large number of inputs (moneromooo-monero)
2017-10-31wallet2: do not bother downloading block hashes below last checkpointmoneromooo-monero1-1/+14
2017-10-30RPC Add cross origin resource sharing supportTim L1-1/+1
2017-10-29Wallet2: Don't throw when subaddress label doesn't existJaquee2-11/+11
2017-10-29Wallet API: override update subdir when built from srcJaquee2-2/+4
2017-10-23wallet2: fix show_transfers missing multiple incoming outputsmoneromooo-monero1-2/+2
2017-10-23wallet2: fix subaddress fields serializationmoneromooo-monero1-0/+15
When loading an older wallet cache, they wouldn't be initialized, leading them to have random(ish) values, and so assigned to some random subaddress.
2017-10-23Add more specific RPC error codesMichał Sałaban3-96/+100
2017-10-22wallet2: fix tx size estimator for large number of inputsmoneromooo-monero1-1/+1
2017-10-22Wallet API: default values for account and subaddr indexJaquee3-14/+13
2017-10-16Wallet: Descriptions through new commands 'set_description', 'get_description'rbrunner75-1/+125
2017-10-16Distinguish "not enough money" and "not enough unlocked money"binaryFate4-10/+64
Fix #1530
2017-10-16wallet2: workaround for lightwallet before supporting subaddress (followup ↵kenshi841-5/+21
#2656)
2017-10-15Fix compiler warnings with Clang 6.0.0.Vasil Dimov1-1/+1
monero/src/cryptonote_protocol/block_queue.cpp:208:44: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces] static const boost::uuids::uuid uuid0 = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ { } monero/src/wallet/wallet_rpc_server.cpp:1895:43: error: lambda capture 'wal' is not used [-Werror,-Wunused-lambda-capture] tools::signal_handler::install([&wrpc, &wal](int) { ^ monero/src/cryptonote_protocol/cryptonote_protocol_handler.inl:1616:40: error: lambda capture 'arg' is not used [-Werror,-Wunused-lambda-capture] m_p2p->for_each_connection([this, &arg, &fluffy_arg, &exclude_context, &fullConnections... ^ monero/src/cryptonote_protocol/cryptonote_protocol_handler.inl:1616:46: error: lambda capture 'fluffy_arg' is not used [-Werror,-Wunused-lambda-capture] m_p2p->for_each_connection([this, &arg, &fluffy_arg, &exclude_context, &fullConnections... ^ monero/src/blockchain_utilities/blockchain_export.cpp:181:3: error: bool literal returned from 'main' [-Werror,-Wmain] CHECK_AND_ASSERT_MES(r, false, "Failed to initialize source blockchain storage"); ^ ~~~~~ monero/contrib/epee/include/misc_log_ex.h:180:97: note: expanded from macro 'CHECK_AND_ASSERT_MES' ...fail_ret_val, message) do{if(!(expr)) {LOG_ERROR(message); return fail_ret_val;};}while(0) ^ ~~~~~~~~~~~~ monero/src/blockchain_utilities/blockchain_export.cpp:195:3: error: bool literal returned from 'main' [-Werror,-Wmain] CHECK_AND_ASSERT_MES(r, false, "Failed to export blockchain raw data"); ^ ~~~~~ monero/contrib/epee/include/misc_log_ex.h:180:97: note: expanded from macro 'CHECK_AND_ASSERT_MES' ...fail_ret_val, message) do{if(!(expr)) {LOG_ERROR(message); return fail_ret_val;};}while(0) ^ ~~~~~~~~~~~~
2017-10-15fix lightwallet and subaddresses conflictJaquee1-1/+6
2017-10-15Merge pull request #2596Riccardo Spagni1-8/+0
06fb9bcf wallet2: fix refresh height calc for new wallets (moneromooo-monero)
2017-10-15Merge pull request #2592Riccardo Spagni1-1/+1
dc19659d Remove network_address_base which has been merged with ipv4_network_address in 8b006877 (Michał Sałaban) 2183ade0 Don't try to create wallet-dir when it's not given, don't crash if wallet-dir already exists. (Michał Sałaban)
2017-10-15Merge pull request #2589Riccardo Spagni1-3/+3
8f0cea63 add a command_line function to check for defaulted options (moneromooo-monero)
2017-10-15Merge pull request #2570Riccardo Spagni1-2/+2
f139a6ca wallet2: fix backlog being off by 1 (moneromooo-monero)
2017-10-15Merge pull request #2568Riccardo Spagni1-1/+1
7130cf0c Add tools::on_startup, and warn about glibc 2.25 bug if found (moneromooo-monero)
2017-10-15Merge pull request #2565Riccardo Spagni1-1/+1
452d4fae tests: fix hashchain unit tests (moneromooo-monero)
2017-10-15Merge pull request #2109Riccardo Spagni6-72/+859
97c2e449 wallet2+API: use separate callbacks for lightwallets (Jaquee) d9261867 walletAPI: correct confirmations in txHistory for unsynced wallets (Jaquee) 9442b043 walletAPI: lightwallet exceptions (Jaquee) fc922934 walletAPI: add lightwallet login() and importWalletRequest() (Jaquee) 79207743 walletAPI: init() lightwallet and SSL support (Jaquee) dde5a1fc walletAPI: add tx unlock_time (Jaquee) bba5cbed wallet2: remove obsolete get_num_rct_outputs() call from create_transactions_2 (Jaquee) 7a482f30 wallet2: create_transactions_2 lightwallet support (Jaquee) ce61b818 wallet2: get_outs lightwallet support (Jaquee) 1197cb71 wallet2: commit_tx() lightwallet support (Jaquee) 43b57804 wallet2: refactor is_tx_spendtime_unlocked() (Jaquee) 32e2b003 wallet2: add lightwallet exceptions to common functions (Jaquee) 2e692fc0 wallet2: refresh() lightwallet support (Jaquee) f44d156c my/openmonero API functions (Jaquee) 288d3c75 wallet2: add remove_obsolete_pool_txs() (Jaquee) 2c6aad7e wallet2: add on_pool_tx_removed callback (Jaquee) ff7c30aa wallet2: light wallet member variables (Jaquee) e2a276cb wallet2: add ssl option to init() (Jaquee) a13540be add string_tools::validate_hex() (Jaquee) fd773d88 refactor cryptonote_basic::add_tx_pub_key_to_extra (Jaquee) 8bfa6c2d lightwallet rpc server commands (Jaquee) 76961ddc Serializer: string to integer conversion for MyMonero compatibility (Jaquee) 1cf940f2 epee http_client SSL support (Jaquee) eec10137 CMakeLists.txt - Add openssl include dir (Jaquee)
2017-10-15wallet2+API: use separate callbacks for lightwalletsJaquee3-7/+43
2017-10-15walletAPI: correct confirmations in txHistory for unsynced walletsJaquee1-2/+2
2017-10-15walletAPI: lightwallet exceptionsJaquee1-2/+12
2017-10-15walletAPI: add lightwallet login() and importWalletRequest()Jaquee3-0/+40
2017-10-15walletAPI: init() lightwallet and SSL supportJaquee3-7/+12
2017-10-15walletAPI: add tx unlock_timeJaquee1-4/+0
2017-10-15wallet2: remove obsolete get_num_rct_outputs() call from create_transactions_2Jaquee1-1/+1
2017-10-15wallet2: create_transactions_2 lightwallet supportJaquee1-0/+7
2017-10-15wallet2: get_outs lightwallet supportJaquee2-10/+129
2017-10-15wallet2: commit_tx() lightwallet supportJaquee1-17/+34
2017-10-15wallet2: refactor is_tx_spendtime_unlocked()Jaquee2-3/+9
2017-10-15wallet2: add lightwallet exceptions to common functionsJaquee1-0/+15
2017-10-15wallet2: refresh() lightwallet supportJaquee1-0/+34
2017-10-15my/openmonero API functionsJaquee2-0/+475
2017-10-15wallet2: add remove_obsolete_pool_txs()Jaquee2-22/+31
2017-10-15wallet2: add on_pool_tx_removed callbackJaquee1-0/+1
2017-10-15wallet2: light wallet member variablesJaquee1-1/+15
2017-10-15Merge pull request #2554Riccardo Spagni2-24/+111
d74336d5 wallet: encrypt (un)signed tx, also optionally save unencrypted raw tx hexstr (stoffu)
2017-10-15wallet2: add ssl option to init()Jaquee2-3/+6
2017-10-14Add tools::on_startup, and warn about glibc 2.25 bug if foundmoneromooo-monero1-1/+1
https://sourceware.org/bugzilla/show_bug.cgi?id=21778
2017-10-07wallet2: fix refresh height calc for new walletsmoneromooo-monero1-8/+0
2017-10-07Subaddresseskenshi8423-388/+1798
2017-10-07wallet: encrypt (un)signed tx, also optionally save unencrypted raw tx hexstrstoffu2-24/+111
2017-10-07Don't try to create wallet-dir when it's not given, don't crash if ↵Michał Sałaban1-1/+1
wallet-dir already exists.
2017-10-06Merge pull request #2542Riccardo Spagni1-1/+1
180a848c wallet2: Missing underflow check on low heights (landergate)
2017-10-06Merge pull request #2539Riccardo Spagni1-1/+10
93ed9321 cmake: add libversion and libcheckpoints to libwallet_merged (redfish)
2017-10-06Merge pull request #2530Riccardo Spagni1-1/+1
cbc5508b construct_tx_and_get_tx_key: return sorted sources for print_ring_memebrs to work properly (stoffu)
2017-10-06Merge pull request #2529Riccardo Spagni2-11/+6
bd937139 wallet2: error check for generate_key_image_helper, removed redundant wallet_generate_key_image_helper (stoffu)
2017-10-06add a command_line function to check for defaulted optionsmoneromooo-monero1-3/+3
2017-10-03wallet2: fix backlog being off by 1moneromooo-monero1-2/+2
We don't want to count "partly filled" blocks in this case
2017-10-03tests: fix hashchain unit testsmoneromooo-monero1-1/+1
and relax the not-empty safety check to stay more intuitiuve
2017-10-03wallet2: error check for generate_key_image_helper, removed redundant ↵stoffu2-11/+6
wallet_generate_key_image_helper
2017-10-03construct_tx_and_get_tx_key: return sorted sources for print_ring_memebrs to ↵stoffu1-1/+1
work properly
2017-10-02simplewallet: allow to set threshold before warning about tx backlogselsta2-0/+9
2017-10-02Merge pull request #2491Riccardo Spagni1-7/+20
d5a9edf2 wallet2: fix exception on split txes (moneromooo-monero) 5c5b0fd0 wallet2: print unused indices on a single line (moneromooo-monero)
2017-10-02wallet2: fix hash chain trimming when the inner chain becomes emptymoneromooo-monero2-2/+30
It'd prevent further syncing. Recovery of empty hash chains is automatic, but requires a running daemon
2017-09-27wallet2: Missing underflow check on low heightslandergate1-1/+1
Lack of it results in `m_refresh_from_block_height` being < 0 (18446744...) on low heights, which blocks `process_new_blockchain_entry` and never process coins on heights less than blocks_per_month. Follow-up to #2258
2017-09-27cmake: add libversion and libcheckpoints to libwallet_mergedredfish1-1/+10
Needed to link monero-core Qt wallet.
2017-09-25wallet2: do not keep block hashes below last checkpointmoneromooo-monero2-20/+100
This saves a lot of space and load/save time for wallet caches
2017-09-25move checkpoints in a separate librarymoneromooo-monero5-14/+14
2017-09-25wallet2: simplify tx processing a bitmoneromooo-monero2-74/+68
2017-09-25wallet2: factor some of the tx scanning codemoneromooo-monero2-48/+21
2017-09-25Merge pull request #2456Riccardo Spagni1-1/+3
91def9a5 daemon, wallet: add --max-log-file-size option (selsta)
2017-09-25Merge pull request #2424Riccardo Spagni6-9/+32
28b72b6e tx_pool: pre-init tvc.m_verifivation_failed before processing (moneromooo-monero) 50a629b2 core_tests: catch (impossible in practice) tx extra api failure (moneromooo-monero) fee15ef1 wallet2: catch failure to parse address (moneromooo-monero) 1399e26d net_peerlist: remove dead code (moneromooo-monero) 50e09698 tx_pool: guard against failure getting tx hash (moneromooo-monero) 54cc209a wallet_rpc_server: catch failure to create directory (moneromooo-monero) 3e55099c wallet_rpc_server: init m_vm to NULL in ctor (moneromooo-monero) 7d0dde5e wallet_args: remove redundant default value for --log-file (moneromooo-monero) ed4a3350 wallet2: catch failure to save keys file (moneromooo-monero) 44434c8a wallet2_api: check whether dynamic_cast returns NULL (moneromooo-monero) 92f2f687 core: check return value from parse_hexstr_to_binbuff (moneromooo-monero) 5475692e wallet2_api: remove an unused, uninitialized, field (moneromooo-monero) a7ba3de1 libwallet_api_tests: initialize newblock_triggered on reset (moneromooo-monero) b2763ace wallet2_api: init error code to "no error" in the ctor (moneromooo-monero) b5faac53 get_blockchain_top now returns void (moneromooo-monero) 2e44d8f2 wallet_rpc_server: guard against exceptions (moneromooo-monero) 4230876b simplewallet: guard against I/O exceptions (moneromooo-monero) 06c1e057 daemon: initialize decode_as_json in RPC request (moneromooo-monero) 11f71af5 http_base: init size_t in http_request_info ctor (moneromooo-monero)
2017-09-25Merge pull request #2443Riccardo Spagni1-1/+1
ffe27127 wallet_rpc_server: fix index for newly added address book entry (moneromooo-monero)
2017-09-25Merge pull request #2442Riccardo Spagni1-2/+1
e29282d2 build: auto update version info without manually deleting version.h (stoffu)
2017-09-25wallet2: catch failure to parse addressmoneromooo-monero1-1/+5
CID 175297
2017-09-25wallet_rpc_server: catch failure to create directorymoneromooo-monero1-1/+10
CID 175281
2017-09-25wallet_rpc_server: init m_vm to NULL in ctormoneromooo-monero1-1/+1
CID 175279
2017-09-25wallet_args: remove redundant default value for --log-filemoneromooo-monero1-1/+1
CID 175265
2017-09-25wallet2: catch failure to save keys filemoneromooo-monero1-2/+3
CID 161848