| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
|
|
also use reserve where appropriate
|
|
|
|
|
|
62c8c07 wallet: do not log by default if we're not asked to log to console (moneromooo-monero)
|
|
63d0ab0 mlog: --max-log-files to set the max number of rotated log files (stoffu)
|
|
5a412b7 disable file size sanity check when loading the wallet cache (moneromooo-monero)
|
|
4764929 use deterministic viewkey if not supplied (cryptochangements34)
|
|
89e51ec simple-wallet-cli: Add warnings about inaccurate balances to to watch-only wallet (jcktm)
|
|
9c2a7b4 wallet-rpc: watch-only and cold wallet features added (ph4r05)
|
|
eb9f3a3 check_spend_proof (itssteven)
|
|
4812c06 add .load() to make Boost 1.67 happy with its new is_integral check (Teutone)
|
|
|
|
8787fd8 WalletApi: publicMultisigSignerKey method (naughtyfox)
|
|
b21bc00 Wallet: added methods to sign and verify arbitrary message with multisig public signer's key (libwallet & wallet api) (naughtyfox)
|
|
f80b157 wallet2: don't ask for pruned txes yet, we still parse the entire tx (moneromooo-monero)
|
|
This means monero-wallet-rpc still does, but the user level program
does not.
|
|
|
|
- unsigned_txset, signed_txset in transfer / submit_transfer / sign_transfer
- export_outputs, import_outputs
Squashed commits:
[f4d9f3d4] wallet-rpc: do_not_relay removed from submit_transfer
[5b16a86f] wallet-rpc: review-fix - method signature changes, renaming
[b7fbb10a] wallet-rpc: naming fixes (unsigned vs signed), consts renamed
[8c7d2727] wallet-rpc: sign_transfer added
[481d024a] wallet2: sign_tx splitted to work with strings and structs, more granular
[2a474db9] wallet-rpc: wallet2::load_unsigned_tx split to load from str, file
[b1e3a018] wallet-rpc: review fix, load_tx_from_str variable rename
[1f6373be] wallet-rpc: review fix: save_tx_to_{str,file}
[2a08eafc] wallet-rpc: review comments fixes
- redundant this removed from wallet2.cpp
- load_tx_from_str, load_tx_from_file
[43498052] wallet-rpc: submit_transfer added
[9c45d1ad] wallet-rpc: watch_only check, return unsigned_txset
[62831396] wallet2: added string variants to load_tx, save_tx
- analogously to save_multisig_tx
- required for monero-wallet-rpc to support watch-only wallet
|
|
f36132a wallet cli/rpc: terminate execution with code 0 when --help or --version is given (stoffu)
|
|
c1bda09 wallet_rpc_server: add a get_version RPC (moneromooo-monero)
|
|
90a16b1 crypto: fix initialization order issue with random mutex (moneromooo-monero)
6a61f52 unit_tests: add ringdb unit tests (moneromooo-monero)
|
|
47fdb74 WalletApi: getMultisigInfo entry for gui wallets... (naughtyfox)
47fdb74 Refactored: work with wallet api statuses to make setting and getting operations atomic along with error strings (naughtyfox)
|
|
|
|
|
|
80d2f80 wallet2: Update function parameter documentation (leonklingele)
|
|
|
|
cb9c7972 Fix output shuffling for multisig (stoffu)
|
|
b13bddc3 Wallet API: allow log path to be non-default & console output to be configurable (stoffu)
|
|
|
|
wallet
|
|
|
|
My intention is to mitigate #3761 by returning "bad signature", rather than throwing an error, as the error is triggered inappropriately in the case of checking a different txid than the one used to create the signature, which causes issues for monerophp: https://github.com/monero-integrations/monerophp/issues/72 & my temp fix: https://github.com/monero-integrations/monerophp/pull/74
|
|
|
|
|
|
ffeeefde speedup get_output_histogram for all amounts when min_count > 0 (moneromooo-monero)
2dae0f20 wallet2: add missing parameters to get_output_histogram (moneromooo-monero)
|
|
5bd7f760 import_multisig_info: fix sanity check crash in detach_blockchain (Mikhail Mitkevichl)
|
|
public signer's key (libwallet & wallet api)
|
|
|
|
given
|
|
|
|
f82c10dc WalletManagerImpl: reuse existing connection to daemon instead of reconnectivng every time (stoffu)
|
|
875c1cab wallet2: increase rpc timeout for get_output_distribution (moneromooo-monero)
70f23217 add top height to get_output_distribution, and cache it for rct (moneromooo-monero)
8c7363fb rpc: add missing perf timer for get_output_distribution (moneromooo-monero)
|
|
|
|
This should cache the vast majority of calls for long running wallets
|
|
|
|
|
|
|
|
|
|
When additional keys was needed, the TX scan failed because the
derivation data was always recomputed with the main tx_key and not
the corresponding additional one.
Moreover this patch avoid perf decreasing when not using HW device.
|
|
73951cbd wallet2: request transactions in slices when scanning for known rings (moneromooo-monero)
25fe67e4 rpc: allow getting pruned blocks from gettransactions (moneromooo-monero)
|
|
24acb66e wallet2: fix misc issues when the ringdb can't be initialized (moneromooo-monero)
|
|
0b26c4d5 wallet2: move segregation height to v7 (moneromooo-monero)
|
|
eecfb57d wallet: warn if not using the default ring size (moneromooo-monero)
|
|
1e0958c0 wallet: fix default mixin (4 -> 6) (sneurlax)
|
|
|
|
11c933e1 fix lambda compile error on openbsd (moneromooo-monero)
|
|
c77d2bfa Add the possibility to export private view key for fast scan. (cslashm)
100b7bc1 Change mutex lock model to avoid dead lock and ensure locks are always released. (cslashm)
641dfc99 Automatic height setup when creating/restoring hw device. (cslashm)
|
|
eaa8bfe7 wallet2: set from_height of GET_OUTPUT_DISTRIBUTION correctly The previous expression (stoffu)
0a619f78 wallet2: enable the mitigation only after the fork height (stoffu)
|
|
0098ed33 wallet2: fix for loading settings of key reuse mitigation (stoffu)
|
|
|
|
This avoid massive memory consumption for huge wallets
|
|
and get them pruned in find_and_save_rings, since it does not need
the pruned data in the first place.
Also set decode_to_json to false where missing, we don't need this
either.
|
|
reconnectivng every time
|
|
since people seem to really want to use things the wrong way.
|
|
On client startup the device asks for authorization to export the private view key.
If user agree, the client hold the private view key allowing a fast blockchain scan.
If the user does not agree, the blockchain scan is fully done via the device.
|
|
|
|
|
|
WalletApi: makeMultisig call introduced
WalletApi: finalizeMultisig call introduced
WalletApi: new calls exportMultisigImages and importMultisigImages
WalletApi: method to return multisig wallet creation state
WalletApi: create multisig transaction, sign multisig transaction, commit transaction and get multisig data are added
WalletApi: identation and style fixes
|
|
operations atomic along with error strings
WalletApi: added method statusWithErrorString to atomically retrieve error with error string
|
|
|
|
The previous expression
req_t.from_height = X ? Y >= Z : 0;
forces the parameter to take the value of either 0 or 1.
|
|
|
|
|
|
|
|
via user setting first, then DNS TXT record, hardcoded fallback
|
|
9732a37e wallet_rpc_server: add sweep_unmixable as alias for sweep_dust (moneromooo-monero)
|
|
|
|
lookahead in order to avoid
so looooong time of set-up when creating a HW based wallet.
|
|
57c0b1ed Fix typos in various files (Dimitris Apostolou)
|
|
It can now take a txid (to display rings for all its inputs),
and will print rings in a format that set_ring understands
|
|
|
|
|
|
|
|
|
|
This will avoid careless forkers polluting the shared database
even if they make their own chain. They'll then automatically
start using another subdb, and any key-reusing fork of those
forks will reuse their subdbs.
|
|
This is so one can set rings for spent key images in case the
attackers don't merge the ring matching patch set.
|
|
|
|
|
|
If a pre-fork output is spent on both Monero and attack chain,
any post-fork output can be deduced to be a fake output, thereby
decreasing the effective ring size.
The segregate-per-fork-outputs option, on by default, allows
selecting only pre-fork outputs in this case, so that the same
ring can be used when spending it on the other side, which does
not decrease the effective ring size.
This is intended to be SET when intending to spend Monero on the
attack fork, and to be UNSET if not intending to spend Monero
on the attack fork (since it leaks the fact that the output being
spent is pre-fork).
If the user is not certain yet whether they will spend pre-fork
outputs on a key reusing fork, the key-reuse-mitigation2 option
should be SET instead.
If you use this option and intend to spend Monero on both forks,
then spend real Monero first.
|
|
This maps key images to rings, so that different forks can reuse
the rings by key image. This avoids revealing the real inputs like
would happen if two forks spent the same outputs with different
rings. This database is meant to be shared with all Monero forks
which don't bother making a new chain, putting users' privacy at
risk in the process. It is placed in a shared data directory by
default ($HOME/.shared-ringdb on UNIX like systems). You may
use --shared-ringdb-dir to override this location, and should
then do so for all Monero forks for them to share the database.
|
|
|
|
|
|
calls to wallet2
|
|
This completes and fixes various parameters docs
|
|
invoke_http_json_rpc("/json_rpc",methodname,...) to reduce boilerplate
|
|
c577abab wallet: fix auto low priority so that it takes effect only when saved default is 0 (stoffu)
|
|
1d39b265 wallet2: fix use_fork_rules() when querying version that is defined but not enabled yet (stoffu)
|
|
9abeff59 wallet2: handle no blocks returned in refresh to mean no new blocks (moneromooo-monero)
|
|
ec41006c node_rpc_proxy: fix target height caching (moneromooo-monero)
|
|
|
|
When #3303 was merged, a cyclic dependency chain was generated:
libdevice <- libcncrypto <- libringct <- libdevice
This was because libdevice needs access to a set of basic crypto operations
implemented in libringct such as scalarmultBase(), while libringct also needs
access to abstracted crypto operations implemented in libdevice such as
ecdhEncode(). To untangle this cyclic dependency chain, this patch splits libringct
into libringct_basic and libringct, where the basic crypto ops previously in
libringct are moved into libringct_basic. The cyclic dependency is now resolved
thanks to this separation:
libcncrypto <- libringct_basic <- libdevice <- libcryptonote_basic <- libringct
This eliminates the need for crypto_device.cpp and rctOps_device.cpp.
Also, many abstracted interfaces of hw::device such as encrypt_payment_id() and
get_subaddress_secret_key() were previously implemented in libcryptonote_basic
(cryptonote_format_utils.cpp) and were then called from hw::core::device_default,
which is odd because libdevice is supposed to be independent of libcryptonote_basic.
Therefore, those functions were moved to device_default.cpp.
|
|
|
|
aa8bef0c fix error message typo in wallet2.cpp (cryptochangements34)
|
|
1979d53d wallet: fixes and tweaks to the save_watch_only command (moneromooo-monero)
|
|
1ff35fda Wallet API: make nettype non-defaulted to disambiguate from deprecated versions (and make libwallet_api_tests compilable) (stoffu)
|
|
0bbd521f libwallet_merged: added missing libdevice (stoffu)
|
|
ffe70b8f Make mixin optional with default for rpc transfer (cryptochangements34)
|
|
73dd883d Ledger HW Bug fixes (Cédric)
|
|
e0cda74a wallet2_api: add info/error/warning entry points (moneromooo-monero)
|
|
91d97dd4 fuzz_tests: set small subaddress lookahead for speed (moneromooo-monero)
5f85cc7e wallet2: guard against overflowing of subaddress indices (moneromooo-monero)
|
|
649a1b7a wallet2 / simplewallet: Must opt-in to create '.address.txt' files for new wallets (Leon Klingele)
|
|
|
|
enabled yet
|
|
default is 0
|
|
Fix the way the REAL mode is handle:
Let create_transactions_2 and create_transactions_from construct the vector of transactions.
Then iterate on it and resign.
We just need to add 'outs' list in the TX struct for that.
Fix default secret keys value when DEBUG_HWDEVICE mode is off
The magic value (00...00 for view key and FF..FF for spend key) was not correctly set
when DEBUG_HWDEVICE was off. Both was set to 00...00.
Add sub-address info in ABP map in order to correctly display destination sub-address on device
Fix DEBUG_HWDEVICE mode:
- Fix compilation errors.
- Fix control device init in ledger device.
- Add more log.
Fix sub addr control
Fix debug Info
|
|
This is not a possible return from the daemon, but I want this in
now so all wallets handle this when the daemon starts doing so.
|
|
|
|
wallets
Previously, a file containing the unencrypted Monero address was
created by default in the wallet's directory. This file might pose
as a privacy risk. The creation of this file is now opt-in and can
be enabled by providing
--create-address-file
|
|
|
|
38657fd0 Bump min ring size from 5 to 7 from v7 (moneromooo-monero)
|
|
55a65f32 Wallet API: corrected testnet/mainnet ordering (stoffu)
|
|
9a6be3da wallet_manager: fixed typo deviuce/device.hpp (stoffu)
|
|
- save the new keys file as FOO-watchonly.keys, not FOO.keys-watchonly
- catch any exception (eg, I/O errors) and error out
- print the new keys filename in simplewallet
|
|
|
|
|
|
versions (and make libwallet_api_tests compilable)
|
|
|
|
|
|
43026822 Wallet2 + CLI wallet: UTF-8 support for filenames and paths under Windows (rbrunner7)
|
|
3d452367 allow using ring size instead of mixin for rpc transfer (cryptochangements34)
|
|
71bff546 wallet api: when restoring from EnglishOld, set language to English (stoffu)
|
|
0e7ad2e2 Wallet API: generalize 'bool testnet' to 'NetworkType nettype' (stoffu)
af773211 Stagenet (stoffu)
cc9a0bee command_line: allow args to depend on more than one args (stoffu)
55f8d917 command_line::get_arg: remove 'required' for dependent args as they're always optional (stoffu)
450306a0 command line: allow has_arg to handle arg_descriptor<bool,false,true> #3318 (stoffu)
9f9e095a Use `genesis_tx` parameter in `generate_genesis_block`. #3261 (Jean Pierre Dudey)
|
|
f3b74e75 Fix refresh height estimation (Howard Chu)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
The basic approach it to delegate all sensitive data (master key, secret
ephemeral key, key derivation, ....) and related operations to the device.
As device has low memory, it does not keep itself the values
(except for view/spend keys) but once computed there are encrypted (with AES
are equivalent) and return back to monero-wallet-cli. When they need to be
manipulated by the device, they are decrypted on receive.
Moreover, using the client for storing the value in encrypted form limits
the modification in the client code. Those values are transfered from one
C-structure to another one as previously.
The code modification has been done with the wishes to be open to any
other hardware wallet. To achieve that a C++ class hw::Device has been
introduced. Two initial implementations are provided: the "default", which
remaps all calls to initial Monero code, and the "Ledger", which delegates
all calls to Ledger device.
|
|
|
|
|
|
df5273de wallet2: fix auto_low_priority field name typo on load (moneromooo-monero)
|
|
89ad162a wallet2: remove unused m_subaddresses_inv (moneromooo-monero)
f2c4c399 wallet2: speed up subaddress generation (by about a third) (moneromooo-monero)
|
|
3c33e131 wallet2: don't store invalid key image when watch-only (stoffu)
0133b348 wallet2: don't throw when spent amount is inconsistent (stoffu)
|
|
6866ed46 Add default value to max_height, otherwise it's 0 (Michał Sałaban)
|
|
|
|
|
|
Since commit b0426d4c refresh height for a newly created wallet
connected to a sync'd daemon was off by a month. Now we only use
the 1 month safety margin if we're unable to talk to a daemon.
|
|
214d251c wallet: suggest the use of sweep_unmixable when not_enough_outs_to_mix is thrown (stoffu)
|
|
a99ef176 wallet-rpc: take subaddress account as arg for get_transfer_by_txid (stoffu)
77125096 wallet-rpc: rename *_INDEX_OUTOFBOUND into *_INDEX_OUT_OF_BOUNDS (stoffu)
|
|
f90c76be Return appropriate error code when there's no connection to daemon (Michał Sałaban)
3cb65b3f Return appropriate error code when not enough money for tx (Michał Sałaban)
|
|
3be98036 wallet-cli: Do not ask for scan_from_height if it explicitly is set to zero. (Maximilian Lupke)
|
|
a85dbb3f Fixed typos and wording tweaks (Maxithi)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
and set v7 height to 1057027 on testnet (one block earlier)
This is to easily dump current nodes since we're going to change
the v7 rules with this.
|
|
|
|
|
|
|
|
|
|
|
|
not full)
|
|
|
|
269ba252 wallet2::import_blockchain fix import loop (Jaquee)
|
|
a9cae0ab Wallet API: remove unused enum Priority from UnsignedTransaction (stoffu)
|
|
3160a930 wallet2: remove {set|get}_default_decimal_point and use the same funcs under cryptonote:: instead (stoffu)
7d1088d3 wallet2: make scan_output const and omit keys arg (stoffu)
bc1ee2c2 wallet2: make member functions const when possible (stoffu)
|
|
6fbb0b06 cmake: set API header install path to what Qt wallet expects (redfish)
|
|
ca336c62 simplewallet: check file overwrite when exporting stuff (stoffu)
|
|
fb5c971c Allow retrieving spend key via RPC (Michał Sałaban)
|
|
ffc2e570 wallet rpc: show fees when querying incoming transfers (stoffu)
|
|
939629e8 Wallet API: all recover options with password (m2049r)
|
|
|
|
|
|
|
|
cryptonote:: instead
|
|
|
|
|
|
|
|
|
|
5ae617d5 simplewallet: single out 0 amount destinations as dummy ones (moneromooo-monero)
c1d19f3c wallet2: fix sweep_all sending an atomic unit (moneromooo-monero)
|
|
d188840c Improved terminology from create to generate (Maxithi)
|
|
3e635a3c wallet2: allow failing parse_tx_extra (moneromooo-monero)
|
|
fa5c0bab Implement #3045, fixing RPC snakecases (Nick Johnson)
|
|
eb39a3d7 wallet_api: make this optional but not built by default (moneromooo-monero)
|
|
a4b006f9 wallet2 bugfix: initialize subaddress table when generating from keys (stoffu)
|
|
6d40a920 Reserve proof (stoffu)
|
|
07da9c80 Resolve addresses in get_transfers (Michał Sałaban)
|
|
Fixes #3080
|
|
also renamed memo => mnemonic in api method parms
|
|
|
|
|
|
|
|
|
|
|
