Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
180a848c wallet2: Missing underflow check on low heights (landergate)
|
|
93ed9321 cmake: add libversion and libcheckpoints to libwallet_merged (redfish)
|
|
cbc5508b construct_tx_and_get_tx_key: return sorted sources for print_ring_memebrs to work properly (stoffu)
|
|
bd937139 wallet2: error check for generate_key_image_helper, removed redundant wallet_generate_key_image_helper (stoffu)
|
|
wallet_generate_key_image_helper
|
|
work properly
|
|
|
|
d5a9edf2 wallet2: fix exception on split txes (moneromooo-monero)
5c5b0fd0 wallet2: print unused indices on a single line (moneromooo-monero)
|
|
It'd prevent further syncing. Recovery of empty hash chains is
automatic, but requires a running daemon
|
|
Lack of it results in `m_refresh_from_block_height` being < 0 (18446744...) on low heights, which blocks `process_new_blockchain_entry` and never process coins on heights less than blocks_per_month.
Follow-up to #2258
|
|
Needed to link monero-core Qt wallet.
|
|
This saves a lot of space and load/save time for wallet caches
|
|
|
|
|
|
|
|
91def9a5 daemon, wallet: add --max-log-file-size option (selsta)
|
|
28b72b6e tx_pool: pre-init tvc.m_verifivation_failed before processing (moneromooo-monero)
50a629b2 core_tests: catch (impossible in practice) tx extra api failure (moneromooo-monero)
fee15ef1 wallet2: catch failure to parse address (moneromooo-monero)
1399e26d net_peerlist: remove dead code (moneromooo-monero)
50e09698 tx_pool: guard against failure getting tx hash (moneromooo-monero)
54cc209a wallet_rpc_server: catch failure to create directory (moneromooo-monero)
3e55099c wallet_rpc_server: init m_vm to NULL in ctor (moneromooo-monero)
7d0dde5e wallet_args: remove redundant default value for --log-file (moneromooo-monero)
ed4a3350 wallet2: catch failure to save keys file (moneromooo-monero)
44434c8a wallet2_api: check whether dynamic_cast returns NULL (moneromooo-monero)
92f2f687 core: check return value from parse_hexstr_to_binbuff (moneromooo-monero)
5475692e wallet2_api: remove an unused, uninitialized, field (moneromooo-monero)
a7ba3de1 libwallet_api_tests: initialize newblock_triggered on reset (moneromooo-monero)
b2763ace wallet2_api: init error code to "no error" in the ctor (moneromooo-monero)
b5faac53 get_blockchain_top now returns void (moneromooo-monero)
2e44d8f2 wallet_rpc_server: guard against exceptions (moneromooo-monero)
4230876b simplewallet: guard against I/O exceptions (moneromooo-monero)
06c1e057 daemon: initialize decode_as_json in RPC request (moneromooo-monero)
11f71af5 http_base: init size_t in http_request_info ctor (moneromooo-monero)
|
|
ffe27127 wallet_rpc_server: fix index for newly added address book entry (moneromooo-monero)
|
|
e29282d2 build: auto update version info without manually deleting version.h (stoffu)
|
|
CID 175297
|
|
CID 175281
|
|
CID 175279
|
|
CID 175265
|
|
CID 161848
|
|
CID 161844
|
|
Silences CID 161874
|
|
CID 161872
|
|
CID 175305
|
|
a15e8583 wallet2: guard against daemon sending txes in the wrong order (moneromooo-monero)
8fe5f609 rpc: order transactions in the order they were requested (moneromooo-monero)
|
|
9c83f806 Do not create file when RPC user/pass is given and use file locking (Lee Clagett)
|
|
b5cbdce8 wallet2: correctly handle in/out payments for view-only wallet (stoffu)
|
|
6ee1116d store is optional during close and defaults to true; except during descruction (m2049r)
|
|
651baaec wallet: add encrypted seed functionality (moneromooo-monero)
|
|
|
|
|
|
|
|
fee3c3ed Update wallet2.cpp for misspelling (Matthew Campassi)
|
|
55b91d86 wallet: fix --help and --version erroring out (moneromooo-monero)
|
|
|
|
Decreases log spam massively on large wallets
|
|
|
|
Instead of constantly creating and destroying threads
|
|
|
|
Misspelling in wallet2.cpp
|
|
This uses luigi1111's CN_Add method.
See https://xmr.llcoins.net for details.
|
|
|
|
|
|
adce8ae4 simplewallet: new "fee" command to display fee information (moneromooo-monero)
|
|
2e338ca5 wallet2: account for huge testnet reorgs for estimating height (moneromooo-monero)
|
|
d58700e0 WalletAPI: only allow trusted daemon when importing key images (Jaquee)
8a9bbd26 WalletAPI: copy wallet data when creating a view only wallet (Jaquee)
d27fe32e wallet2: export/import wallet data functions (Jaquee)
225a25f3 import_key_images - allow importing without being connected to daemon (Jaquee)
|
|
|
|
including expected transaction backlog at different priorities
|
|
|
|
|
|
|
|
|
|
|
|
|
|
8655ba04 wallet_rpc_server: adjust small ring sizes to 5 for v6 (moneromooo-monero)
|
|
359517c7 wallet_rpc_server: fix possible privacy leak in on_import_key_images() (Jaquee)
20495b27 simplewallet: fix possible privacy leak in import_key_images() (Jaquee)
|
|
1307e3cc WalletAPI: add getDefaultDataDir() (Jaquee)
|
|
74597bd1 wallet2: improve refresh height determination (moneromooo-monero)
|
|
9707998a wallet2: clear some missing containers in clear() (moneromooo-monero)
|
|
b7d6ec83 simplewallet: add (out of sync) or (no daemon) markers in the prompt (moneromooo-monero)
fa23a500 wallet2: add a is_synced function (moneromooo-monero)
f1307bbd node_rpc_proxy: add a proxy for target height (moneromooo-monero)
|
|
ad4649ac Enable verifying wallet password with having to load wallet. (m2049r)
|
|
67ce4910 wallet2: store testnet bool in keys file (Jaquee)
|
|
c97d1bd3 wallet: return unlock_time in get_transfers (moneromooo-monero)
|
|
|
|
|
|
|
|
a839a6fa Wallet API: add tx unlock time (Jaquee)
|
|
|
|
e31aac80 walletAPI: add getRefreshFromBlockHeight() (Jaquee)
48c0cb1b wallet api: pause refresh while commiting tx (Jaquee)
f233c01c CMakeLists.txt - ios/xcode fix (Jaquee)
|
|
600353e2 fix wallet callback signatures (m2049r)
|
|
525975ac wallet-cli: Minor improvement to help output (Erik de Castro Lopo)
|
|
cb0b5594 Move OpenAlias console input back from libs (moneromooo-monero)
|
|
0c57df97 wallet2: fix temporarily missing incoming tx when being mined (moneromooo-monero)
|
|
dc0b312f wallet_rpc_server: optionally return tx blobs on transfer calls (moneromooo-monero)
5eb79983 epee: add a KV_SERIALIZE variant for optional parameters (moneromooo-monero)
|
|
As reported by jaquee, the calculation could underflow for very
low heights.
Additionally, we now use the target height too.
|
|
|
|
|
|
|
|
|
|
When scanning the txpool without having first updated the
blockchain, the tx would be seen as neither in the txpool
nor the chain, and removed, so it'd only reappear once the
chain is refreshed, and the tx seen in a block.
|
|
|
|
|
|
|
|
|
|
also show it in simplewallet's show_transfer
|
|
|
|
|
|
Library code should definitely not ask for console input unless
it's clearly an input function. Delegating the user interaction
part to the caller means it can now be used by a GUI, or have a
decision algorithm better adapted to a particular caller.
|
|
also add do_not_relay flag to them, so it now becomes possible
to create a tx without sending it yet
|
|
|
|
f98bf48b Minor cleanup: tab vs. space + logs messages (binaryFate)
|
|
3b599d2b wallet2: get current height from the daemon on creation (moneromooo-monero)
d3bb72ff wallet2: fix infinite loop on future refresh height (moneromooo-monero)
32754784 wallet: fix refresh_from_height setting on new wallet (moneromooo-monero)
|
|
5a09d79c Fix #2120: return per-tx amount in transfer_split RPC call. (binaryFate)
|
|
|
|
|
|
Use current time to estimate current height only if the daemon
cannot be queried.
|
|
If the refresh height is in the future, the current code will
loop till the actual height reaches this. Fix it by bailing out
if we receive only three hashes, which is what we set in the
call parameters.
|
|
The previous patch was based on a wrong premise (that the
daemon height was 0 because the daemon calling code wasn't
yet initialized). In fact, current height approximation
was not setup for testnet. Fix this.
|
|
|
|
4e13ab30 wallet_api: fix missing transaction parameter in callback (moneromooo-monero)
|
|
It was unused, so harmless
Reported by erikd on IRC
|
|
|
|
6bcd3b2d fix get_upper_transaction rename (schnerchi)
|
|
|
|
740bc24c Wallet API: Set seed lang when recovering form keys (Jaquee)
|
|
4b932ff3 changed crypto to cncrypto so it generated libcncrypto (Gentian)
|
|
89b2f306 tests: fix invalid key image test (moneromooo-monero)
a374a522 wallet2: check key image validity domain in import_key_images (moneromooo-monero)
|
|
e2529347 Correct spelling of 'get_upper_transaction_size_limit' (Nano Akron)
3029d0ef Remove the 1.25x multiplier in max transaction size in just the wallet (Nano Akron)
|
|
6cb1ad1f wallet fix: ensure iterator to be valid (stoffu)
|
|
|
|
|
|
fix a cmakelist
|
|
|
|
|
|
|
|
|
|
The bump to minimum mixin 4 was moved from v5 to v6
|
|
bbf4c210 Wallet API: add spend/view key getters (Jaquee)
|
|
|
|
It sweeps all outputs below the given threshold
This is available via the existing sweep_all RPC, by setting
amount_threshold the desired amount (in atomic units)
|
|
a6d5bb75 wallet2: refer to triangular distribution for recent zone in comment (moneromooo-monero)
ac1aba90 wallet2: bias fake outs more towards recent outputs (moneromooo-monero)
|
|
7f4beaa4 wallet2: fix removal of wrong txes from unconfirmed_payments (moneromooo-monero)
|
|
a7d78dda wallet2: fix --generate-from-json in RPC mode (moneromooo-monero)
|
|
89d70756 wallet2: fix spurious output splitting when not merging destinations (moneromooo-monero)
|
|
10e137be wallet2: mention escaping/quoting --password in help string (moneromooo-monero)
|
|
It was wrongly refering to equiprobable distribution, which I think
I'd originally done, but forgot to update the comment after changing
to triangular
Reported by smooth on IRC
|
|
Two recent papers quantified the real usage bias for the
real output in a ring being the true one, and shows that
the current biasing is much too weak.
While we wait for a better solution, we increase the ratio
of recent-to-total fake outputs, as well as decrease the
time window for recent outputs, so that half the fake outs
are selected within the last 1.8 day. Value plucked from
figure 10, page 11 of An Empirical Analysis of Linkability
in the Monero Blockchain, 2017, Miller et al.
This is also arbitrary, of course, but serves as a stopgap
till a better selection algorithm is chosen.
|
|
unconfirmed_payments changed from having the txid as key to
the payment id, and this was not changed to match.
|
|
The daemon address was initialized too late
|
|
Reviewed and squashed. Open/Create is only allowed if no walletfile
was specified at startup.
|
|
0a7885bf Wallet API: fix Cold signing split tx (Jaquee)
|
|
f5bd3465 IOS CMAKE build settings (Jaquee)
d8a88d05 add IOS CMAKE toolchain (Jaquee)
|
|
|
|
|
|
|
|
|
|
If using a large input and many destinations, the code would
generate as many outputs as it could using that input, even if
it would bring the resulting tx above the max tx size.
|
|
With the change from the original transfer method to the new
algorithm, payments to the same destination were merged. It
seemed like a good idea, optimizing space. However, it is a
useful tool for people who want to split large outputs into
several smaller ones (ie, service providers making frequent
payments, and who do not like a large chunk of their balance
being locked for 10 blocks after each payment).
Default to off, which is a change from the previous behavior.
|
|
When a single input is enough to satisfy a transfer, the code would
previously try to add a second input, to match the "canonical" makeup
of a transaction with two inputs and two outputs. This would cause
wallets to slowly merge outputs till all the monero ends up in a
single output, which causes trouble when making two transactions
one after the other, since change is locked for 10 blocks, and an
increasing portion of the remaining balance would end up locked on
each transaction.
There are two new settings (min-output-count and min-output-value)
which can control when to stop adding such unneeded second outputs.
The idea is that small "dust" outputs will still get added, but
larger ones will not.
Enable with, eg:
set min-output-count 10
set min-output-value 30
to avoid using an unneeded second output of 30 monero or more, if
there would be less than 10 such outputs left.
This does not invalidate any other reason why such outputs would
be used (ie, when they're really needed to satisfy a transfer, or
when randomly picked in the normal course of selection). This may
be improved in the future.
|
|
a8646b09 Wallet API: add hard fork info functions (Jaquee)
|
|
8bbcbcfb wallet rpc: enable solo mining (stoffu)
|
|
|
|
Includes a new RPC to get tx pool hashes fast.
|
|
995969b1 wallet: fix set_log not handling 0,xxx style settings (moneromooo-monero)
|
|
350e99ae wallet2: cache which pool txes were scanned already (moneromooo-monero)
|
|
c1e9ccc7 wallet2: speed up transactions using remote nodes (moneromooo-monero)
|
|
|
|
This massively speeds up the wallet updating the pool on mainnet,
where the tx backlog is more than 500 txes.
|
|
Waiting would mean the fee used is 1x base, but the base will
have suddenly dropped
|
|
Asking for a full histogram from a remote node (since it's
untrusted) is pretty slow, and spams the remote node, so
we replace it by only adding a second input if we have rct
ones, which are for all intents and purposes always mixable.
|
|
|
|
df810a82 wallet-rpc bugfix: get_transfer_by_txid previously checking against payment id (kenshi84)
|
|
|
|
|
|
e9175cec wallet_rpc_server: make a few RPCs unavailable in restricted mode (moneromooo-monero)
|
|
d0238313 use const references in catch blocks (moneromooo-monero)
|
|
3fa59755 wallet2: call is_key_image_spent in blocks in rescan_spent (moneromooo-monero)
9d134e86 wallet_rpc_server: add a rescan_spent RPC (moneromooo-monero)
|
|
Address book modification, setting tx nodes, importing key images
|
|
|
|
This is a potentially long lasting daemon RPC call
|
|
|
|
|
|
3396a9f2 Add intervening v5 fork for increased min block size (moneromooo-monero)
|
|
Minimum mixin 4 and enforced ringct is moved from v5 to v6.
v5 is now used for an increased minimum block size (from 60000
to 300000) to cater for larger typical/minimum transaction size.
The fee algorithm is also changed to decrease the base per kB
fee, and add a cheap tier for those transactions which we do
not care if they get delayed (or even included in a block).
|
|
|
|
4b48565c wallet: add password command (moneromooo-monero)
|
|
223fe5bb wallet: fix get_tranfers with multiple incoming txes with same pid (moneromooo-monero)
|
|
Also tweak wallet2 password code to verify password without
saying it's a new wallet, because it's assuming things.
|
|
|
|
This reverts commit d47dac9a88ddd46b88850a899311363b3261c89e.
Callers actually expect the key to be payment id, so this
needs a lot more changes (like storing payment ids in the
structure, and possibly also to other existing structures
which do the same thing).
|
|
|
|
|
|
db1c7d80 wallet api: add missing mining options (Jaquee)
|
|
2c468dd4 allow user I/O in millinero, micronero, nanonero, piconero (moneromooo-monero)
|
|
d47dac9a wallet: fix insertion of pool transactions (moneromooo-monero)
|
|
7a44f38a Add support for the wallet to refresh pruned blocks (moneromooo-monero)
da18898f ringct: do not require range proof in decodeRct/decodeRctSimple (moneromooo-monero)
b49c6ab4 rpc: add a default category for daemon rpc (moneromooo-monero)
f113b92b core: add functions to serialize base tx info (moneromooo-monero)
6fd4b827 node_rpc_proxy: allow caching daemon RPC version (moneromooo-monero)
b5c74e40 wallet: invalidate node proxy cache when reconnecting (moneromooo-monero)
|
|
b8a08f19 wallet: fix --log-file not working (moneromooo-monero)
|
|
53105743 Wallet API: Add support for daemon rpc login (Jaquee)
|
|
|
|
|
|
They were inserted using payment id as key, not txid
|
|
|
|
|
|
|
|
|
|
|
|
|
|
ada6a8a2 wallet_rpc_server: new --trusted-daemon flag (moneromooo-monero)
|
|
and remove trusted_daemon fields from transfer RPCs,
it is much friendlier on users
|