Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2018-05-20 | Fix output shuffling for multisig | stoffu | 1 | -2/+2 | |
2018-05-10 | wallet2: consider 6 outputs or less to be unmixable from v7 | moneromooo-monero | 1 | -2/+2 | |
2018-05-04 | Wallet API: allow log path to be non-default & console output to be configurable | stoffu | 2 | -3/+4 | |
2018-04-23 | wallet2: add missing parameters to get_output_histogram | moneromooo-monero | 1 | -0/+3 | |
2018-04-21 | import_multisig_info: fix sanity check crash in detach_blockchain | Mikhail Mitkevichl | 1 | -1/+6 | |
2018-04-19 | wallet2: increase rpc timeout for get_output_distribution | moneromooo-monero | 1 | -1/+1 | |
2018-04-19 | add top height to get_output_distribution, and cache it for rct | moneromooo-monero | 1 | -0/+2 | |
This should cache the vast majority of calls for long running wallets | |||||
2018-04-12 | wallet2: store subaddress lookahead settings | stoffu | 1 | -0/+12 | |
2018-04-12 | Use 'boost' mutex instead of 'std' mutex | cslashm | 1 | -4/+4 | |
2018-04-12 | Fix sub-address tx scan. | cslashm | 1 | -3/+3 | |
When additional keys was needed, the TX scan failed because the derivation data was always recomputed with the main tx_key and not the corresponding additional one. Moreover this patch avoid perf decreasing when not using HW device. | |||||
2018-04-12 | wallet2: fix misc issues when the ringdb can't be initialized | moneromooo-monero | 1 | -9/+9 | |
2018-04-07 | wallet2: request transactions in slices when scanning for known rings | moneromooo-monero | 1 | -22/+32 | |
This avoid massive memory consumption for huge wallets | |||||
2018-04-07 | rpc: allow getting pruned blocks from gettransactions | moneromooo-monero | 1 | -0/+13 | |
and get them pruned in find_and_save_rings, since it does not need the pruned data in the first place. Also set decode_to_json to false where missing, we don't need this either. | |||||
2018-04-07 | WalletManagerImpl: reuse existing connection to daemon instead of ↵ | stoffu | 3 | -39/+35 | |
reconnectivng every time | |||||
2018-04-05 | wallet2: move segregation height to v7 | moneromooo-monero | 1 | -1/+1 | |
since people seem to really want to use things the wrong way. | |||||
2018-03-31 | Add the possibility to export private view key for fast scan. | cslashm | 1 | -11/+44 | |
On client startup the device asks for authorization to export the private view key. If user agree, the client hold the private view key allowing a fast blockchain scan. If the user does not agree, the blockchain scan is fully done via the device. | |||||
2018-03-31 | wallet: warn if not using the default ring size | moneromooo-monero | 2 | -0/+10 | |
2018-03-28 | wallet: fix default mixin (4 -> 6) | sneurlax | 1 | -1/+1 | |
2018-03-27 | fix lambda compile error on openbsd | moneromooo-monero | 1 | -1/+1 | |
2018-03-22 | wallet2: set from_height of GET_OUTPUT_DISTRIBUTION correctly | stoffu | 1 | -1/+1 | |
The previous expression req_t.from_height = X ? Y >= Z : 0; forces the parameter to take the value of either 0 or 1. | |||||
2018-03-22 | wallet2: enable the mitigation only after the fork height | stoffu | 1 | -4/+5 | |
2018-03-22 | wallet2: fix for loading settings of key reuse mitigation | stoffu | 1 | -0/+9 | |
2018-03-21 | wallet: catch exceptions dealing with ringdb and warn | moneromooo-monero | 2 | -20/+45 | |
2018-03-17 | wallet: make the segregation height settable | moneromooo-monero | 2 | -8/+63 | |
via user setting first, then DNS TXT record, hardcoded fallback | |||||
2018-03-17 | wallet_rpc_server: add sweep_unmixable as alias for sweep_dust | moneromooo-monero | 1 | -0/+1 | |
2018-03-16 | Add command line option allowing to restrict the default sub-address ↵ | stoffu | 1 | -0/+1 | |
lookahead in order to avoid so looooong time of set-up when creating a HW based wallet. | |||||
2018-03-16 | wallet: more user friendly print_ring | moneromooo-monero | 5 | -5/+78 | |
It can now take a txid (to display rings for all its inputs), and will print rings in a format that set_ring understands | |||||
2018-03-16 | wallet2_api: add key reuse mitigations API | moneromooo-monero | 3 | -0/+27 | |
2018-03-16 | wallet2_api: add ring api | moneromooo-monero | 3 | -0/+46 | |
2018-03-16 | ringdb: factor ring addition code | moneromooo-monero | 1 | -22/+16 | |
2018-03-16 | wallet2_api: add blackball api | moneromooo-monero | 4 | -0/+65 | |
2018-03-16 | ringdb: use the genesis block as a db name | moneromooo-monero | 3 | -5/+7 | |
This will avoid careless forkers polluting the shared database even if they make their own chain. They'll then automatically start using another subdb, and any key-reusing fork of those forks will reuse their subdbs. | |||||
2018-03-16 | wallet: add a set_ring command | moneromooo-monero | 4 | -0/+43 | |
This is so one can set rings for spent key images in case the attackers don't merge the ring matching patch set. | |||||
2018-03-16 | wallet: make ringdb an object with database state | moneromooo-monero | 4 | -164/+179 | |
2018-03-16 | wallet: add an output blackball list to avoid using those in rings | moneromooo-monero | 4 | -8/+153 | |
2018-03-16 | wallet: key reuse mitigation options | moneromooo-monero | 2 | -15/+172 | |
If a pre-fork output is spent on both Monero and attack chain, any post-fork output can be deduced to be a fake output, thereby decreasing the effective ring size. The segregate-per-fork-outputs option, on by default, allows selecting only pre-fork outputs in this case, so that the same ring can be used when spending it on the other side, which does not decrease the effective ring size. This is intended to be SET when intending to spend Monero on the attack fork, and to be UNSET if not intending to spend Monero on the attack fork (since it leaks the fact that the output being spent is pre-fork). If the user is not certain yet whether they will spend pre-fork outputs on a key reusing fork, the key-reuse-mitigation2 option should be SET instead. If you use this option and intend to spend Monero on both forks, then spend real Monero first. | |||||
2018-03-16 | wallet: add shared ring database | moneromooo-monero | 6 | -7/+638 | |
This maps key images to rings, so that different forks can reuse the rings by key image. This avoids revealing the real inputs like would happen if two forks spent the same outputs with different rings. This database is meant to be shared with all Monero forks which don't bother making a new chain, putting users' privacy at risk in the process. It is placed in a shared data directory by default ($HOME/.shared-ringdb on UNIX like systems). You may use --shared-ringdb-dir to override this location, and should then do so for all Monero forks for them to share the database. | |||||
2018-03-16 | add RPC to get a histogram of outputs of a given amount | moneromooo-monero | 3 | -0/+76 | |
2018-03-15 | Fix typos in various files | Dimitris Apostolou | 3 | -6/+6 | |
2018-03-15 | wallet2+cli+rpc: eliminate redundant m_http_client from cli/rpc and delegate ↵ | stoffu | 3 | -6/+22 | |
calls to wallet2 | |||||
2018-03-14 | replace invoke_http_json("/json_rpc",...) with ↵ | stoffu | 2 | -146/+104 | |
invoke_http_json_rpc("/json_rpc",methodname,...) to reduce boilerplate | |||||
2018-03-14 | wallet2: check_tx_key() shouldn't require hardware encryption | stoffu | 1 | -2/+2 | |
2018-03-14 | device: untangle cyclic depenency | stoffu | 3 | -21/+20 | |
When #3303 was merged, a cyclic dependency chain was generated: libdevice <- libcncrypto <- libringct <- libdevice This was because libdevice needs access to a set of basic crypto operations implemented in libringct such as scalarmultBase(), while libringct also needs access to abstracted crypto operations implemented in libdevice such as ecdhEncode(). To untangle this cyclic dependency chain, this patch splits libringct into libringct_basic and libringct, where the basic crypto ops previously in libringct are moved into libringct_basic. The cyclic dependency is now resolved thanks to this separation: libcncrypto <- libringct_basic <- libdevice <- libcryptonote_basic <- libringct This eliminates the need for crypto_device.cpp and rctOps_device.cpp. Also, many abstracted interfaces of hw::device such as encrypt_payment_id() and get_subaddress_secret_key() were previously implemented in libcryptonote_basic (cryptonote_format_utils.cpp) and were then called from hw::core::device_default, which is odd because libdevice is supposed to be independent of libcryptonote_basic. Therefore, those functions were moved to device_default.cpp. | |||||
2018-03-14 | device: made function prototypes consistent with pre-#3303 codebase | stoffu | 1 | -6/+2 | |
2018-03-14 | wallet2: guard against overflowing of subaddress indices | moneromooo-monero | 1 | -3/+14 | |
2018-03-14 | wallet2: fix use_fork_rules() when querying version that is defined but not ↵ | stoffu | 1 | -1/+1 | |
enabled yet | |||||
2018-03-14 | wallet: fix auto low priority so that it takes effect only when saved ↵ | stoffu | 1 | -1/+1 | |
default is 0 | |||||
2018-03-12 | Ledger HW Bug fixes | Cédric | 1 | -43/+59 | |
Fix the way the REAL mode is handle: Let create_transactions_2 and create_transactions_from construct the vector of transactions. Then iterate on it and resign. We just need to add 'outs' list in the TX struct for that. Fix default secret keys value when DEBUG_HWDEVICE mode is off The magic value (00...00 for view key and FF..FF for spend key) was not correctly set when DEBUG_HWDEVICE was off. Both was set to 00...00. Add sub-address info in ABP map in order to correctly display destination sub-address on device Fix DEBUG_HWDEVICE mode: - Fix compilation errors. - Fix control device init in ledger device. - Add more log. Fix sub addr control Fix debug Info | |||||
2018-03-11 | wallet2: handle no blocks returned in refresh to mean no new blocks | moneromooo-monero | 1 | -0/+5 | |
This is not a possible return from the daemon, but I want this in now so all wallets handle this when the daemon starts doing so. | |||||
2018-03-11 | node_rpc_proxy: fix target height caching | moneromooo-monero | 1 | -1/+1 | |
2018-03-10 | wallet2 / simplewallet: Must opt-in to create '.address.txt' files for new ↵ | Leon Klingele | 2 | -44/+72 | |
wallets Previously, a file containing the unencrypted Monero address was created by default in the wallet's directory. This file might pose as a privacy risk. The creation of this file is now opt-in and can be enabled by providing --create-address-file | |||||
2018-03-09 | fix error message typo in wallet2.cpp | cryptochangements34 | 1 | -1/+1 | |
2018-03-07 | wallet: fixes and tweaks to the save_watch_only command | moneromooo-monero | 2 | -7/+7 | |
- save the new keys file as FOO-watchonly.keys, not FOO.keys-watchonly - catch any exception (eg, I/O errors) and error out - print the new keys filename in simplewallet | |||||
2018-03-07 | Bump min ring size from 5 to 7 from v7 | moneromooo-monero | 1 | -1/+5 | |
2018-03-07 | Wallet API: corrected testnet/mainnet ordering | stoffu | 1 | -1/+1 | |
2018-03-06 | Wallet API: make nettype non-defaulted to disambiguate from deprecated ↵ | stoffu | 1 | -3/+3 | |
versions (and make libwallet_api_tests compilable) | |||||
2018-03-06 | libwallet_merged: added missing libdevice | stoffu | 1 | -0/+1 | |
2018-03-05 | Make mixin optional with default for rpc transfer | cryptochangements34 | 1 | -4/+4 | |
2018-03-05 | Correct spelling mistakes. | Edward Betts | 3 | -10/+10 | |
2018-03-05 | allow using ring size instead of mixin for rpc transfer | cryptochangements34 | 2 | -4/+44 | |
2018-03-05 | Wallet API: generalize 'bool testnet' to 'NetworkType nettype' | stoffu | 5 | -42/+103 | |
2018-03-05 | wallet_manager: fixed typo deviuce/device.hpp | stoffu | 1 | -1/+1 | |
2018-03-05 | Stagenet | stoffu | 9 | -99/+123 | |
2018-03-04 | wallet2_api: add info/error/warning entry points | moneromooo-monero | 2 | -3/+18 | |
2018-03-04 | Code modifications to integrate Ledger HW device into monero-wallet-cli. | cslashm | 3 | -92/+182 | |
The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device. | |||||
2018-02-25 | wallet api: when restoring from EnglishOld, set language to English | stoffu | 1 | -0/+4 | |
2018-02-25 | Wallet2 + CLI wallet: UTF-8 support for filenames and paths under Windows | rbrunner7 | 2 | -0/+22 | |
2018-02-16 | wallet2: remove unused m_subaddresses_inv | moneromooo-monero | 2 | -6/+2 | |
2018-02-16 | wallet2: speed up subaddress generation (by about a third) | moneromooo-monero | 2 | -16/+16 | |
2018-02-16 | Fix refresh height estimation | Howard Chu | 1 | -13/+16 | |
Since commit b0426d4c refresh height for a newly created wallet connected to a sync'd daemon was off by a month. Now we only use the 1 month safety margin if we're unable to talk to a daemon. | |||||
2018-02-13 | wallet2: fix auto_low_priority field name typo on load | moneromooo-monero | 1 | -2/+2 | |
2018-02-12 | wallet2: don't store invalid key image when watch-only | stoffu | 1 | -1/+1 | |
2018-02-10 | wallet2: don't throw when spent amount is inconsistent | stoffu | 1 | -4/+14 | |
2018-02-08 | wallet: suggest the use of sweep_unmixable when not_enough_outs_to_mix is thrown | stoffu | 2 | -1/+2 | |
2018-02-05 | Add default value to max_height, otherwise it's 0 | Michał Sałaban | 2 | -3/+5 | |
2018-01-31 | wallets: reorg 61 more days on testnet | moneromooo-monero | 1 | -2/+3 | |
2018-01-31 | blockchain: move bulletproofs to v8 | moneromooo-monero | 1 | -7/+4 | |
and set v7 height to 1057027 on testnet (one block earlier) This is to easily dump current nodes since we're going to change the v7 rules with this. | |||||
2018-01-31 | wallet-rpc: take subaddress account as arg for get_transfer_by_txid | stoffu | 2 | -4/+13 | |
2018-01-31 | wallet-rpc: rename *_INDEX_OUTOFBOUND into *_INDEX_OUT_OF_BOUNDS | stoffu | 2 | -4/+4 | |
2018-01-29 | Fixed typos and wording tweaks | Maxithi | 4 | -13/+13 | |
2018-01-29 | Return appropriate error code when there's no connection to daemon | Michał Sałaban | 2 | -0/+6 | |
2018-01-28 | Return appropriate error code when not enough money for tx | Michał Sałaban | 2 | -0/+6 | |
2018-01-28 | wallet: automatically use low priority if safe (no backlog & recent blocks ↵ | stoffu | 5 | -6/+108 | |
not full) | |||||
2018-01-28 | wallet2: split estimate_backlog to allow for raw fee levels | moneromooo-monero | 2 | -9/+27 | |
2018-01-26 | Readd copyright starting date | xmr-eric | 6 | -6/+6 | |
2018-01-26 | Update 2018 copyright | xmr-eric | 33 | -33/+33 | |
2018-01-26 | Wallet API: remove unused enum Priority from UnsignedTransaction | stoffu | 1 | -7/+0 | |
2018-01-26 | wallet2: remove {set|get}_default_decimal_point and use the same funcs under ↵ | stoffu | 2 | -12/+0 | |
cryptonote:: instead | |||||
2018-01-26 | wallet2: make scan_output const and omit keys arg | stoffu | 2 | -6/+6 | |
2018-01-26 | wallet2: make member functions const when possible | stoffu | 2 | -35/+35 | |
2018-01-26 | wallet rpc: show fees when querying incoming transfers | stoffu | 3 | -4/+15 | |
2018-01-26 | simplewallet: check file overwrite when exporting stuff | stoffu | 2 | -0/+10 | |
2018-01-24 | wallet-cli: Do not ask for scan_from_height if it explicitly is set to zero. | Maximilian Lupke | 2 | -0/+8 | |
Fixes #3080 | |||||
2018-01-17 | Wallet API: all recover options with password | m2049r | 5 | -12/+110 | |
also renamed memo => mnemonic in api method parms | |||||
2018-01-15 | wallet2: fix sweep_all sending an atomic unit | moneromooo-monero | 1 | -2/+2 | |
2018-01-14 | cmake: set API header install path to what Qt wallet expects | redfish | 1 | -1/+1 | |
2018-01-14 | wallet2::import_blockchain fix import loop | Jaquee | 1 | -1/+1 | |
2018-01-14 | Allow retrieving spend key via RPC | Michał Sałaban | 1 | -0/+4 | |
2018-01-10 | Reserve proof | stoffu | 8 | -0/+464 | |
2018-01-10 | move memwipe to epee to avoid common<->crypto circular dependencies | moneromooo-monero | 1 | -1/+1 | |
2018-01-10 | epee: remove dependency on common | moneromooo-monero | 1 | -1/+2 | |
2018-01-09 | Improved terminology from create to generate | Maxithi | 1 | -1/+1 | |
2018-01-06 | Implement #3045, fixing RPC snakecases | Nick Johnson | 1 | -0/+3 | |
2018-01-04 | wallet2: allow failing parse_tx_extra | moneromooo-monero | 1 | -14/+7 | |
It can fail if it fails to parse extra, while still having filled the returned data with partial contents | |||||
2017-12-31 | wallet_api: make this optional but not built by default | moneromooo-monero | 2 | -2/+4 | |
It means it can still be built with make -C build/debug wallet_api but still not DoS us while debugging | |||||
2017-12-29 | wallet2 bugfix: initialize subaddress table when generating from keys | stoffu | 1 | -0/+1 | |
2017-12-28 | wallet2: std::unordered_set ctor is sometimes explicit | moneromooo-monero | 1 | -2/+2 | |
2017-12-28 | sweep_below: do not prematurely exclude subaddresses set | stoffu | 1 | -18/+29 | |
2017-12-27 | Resolve addresses in get_transfers | Michał Sałaban | 2 | -0/+6 | |
2017-12-26 | wallet-api: added Utils::onStartup | stoffu | 2 | -0/+6 | |
2017-12-25 | Revert "return subaddress in get_bulk_payments" | moneromooo-monero | 1 | -1/+0 | |
This reverts commit b60f48f0e31c17638f771042887b2fffdbad15b4. | |||||
2017-12-25 | wallet2: switch to chacha20 instead of chacha8 | moneromooo-monero | 1 | -19/+36 | |
Wallet caches and keys files are loaded with chacha8 as needed, but only saved with chacha20. Other data (eg, cold wallet data files, etc) will be incompatible. | |||||
2017-12-25 | Add a chacha20 variant to go with chacha8 | moneromooo-monero | 2 | -25/+25 | |
2017-12-24 | wallet2: guard against the dameon sending blocks before last checkpoint | moneromooo-monero | 1 | -0/+5 | |
2017-12-24 | wallet_rpc_server: fix wallet leak on error exit | moneromooo-monero | 1 | -0/+2 | |
Makes it easier to debug leaks | |||||
2017-12-22 | factor STL container serialization | moneromooo-monero | 1 | -0/+1 | |
2017-12-21 | wallet2: fix failure to create tx if inputs are not enough for fee | moneromooo-monero | 1 | -0/+12 | |
2017-12-20 | wallet2: fix m_key_image_{partial,known} in_light_wallet code | moneromooo-monero | 1 | -1/+2 | |
2017-12-20 | wallet: support for multisig seeds | moneromooo-monero | 3 | -0/+176 | |
They are hex rather than words, because they are a lot longer than "normal" seeds, as they have to embed a lot more information | |||||
2017-12-20 | wallet_rpc_server: factor transfer info return and add missing info | moneromooo-monero | 3 | -303/+118 | |
Additional tx keys, amounts and fees were missing in some cases | |||||
2017-12-19 | wallet2: fix use of uninitialized data | moneromooo-monero | 1 | -0/+1 | |
2017-12-18 | use const refs in for loops for non tiny types | moneromooo-monero | 1 | -1/+1 | |
2017-12-18 | check accessing an element past the end of a container | moneromooo-monero | 4 | -7/+30 | |
2017-12-18 | check return value for generate_key_derivation and derive_public_key | moneromooo-monero | 1 | -7/+14 | |
2017-12-18 | add empty container sanity checks when using front() and back() | moneromooo-monero | 2 | -0/+8 | |
2017-12-18 | wallet-rpc: added receiving address to res of get(_bulk)_payments; selective ↵ | stoffu | 2 | -4/+22 | |
addresses for getaddress | |||||
2017-12-18 | Account tagging | stoffu | 5 | -1/+235 | |
2017-12-17 | change the N-1/N multisig second message signer for auth | moneromooo-monero | 1 | -10/+9 | |
2017-12-17 | wallet: factor multisig info parsing | moneromooo-monero | 3 | -50/+63 | |
2017-12-17 | wallet: use raw encrypted data in multisig import/export RPC | moneromooo-monero | 4 | -87/+69 | |
2017-12-17 | wallet: add multisig sign/submit RPC | moneromooo-monero | 6 | -108/+465 | |
2017-12-17 | Match surae's recommendation to derive multisig keys | moneromooo-monero | 2 | -18/+19 | |
2017-12-17 | wallet2: fix slow multisig unit tests with subaddress patch | moneromooo-monero | 2 | -8/+47 | |
While there, move the wallet2 ctor to the cpp file as it's a huge amount of init list now, and remove an unused one. | |||||
2017-12-17 | make multisig work with subaddresses | moneromooo-monero | 2 | -30/+13 | |
Thanks to kenshi84 for help getting this work | |||||
2017-12-17 | wallet: guard against partly initialized multisig wallet | moneromooo-monero | 4 | -6/+31 | |
2017-12-17 | add multisig core test and factor multisig building blocks | moneromooo-monero | 4 | -98/+45 | |
2017-12-17 | N-1/N multisig | moneromooo-monero | 5 | -118/+707 | |
2017-12-17 | multisig address generation RPC | moneromooo-monero | 6 | -6/+400 | |
2017-12-17 | gen_multisig: generates multisig wallets if participants trust each other | moneromooo-monero | 4 | -2/+6 | |
2017-12-17 | wallet2: allow empty wallet filename to avoid saving data | moneromooo-monero | 1 | -29/+57 | |
Useful to speed tests up and avoid unnecessary leftover files | |||||
2017-12-17 | Add N/N multisig tx generation and signing | moneromooo-monero | 8 | -73/+634 | |
Scheme by luigi1111: Multisig for RingCT on Monero 2 of 2 User A (coordinator): Spendkey b,B Viewkey a,A (shared) User B: Spendkey c,C Viewkey a,A (shared) Public Address: C+B, A Both have their own watch only wallet via C+B, a A will coordinate spending process (though B could easily as well, coordinator is more needed for more participants) A and B watch for incoming outputs B creates "half" key images for discovered output D: I2_D = (Hs(aR)+c) * Hp(D) B also creates 1.5 random keypairs (one scalar and 2 pubkeys; one on base G and one on base Hp(D)) for each output, storing the scalar(k) (linked to D), and sending the pubkeys with I2_D. A also creates "half" key images: I1_D = (Hs(aR)+b) * Hp(D) Then I_D = I1_D + I2_D Having I_D allows A to check spent status of course, but more importantly allows A to actually build a transaction prefix (and thus transaction). A builds the transaction until most of the way through MLSAG_Gen, adding the 2 pubkeys (per input) provided with I2_D to his own generated ones where they are needed (secret row L, R). At this point, A has a mostly completed transaction (but with an invalid/incomplete signature). A sends over the tx and includes r, which allows B (with the recipient's address) to verify the destination and amount (by reconstructing the stealth address and decoding ecdhInfo). B then finishes the signature by computing ss[secret_index][0] = ss[secret_index][0] + k - cc[secret_index]*c (secret indices need to be passed as well). B can then broadcast the tx, or send it back to A for broadcasting. Once B has completed the signing (and verified the tx to be valid), he can add the full I_D to his cache, allowing him to verify spent status as well. NOTE: A and B *must* present key A and B to each other with a valid signature proving they know a and b respectively. Otherwise, trickery like the following becomes possible: A creates viewkey a,A, spendkey b,B, and sends a,A,B to B. B creates a fake key C = zG - B. B sends C back to A. The combined spendkey C+B then equals zG, allowing B to spend funds at any time! The signature fixes this, because B does not know a c corresponding to C (and thus can't produce a signature). 2 of 3 User A (coordinator) Shared viewkey a,A "spendkey" j,J User B "spendkey" k,K User C "spendkey" m,M A collects K and M from B and C B collects J and M from A and C C collects J and K from A and B A computes N = nG, n = Hs(jK) A computes O = oG, o = Hs(jM) B anc C compute P = pG, p = Hs(kM) || Hs(mK) B and C can also compute N and O respectively if they wish to be able to coordinate Address: N+O+P, A The rest follows as above. The coordinator possesses 2 of 3 needed keys; he can get the other needed part of the signature/key images from either of the other two. Alternatively, if secure communication exists between parties: A gives j to B B gives k to C C gives m to A Address: J+K+M, A 3 of 3 Identical to 2 of 2, except the coordinator must collect the key images from both of the others. The transaction must also be passed an additional hop: A -> B -> C (or A -> C -> B), who can then broadcast it or send it back to A. N-1 of N Generally the same as 2 of 3, except participants need to be arranged in a ring to pass their keys around (using either the secure or insecure method). For example (ignoring viewkey so letters line up): [4 of 5] User: spendkey A: a B: b C: c D: d E: e a -> B, b -> C, c -> D, d -> E, e -> A Order of signing does not matter, it just must reach n-1 users. A "remaining keys" list must be passed around with the transaction so the signers know if they should use 1 or both keys. Collecting key image parts becomes a little messy, but basically every wallet sends over both of their parts with a tag for each. Thia way the coordinating wallet can keep track of which images have been added and which wallet they come from. Reasoning: 1. The key images must be added only once (coordinator will get key images for key a from both A and B, he must add only one to get the proper key actual key image) 2. The coordinator must keep track of which helper pubkeys came from which wallet (discussed in 2 of 2 section). The coordinator must choose only one set to use, then include his choice in the "remaining keys" list so the other wallets know which of their keys to use. You can generalize it further to N-2 of N or even M of N, but I'm not sure there's legitimate demand to justify the complexity. It might also be straightforward enough to support with minimal changes from N-1 format. You basically just give each user additional keys for each additional "-1" you desire. N-2 would be 3 keys per user, N-3 4 keys, etc. The process is somewhat cumbersome: To create a N/N multisig wallet: - each participant creates a normal wallet - each participant runs "prepare_multisig", and sends the resulting string to every other participant - each participant runs "make_multisig N A B C D...", with N being the threshold and A B C D... being the strings received from other participants (the threshold must currently equal N) As txes are received, participants' wallets will need to synchronize so that those new outputs may be spent: - each participant runs "export_multisig FILENAME", and sends the FILENAME file to every other participant - each participant runs "import_multisig A B C D...", with A B C D... being the filenames received from other participants Then, a transaction may be initiated: - one of the participants runs "transfer ADDRESS AMOUNT" - this partly signed transaction will be written to the "multisig_monero_tx" file - the initiator sends this file to another participant - that other participant runs "sign_multisig multisig_monero_tx" - the resulting transaction is written to the "multisig_monero_tx" file again - if the threshold was not reached, the file must be sent to another participant, until enough have signed - the last participant to sign runs "submit_multisig multisig_monero_tx" to relay the transaction to the Monero network | |||||
2017-12-17 | wallet: add multisig key generation | moneromooo-monero | 2 | -5/+180 | |
Scheme by luigi1111 | |||||
2017-12-16 | Wallets now do not depend on the daemon rpc lib | moneromooo-monero | 1 | -1/+1 | |
The shared RPC code is now moved off into a separate lib | |||||
2017-12-16 | move includes around to lessen overall load | moneromooo-monero | 3 | -4/+6 | |
2017-12-16 | Scrub keys from memory just before scope end. | moneromooo-monero | 1 | -5/+5 | |
Partially implements #74. Securely erases keys from memory after they are no longer needed. Might have a performance impact, which I haven't measured (perf measurements aren't generally reliable on laptops). Thanks to @stoffu for the suggestion to specialize the pod_to_hex/hex_to_pod functions. Using overloads + SFINAE instead generalizes it so other types can be marked as scrubbed without adding more boilerplate. | |||||
2017-12-16 | wallet2: print tx size in bytes and kB | moneromooo-monero | 1 | -8/+18 | |
Helpful now that tx sizes are smaller | |||||
2017-12-16 | wallet2: reinstate the single preferred output selection | moneromooo-monero | 1 | -1/+13 | |
Removing it nullified the min-outputs-{count,value} system, and will not increase the number of attempted transactions in the general case. | |||||
2017-12-15 | wallet2: error out in get_seed if the language is invalid | moneromooo-monero | 1 | -1/+5 | |
2017-12-09 | node_rpc_proxy: remove unused local and time call | moneromooo-monero | 1 | -1/+0 | |
2017-12-08 | return subaddress in get_bulk_payments | Dmitriy Plekhanov | 1 | -0/+1 | |
2017-12-08 | add bulletproofs from v7 on testnet | moneromooo-monero | 2 | -8/+11 | |
2017-12-08 | integrate bulletproofs into monero | moneromooo-monero | 1 | -12/+25 | |
2017-12-07 | wallet2: don't write a .new file when not needed | moneromooo-monero | 1 | -8/+8 | |
2017-12-06 | wallet2: detect spends in txes without a valid public tx key | moneromooo-monero | 1 | -1/+1 | |
2017-12-04 | catch wallet decrypt false positive | Riccardo Spagni | 1 | -1/+6 | |
2017-11-27 | new wipeable_string class to replace std::string passphrases | moneromooo-monero | 3 | -29/+30 | |
2017-11-24 | wallet_rpc_server: new relay_tx command | moneromooo-monero | 4 | -0/+72 | |
It takes a full tx+metadata hex string as input | |||||
2017-11-24 | wallet: transfer RPC can now return tx metadata (pending_tx) | moneromooo-monero | 3 | -3/+86 | |
2017-11-21 | wallet2: detect multiple outputs from a tx to different subaddresses | moneromooo-monero | 1 | -1/+1 | |
2017-11-21 | Spend proof without txkey | stoffu | 8 | -0/+384 | |
2017-11-21 | fix for tx proof: use exception instead of error_str when signature gen failed | stoffu | 6 | -23/+9 | |
2017-11-18 | Tx proof (revised): | stoffu | 11 | -171/+770 | |
- refactoring: proof generation/checking code was moved from simplewallet.cpp to wallet2.cpp - allow an arbitrary message to be signed together with txid - introduce two types (outbound & inbound) of tx proofs; with the same syntax, inbound is selected when <address> belongs to this wallet, outbound otherwise. see GitHub thread for more discussion - wallet RPC: added get_tx_key, check_tx_key, get_tx_proof, check_tx_proof - wallet API: moved WalletManagerImpl::checkPayment to Wallet::checkTxKey, added Wallet::getTxProof/checkTxProof - get_tx_key/check_tx_key: handle additional tx keys by concatenating them into a single string | |||||
2017-11-17 | Fixes #759 Add sanity check on restore height | Cifrado | 2 | -20/+34 | |
2017-11-16 | split wallet and wallet_api | moneromooo-monero | 13 | -39/+102 | |
This speeds up building a lot when wallet2.h (or something it includes) changes, since all the API includes wallet2.h | |||||
2017-11-16 | wallet2: check generate_key_derivation return value | moneromooo-monero | 1 | -2/+11 | |
2017-11-16 | daemon & simplewallet: don't set max-concurrency when unspecified | stoffu | 1 | -1/+1 | |
2017-11-15 | Wallet RPC: Add prompt-for-password flag | Tim L | 2 | -5/+10 | |
2017-11-15 | wallet2: minimize the number of construct_tx calls | moneromooo-monero | 1 | -95/+90 | |
2017-11-15 | wallet2: cleanup some debug logs | moneromooo-monero | 1 | -7/+4 | |
2017-11-15 | Add out-of-bound exceptions and handle them in RPC | Michał Sałaban | 3 | -27/+47 | |
2017-11-15 | simplewallet: wrong ns for input_line in sweep_single (fix #2634) | stoffu | 2 | -2/+1 | |
2017-11-15 | wallet: add sweep_single command | stoffu | 5 | -0/+167 | |
2017-11-15 | wallet2 bugfix: loading old m_unconfirmed_payments | stoffu | 1 | -3/+2 | |
2017-11-14 | More missed readline dependencies thru scoped_message_writer | Howard Chu | 2 | -5/+2 | |
2017-11-14 | Fix 437421ce42f1deaa7ec3f28c0c17aff519f1230d | Howard Chu | 1 | -1/+1 | |
Missing an error argument for an exception | |||||
2017-11-14 | CMake: include RPC when building GUI deps | anonimal | 1 | -33/+30 | |
2017-11-14 | wallet2: avoid growing the short history when refreshing in a loop | moneromooo-monero | 1 | -10/+17 | |
2017-11-14 | Do not build against epee_readline if it was not built | Howard Chu | 1 | -1/+1 | |
2017-11-14 | split off readline code into epee_readline | moneromooo-monero | 1 | -0/+1 | |
2017-11-14 | wallet: move some scoped_message_writer calls from the libs | moneromooo-monero | 5 | -85/+76 | |
2017-11-14 | wallet: rejig to avoid prompting in wallet2 | moneromooo-monero | 3 | -40/+37 | |
wallet2 is a library, and should not prompt for stdin. Instead, pass a function so simplewallet can prompt on stdin, and a GUI might display a window, etc. | |||||
2017-11-14 | remove "using namespace std" from headers | moneromooo-monero | 1 | -0/+2 | |
It's nasty, and actually breaks on Solaris, where if.h fails to build due to: struct map *if_memmap; | |||||
2017-11-14 | wallet2: simplify incoming tx processing code | moneromooo-monero | 1 | -42/+19 | |
2017-11-14 | simplewallet: reject attempts to use too low mixin early | moneromooo-monero | 3 | -16/+17 | |
This yields a clear error message rather then some possibly confusing more technical errors down the line | |||||
2017-11-14 | Fix false GCC warning '‘*((void*)& subaddr_account +4)’ may be used ↵ | binaryFate | 1 | -1/+3 | |
unitialized' | |||||
2017-11-14 | wallet-cli: added --generate-from-spend-key option | stoffu | 1 | -2/+11 | |
2017-11-13 | wallet2: use a vector, not a list, for selected_transfers | moneromooo-monero | 2 | -24/+49 | |
Friendlier on memory/speed, we know in advance the max amount of items, which are small and constant size, and there's a lot of list walking involved. | |||||
2017-11-13 | wallet2: only add a dummy 0 output if there's one output otherwise | moneromooo-monero | 1 | -10/+14 | |
2017-11-08 | Correct totals computation | Michał Sałaban | 1 | -13/+12 | |
2017-11-07 | wallet2: typo fix in error message | moneromooo-monero | 1 | -1/+1 | |
2017-11-06 | wallet2 bugfix: supply missing subaddr_account arg to balance() and unlocked ↵ | stoffu | 1 | -4/+4 | |
balance() | |||||
2017-11-06 | track double spending in the txpool | moneromooo-monero | 6 | -40/+94 | |
Transactions in the txpool are marked when another transaction is seen double spending one or more of its inputs. This is then exposed wherever appropriate. Note that being marked with this "double spend seen" flag does NOT mean this transaction IS a double spend and will never be mined: it just means that the network has seen at least another transaction spending at least one of the same inputs, so care should be taken to wait for a few confirmations before acting upon that transaction (ie, mostly of use for merchants wanting to accept unconfirmed transactions). | |||||
2017-11-03 | Fix file permission issue | Tim L | 1 | -0/+0 | |
This branch fixes a file permission issue introduced by https://github.com/monero-project/monero/commit/69c37200aa87f100f731e755bdca7a0dc6ae820a | |||||
2017-11-03 | Used declared default refresh status as default rather than it's current value | Maxime THIEBAUT | 1 | -2/+2 | |
2017-11-02 | Remove wallet dependency on p2p | moneromooo-monero | 1 | -1/+0 | |
2017-10-31 | wallet2: do not bother downloading block hashes below last checkpoint | moneromooo-monero | 1 | -1/+14 | |
2017-10-30 | RPC Add cross origin resource sharing support | Tim L | 1 | -1/+1 | |
2017-10-29 | Wallet2: Don't throw when subaddress label doesn't exist | Jaquee | 2 | -11/+11 | |
2017-10-29 | Wallet API: override update subdir when built from src | Jaquee | 2 | -2/+4 | |
2017-10-23 | wallet2: fix show_transfers missing multiple incoming outputs | moneromooo-monero | 1 | -2/+2 | |