aboutsummaryrefslogtreecommitdiff
path: root/src/wallet (unfollow)
AgeCommit message (Collapse)AuthorFilesLines
2018-10-02Merge pull request #4490Riccardo Spagni1-1/+1
bccd88dd wallet2: clear found out for every tx key (doy-lee)
2018-10-02Merge pull request #4484Riccardo Spagni2-9/+17
2c74b1a1 wallet_rpc_server: include all transfer records for a txid (moneromooo-monero)
2018-10-02Merge pull request #4482Riccardo Spagni3-6/+12
25e5890d wallet: fix --generate-from-json using wrong password (moneromooo-monero)
2018-10-02Merge pull request #4475Riccardo Spagni3-2/+28
6da36ea0 wallet2_api: blackball/unblackball now take two parameters (moneromooo-monero)
2018-09-29add --block-notify to monerod and --tx-notify to monero-wallet-{cli,rpc}moneromooo-monero2-0/+29
Those take a command line of the form "A [B]", with A being the name (and optional path, if not in the caller's CWD, but fully qualified path is recommended, avoids possible security issues) to a program, and optional arguments. Any occurence of the two character string "%s" will be replaced by the hash of the block or transaction which triggered the notification. Tokenization is barebones. If you want things like pipes, calls to paths with spaces, etc, then use a script (though exec time will suffer). block-notify is called when a new block is added onto the chain. tx-notify is called when a new transaction happens with the wallet as source and/or destination. It is the notification program's responsibility to determine what to do in those cases. Note that this is asynchronous, so it is very possible that: - the notification programs will be run out of order - several events happen before the notification for the first one A Windows port would be nice if someone wants to make one.
2018-09-28wallet_rpc_server: remove verbose field in incoming_transfers querymoneromooo-monero2-3/+1
The key image (which was only supplied if verbose was true) is readily available, not a secret key, and it was only modelled after the CLI command because it's a bit spammy for the CLI.
2018-09-28wallet2: fix transfers between subaddresses hitting the sanity checkmoneromooo-monero1-1/+5
Transfers between subaddresses are accounted for differently
2018-09-27wallet_rpc_server: exit cleanly on unhandled exceptionsmoneromooo-monero1-0/+3
Coverity 161868
2018-09-27use default create_address_file argumentm2049r2-3/+3
2018-09-27device: set device name correctly if key_on_device is setDusan Klinec1-2/+9
2018-09-25wallet2: fix duplicate output making it to the RPCmoneromooo-monero1-8/+33
2018-09-24wallet_rpc_server: include account index in incoming_transfers RPCmoneromooo-monero2-2/+2
2018-09-22wallet2_api: fix for latest code changesmoneromooo-monero3-3/+3
2018-09-22Wallet: use unique_ptr for WalletImpl membersoneiric2-22/+16
Use unique_ptr to manage WalletImpl internals, rather than raw pointers.
2018-09-22wallet2: handle corner case in picking fake outputsmoneromooo-monero1-3/+27
If we originally think we have enough outputs on the blockchain to pick random fake outputs, we might end up with not enough of them if enough are actually blackballed.
2018-09-22wallet_rpc_server: fix --run-as-service on Windowsmoneromooo-monero1-0/+1
Thanks iDunk for the windows testing
2018-09-21wallet_rpc_server: fix build for windowsmoneromooo-monero1-8/+17
Thanks iDunk for building patches on windows
2018-09-21WalletAPI: multisigSignData bug fixednaughtyfox1-1/+5
2018-09-20ringdb: use cursors to be a bit fastermoneromooo-monero1-7/+8
2018-09-19query backing devicem2049r7-14/+109
2018-09-18wallet: implement coin splitting for sweep_* 'outputs' optionwhythat1-3/+25
Implemented strategy splits total amount into N equal parts, where N is a specified number of outputs. If N > 1, dummy change output is NOT created. rebased by moneromooo
2018-09-18wallet: add 'outputs' option for sweep_* commandswhythat4-11/+29
'outputs' option allows to specify the number of separate outputs of smaller denomination that will be created by sweep operation. rebased by moneromooo
2018-09-17api/wallet: properly disable key encryptionstoffu3-10/+9
2018-09-17node_rpc_proxy: return a non empty error string on connection failuremoneromooo-monero1-5/+5
This makes it easier to avoid bugs on the caller side if errors are represented by non empty strings. This fixes the refresh height setting in new wallets when no daemon is running.
2018-09-16wallet2_api: bring up to latest wallet apimoneromooo-monero3-18/+38
2018-09-15add daemonizer to rpc walletjcktm2-111/+166
2018-09-14hw_device: support for multiple devices added [for review]Dusan Klinec2-2/+54
- device name is a new wallet property - full device name is now a bit more structured so we can address particular device vendor + device path. Example: 'Ledger', 'Trezor:udp', 'Trezor:udp:127.0.0.1:21324', 'Trezor:bridge:usb01'. The part before ':' identifies HW device implementation, the optional part after ':' is device path to look for. - new --hw-device parameter added to the wallet, can name the hardware device - device reconnect added
2018-09-14wallet: ask-password can now ask without encrypting the secret spend keymoneromooo-monero2-39/+48
2018-09-14remove obsolete daemon selection of fake outs and old tx constructionmoneromooo-monero4-382/+8
2018-09-12wallet: use wipeable_string in more places where a secret is usedmoneromooo-monero1-15/+24
2018-09-11wallet2: bump testnet rollback to account for coming reorgmoneromooo-monero1-1/+1
2018-09-11Check inputs to addKeys are in rangemoneromooo-monero1-0/+2
Reported by QuarksLab.
2018-09-11v8: per byte fee, pad bulletproofs, fixed 11 ring sizemoneromooo-monero8-180/+336
2018-09-11Bulletproof aggregated verification and testsmoneromooo-monero1-2/+1
Also constrains bulletproofs to simple rct, for simplicity
2018-09-11bulletproofs: add multi output bulletproofs to rctmoneromooo-monero2-14/+32
2018-09-10WalletAPI: 'hasMultisigPartialKeyImages' function addednaughtyfox3-0/+20
2018-09-10wallet2: import_multisig forward refresh exceptionnaughtyfox1-1/+6
2018-09-10record blackballs as amount/offset, and add export abilitymoneromooo-monero4-34/+44
2018-09-09wallet_rpc_server: remove some unused codemoneroexamples1-9/+0
2018-09-09ringdb: allow blackballing many outputs at oncemoneromooo-monero3-41/+60
It cuts down on txn commits, and speeds up blackballing substantially
2018-09-08wallet2: fix secondary partially signed multisig txesmoneromooo-monero1-1/+1
2018-09-08wallet_rpc_server: error out if wallet-file and wallet-dir are both usedmoneromooo-monero1-1/+6
2018-09-05wallet rpc: Add close_wallet RPCGuillaume LE VAILLANT3-0/+59
And close the current wallet automatically if necessary when opening another wallet.
2018-09-04wallet2.get_reserve_proof: throw when specified amount is zerostoffu1-0/+1
2018-09-03wallet2: factor the creation of a new wallet keys filemoneromooo-monero2-76/+27
2018-09-03wallet2: factor new blockchain setupmoneromooo-monero2-36/+18
2018-09-03wallet2: fill in v2 height for stagenetmoneromooo-monero1-1/+1
2018-09-02remove unused fields from relay_tx RPCel00ruobuob1-6/+0
2018-08-23wallet: store trusted-daemon flag in wallet2stoffu6-78/+95
2018-08-22rpc-wallet: refresh command addedDusan Klinec3-0/+47
2018-08-22wallet2: fix refresh retry when a block/tx fails to parsemoneromooo-monero1-4/+5
It would switch to a new set of blocks and fail, getting out of sync with the hash chain in the process
2018-08-22wallet2: trim hash chain after fast refresh of hashesmoneromooo-monero1-0/+1
This ensures it can't end up filled with the actual placeholders
2018-08-22wallet2: fix checking the wrong vector when adding hashesmoneromooo-monero1-1/+3
The two vectors should be the same size anyway, so add an assert to catch any case where they aren't
2018-08-19wallet2: ask for a binary output distribution, for speedmoneromooo-monero1-0/+2
2018-08-17[#4027] add change_wallet_password wallet rpc commandartyomsol3-1/+54
2018-08-16Do memwipe for critical secret keys copied to rct::keystoffu1-0/+2
2018-08-16crypto: make secret_key automatically mlockmoneromooo-monero1-1/+1
2018-08-16store secret keys encrypted where possiblemoneromooo-monero5-75/+316
The secret spend key is kept encrypted in memory, and decrypted on the fly when needed. Both spend and view secret keys are kept encrypted in a JSON field in the keys file. This avoids leaving the keys in memory due to being manipulated by the JSON I/O API.
2018-08-16wallet: wipe seed from memory where appropriatemoneromooo-monero4-20/+43
2018-08-16wallet2: make --restricted-rpc available for wallet RPC onlystoffu7-49/+47
2018-08-15wallet_rpc_server: remove unused amount_keys field in transfer RPCmoneromooo-monero1-2/+0
2018-08-13node_rpc_proxy: fix fork earliest height caching [RYO backport]fireice-uk2-2/+2
xref https://github.com/ryo-currency/ryo-currency/pull/86
2018-08-13wallet2: remove obsolete pruned/unpruned casemoneromooo-monero1-28/+1
All daemons will not support pruned blocks
2018-08-12wallet: disable core dumps on startup in release modemoneromooo-monero2-0/+6
2018-08-08wallet: allow adjusting number of rounds for the key derivation functionstoffu7-39/+59
2018-08-03wallet: distinguish coinbase from other txes in show_transfersmoneromooo-monero3-3/+13
2018-07-31wallet2: do not divide by 0 on invalid daemon responsemoneromooo-monero1-0/+1
2018-07-31wallet-rpc: add get_address_index commandstoffu5-1/+52
2018-07-31wallet-rpc: filter getbalance response by address indexstoffu2-5/+13
2018-07-30wallet2: avoid using arbitrary random values when unknownmoneromooo-monero1-4/+3
2018-07-30wallet2: guard against bad outputs in import_outputsmoneromooo-monero1-2/+4
also some minor speedup
2018-07-30simplewallet: add set_tx_key for importing tx keys from 3rd party walletsstoffu2-0/+49
2018-07-24wallet2: fix O(n^2) behaviour in import_key_imagesmoneromooo-monero1-21/+15
That takes a lot of time for even not so large wallets
2018-07-20wallet rpc: support making integrated address of given standard addressstoffu2-1/+35
2018-07-19wallet2: consider minimum fee when testing if balance is sufficientstoffu1-2/+3
2018-07-16wallet2: recover from index out of hashchain bounds errormoneromooo-monero3-5/+44
This can happen when there's a very large reorg on the daemon (ie, on testnet)
2018-07-12wallet: warn when payment IDs are usedmoneromooo-monero1-4/+2
Subaddresses are better for privacy
2018-07-08wallet2: ensure outputs are processed only oncemoneromooo-monero2-14/+18
This should be proof against any way one might get to multiple processing, such as generating the same derivation from the same pubkey, etc
2018-07-03wallet2: use a gamma distribution to pick fake outsmoneromooo-monero2-30/+115
as per "An Empirical Analysis of Linkability in the Monero Blockchain", by Miller et al.
2018-07-03wallet2: fix double counting outs if the tx pubkey is duplicatedmoneromooo-monero1-10/+24
2018-07-03wallet2: unlock keys file before calling verify_password (needed for Windows)stoffu5-10/+71
Also added notes to WalletManager::verifyWalletPassword (which afaik seems unused by anyone at the moment) regarding the need to unlock the keys file beforehand.
2018-07-03Allow fractional outputs to be ignoredstoffu2-0/+22
2018-07-02node_rpc_proxy: factor a few RPC calls using get_infomoneromooo-monero3-80/+57
Takes advantage of caching
2018-06-28remove epee from link lines where it's redundantmoneromooo-monero1-1/+0
For some reason, this confuses and kills ASAN on startup as it thinks const uint8_t ipv4_network_address::ID is defined multiple times.
2018-06-28api/wallet: add missing arg to wallet2::refresh()stoffu1-1/+1
2018-06-28Wallet API: add some missing override keywordstoffu7-165/+164
Also remove dust() from UnsignedTransactionImpl (already in PendingTransactionImpl)
2018-06-28wallet: prevent the same wallet file from being opened by multiple processesstoffu3-0/+10
2018-06-28wallet2: fix build for windows (std::max again)moneromooo-monero1-1/+1
2018-06-27wallet_rpc_server: fix build - forgot to build rpc versionmoneromooo-monero1-3/+3
2018-06-27wallet: include a suggested number of confirmations based on amountmoneromooo-monero4-3/+45
This is based on how much an attacking miner stands to lose in block rewardy by mining a private chain which double spends a payment. This is not foolproof, since mining is based on luck, and breaks down as the attacking miner nears 50% of the network hash rate, and the estimation is based on a constant block reward.
2018-06-26wallet2: cache ringdb key while refreshingmoneromooo-monero2-23/+47
Speeds up syncing with a lot of outgoing outputs as key generation runs Cryptonight.
2018-06-26threadpool: allow leaf functions to run concurrentlymoneromooo-monero1-17/+17
Decrease the number of worker threads by one to account for the fact the calling thread acts as a worker thread now
2018-06-26wallet2: remove unneeded divisionsmoneromooo-monero1-2/+2
2018-06-26wallet2: remove old blockchain size cache hackmoneromooo-monero2-16/+3
2018-06-26wallet2: speedup refreshmoneromooo-monero2-59/+258
key derivation and checking for incoming outputs are threaded in batch before adding blocks to the local blockchain. Other minor bits and bobs are also cached.
2018-06-26wallet2: avoid re-parsing blocks when refreshing in a loopmoneromooo-monero2-8/+5
2018-06-26wallet2: avoid duplicate parsing of tx extramoneromooo-monero1-9/+12
2018-06-26wallet2: remove useless device lockingmoneromooo-monero1-2/+1
2018-06-26wallet2: parse blocks in the RPC thread, not the processing threadmoneromooo-monero2-34/+51
Processing typically is the bottleneck
2018-06-26wallet2: simplify/speedup process_blocksmoneromooo-monero1-66/+17
2018-06-26wallet: don't process miner tx if we're refreshing with no-coinbasemoneromooo-monero1-1/+3
2018-06-26replace std::list with std::vector on some hot pathsmoneromooo-monero2-15/+15
also use reserve where appropriate
2018-06-26rpc: add option to skip coinbase info in get_blocks.binmoneromooo-monero1-0/+1
2018-06-26wallet2: use std::move on containers where appropriatemoneromooo-monero1-4/+4
2018-06-23wallet2: fix read buffer overflow in import_key_imagesmoneromooo-monero1-1/+1
2018-06-21rpc: add a non binary get_transaction_pool_hashes RPCmoneromooo-monero1-2/+2
2018-06-21Wallet API: add support for wallet creation from hardware devicestoffu5-1/+95
2018-06-21wallet2: lower default for subaddress lookahead when restoring with hardwarestoffu1-0/+6
2018-06-21wallet-rpc.getaddress: throw if index is out of boundstoffu1-0/+2
2018-06-19wallet2: fix double header in unsigned transfer filemoneromooo-monero1-1/+1
2018-06-15Fix RPC crashes that didn't check for an open walletHoward Chu1-0/+6
2018-06-15wallet2: fix out of sync account tag cachemoneromooo-monero1-0/+1
This would cause crashes when trying to tag an account that was just created
2018-06-13wallet: on first refresh, start off with a quantized heightmoneromooo-monero3-20/+27
for privacy reasons, so an untrusted node can't easily track wallets from IP address to IP address, etc. The granularity is 1024 blocks, which is about a day and a half.
2018-06-13mlog: --max-log-files to set the max number of rotated log filesstoffu1-1/+3
2018-06-13wallet: allow unspendable unmixable outputs to be discardedstoffu2-0/+11
2018-06-13wallet2: use decoded amount when reporting repeated output keystoffu1-5/+5
2018-06-12wallet2: use correct fee for split txesstoffu1-6/+14
2018-06-11cryptonote_config: add get_config to refactor x = testnet ? ↵stoffu1-14/+4
config::testnet::X : stagenet ? config::stagenet::X : config::X
2018-06-07wallet2: fix bulletproof cold signingmoneromooo-monero2-5/+11
Cold signing was always using Borromean range proofs, causing a larger tx, and an incorrect fee
2018-06-06wallet2: fix get_approximate_blockchain_height for stagenetstoffu1-2/+2
2018-06-06wallet: do not log by default if we're not asked to log to consolemoneromooo-monero1-0/+4
This means monero-wallet-rpc still does, but the user level program does not.
2018-06-05use deterministic viewkey if not suppliedcryptochangements341-20/+34
2018-06-03wallet-rpc: watch-only and cold wallet features addedDusan Klinec6-34/+491
- unsigned_txset, signed_txset in transfer / submit_transfer / sign_transfer - export_outputs, import_outputs Squashed commits: [f4d9f3d4] wallet-rpc: do_not_relay removed from submit_transfer [5b16a86f] wallet-rpc: review-fix - method signature changes, renaming [b7fbb10a] wallet-rpc: naming fixes (unsigned vs signed), consts renamed [8c7d2727] wallet-rpc: sign_transfer added [481d024a] wallet2: sign_tx splitted to work with strings and structs, more granular [2a474db9] wallet-rpc: wallet2::load_unsigned_tx split to load from str, file [b1e3a018] wallet-rpc: review fix, load_tx_from_str variable rename [1f6373be] wallet-rpc: review fix: save_tx_to_{str,file} [2a08eafc] wallet-rpc: review comments fixes - redundant this removed from wallet2.cpp - load_tx_from_str, load_tx_from_file [43498052] wallet-rpc: submit_transfer added [9c45d1ad] wallet-rpc: watch_only check, return unsigned_txset [62831396] wallet2: added string variants to load_tx, save_tx - analogously to save_multisig_tx - required for monero-wallet-rpc to support watch-only wallet
2018-05-31wallet2: don't ask for pruned txes yet, we still parse the entire txmoneromooo-monero1-1/+1
2018-05-31wallet: fix shared ring db pathstoffu2-6/+12
2018-05-28disable file size sanity check when loading the wallet cachemoneromooo-monero1-1/+1
2018-05-20Fix output shuffling for multisigstoffu1-2/+2
2018-05-15simple-wallet-cli: Add warnings about inaccurate balances to to watch-only ↵jcktm2-0/+9
wallet
2018-05-10wallet2: consider 6 outputs or less to be unmixable from v7moneromooo-monero1-2/+2
2018-05-06check_spend_proofitssteven1-2/+3
My intention is to mitigate #3761 by returning "bad signature", rather than throwing an error, as the error is triggered inappropriately in the case of checking a different txid than the one used to create the signature, which causes issues for monerophp: https://github.com/monero-integrations/monerophp/issues/72 & my temp fix: https://github.com/monero-integrations/monerophp/pull/74
2018-05-05add .load() to make Boost 1.67 happy with its new is_integral checkTeutone1-1/+1
2018-05-04Wallet API: allow log path to be non-default & console output to be configurablestoffu2-3/+4
2018-04-25Wallet: added methods to sign and verify arbitrary message with multisig ↵naughtyfox5-0/+113
public signer's key (libwallet & wallet api)
2018-04-23wallet2: add missing parameters to get_output_histogrammoneromooo-monero1-0/+3
2018-04-22wallet cli/rpc: terminate execution with code 0 when --help or --version is ↵stoffu3-8/+23
given
2018-04-21import_multisig_info: fix sanity check crash in detach_blockchainMikhail Mitkevichl1-1/+6
2018-04-19wallet2: increase rpc timeout for get_output_distributionmoneromooo-monero1-1/+1
2018-04-19add top height to get_output_distribution, and cache it for rctmoneromooo-monero1-0/+2
This should cache the vast majority of calls for long running wallets
2018-04-14wallet_rpc_server: add a get_version RPCmoneromooo-monero3-0/+37
2018-04-13WalletApi: publicMultisigSignerKey methodnaughtyfox3-0/+17
2018-04-12wallet2: store subaddress lookahead settingsstoffu1-0/+12
2018-04-12Use 'boost' mutex instead of 'std' mutexcslashm1-4/+4
2018-04-12Fix sub-address tx scan.cslashm1-3/+3
When additional keys was needed, the TX scan failed because the derivation data was always recomputed with the main tx_key and not the corresponding additional one. Moreover this patch avoid perf decreasing when not using HW device.
2018-04-12wallet2: fix misc issues when the ringdb can't be initializedmoneromooo-monero1-9/+9
2018-04-11unit_tests: add ringdb unit testsmoneromooo-monero2-4/+15
2018-04-07wallet2: request transactions in slices when scanning for known ringsmoneromooo-monero1-22/+32
This avoid massive memory consumption for huge wallets
2018-04-07rpc: allow getting pruned blocks from gettransactionsmoneromooo-monero1-0/+13
and get them pruned in find_and_save_rings, since it does not need the pruned data in the first place. Also set decode_to_json to false where missing, we don't need this either.
2018-04-07WalletManagerImpl: reuse existing connection to daemon instead of ↵stoffu3-39/+35
reconnectivng every time
2018-04-05wallet2: move segregation height to v7moneromooo-monero1-1/+1
since people seem to really want to use things the wrong way.
2018-03-31Add the possibility to export private view key for fast scan.cslashm1-11/+44
On client startup the device asks for authorization to export the private view key. If user agree, the client hold the private view key allowing a fast blockchain scan. If the user does not agree, the blockchain scan is fully done via the device.
2018-03-31wallet: warn if not using the default ring sizemoneromooo-monero2-0/+10
2018-03-28wallet: fix default mixin (4 -> 6)sneurlax1-1/+1
2018-03-28WalletApi: getMultisigInfo entry for gui walletsnaughtyfox7-2/+308
WalletApi: makeMultisig call introduced WalletApi: finalizeMultisig call introduced WalletApi: new calls exportMultisigImages and importMultisigImages WalletApi: method to return multisig wallet creation state WalletApi: create multisig transaction, sign multisig transaction, commit transaction and get multisig data are added WalletApi: identation and style fixes
2018-03-28Refactored: work with wallet api statuses to make setting and getting ↵naughtyfox3-255/+175
operations atomic along with error strings WalletApi: added method statusWithErrorString to atomically retrieve error with error string
2018-03-27fix lambda compile error on openbsdmoneromooo-monero1-1/+1
2018-03-22wallet2: set from_height of GET_OUTPUT_DISTRIBUTION correctlystoffu1-1/+1
The previous expression req_t.from_height = X ? Y >= Z : 0; forces the parameter to take the value of either 0 or 1.
2018-03-22wallet2: enable the mitigation only after the fork heightstoffu1-4/+5
2018-03-22wallet2: fix for loading settings of key reuse mitigationstoffu1-0/+9
2018-03-21wallet: catch exceptions dealing with ringdb and warnmoneromooo-monero2-20/+45
2018-03-17wallet: make the segregation height settablemoneromooo-monero2-8/+63
via user setting first, then DNS TXT record, hardcoded fallback
2018-03-17wallet_rpc_server: add sweep_unmixable as alias for sweep_dustmoneromooo-monero1-0/+1
2018-03-16Add command line option allowing to restrict the default sub-address ↵stoffu1-0/+1
lookahead in order to avoid so looooong time of set-up when creating a HW based wallet.
2018-03-16wallet: more user friendly print_ringmoneromooo-monero5-5/+78
It can now take a txid (to display rings for all its inputs), and will print rings in a format that set_ring understands
2018-03-16wallet2_api: add key reuse mitigations APImoneromooo-monero3-0/+27
2018-03-16wallet2_api: add ring apimoneromooo-monero3-0/+46
2018-03-16ringdb: factor ring addition codemoneromooo-monero1-22/+16
2018-03-16wallet2_api: add blackball apimoneromooo-monero4-0/+65
2018-03-16ringdb: use the genesis block as a db namemoneromooo-monero3-5/+7
This will avoid careless forkers polluting the shared database even if they make their own chain. They'll then automatically start using another subdb, and any key-reusing fork of those forks will reuse their subdbs.
2018-03-16wallet: add a set_ring commandmoneromooo-monero4-0/+43
This is so one can set rings for spent key images in case the attackers don't merge the ring matching patch set.
2018-03-16wallet: make ringdb an object with database statemoneromooo-monero4-164/+179
2018-03-16wallet: add an output blackball list to avoid using those in ringsmoneromooo-monero4-8/+153
2018-03-16wallet: key reuse mitigation optionsmoneromooo-monero2-15/+172
If a pre-fork output is spent on both Monero and attack chain, any post-fork output can be deduced to be a fake output, thereby decreasing the effective ring size. The segregate-per-fork-outputs option, on by default, allows selecting only pre-fork outputs in this case, so that the same ring can be used when spending it on the other side, which does not decrease the effective ring size. This is intended to be SET when intending to spend Monero on the attack fork, and to be UNSET if not intending to spend Monero on the attack fork (since it leaks the fact that the output being spent is pre-fork). If the user is not certain yet whether they will spend pre-fork outputs on a key reusing fork, the key-reuse-mitigation2 option should be SET instead. If you use this option and intend to spend Monero on both forks, then spend real Monero first.
2018-03-16wallet: add shared ring databasemoneromooo-monero6-7/+638
This maps key images to rings, so that different forks can reuse the rings by key image. This avoids revealing the real inputs like would happen if two forks spent the same outputs with different rings. This database is meant to be shared with all Monero forks which don't bother making a new chain, putting users' privacy at risk in the process. It is placed in a shared data directory by default ($HOME/.shared-ringdb on UNIX like systems). You may use --shared-ringdb-dir to override this location, and should then do so for all Monero forks for them to share the database.
2018-03-16add RPC to get a histogram of outputs of a given amountmoneromooo-monero3-0/+76
2018-03-15Fix typos in various filesDimitris Apostolou3-6/+6
2018-03-15wallet2+cli+rpc: eliminate redundant m_http_client from cli/rpc and delegate ↵stoffu3-6/+22
calls to wallet2
2018-03-14wallet2: Update function parameter documentationLeon Klingele2-31/+41
This completes and fixes various parameters docs
2018-03-14replace invoke_http_json("/json_rpc",...) with ↵stoffu2-146/+104
invoke_http_json_rpc("/json_rpc",methodname,...) to reduce boilerplate
2018-03-14wallet2: check_tx_key() shouldn't require hardware encryptionstoffu1-2/+2
2018-03-14device: untangle cyclic depenencystoffu3-21/+20
When #3303 was merged, a cyclic dependency chain was generated: libdevice <- libcncrypto <- libringct <- libdevice This was because libdevice needs access to a set of basic crypto operations implemented in libringct such as scalarmultBase(), while libringct also needs access to abstracted crypto operations implemented in libdevice such as ecdhEncode(). To untangle this cyclic dependency chain, this patch splits libringct into libringct_basic and libringct, where the basic crypto ops previously in libringct are moved into libringct_basic. The cyclic dependency is now resolved thanks to this separation: libcncrypto <- libringct_basic <- libdevice <- libcryptonote_basic <- libringct This eliminates the need for crypto_device.cpp and rctOps_device.cpp. Also, many abstracted interfaces of hw::device such as encrypt_payment_id() and get_subaddress_secret_key() were previously implemented in libcryptonote_basic (cryptonote_format_utils.cpp) and were then called from hw::core::device_default, which is odd because libdevice is supposed to be independent of libcryptonote_basic. Therefore, those functions were moved to device_default.cpp.
2018-03-14device: made function prototypes consistent with pre-#3303 codebasestoffu1-6/+2
2018-03-14wallet2: guard against overflowing of subaddress indicesmoneromooo-monero1-3/+14
2018-03-14wallet2: fix use_fork_rules() when querying version that is defined but not ↵stoffu1-1/+1
enabled yet
2018-03-14wallet: fix auto low priority so that it takes effect only when saved ↵stoffu1-1/+1
default is 0
2018-03-12Ledger HW Bug fixesCédric1-43/+59
Fix the way the REAL mode is handle: Let create_transactions_2 and create_transactions_from construct the vector of transactions. Then iterate on it and resign. We just need to add 'outs' list in the TX struct for that. Fix default secret keys value when DEBUG_HWDEVICE mode is off The magic value (00...00 for view key and FF..FF for spend key) was not correctly set when DEBUG_HWDEVICE was off. Both was set to 00...00. Add sub-address info in ABP map in order to correctly display destination sub-address on device Fix DEBUG_HWDEVICE mode: - Fix compilation errors. - Fix control device init in ledger device. - Add more log. Fix sub addr control Fix debug Info
2018-03-11wallet2: handle no blocks returned in refresh to mean no new blocksmoneromooo-monero1-0/+5
This is not a possible return from the daemon, but I want this in now so all wallets handle this when the daemon starts doing so.
2018-03-11node_rpc_proxy: fix target height cachingmoneromooo-monero1-1/+1
2018-03-10wallet2 / simplewallet: Must opt-in to create '.address.txt' files for new ↵Leon Klingele2-44/+72
wallets Previously, a file containing the unencrypted Monero address was created by default in the wallet's directory. This file might pose as a privacy risk. The creation of this file is now opt-in and can be enabled by providing --create-address-file
2018-03-09fix error message typo in wallet2.cppcryptochangements341-1/+1
2018-03-07wallet: fixes and tweaks to the save_watch_only commandmoneromooo-monero2-7/+7
- save the new keys file as FOO-watchonly.keys, not FOO.keys-watchonly - catch any exception (eg, I/O errors) and error out - print the new keys filename in simplewallet
2018-03-07Bump min ring size from 5 to 7 from v7moneromooo-monero1-1/+5
2018-03-07Wallet API: corrected testnet/mainnet orderingstoffu1-1/+1
2018-03-06Wallet API: make nettype non-defaulted to disambiguate from deprecated ↵stoffu1-3/+3
versions (and make libwallet_api_tests compilable)
2018-03-06libwallet_merged: added missing libdevicestoffu1-0/+1
2018-03-05Make mixin optional with default for rpc transfercryptochangements341-4/+4
2018-03-05Correct spelling mistakes.Edward Betts3-10/+10
2018-03-05allow using ring size instead of mixin for rpc transfercryptochangements342-4/+44
2018-03-05Wallet API: generalize 'bool testnet' to 'NetworkType nettype'stoffu5-42/+103
2018-03-05wallet_manager: fixed typo deviuce/device.hppstoffu1-1/+1
2018-03-05Stagenetstoffu9-99/+123