aboutsummaryrefslogtreecommitdiff
path: root/src/wallet/wallet_rpc_server.cpp (follow)
AgeCommit message (Collapse)AuthorFilesLines
2019-07-09wallet_rpc_server: fix get_bulk_payments with short payment idsmoneromooo-monero1-0/+5
2019-05-21Fix allow any cert mode in wallet rpc when configured over rpcLee Clagett1-1/+5
2019-05-21Add ssl_options support to monerod's rpc mode.Lee Clagett1-50/+1
2019-05-14Merge pull request #5538luigi11111-1/+1
615f287 wallet: fix certificate fingerprint length check (moneromooo-monero)
2019-05-11wallet: fix certificate fingerprint length checkmoneromooo-monero1-1/+1
Fixed by crCr62U0
2019-05-10wallet_rpc_server: use original addresses in destinations in get_transfersmoneromooo-monero1-1/+9
And add them for pending transfers, where they were missing
2019-05-07Merge pull request #5503Riccardo Spagni1-4/+4
ccc1e311 wallet_rpc_server: reject standalone short payment id in address book (moneromooo-monero)
2019-05-02Merge pull request #5493Riccardo Spagni1-0/+9
5e0da6fb change SSL certificate fingerprint whitelisting from SHA1 to SHA-256 (moneromooo-monero)
2019-05-02Merge pull request #5491Riccardo Spagni1-2/+4
98fb98f9 wallet_rpc_server: adding missing return on error in set_daemon (moneromooo-monero) 9074c0d8 wallet_rpc_server: return false on error in set_log_categories (moneromooo-monero) 968848a7 wallet_rpc_server: fix crash in validate_address if no wallet is loaded (moneromooo-monero)
2019-04-30wallet_rpc_server: reject standalone short payment id in address bookmoneromooo-monero1-4/+4
2019-04-26change SSL certificate fingerprint whitelisting from SHA1 to SHA-256moneromooo-monero1-0/+9
SHA1 is too close to bruteforceable
2019-04-25wallet_rpc_server: adding missing return on error in set_daemonmoneromooo-monero1-0/+1
2019-04-25wallet_rpc_server: return false on error in set_log_categoriesmoneromooo-monero1-1/+1
Reported by SmajeNz0
2019-04-25wallet_rpc_server: fix crash in validate_address if no wallet is loadedmoneromooo-monero1-1/+2
Reported by SmajeNz0
2019-04-20wallet_rpc_server: add block_height and frozen to incoming_transfersmoneromooo-monero1-0/+2
2019-04-18Merge pull request #5458Riccardo Spagni1-0/+1
84047cb7 wallet_rpc_server: add unlocked field to incoming_transfers output (moneromooo-monero)
2019-04-17wallet_rpc_server: add unlocked field to incoming_transfers outputmoneromooo-monero1-0/+1
2019-04-16wallet_rpc_server: set suggested_confirmations_threshold for pool txesmoneromooo-monero1-5/+3
2019-04-16wallet_rpc_server: add set_log_level/set_log_categoriesmoneromooo-monero1-0/+33
2019-04-16Merge pull request #5446Riccardo Spagni1-5/+1
7d79222f daemon: remove debug info (moneromooo-monero) 8fec0f98 functional_tests: add sweep_single test (moneromooo-monero) 9880d61b wallet_rpc_server: remove unused code (moneromooo-monero) 8a61b33d rpc: omit irrelevant fields for pool txes in gettransactions (moneromooo-monero) 56508524 rpc: add relayed in get_transaction output (moneromooo-monero) 82e510f1 rpc: set default log category in core_rpc_server.h (moneromooo-monero)
2019-04-16Merge pull request #5429Riccardo Spagni1-41/+48
bcb86ae6 wallet_rpc_server: fix inconsistent wallet caches on reload (moneromooo-monero)
2019-04-16Merge pull request #5418Riccardo Spagni1-1/+1
374f388d wallet_rpc_server: add a all flag to export_outputs (moneromooo-monero)
2019-04-15wallet_rpc_server: remove unused codemoneromooo-monero1-5/+1
2019-04-12wallet_rpc_server: fix inconsistent wallet caches on reloadmoneromooo-monero1-41/+48
Loading the same wallet as the currently loaded one would autosave the current state after loading it, leading to some kind of rollback effect. We now save before loading to avoid this. If loading fails, it means the current wallet will be saved (or maybe not, depending on where the failure occurs: most of the sanity checks occur before saving). There is a new autosave_current flag to open/restore calls so the (enabled by default) autosave can be skipped.
2019-04-11Merge pull request #5382Riccardo Spagni1-4/+5
c12b43cb wallet: add number of blocks required for the balance to fully unlock (moneromooo-monero) 3f1e9e84 wallet2: set confirmations to 0 for pool txes in proofs (moneromooo-monero) 36c037ec wallet_rpc_server: error out on getting the spend key from a hot wallet (moneromooo-monero) cd1eaff2 wallet_rpc_server: always fill out subaddr_indices in get_transfers (moneromooo-monero)
2019-04-11Merge pull request #5374Riccardo Spagni1-0/+56
a2561653 wallet: new option to start background mining (moneromooo-monero)
2019-04-10wallet_rpc_server: add a all flag to export_outputsmoneromooo-monero1-1/+1
if we don't want to export new outputs only
2019-04-07Enabling daemon-rpc SSL now requires non-system CA verificationLee Clagett1-7/+16
If `--daemon-ssl enabled` is set in the wallet, then a user certificate, fingerprint, or onion/i2p address must be provided.
2019-04-07Pass SSL arguments via one class and use shared_ptr instead of referenceLee Clagett1-9/+29
2019-04-06Change default SSL to "enabled" if user specifies fingerprint/certificateLee Clagett1-4/+9
Currently if a user specifies a ca file or fingerprint to verify peer, the default behavior is SSL autodetect which allows for mitm downgrade attacks. It should be investigated whether a manual override should be allowed - the configuration is likely always invalid.
2019-04-06Change SSL certificate file list to OpenSSL builtin load_verify_locationLee Clagett1-15/+5
Specifying SSL certificates for peer verification does an exact match, making it a not-so-obvious alias for the fingerprints option. This changes the checks to OpenSSL which loads concatenated certificate(s) from a single file and does a certificate-authority (chain of trust) check instead. There is no drop in security - a compromised exact match fingerprint has the same worse case failure. There is increased security in allowing separate long-term CA key and short-term SSL server keys. This also removes loading of the system-default CA files if a custom CA file or certificate fingerprint is specified.
2019-04-06Merge pull request #5345Riccardo Spagni1-3/+9
678262ab wallet_rpc_server: allow english/local language names in create_wallet (moneromooo-monero)
2019-04-06Merge pull request #5340Riccardo Spagni1-1/+1
16eda54b wallet: use original user address if we have a short payment id (moneromooo-monero)
2019-04-04wallet: new option to start background miningmoneromooo-monero1-0/+56
The setup-background-mining option can be used to select background mining when a wallet loads. The user will be asked the first time the wallet is created.
2019-04-01wallet: add number of blocks required for the balance to fully unlockmoneromooo-monero1-4/+5
2019-04-01wallet_rpc_server: error out on getting the spend key from a hot walletmoneromooo-monero1-1/+7
2019-04-01wallet_rpc_server: always fill out subaddr_indices in get_transfersmoneromooo-monero1-0/+2
It was not filled out for in and pool types
2019-04-01wallet_rpc_server: error out on getting the spend key from a hot walletmoneromooo-monero1-1/+7
2019-04-01wallet_rpc_server: add a set_daemon RPCmoneromooo-monero1-0/+34
2019-04-01wallet_rpc_server: always fill out subaddr_indices in get_transfersmoneromooo-monero1-0/+2
It was not filled out for in and pool types
2019-04-01wallet_rpc_server: set confirmations to 0 for pending/pool txesmoneromooo-monero1-1/+1
2019-04-01Merge pull request #5329Riccardo Spagni1-36/+4
023f2c77 wallet_rpc_server: remove mixin from transfer RPCs (moneromooo-monero)
2019-04-01Merge pull request #5302Riccardo Spagni1-1/+33
23fb056a wallet_rpc_server: new auto_refresh RPC (moneromooo-monero)
2019-04-01Merge pull request #5299Riccardo Spagni1-1/+1
4ee15655 wallet_rpc_server: fix buffer read overflow in string assignment (moneromooo-monero)
2019-04-01Merge pull request #5297Riccardo Spagni1-16/+5
a8b98a0b wallet: fix memory only wallets (moneromooo-monero)
2019-03-25wallet_rpc_server: allow english/local language names in create_walletmoneromooo-monero1-3/+9
and return both in get_languages
2019-03-25wallet: fix memory only walletsmoneromooo-monero1-16/+5
at least when using restore_deterministic_wallet
2019-03-24Merge pull request #5282Riccardo Spagni1-0/+4
f962449d wallet_rpc_server: include out subaddress indices in get_transfers (moneromooo-monero)
2019-03-24wallet: use original user address if we have a short payment idmoneromooo-monero1-1/+1
2019-03-21wallet_rpc_server: remove mixin from transfer RPCsmoneromooo-monero1-36/+4
it's been a while, only use ring_size now
2019-03-19Merge pull request #5203Riccardo Spagni1-22/+52
8b514645 add multisig tx sets to describe_transfer rpc endpoint (spoke0)
2019-03-17Merge pull request #5165Riccardo Spagni1-0/+168
36451697 Simplify RPC endpoint, emoving second RPC endpoint generate_from_view_key (Joel) c17c8188 Remove code duplication (Joel) acb14c10 Add generate_from_view_key RPC method (Joel) 7dd7a3b7 Add generate_from_keys RPC method (Joel)
2019-03-17Merge pull request #5061Riccardo Spagni1-1/+1
1f2930ce Update 2019 copyright (binaryFate)
2019-03-17wallet_rpc_server: new auto_refresh RPCmoneromooo-monero1-1/+33
It can enable/disable auto refresh, and set auto refresh period
2019-03-15wallet_rpc_server: fix buffer read overflow in string assignmentmoneromooo-monero1-1/+1
2019-03-13wallet_rpc_server: include out subaddress indices in get_transfersmoneromooo-monero1-0/+4
2019-03-13wallet_rpc_server: add missing --rpc-ssl-allowed-fingerprintsmoneromooo-monero1-0/+1
2019-03-05Update 2019 copyrightbinaryFate1-1/+1
2019-03-05Merge pull request #4852Riccardo Spagni1-1/+6
057c279c epee: add SSL support (Martijn Otto)
2019-03-05add multisig tx sets to describe_transfer rpc endpointspoke01-22/+52
2019-03-05epee: add SSL supportMartijn Otto1-1/+6
RPC connections now have optional tranparent SSL. An optional private key and certificate file can be passed, using the --{rpc,daemon}-ssl-private-key and --{rpc,daemon}-ssl-certificate options. Those have as argument a path to a PEM format private private key and certificate, respectively. If not given, a temporary self signed certificate will be used. SSL can be enabled or disabled using --{rpc}-ssl, which accepts autodetect (default), disabled or enabled. Access can be restricted to particular certificates using the --rpc-ssl-allowed-certificates, which takes a list of paths to PEM encoded certificates. This can allow a wallet to connect to only the daemon they think they're connected to, by forcing SSL and listing the paths to the known good certificates. To generate long term certificates: openssl genrsa -out /tmp/KEY 4096 openssl req -new -key /tmp/KEY -out /tmp/REQ openssl x509 -req -days 999999 -sha256 -in /tmp/REQ -signkey /tmp/KEY -out /tmp/CERT /tmp/KEY is the private key, and /tmp/CERT is the certificate, both in PEM format. /tmp/REQ can be removed. Adjust the last command to set expiration date, etc, as needed. It doesn't make a whole lot of sense for monero anyway, since most servers will run with one time temporary self signed certificates anyway. SSL support is transparent, so all communication is done on the existing ports, with SSL autodetection. This means you can start using an SSL daemon now, but you should not enforce SSL yet or nothing will talk to you.
2019-03-05wallet_rpc_server: avoid repeated string allocations when parsingmoneromooo-monero1-20/+14
2019-03-04various: remove unused variablesmoneromooo-monero1-5/+0
2019-03-04Merge pull request #5156Riccardo Spagni1-20/+44
3d2772a0 wallet-rpc: get balance for all accounts and subaddresses (stoffu)
2019-03-04Merge pull request #5154Riccardo Spagni1-4/+12
8a1ff079 wallet-rpc: get transfers for all accounts and subaddresses (Jethro Grassie)
2019-03-04Merge pull request #5141Riccardo Spagni1-0/+51
5c81a9f1 wallet_rpc_server: add a validate_address RPC (moneromooo-monero)
2019-03-04Merge pull request #4054Riccardo Spagni1-1/+31
24569454 epee: add SSL support (moneromooo-monero)
2019-03-02Simplify RPC endpoint, emoving second RPC endpoint generate_from_view_keyJoel1-15/+4
2019-02-21Remove code duplicationJoel1-157/+18
2019-02-20wallet-rpc: get balance for all accounts and subaddressesstoffu1-20/+44
2019-02-19Add generate_from_view_key RPC methodJoel1-0/+152
2019-02-19Add generate_from_keys RPC methodJoel1-0/+166
2019-02-17wallet-rpc: get transfers for all accounts and subaddressesJethro Grassie1-4/+12
2019-02-14wallet_rpc_server: add a validate_address RPCmoneromooo-monero1-0/+51
2019-02-02epee: add SSL supportmoneromooo-monero1-1/+31
RPC connections now have optional tranparent SSL. An optional private key and certificate file can be passed, using the --{rpc,daemon}-ssl-private-key and --{rpc,daemon}-ssl-certificate options. Those have as argument a path to a PEM format private private key and certificate, respectively. If not given, a temporary self signed certificate will be used. SSL can be enabled or disabled using --{rpc}-ssl, which accepts autodetect (default), disabled or enabled. Access can be restricted to particular certificates using the --rpc-ssl-allowed-certificates, which takes a list of paths to PEM encoded certificates. This can allow a wallet to connect to only the daemon they think they're connected to, by forcing SSL and listing the paths to the known good certificates. To generate long term certificates: openssl genrsa -out /tmp/KEY 4096 openssl req -new -key /tmp/KEY -out /tmp/REQ openssl x509 -req -days 999999 -sha256 -in /tmp/REQ -signkey /tmp/KEY -out /tmp/CERT /tmp/KEY is the private key, and /tmp/CERT is the certificate, both in PEM format. /tmp/REQ can be removed. Adjust the last command to set expiration date, etc, as needed. It doesn't make a whole lot of sense for monero anyway, since most servers will run with one time temporary self signed certificates anyway. SSL support is transparent, so all communication is done on the existing ports, with SSL autodetection. This means you can start using an SSL daemon now, but you should not enforce SSL yet or nothing will talk to you.
2019-02-02wallet_rpc_server: remove detached short payment ids supportmoneromooo-monero1-5/+1
2019-01-28rpc: fix internal daemon calls in restricted rpc getting partial datamoneromooo-monero1-76/+76
2019-01-18core, wallet: remember original text version of destination addressmoneromooo-monero1-0/+2
2018-12-24wallet_rpc_server: add all field to export_key_imagesmoneromooo-monero1-1/+1
To use if you want all key images, not just the ones for recently imported outputs
2018-11-23wallet_rpc_server: do not use RPC data if the call failedmoneromooo-monero1-1/+2
Found by codacy.com
2018-11-16Merge pull request #4801Riccardo Spagni1-1/+32
7ae36e91 wallet_rpc_server: account for watch-only/non-deterministic/multisig when querying seed (stoffu)
2018-11-16Merge pull request #4784Riccardo Spagni1-0/+4
1c04c21d wallet_rpc_server: include additional tx keys in sign_transfer response (stoffu)
2018-11-14Merge pull request #4746Riccardo Spagni1-0/+194
f3019efe wallet-rpc: add on_restore_deterministic RPC call. (Hasan Pekdemir)
2018-11-06Merge pull request #4731Riccardo Spagni1-1/+1
f26ce08c wallet: add a non destructive blockchain rescan (moneromooo-monero)
2018-11-05wallet_rpc_server: account for watch-only/non-deterministic/multisig when ↵stoffu1-1/+32
querying seed Followup on #4653
2018-11-04wallet2: only export necessary outputs and key imagesmoneromooo-monero1-6/+7
and disable annoying test that requires ridiculous amounts of skullduggery every time some format changes
2018-11-03wallet: add a non destructive blockchain rescanmoneromooo-monero1-1/+1
2018-11-02wallet_rpc_server: include additional tx keys in sign_transfer responsestoffu1-0/+4
Followup on #4552
2018-11-01Merge pull request #4653Riccardo Spagni1-0/+1
ade369f9 Add RPC error code for non-deterministic wallet (Michał Sałaban)
2018-10-29wallet-rpc: add on_restore_deterministic RPC call.Hasan Pekdemir1-0/+194
2018-10-26Merge pull request #4561Riccardo Spagni1-0/+5
04ddf02e Return appropriate RPC error code when key image signature check fails (Michał Sałaban)
2018-10-26Merge pull request #4552Riccardo Spagni1-0/+2
67e76aa0 wallet_rpc_server: optionally return tx keys in sign_transfer (moneromooo-monero)
2018-10-26Merge pull request #4539Riccardo Spagni1-0/+165
977fc1bc wallet_rpc_server: add describe_transfer RPC (moneromooo-monero)
2018-10-18Add RPC error code for non-deterministic walletMichał Sałaban1-0/+1
2018-10-16wallet_rpc_server: fix change_wallet_password RPCmoneromooo-monero1-2/+1
2018-10-11Return appropriate RPC error code when key image signature check failsMichał Sałaban1-0/+5
2018-10-10wallet_rpc_server: optionally return tx keys in sign_transfermoneromooo-monero1-0/+2
2018-10-09wallet_rpc_server: add describe_transfer RPCmoneromooo-monero1-0/+165
for unsigned tx sets using a view only wallet
2018-10-07Merge pull request #4036Riccardo Spagni1-1/+50
9acf42d3 Multisig M/N functionality core tests added (naughtyfox) 9f3963e8 Arbitrary M/N multisig schemes: * support in wallet2 * support in monero-wallet-cli * support in monero-wallet-rpc * support in wallet api * support in monero-gen-trusted-multisig * unit tests for multisig wallets creation (naughtyfox)
2018-10-02Merge pull request #4484Riccardo Spagni1-8/+14
2c74b1a1 wallet_rpc_server: include all transfer records for a txid (moneromooo-monero)
2018-10-01Arbitrary M/N multisig schemes:naughtyfox1-1/+50
* support in wallet2 * support in monero-wallet-cli * support in monero-wallet-rpc * support in wallet api * support in monero-gen-trusted-multisig * unit tests for multisig wallets creation
2018-10-01wallet_rpc_server: include all transfer records for a txidmoneromooo-monero1-8/+14
Since subaddresses were added, a tx can now create more than one payment
2018-10-01wallet: fix --generate-from-json using wrong passwordmoneromooo-monero1-1/+2
2018-09-29Merge pull request #4459Riccardo Spagni1-0/+3
bcf3f6af fuzz_tests: catch unhandled exceptions (moneromooo-monero) 3ebd05d4 miner: restore stream flags after changing them (moneromooo-monero) a093092e levin_protocol_handler_async: do not propagate exception through dtor (moneromooo-monero) 1eebb82b net_helper: do not propagate exceptions through dtor (moneromooo-monero) fb6a3630 miner: do not propagate exceptions through dtor (moneromooo-monero) 2e2139ff epee: do not propagate exception through dtor (moneromooo-monero) 0749a8bd db_lmdb: do not propagate exceptions in dtor (moneromooo-monero) 1b0afeeb wallet_rpc_server: exit cleanly on unhandled exceptions (moneromooo-monero) 418a9936 unit_tests: catch unhandled exceptions (moneromooo-monero) ea7f9543 threadpool: do not propagate exceptions through the dtor (moneromooo-monero) 6e855422 gen_multisig: nice exit on unhandled exception (moneromooo-monero) 53df2deb db_lmdb: catch error in mdb_stat calls during migration (moneromooo-monero) e67016dd blockchain_blackball: catch failure to commit db transaction (moneromooo-monero) 661439f4 mlog: don't remove old logs if we failed to rename the current file (moneromooo-monero) 5fdcda50 easylogging++: test for NULL before dereference (moneromooo-monero) 7ece1550 performance_test: fix bad last argument calling add_arg (moneromooo-monero) a085da32 unit_tests: add check for page size > 0 before dividing (moneromooo-monero) d8b1ec8b unit_tests: use std::shared_ptr to shut coverity up about leaks (moneromooo-monero) 02563bf4 simplewallet: top level exception catcher to print nicer messages (moneromooo-monero) c57a65b2 blockchain_blackball: fix shift range for 32 bit archs (moneromooo-monero)
2018-09-29Merge pull request #4427Riccardo Spagni1-1/+1
83debef9 wallet_rpc_server: remove verbose field in incoming_transfers query (moneromooo-monero)
2018-09-25Merge pull request #4433Riccardo Spagni1-1/+1
b35beaa8 wallet_rpc_server: include account index in incoming_transfers RPC (moneromooo-monero)
2018-09-24wallet_rpc_server: include account index in incoming_transfers RPCmoneromooo-monero1-1/+1
2018-09-22wallet_rpc_server: fix --run-as-service on Windowsmoneromooo-monero1-0/+1
Thanks iDunk for the windows testing
2018-09-21wallet_rpc_server: fix build for windowsmoneromooo-monero1-8/+17
Thanks iDunk for building patches on windows
2018-09-21Merge pull request #4401Riccardo Spagni1-2/+16
66901901 README: harmonize command formatting inside README.md (Andrea) 8cd98408 disable AES on s390x architecture (Tuan M. Hoang) 4ed30bab wallet: implement coin splitting for sweep_* 'outputs' option (whythat) 24f52396 wallet: add 'outputs' option for sweep_* commands (whythat) 52e19d69 README: Compile boost with cxxflags=-fPIC cflags=-fPIC (Italocoin Project) 0c77523d README: fill in libsodium package name for Arch (phloatingman)
2018-09-18Merge pull request #4306Riccardo Spagni1-15/+24
56b50faa wallet: use wipeable_string in more places where a secret is used (moneromooo-monero) 07ec748c wipeable_string: add hex_to_pod function (moneromooo-monero)
2018-09-18wallet: add 'outputs' option for sweep_* commandswhythat1-2/+16
'outputs' option allows to specify the number of separate outputs of smaller denomination that will be created by sweep operation. rebased by moneromooo
2018-09-15add daemonizer to rpc walletjcktm1-111/+164
2018-09-14Merge pull request #4337Riccardo Spagni1-1/+6
97764bae wallet_rpc_server: error out if wallet-file and wallet-dir are both used (moneromooo-monero)
2018-09-12wallet: use wipeable_string in more places where a secret is usedmoneromooo-monero1-15/+24
2018-09-11Merge pull request #4352Riccardo Spagni1-9/+0
0664a984 wallet_rpc_server: remove some unused code (moneroexamples)
2018-09-11v8: per byte fee, pad bulletproofs, fixed 11 ring sizemoneromooo-monero1-1/+0
2018-09-09wallet_rpc_server: remove some unused codemoneroexamples1-9/+0
2018-09-08wallet_rpc_server: error out if wallet-file and wallet-dir are both usedmoneromooo-monero1-1/+6
2018-09-05wallet rpc: Add close_wallet RPCGuillaume LE VAILLANT1-0/+42
And close the current wallet automatically if necessary when opening another wallet.
2018-09-04Merge pull request #4269luigi11111-0/+32
3d5abbe [#4027] add change_wallet_password wallet rpc command (artyomsol)
2018-08-23wallet: store trusted-daemon flag in wallet2stoffu1-23/+12
2018-08-22Merge pull request #4242luigi11111-0/+22
6fcdc9e rpc-wallet: refresh command added (ph4r05)
2018-08-22rpc-wallet: refresh command addedDusan Klinec1-0/+22
2018-08-17[#4027] add change_wallet_password wallet rpc commandartyomsol1-0/+32
2018-08-16store secret keys encrypted where possiblemoneromooo-monero1-5/+5
The secret spend key is kept encrypted in memory, and decrypted on the fly when needed. Both spend and view secret keys are kept encrypted in a JSON field in the keys file. This avoids leaving the keys in memory due to being manipulated by the JSON I/O API.
2018-08-16wallet: wipe seed from memory where appropriatemoneromooo-monero1-1/+3
2018-08-16wallet2: make --restricted-rpc available for wallet RPC onlystoffu1-32/+35
2018-08-15Merge pull request #4171luigi11111-4/+10
9127a8b wallet-rpc: filter getbalance response by address index (stoffu)
2018-08-15Merge pull request #4170luigi11111-0/+21
1c6cfd3 wallet-rpc: add get_address_index command (stoffu)
2018-08-15Merge pull request #4158luigi11111-1/+33
7db7ec8 wallet rpc: support making integrated address of given standard address (stoffu)
2018-08-03wallet: distinguish coinbase from other txes in show_transfersmoneromooo-monero1-1/+1
2018-07-31wallet-rpc: add get_address_index commandstoffu1-0/+21
2018-07-31wallet-rpc: filter getbalance response by address indexstoffu1-4/+10
2018-07-20wallet rpc: support making integrated address of given standard addressstoffu1-1/+33
2018-07-03Merge pull request #4035Riccardo Spagni1-0/+2
66df13a5 wallet-rpc.getaddress: throw if index is out of bound (stoffu)
2018-07-03Merge pull request #4005Riccardo Spagni1-0/+6
b85acb4c Fix RPC crashes that didn't check for an open wallet (Howard Chu)
2018-06-27Merge pull request #3907luigi11111-0/+19
dcbc17e wallet: include a suggested number of confirmations based on amount (moneromooo-monero)
2018-06-27Merge pull request #3998luigi11111-2/+2
8db23df wallet: on first refresh, start off with a quantized height (moneromooo-monero)
2018-06-27wallet: include a suggested number of confirmations based on amountmoneromooo-monero1-0/+19
This is based on how much an attacking miner stands to lose in block rewardy by mining a private chain which double spends a payment. This is not foolproof, since mining is based on luck, and breaks down as the attacking miner nears 50% of the network hash rate, and the estimation is based on a constant block reward.
2018-06-21wallet-rpc.getaddress: throw if index is out of boundstoffu1-0/+2
2018-06-16Merge pull request #3780luigi11111-7/+217
9c2a7b4 wallet-rpc: watch-only and cold wallet features added (ph4r05)
2018-06-15Fix RPC crashes that didn't check for an open walletHoward Chu1-0/+6
2018-06-13wallet: on first refresh, start off with a quantized heightmoneromooo-monero1-2/+2
for privacy reasons, so an untrusted node can't easily track wallets from IP address to IP address, etc. The granularity is 1024 blocks, which is about a day and a half.
2018-06-03wallet-rpc: watch-only and cold wallet features addedDusan Klinec1-7/+217
- unsigned_txset, signed_txset in transfer / submit_transfer / sign_transfer - export_outputs, import_outputs Squashed commits: [f4d9f3d4] wallet-rpc: do_not_relay removed from submit_transfer [5b16a86f] wallet-rpc: review-fix - method signature changes, renaming [b7fbb10a] wallet-rpc: naming fixes (unsigned vs signed), consts renamed [8c7d2727] wallet-rpc: sign_transfer added [481d024a] wallet2: sign_tx splitted to work with strings and structs, more granular [2a474db9] wallet-rpc: wallet2::load_unsigned_tx split to load from str, file [b1e3a018] wallet-rpc: review fix, load_tx_from_str variable rename [1f6373be] wallet-rpc: review fix: save_tx_to_{str,file} [2a08eafc] wallet-rpc: review comments fixes - redundant this removed from wallet2.cpp - load_tx_from_str, load_tx_from_file [43498052] wallet-rpc: submit_transfer added [9c45d1ad] wallet-rpc: watch_only check, return unsigned_txset [62831396] wallet2: added string variants to load_tx, save_tx - analogously to save_multisig_tx - required for monero-wallet-rpc to support watch-only wallet
2018-05-31Merge pull request #3640luigi11111-1/+7
f36132a wallet cli/rpc: terminate execution with code 0 when --help or --version is given (stoffu)
2018-04-22wallet cli/rpc: terminate execution with code 0 when --help or --version is ↵stoffu1-1/+7
given
2018-04-14wallet_rpc_server: add a get_version RPCmoneromooo-monero1-0/+6
2018-03-16Merge pull request #3336Riccardo Spagni1-1/+1
57c0b1ed Fix typos in various files (Dimitris Apostolou)
2018-03-15Fix typos in various filesDimitris Apostolou1-1/+1
2018-03-15wallet2+cli+rpc: eliminate redundant m_http_client from cli/rpc and delegate ↵stoffu1-5/+3
calls to wallet2
2018-03-05Merge pull request #3343Riccardo Spagni1-4/+36
3d452367 allow using ring size instead of mixin for rpc transfer (cryptochangements34)
2018-03-05allow using ring size instead of mixin for rpc transfercryptochangements341-4/+36
2018-03-05Stagenetstoffu1-15/+23
2018-02-20Merge pull request #3235Riccardo Spagni1-2/+3
6866ed46 Add default value to max_height, otherwise it's 0 (Michał Sałaban)
2018-02-16Merge pull request #3214Riccardo Spagni1-1/+1
214d251c wallet: suggest the use of sweep_unmixable when not_enough_outs_to_mix is thrown (stoffu)
2018-02-16Merge pull request #3207Riccardo Spagni1-6/+13
a99ef176 wallet-rpc: take subaddress account as arg for get_transfer_by_txid (stoffu) 77125096 wallet-rpc: rename *_INDEX_OUTOFBOUND into *_INDEX_OUT_OF_BOUNDS (stoffu)
2018-02-16Merge pull request #3197Riccardo Spagni1-0/+10
f90c76be Return appropriate error code when there's no connection to daemon (Michał Sałaban) 3cb65b3f Return appropriate error code when not enough money for tx (Michał Sałaban)
2018-02-16Merge pull request #3094Riccardo Spagni1-9/+9
a85dbb3f Fixed typos and wording tweaks (Maxithi)
2018-02-08wallet: suggest the use of sweep_unmixable when not_enough_outs_to_mix is thrownstoffu1-1/+1
2018-02-05Add default value to max_height, otherwise it's 0Michał Sałaban1-2/+3
2018-01-31wallet-rpc: take subaddress account as arg for get_transfer_by_txidstoffu1-4/+11
2018-01-31wallet-rpc: rename *_INDEX_OUTOFBOUND into *_INDEX_OUT_OF_BOUNDSstoffu1-2/+2
2018-01-29Fixed typos and wording tweaksMaxithi1-9/+9
2018-01-29Return appropriate error code when there's no connection to daemonMichał Sałaban1-0/+5
2018-01-28Return appropriate error code when not enough money for txMichał Sałaban1-0/+5
2018-01-28wallet: automatically use low priority if safe (no backlog & recent blocks ↵stoffu1-4/+8
not full)
2018-01-27Merge pull request #3114Riccardo Spagni1-0/+4
fb5c971c Allow retrieving spend key via RPC (Michał Sałaban)
2018-01-27Merge pull request #3113Riccardo Spagni1-2/+2
ffc2e570 wallet rpc: show fees when querying incoming transfers (stoffu)
2018-01-26Update 2018 copyrightxmr-eric1-1/+1
2018-01-26wallet rpc: show fees when querying incoming transfersstoffu1-2/+2
2018-01-25Merge pull request #3027Riccardo Spagni1-0/+60
6d40a920 Reserve proof (stoffu)
2018-01-25Merge pull request #3010Riccardo Spagni1-0/+4
07da9c80 Resolve addresses in get_transfers (Michał Sałaban)
2018-01-14Allow retrieving spend key via RPCMichał Sałaban1-0/+4
2018-01-10Reserve proofstoffu1-0/+60
2018-01-10Merge pull request #3002Riccardo Spagni1-0/+2
9996d5e9 wallet2: guard against the dameon sending blocks before last checkpoint (moneromooo-monero) eadaa6aa wallet_rpc_server: fix wallet leak on error exit (moneromooo-monero)
2018-01-10epee: remove dependency on commonmoneromooo-monero1-1/+2
2018-01-02Merge pull request #2967Riccardo Spagni1-301/+103
55556fab wallet_rpc_server: factor transfer info return and add missing info (moneromooo-monero)
2017-12-27Resolve addresses in get_transfersMichał Sałaban1-0/+4
2017-12-25Revert "return subaddress in get_bulk_payments"moneromooo-monero1-1/+0
This reverts commit b60f48f0e31c17638f771042887b2fffdbad15b4.
2017-12-25Merge pull request #2926Riccardo Spagni1-0/+70
6b5bd129 Account tagging (stoffu)
2017-12-25Merge pull request #2920Riccardo Spagni1-5/+19
bd5cce07 network_throttle: fix ineffective locking (moneromooo-monero) e0a61299 network_throttle: remove unused xxx static member (moneromooo-monero) 24f584d9 cryptonote_core: remove unused functions with off by one bugs (moneromooo-monero) b1634aa3 blockchain: don't leave dangling pointers in this (moneromooo-monero) 8e60b81c cryptonote_core: fix db leak on error (moneromooo-monero) 213e326c abstract_tcp_server2: log init_server errors as fatal (moneromooo-monero) b51dc566 use const refs in for loops for non tiny types (moneromooo-monero) f0568ca6 net_parse_helpers: fix regex error checking (moneromooo-monero) b49ddc76 check accessing an element past the end of a container (moneromooo-monero) 2305bf26 check return value for generate_key_derivation and derive_public_key (moneromooo-monero) a4240d9f catch const exceptions (moneromooo-monero) 45a1c4c0 add empty container sanity checks when using front() and back() (moneromooo-monero) 56fa6ce1 tests: fix a buffer overread in a unit test (moneromooo-monero) b4524892 rpc: guard against json parsing a non object (moneromooo-monero) c2ed8618 easylogging++: avoid buffer underflow (moneromooo-monero) 187a6ab2 epee: trap failure to parse URI from request (moneromooo-monero) 061789b5 checkpoints: trap failure to load JSON checkpoints (moneromooo-monero) ba2fefb9 checkpoints: pass std::string by const ref, not const value (moneromooo-monero) 38c8f4e0 mlog: terminate a string at last char, just in case (moneromooo-monero) d753d716 fix a few leaks by throwing objects, not newed pointers to objects (moneromooo-monero) fe568db8 p2p: use size_t for arbitrary counters instead of uint8_t (moneromooo-monero) 46d6fa35 cryptonote_protocol: sanity check chain hashes from peer (moneromooo-monero) 25584f86 cryptonote_protocol: print peer versions when unexpected (moneromooo-monero) 490a5d41 rpc: do not try to use an invalid txid in relay_tx (moneromooo-monero)
2017-12-25Merge pull request #2916Riccardo Spagni1-4/+18
a9217641 wallet-rpc: added receiving address to res of get(_bulk)_payments; selective addresses for getaddress (stoffu)
2017-12-25Merge pull request #2899Riccardo Spagni1-0/+1
b60f48f0 return subaddress in get_bulk_payments (Dmitriy Plekhanov)
2017-12-24wallet_rpc_server: fix wallet leak on error exitmoneromooo-monero1-0/+2
Makes it easier to debug leaks
2017-12-20wallet_rpc_server: factor transfer info return and add missing infomoneromooo-monero1-301/+103
Additional tx keys, amounts and fees were missing in some cases
2017-12-18check accessing an element past the end of a containermoneromooo-monero1-5/+12
2017-12-18add empty container sanity checks when using front() and back()moneromooo-monero1-0/+7
2017-12-18wallet-rpc: added receiving address to res of get(_bulk)_payments; selective ↵stoffu1-4/+18
addresses for getaddress
2017-12-18Account taggingstoffu1-0/+70
2017-12-17wallet: factor multisig info parsingmoneromooo-monero1-50/+1
2017-12-17wallet: use raw encrypted data in multisig import/export RPCmoneromooo-monero1-47/+7
2017-12-17wallet: add multisig sign/submit RPCmoneromooo-monero1-82/+361
2017-12-17Match surae's recommendation to derive multisig keysmoneromooo-monero1-3/+3
2017-12-17wallet: guard against partly initialized multisig walletmoneromooo-monero1-4/+25
2017-12-17add multisig core test and factor multisig building blocksmoneromooo-monero1-14/+1
2017-12-17N-1/N multisigmoneromooo-monero1-11/+93
2017-12-17multisig address generation RPCmoneromooo-monero1-0/+234
2017-12-17gen_multisig: generates multisig wallets if participants trust each othermoneromooo-monero1-0/+1
2017-12-17Add N/N multisig tx generation and signingmoneromooo-monero1-0/+1
Scheme by luigi1111: Multisig for RingCT on Monero 2 of 2 User A (coordinator): Spendkey b,B Viewkey a,A (shared) User B: Spendkey c,C Viewkey a,A (shared) Public Address: C+B, A Both have their own watch only wallet via C+B, a A will coordinate spending process (though B could easily as well, coordinator is more needed for more participants) A and B watch for incoming outputs B creates "half" key images for discovered output D: I2_D = (Hs(aR)+c) * Hp(D) B also creates 1.5 random keypairs (one scalar and 2 pubkeys; one on base G and one on base Hp(D)) for each output, storing the scalar(k) (linked to D), and sending the pubkeys with I2_D. A also creates "half" key images: I1_D = (Hs(aR)+b) * Hp(D) Then I_D = I1_D + I2_D Having I_D allows A to check spent status of course, but more importantly allows A to actually build a transaction prefix (and thus transaction). A builds the transaction until most of the way through MLSAG_Gen, adding the 2 pubkeys (per input) provided with I2_D to his own generated ones where they are needed (secret row L, R). At this point, A has a mostly completed transaction (but with an invalid/incomplete signature). A sends over the tx and includes r, which allows B (with the recipient's address) to verify the destination and amount (by reconstructing the stealth address and decoding ecdhInfo). B then finishes the signature by computing ss[secret_index][0] = ss[secret_index][0] + k - cc[secret_index]*c (secret indices need to be passed as well). B can then broadcast the tx, or send it back to A for broadcasting. Once B has completed the signing (and verified the tx to be valid), he can add the full I_D to his cache, allowing him to verify spent status as well. NOTE: A and B *must* present key A and B to each other with a valid signature proving they know a and b respectively. Otherwise, trickery like the following becomes possible: A creates viewkey a,A, spendkey b,B, and sends a,A,B to B. B creates a fake key C = zG - B. B sends C back to A. The combined spendkey C+B then equals zG, allowing B to spend funds at any time! The signature fixes this, because B does not know a c corresponding to C (and thus can't produce a signature). 2 of 3 User A (coordinator) Shared viewkey a,A "spendkey" j,J User B "spendkey" k,K User C "spendkey" m,M A collects K and M from B and C B collects J and M from A and C C collects J and K from A and B A computes N = nG, n = Hs(jK) A computes O = oG, o = Hs(jM) B anc C compute P = pG, p = Hs(kM) || Hs(mK) B and C can also compute N and O respectively if they wish to be able to coordinate Address: N+O+P, A The rest follows as above. The coordinator possesses 2 of 3 needed keys; he can get the other needed part of the signature/key images from either of the other two. Alternatively, if secure communication exists between parties: A gives j to B B gives k to C C gives m to A Address: J+K+M, A 3 of 3 Identical to 2 of 2, except the coordinator must collect the key images from both of the others. The transaction must also be passed an additional hop: A -> B -> C (or A -> C -> B), who can then broadcast it or send it back to A. N-1 of N Generally the same as 2 of 3, except participants need to be arranged in a ring to pass their keys around (using either the secure or insecure method). For example (ignoring viewkey so letters line up): [4 of 5] User: spendkey A: a B: b C: c D: d E: e a -> B, b -> C, c -> D, d -> E, e -> A Order of signing does not matter, it just must reach n-1 users. A "remaining keys" list must be passed around with the transaction so the signers know if they should use 1 or both keys. Collecting key image parts becomes a little messy, but basically every wallet sends over both of their parts with a tag for each. Thia way the coordinating wallet can keep track of which images have been added and which wallet they come from. Reasoning: 1. The key images must be added only once (coordinator will get key images for key a from both A and B, he must add only one to get the proper key actual key image) 2. The coordinator must keep track of which helper pubkeys came from which wallet (discussed in 2 of 2 section). The coordinator must choose only one set to use, then include his choice in the "remaining keys" list so the other wallets know which of their keys to use. You can generalize it further to N-2 of N or even M of N, but I'm not sure there's legitimate demand to justify the complexity. It might also be straightforward enough to support with minimal changes from N-1 format. You basically just give each user additional keys for each additional "-1" you desire. N-2 would be 3 keys per user, N-3 4 keys, etc. The process is somewhat cumbersome: To create a N/N multisig wallet: - each participant creates a normal wallet - each participant runs "prepare_multisig", and sends the resulting string to every other participant - each participant runs "make_multisig N A B C D...", with N being the threshold and A B C D... being the strings received from other participants (the threshold must currently equal N) As txes are received, participants' wallets will need to synchronize so that those new outputs may be spent: - each participant runs "export_multisig FILENAME", and sends the FILENAME file to every other participant - each participant runs "import_multisig A B C D...", with A B C D... being the filenames received from other participants Then, a transaction may be initiated: - one of the participants runs "transfer ADDRESS AMOUNT" - this partly signed transaction will be written to the "multisig_monero_tx" file - the initiator sends this file to another participant - that other participant runs "sign_multisig multisig_monero_tx" - the resulting transaction is written to the "multisig_monero_tx" file again - if the threshold was not reached, the file must be sent to another participant, until enough have signed - the last participant to sign runs "submit_multisig multisig_monero_tx" to relay the transaction to the Monero network