Age | Commit message (Collapse) | Author | Files | Lines |
|
e198b06e Fix: out_of_hashchain_bounds_error in refresh (Hasan Pekdemir)
|
|
0afdb00b wallet2: fix print_ring printing double entries for transactions (moneromooo-monero)
|
|
8f3963d2 wallet2: demote a few uninteresting recurring logs to TRACE (moneromooo-monero)
|
|
1598f01c wallet2: use padded bulletproofs for multisig signing (stoffu)
|
|
6e1282b6 wallet2: fix off by one in output picking (moneromooo-monero)
|
|
|
|
9335d5a2 wallet2: save ring in the ringdb once a tx is created (moneromooo-monero)
|
|
107f3398 wallet2: fix ring reuse breaking when using histogram (moneromooo-monero)
|
|
f26ce08c wallet: add a non destructive blockchain rescan (moneromooo-monero)
|
|
e86af52e wallet2: rewrite keys file in a safer manner (Nathan Dorfman)
|
|
and take into account wallet level minimum spend age
|
|
and disable annoying test that requires ridiculous amounts
of skullduggery every time some format changes
|
|
|
|
70877b1d wallet2/create_transactions_2: removed obsolete '/ 1024' on min_fee calc (Paul Shapiro)
|
|
7f0dd094 wallet2: sanity check rct output distribution from the daemon (moneromooo-monero)
|
|
6097472a Update ZMQ fee estimate and add ZMQ output distribution (Lee Clagett)
|
|
cf646e3a wallet2/create_transactions_2: removed extraneous shuffle before sort of unused_*_indices_per_subaddr (Paul Shapiro)
|
|
76681b9b wallet2/create_transactions_2: fixed typo in try_tx=true's estimate_fee args (Paul Shapiro)
|
|
15:43 < hahsun> Im on stagenet and I suddenly get this exception: 2018-11-04 14:42:52.416 [RPC0] ERROR wallet.wallet2 src/wallet/wallet2.cpp:2070 !m_blockchain.is_in_bounds(current_index). THROW EXCEPTION: error::out_of_hashchain_bounds_error
16:01 <+moneromooo> OK, possibly because the blckchain is always seeded with the genesis block hash...
16:02 <+moneromooo> So that case should be allowed, assuming it doesn't break the code around it.
16:05 <+moneromooo> OK if stop_height == size || (size==1 && stop_heigt ==0)
16:05 <+moneromooo> Throw if not that.
16:06 < hahsun> k
|
|
|
|
|
|
When a tx gets from unconfirmed to conirmed, the rings for that
transaction were being added twice
|
|
|
|
Analogous to #4540
|
|
|
|
Even if it is never relayed, it ensures a daemon supplying
fake outs on demand will never be asked for a set with the
real input being the only intersecting member (only a problem
with people who trust their privacy to some stranger's node,
but it seems to be a massively common thing, even in Monero)
|
|
|
|
3ffbec15 rpc: init m_rpc_version in Message ctor (moneromooo-monero)
bfa2dce1 rpc: remove unused ctors (moneromooo-monero)
7cc39845 account: init creation timestamp to 0 (moneromooo-monero)
32123789 wallet2: initialize some scalar fields in ctor where appropriate (moneromooo-monero)
4eca42b2 blockchain_db: initialize m_hardfork in ctor just in case (moneromooo-monero)
|
|
04ddf02e Return appropriate RPC error code when key image signature check fails (Michał Sałaban)
|
|
67e76aa0 wallet_rpc_server: optionally return tx keys in sign_transfer (moneromooo-monero)
|
|
|
|
in order to unbias selection from blocks with few txes
|
|
|
|
|
|
|
|
unused_*_indices_per_subaddr
|
|
92a0827e wallet2: make fake out selection messages less spammy (moneromooo-monero)
|
|
Apparently some people seem to think it's a censorship list...
|
|
Coverity 188336
|
|
|
|
|
|
|
|
|
|
This code was deciding which bulletproof configuration to use
based on ptx which weren't created yet.
|
|
9acf42d3 Multisig M/N functionality core tests added (naughtyfox)
9f3963e8 Arbitrary M/N multisig schemes: * support in wallet2 * support in monero-wallet-cli * support in monero-wallet-rpc * support in wallet api * support in monero-gen-trusted-multisig * unit tests for multisig wallets creation (naughtyfox)
|
|
Some strings were not detected by lupdate because "tr() cannot be called without
context".
|
|
It can still be enable via DNS if a key reusing fork pops up
|
|
bccd88dd wallet2: clear found out for every tx key (doy-lee)
|
|
Avoids triggering the sanity check
|
|
* support in wallet2
* support in monero-wallet-cli
* support in monero-wallet-rpc
* support in wallet api
* support in monero-gen-trusted-multisig
* unit tests for multisig wallets creation
|
|
|
|
73403004 add --block-notify to monerod and --tx-notify to monero-wallet-{cli,rpc} (moneromooo-monero)
|
|
7dd11711 wallet2: fix transfers between subaddresses hitting the sanity check (moneromooo-monero)
|
|
06d05c21 device: set device name correctly if key_on_device is set (Dusan Klinec)
|
|
7964d4f8 wallet2: handle corner case in picking fake outputs (moneromooo-monero)
|
|
|
|
66901901 README: harmonize command formatting inside README.md (Andrea)
8cd98408 disable AES on s390x architecture (Tuan M. Hoang)
4ed30bab wallet: implement coin splitting for sweep_* 'outputs' option (whythat)
24f52396 wallet: add 'outputs' option for sweep_* commands (whythat)
52e19d69 README: Compile boost with cxxflags=-fPIC cflags=-fPIC (Italocoin Project)
0c77523d README: fill in libsodium package name for Arch (phloatingman)
|
|
|
|
7a76354c wallet2: import_multisig forward refresh exception (naughtyfox)
|
|
ba8dd347 api/wallet: properly disable key encryption (stoffu)
|
|
Implemented strategy splits total amount into N equal parts,
where N is a specified number of outputs. If N > 1, dummy
change output is NOT created.
rebased by moneromooo
|
|
'outputs' option allows to specify the number of
separate outputs of smaller denomination that will
be created by sweep operation.
rebased by moneromooo
|
|
|
|
- device name is a new wallet property
- full device name is now a bit more structured so we can address particular device vendor + device path. Example: 'Ledger', 'Trezor:udp', 'Trezor:udp:127.0.0.1:21324', 'Trezor:bridge:usb01'. The part before ':' identifies HW device implementation, the optional part after ':' is device path to look for.
- new --hw-device parameter added to the wallet, can name the hardware device
- device reconnect added
|
|
44259e56 wallet: ask-password can now ask without encrypting the secret spend key (moneromooo-monero)
|
|
|
|
df0e7c2f wallet2: fix secondary partially signed multisig txes (moneromooo-monero)
|
|
5f8f5631 wallet2.get_reserve_proof: throw when specified amount is zero (stoffu)
|
|
20171746 wallet2: factor the creation of a new wallet keys file (moneromooo-monero)
be6acfd5 wallet2: factor new blockchain setup (moneromooo-monero)
|
|
88fbc4a5 wallet2: fill in v2 height for stagenet (moneromooo-monero)
|
|
be001326 remove obsolete daemon selection of fake outs and old tx construction (moneromooo-monero)
|
|
|
|
a54dbaee blockchain_blackball: add --force-chain-reaction-pass flag (moneromooo-monero)
44439c32 record blackballs as amount/offset, and add export ability (moneromooo-monero)
4bce935b blockchain_blackball: more optimizations (moneromooo-monero)
b66ba783 blockchain_blackball: do not process duplicate blockchains parts (moneromooo-monero)
639a3c01 blockchain_blackball: make it clear secondary passes are not incremental (moneromooo-monero)
eb8a51be blockchain_blackball: detect spent outputs by partial ring reuse (moneromooo-monero)
d6d276c6 blockchain_blackball: fix chain reaction phase in incremental mode (moneromooo-monero)
2b2a681b blockchain_blackball: avoid false positives for different amounts (moneromooo-monero)
80e4fef3 blockchain_blackball: set transaction looping txn to read only (moneromooo-monero)
4801d6b5 blockchain_blackball: add stats (moneromooo-monero)
846190fd blockchain_blackball: support pre-v2 databases (moneromooo-monero)
daa6cc7d blockchain_blackball: use LMDB for the cache (moneromooo-monero)
50cb370d ringdb: allow blackballing many outputs at once (moneromooo-monero)
|
|
62511df6 wallet2: fix refresh retry when a block/tx fails to parse (moneromooo-monero)
b219c24c wallet2: trim hash chain after fast refresh of hashes (moneromooo-monero)
5b6bcca3 wallet2: fix checking the wrong vector when adding hashes (moneromooo-monero)
|
|
|
|
Reported by QuarksLab.
|
|
|
|
Also constrains bulletproofs to simple rct, for simplicity
|
|
|
|
|
|
|
|
It cuts down on txn commits, and speeds up blackballing substantially
|
|
|
|
29dea03 epee: resize vectors where possible in serialization (moneromooo-monero)
76affd9 epee: some speedup in parsing (moneromooo-monero)
dc6c069 db_lmdb: speedup the get_output_distribution common case (moneromooo-monero)
76ac5a8 wallet2: ask for a binary output distribution, for speed (moneromooo-monero)
|
|
1f2409e Do memwipe for critical secret keys copied to rct::key (stoffu)
|
|
ac09cfa wallet2: remove obsolete pruned/unpruned case (moneromooo-monero)
|
|
|
|
|
|
|
|
|
|
|
|
10475ab node_rpc_proxy: fix fork earliest height caching [RYO backport] (fireice-uk)
|
|
8439306 wallet2: do not divide by 0 on invalid daemon response (moneromooo-monero)
|
|
It would switch to a new set of blocks and fail, getting out of sync
with the hash chain in the process
|
|
This ensures it can't end up filled with the actual placeholders
|
|
The two vectors should be the same size anyway, so add an assert
to catch any case where they aren't
|
|
|
|
|
|
|
|
The secret spend key is kept encrypted in memory, and
decrypted on the fly when needed.
Both spend and view secret keys are kept encrypted in a JSON
field in the keys file. This avoids leaving the keys in
memory due to being manipulated by the JSON I/O API.
|
|
|
|
|
|
0f75717 wallet2: avoid using arbitrary random values when unknown (moneromooo-monero)
|
|
4520cfd wallet2: guard against bad outputs in import_outputs (moneromooo-monero)
|
|
a3fe1c5 simplewallet: add set_tx_key for importing tx keys from 3rd party wallets (stoffu)
|
|
ff37bd0 wallet2: fix O(n^2) behaviour in import_key_images (moneromooo-monero)
|
|
1c6cfd3 wallet-rpc: add get_address_index command (stoffu)
|
|
37f0799 wallet: distinguish coinbase from other txes in show_transfers (moneromooo-monero)
|
|
f2e65c6 wallet2: consider minimum fee when testing if balance is sufficient (stoffu)
|
|
bcab579 wallet: allow adjusting number of rounds for the key derivation function (stoffu)
|
|
34d4b79 wallet2: use a gamma distribution to pick fake outs (moneromooo-monero)
|
|
xref https://github.com/ryo-currency/ryo-currency/pull/86
|
|
All daemons will not support pruned blocks
|
|
|
|
|
|
|
|
|
|
|
|
also some minor speedup
|
|
|
|
2951436 wallet: warn when payment IDs are used (moneromooo-monero)
|
|
a4272de wallet2: unlock keys file before calling verify_password (needed for Windows) (stoffu)
|
|
That takes a lot of time for even not so large wallets
|
|
8c4db68 node_rpc_proxy: factor a few RPC calls using get_info (moneromooo-monero)
|
|
d6440ab wallet2: recover from index out of hashchain bounds error (moneromooo-monero)
|
|
d6d78f1 Allow fractional outputs to be ignored (stoffu)
|
|
3e46db9 rpc: add a non binary get_transaction_pool_hashes RPC (moneromooo-monero)
|
|
|
|
This can happen when there's a very large reorg on the daemon
(ie, on testnet)
|
|
Subaddresses are better for privacy
|
|
This should be proof against any way one might get to multiple
processing, such as generating the same derivation from the
same pubkey, etc
|
|
as per "An Empirical Analysis of Linkability in the Monero
Blockchain", by Miller et al.
|
|
58cceaad wallet2: fix double counting outs if the tx pubkey is duplicated (moneromooo-monero)
|
|
df9d50a8 wallet2: fix read buffer overflow in import_key_images (moneromooo-monero)
|
|
2a19697b wallet2: fix double header in unsigned transfer file (moneromooo-monero)
|
|
bc443494 wallet2: fix out of sync account tag cache (moneromooo-monero)
|
|
|
|
Also added notes to WalletManager::verifyWalletPassword (which afaik seems unused
by anyone at the moment) regarding the need to unlock the keys file beforehand.
|
|
|
|
Takes advantage of caching
|
|
9a39b7d wallet2: fix build for windows (std::max again) (moneromooo-monero)
|
|
|
|
|
|
dcbc17e wallet: include a suggested number of confirmations based on amount (moneromooo-monero)
|
|
8db23df wallet: on first refresh, start off with a quantized height (moneromooo-monero)
|
|
0a5292c wallet2: use decoded amount when reporting repeated output key (stoffu)
|
|
25c15dc wallet2: use correct fee for split txes (stoffu)
|
|
798dfcf wallet: allow unspendable unmixable outputs to be discarded (stoffu)
|
|
08b85a8 cryptonote_config: add get_config to refactor x = testnet ? config::testnet::X : stagenet ? config::stagenet::X : config::X (stoffu)
0cf80ba net_node: resolve host for node addresses given via command line flags (stoffu)
|
|
This is based on how much an attacking miner stands to lose in block
rewardy by mining a private chain which double spends a payment.
This is not foolproof, since mining is based on luck, and breaks
down as the attacking miner nears 50% of the network hash rate,
and the estimation is based on a constant block reward.
|
|
a2b557f 6795bd0 209ec96 ed2c81e a830db2 57ea902 31a895e ba8331c f7f1917 41be339 f025ae9 ef2cb63 dcfd299 5d3e702 2704624 2771a18 0e4c7d0 (moneromooo-monero)
|
|
Speeds up syncing with a lot of outgoing outputs as key generation
runs Cryptonight.
|
|
Decrease the number of worker threads by one to account
for the fact the calling thread acts as a worker thread now
|
|
|
|
|
|
key derivation and checking for incoming outputs are threaded
in batch before adding blocks to the local blockchain. Other
minor bits and bobs are also cached.
|
|
|
|
|
|
|
|
Processing typically is the bottleneck
|
|
|
|
|
|
also use reserve where appropriate
|
|
|
|
|
|
d7a6b72 wallet2: fix bulletproof cold signing (moneromooo-monero)
|
|
bf26920 wallet2: fix get_approximate_blockchain_height for stagenet (stoffu)
|
|
|
|
|
|
|
|
|
|
5a412b7 disable file size sanity check when loading the wallet cache (moneromooo-monero)
|
|
89e51ec simple-wallet-cli: Add warnings about inaccurate balances to to watch-only wallet (jcktm)
|
|
9c2a7b4 wallet-rpc: watch-only and cold wallet features added (ph4r05)
|
|
eb9f3a3 check_spend_proof (itssteven)
|
|
This would cause crashes when trying to tag an account that was
just created
|
|
for privacy reasons, so an untrusted node can't easily track
wallets from IP address to IP address, etc. The granularity
is 1024 blocks, which is about a day and a half.
|
|
|
|
|
|
|
|
config::testnet::X : stagenet ? config::stagenet::X : config::X
|
|
b21bc00 Wallet: added methods to sign and verify arbitrary message with multisig public signer's key (libwallet & wallet api) (naughtyfox)
|
|
f80b157 wallet2: don't ask for pruned txes yet, we still parse the entire tx (moneromooo-monero)
|
|
Cold signing was always using Borromean range proofs, causing
a larger tx, and an incorrect fee
|
|
|
|
- unsigned_txset, signed_txset in transfer / submit_transfer / sign_transfer
- export_outputs, import_outputs
Squashed commits:
[f4d9f3d4] wallet-rpc: do_not_relay removed from submit_transfer
[5b16a86f] wallet-rpc: review-fix - method signature changes, renaming
[b7fbb10a] wallet-rpc: naming fixes (unsigned vs signed), consts renamed
[8c7d2727] wallet-rpc: sign_transfer added
[481d024a] wallet2: sign_tx splitted to work with strings and structs, more granular
[2a474db9] wallet-rpc: wallet2::load_unsigned_tx split to load from str, file
[b1e3a018] wallet-rpc: review fix, load_tx_from_str variable rename
[1f6373be] wallet-rpc: review fix: save_tx_to_{str,file}
[2a08eafc] wallet-rpc: review comments fixes
- redundant this removed from wallet2.cpp
- load_tx_from_str, load_tx_from_file
[43498052] wallet-rpc: submit_transfer added
[9c45d1ad] wallet-rpc: watch_only check, return unsigned_txset
[62831396] wallet2: added string variants to load_tx, save_tx
- analogously to save_multisig_tx
- required for monero-wallet-rpc to support watch-only wallet
|
|
47fdb74 WalletApi: getMultisigInfo entry for gui wallets... (naughtyfox)
47fdb74 Refactored: work with wallet api statuses to make setting and getting operations atomic along with error strings (naughtyfox)
|
|
|
|
|
|
80d2f80 wallet2: Update function parameter documentation (leonklingele)
|
|
|
|
|
|
wallet
|
|
|
|
My intention is to mitigate #3761 by returning "bad signature", rather than throwing an error, as the error is triggered inappropriately in the case of checking a different txid than the one used to create the signature, which causes issues for monerophp: https://github.com/monero-integrations/monerophp/issues/72 & my temp fix: https://github.com/monero-integrations/monerophp/pull/74
|
|
ffeeefde speedup get_output_histogram for all amounts when min_count > 0 (moneromooo-monero)
2dae0f20 wallet2: add missing parameters to get_output_histogram (moneromooo-monero)
|
|
5bd7f760 import_multisig_info: fix sanity check crash in detach_blockchain (Mikhail Mitkevichl)
|
|
public signer's key (libwallet & wallet api)
|
|
|
|
|