| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
ef941855 Wallet RPC: Add prompt-for-password flag (Tim L)
|
|
- refactoring: proof generation/checking code was moved from simplewallet.cpp to wallet2.cpp
- allow an arbitrary message to be signed together with txid
- introduce two types (outbound & inbound) of tx proofs; with the same syntax, inbound is selected when <address> belongs to this wallet, outbound otherwise. see GitHub thread for more discussion
- wallet RPC: added get_tx_key, check_tx_key, get_tx_proof, check_tx_proof
- wallet API: moved WalletManagerImpl::checkPayment to Wallet::checkTxKey, added Wallet::getTxProof/checkTxProof
- get_tx_key/check_tx_key: handle additional tx keys by concatenating them into a single string
|
|
|
|
ffe5b857 Correct totals computation (Michał Sałaban)
|
|
5d92c7cc wallet2: typo fix in error message (moneromooo-monero)
|
|
b738f4b5 wallet: add sweep_single command (stoffu)
|
|
7cb303a4 wallet2: simplify incoming tx processing code (moneromooo-monero)
|
|
|
|
|
|
Missing an error argument for an exception
|
|
99f398a2 wallet2: avoid growing the short history when refreshing in a loop (moneromooo-monero)
|
|
0d9c0db9 Do not build against epee_readline if it was not built (Howard Chu)
178014c9 split off readline code into epee_readline (moneromooo-monero)
a9e14a19 link against readline only for monerod and wallet-wallet-{rpc,cli} (moneromooo-monero)
437421ce wallet: move some scoped_message_writer calls from the libs (moneromooo-monero)
e89994e9 wallet: rejig to avoid prompting in wallet2 (moneromooo-monero)
ec5135e5 move input_line from command_line to simplewallet (moneromooo-monero)
082db75f move cryptonote command line options to cryptonote_core (moneromooo-monero)
|
|
383ff4f6 remove "using namespace std" from headers (moneromooo-monero)
|
|
|
|
|
|
wallet2 is a library, and should not prompt for stdin. Instead,
pass a function so simplewallet can prompt on stdin, and a GUI
might display a window, etc.
|
|
It's nasty, and actually breaks on Solaris, where if.h fails to
build due to:
struct map *if_memmap;
|
|
9d6c6c5d wallet2: do not bother downloading block hashes below last checkpoint (moneromooo-monero)
|
|
|
|
2677ade5 simplewallet: forbid 0 ring size (moneromooo-monero)
da8b60cb simplewallet: reject attempts to use too low mixin early (moneromooo-monero)
|
|
d269bff2 wallet2: use a vector, not a list, for selected_transfers (moneromooo-monero)
|
|
This yields a clear error message rather then some possibly
confusing more technical errors down the line
|
|
ac4018a7 wallet2: workaround for lightwallet before supporting subaddress (followup #2656) (kenshi84)
|
|
ad96c478 wallet-cli: added --generate-from-spend-key option (stoffu)
|
|
ccf53a56 track double spending in the txpool (moneromooo-monero)
|
|
|
|
Friendlier on memory/speed, we know in advance the max amount
of items, which are small and constant size, and there's a lot
of list walking involved.
|
|
|
|
|
|
balance()
|
|
Transactions in the txpool are marked when another transaction
is seen double spending one or more of its inputs.
This is then exposed wherever appropriate.
Note that being marked with this "double spend seen" flag does
NOT mean this transaction IS a double spend and will never be
mined: it just means that the network has seen at least another
transaction spending at least one of the same inputs, so care
should be taken to wait for a few confirmations before acting
upon that transaction (ie, mostly of use for merchants wanting
to accept unconfirmed transactions).
|
|
b370ef54 Wallet: Descriptions through new commands 'set_description', 'get_description' (rbrunner7)
|
|
b2d416f2 Distinguish "not enough money" and "not enough unlocked money" (binaryFate)
|
|
d0463312 fix libwallet api test after api change (Jaquee)
a46c1eed Wallet2: Don't throw when subaddress label doesn't exist (Jaquee)
086b7db2 Wallet API: default values for account and subaddr index (Jaquee)
|
|
626e8078 wallet2: fix show_transfers missing multiple incoming outputs (moneromooo-monero)
|
|
|
|
|
|
|
|
|
|
|
|
Fix #1530
|
|
#2656)
|
|
|
|
06fb9bcf wallet2: fix refresh height calc for new wallets (moneromooo-monero)
|
|
f139a6ca wallet2: fix backlog being off by 1 (moneromooo-monero)
|
|
97c2e449 wallet2+API: use separate callbacks for lightwallets (Jaquee)
d9261867 walletAPI: correct confirmations in txHistory for unsynced wallets (Jaquee)
9442b043 walletAPI: lightwallet exceptions (Jaquee)
fc922934 walletAPI: add lightwallet login() and importWalletRequest() (Jaquee)
79207743 walletAPI: init() lightwallet and SSL support (Jaquee)
dde5a1fc walletAPI: add tx unlock_time (Jaquee)
bba5cbed wallet2: remove obsolete get_num_rct_outputs() call from create_transactions_2 (Jaquee)
7a482f30 wallet2: create_transactions_2 lightwallet support (Jaquee)
ce61b818 wallet2: get_outs lightwallet support (Jaquee)
1197cb71 wallet2: commit_tx() lightwallet support (Jaquee)
43b57804 wallet2: refactor is_tx_spendtime_unlocked() (Jaquee)
32e2b003 wallet2: add lightwallet exceptions to common functions (Jaquee)
2e692fc0 wallet2: refresh() lightwallet support (Jaquee)
f44d156c my/openmonero API functions (Jaquee)
288d3c75 wallet2: add remove_obsolete_pool_txs() (Jaquee)
2c6aad7e wallet2: add on_pool_tx_removed callback (Jaquee)
ff7c30aa wallet2: light wallet member variables (Jaquee)
e2a276cb wallet2: add ssl option to init() (Jaquee)
a13540be add string_tools::validate_hex() (Jaquee)
fd773d88 refactor cryptonote_basic::add_tx_pub_key_to_extra (Jaquee)
8bfa6c2d lightwallet rpc server commands (Jaquee)
76961ddc Serializer: string to integer conversion for MyMonero compatibility (Jaquee)
1cf940f2 epee http_client SSL support (Jaquee)
eec10137 CMakeLists.txt - Add openssl include dir (Jaquee)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
d74336d5 wallet: encrypt (un)signed tx, also optionally save unencrypted raw tx hexstr (stoffu)
|
|
|
|
|
|
|
|
|
|
180a848c wallet2: Missing underflow check on low heights (landergate)
|
|
cbc5508b construct_tx_and_get_tx_key: return sorted sources for print_ring_memebrs to work properly (stoffu)
|
|
bd937139 wallet2: error check for generate_key_image_helper, removed redundant wallet_generate_key_image_helper (stoffu)
|
|
We don't want to count "partly filled" blocks in this case
|
|
wallet_generate_key_image_helper
|
|
work properly
|
|
|
|
d5a9edf2 wallet2: fix exception on split txes (moneromooo-monero)
5c5b0fd0 wallet2: print unused indices on a single line (moneromooo-monero)
|
|
It'd prevent further syncing. Recovery of empty hash chains is
automatic, but requires a running daemon
|
|
Lack of it results in `m_refresh_from_block_height` being < 0 (18446744...) on low heights, which blocks `process_new_blockchain_entry` and never process coins on heights less than blocks_per_month.
Follow-up to #2258
|
|
This saves a lot of space and load/save time for wallet caches
|
|
|
|
|
|
|
|
CID 175297
|
|
CID 161848
|
|
a15e8583 wallet2: guard against daemon sending txes in the wrong order (moneromooo-monero)
8fe5f609 rpc: order transactions in the order they were requested (moneromooo-monero)
|
|
b5cbdce8 wallet2: correctly handle in/out payments for view-only wallet (stoffu)
|
|
651baaec wallet: add encrypted seed functionality (moneromooo-monero)
|
|
|
|
fee3c3ed Update wallet2.cpp for misspelling (Matthew Campassi)
|
|
|
|
Decreases log spam massively on large wallets
|
|
Instead of constantly creating and destroying threads
|
|
Misspelling in wallet2.cpp
|
|
This uses luigi1111's CN_Add method.
See https://xmr.llcoins.net for details.
|
|
|
|
adce8ae4 simplewallet: new "fee" command to display fee information (moneromooo-monero)
|
|
2e338ca5 wallet2: account for huge testnet reorgs for estimating height (moneromooo-monero)
|
|
d58700e0 WalletAPI: only allow trusted daemon when importing key images (Jaquee)
8a9bbd26 WalletAPI: copy wallet data when creating a view only wallet (Jaquee)
d27fe32e wallet2: export/import wallet data functions (Jaquee)
225a25f3 import_key_images - allow importing without being connected to daemon (Jaquee)
|
|
including expected transaction backlog at different priorities
|
|
|
|
|
|
|
|
|
|
74597bd1 wallet2: improve refresh height determination (moneromooo-monero)
|
|
9707998a wallet2: clear some missing containers in clear() (moneromooo-monero)
|
|
b7d6ec83 simplewallet: add (out of sync) or (no daemon) markers in the prompt (moneromooo-monero)
fa23a500 wallet2: add a is_synced function (moneromooo-monero)
f1307bbd node_rpc_proxy: add a proxy for target height (moneromooo-monero)
|
|
ad4649ac Enable verifying wallet password with having to load wallet. (m2049r)
|
|
67ce4910 wallet2: store testnet bool in keys file (Jaquee)
|
|
c97d1bd3 wallet: return unlock_time in get_transfers (moneromooo-monero)
|
|
|
|
0c57df97 wallet2: fix temporarily missing incoming tx when being mined (moneromooo-monero)
|
|
As reported by jaquee, the calculation could underflow for very
low heights.
Additionally, we now use the target height too.
|
|
|
|
|
|
When scanning the txpool without having first updated the
blockchain, the tx would be seen as neither in the txpool
nor the chain, and removed, so it'd only reappear once the
chain is refreshed, and the tx seen in a block.
|
|
|
|
|
|
also show it in simplewallet's show_transfer
|
|
|
|
Use current time to estimate current height only if the daemon
cannot be queried.
|
|
If the refresh height is in the future, the current code will
loop till the actual height reaches this. Fix it by bailing out
if we receive only three hashes, which is what we set in the
call parameters.
|
|
The previous patch was based on a wrong premise (that the
daemon height was 0 because the daemon calling code wasn't
yet initialized). In fact, current height approximation
was not setup for testnet. Fix this.
|
|
|
|
6bcd3b2d fix get_upper_transaction rename (schnerchi)
|
|
|
|
89b2f306 tests: fix invalid key image test (moneromooo-monero)
a374a522 wallet2: check key image validity domain in import_key_images (moneromooo-monero)
|
|
e2529347 Correct spelling of 'get_upper_transaction_size_limit' (Nano Akron)
3029d0ef Remove the 1.25x multiplier in max transaction size in just the wallet (Nano Akron)
|
|
6cb1ad1f wallet fix: ensure iterator to be valid (stoffu)
|
|
|
|
|
|
|
|
|
|
The bump to minimum mixin 4 was moved from v5 to v6
|
|
It sweeps all outputs below the given threshold
This is available via the existing sweep_all RPC, by setting
amount_threshold the desired amount (in atomic units)
|
|
a6d5bb75 wallet2: refer to triangular distribution for recent zone in comment (moneromooo-monero)
ac1aba90 wallet2: bias fake outs more towards recent outputs (moneromooo-monero)
|
|
7f4beaa4 wallet2: fix removal of wrong txes from unconfirmed_payments (moneromooo-monero)
|
|
a7d78dda wallet2: fix --generate-from-json in RPC mode (moneromooo-monero)
|
|
89d70756 wallet2: fix spurious output splitting when not merging destinations (moneromooo-monero)
|
|
10e137be wallet2: mention escaping/quoting --password in help string (moneromooo-monero)
|
|
It was wrongly refering to equiprobable distribution, which I think
I'd originally done, but forgot to update the comment after changing
to triangular
Reported by smooth on IRC
|
|
Two recent papers quantified the real usage bias for the
real output in a ring being the true one, and shows that
the current biasing is much too weak.
While we wait for a better solution, we increase the ratio
of recent-to-total fake outputs, as well as decrease the
time window for recent outputs, so that half the fake outs
are selected within the last 1.8 day. Value plucked from
figure 10, page 11 of An Empirical Analysis of Linkability
in the Monero Blockchain, 2017, Miller et al.
This is also arbitrary, of course, but serves as a stopgap
till a better selection algorithm is chosen.
|
|
unconfirmed_payments changed from having the txid as key to
the payment id, and this was not changed to match.
|
|
The daemon address was initialized too late
|
|
Reviewed and squashed. Open/Create is only allowed if no walletfile
was specified at startup.
|
|
|
|
|
|
If using a large input and many destinations, the code would
generate as many outputs as it could using that input, even if
it would bring the resulting tx above the max tx size.
|
|
With the change from the original transfer method to the new
algorithm, payments to the same destination were merged. It
seemed like a good idea, optimizing space. However, it is a
useful tool for people who want to split large outputs into
several smaller ones (ie, service providers making frequent
payments, and who do not like a large chunk of their balance
being locked for 10 blocks after each payment).
Default to off, which is a change from the previous behavior.
|
|
When a single input is enough to satisfy a transfer, the code would
previously try to add a second input, to match the "canonical" makeup
of a transaction with two inputs and two outputs. This would cause
wallets to slowly merge outputs till all the monero ends up in a
single output, which causes trouble when making two transactions
one after the other, since change is locked for 10 blocks, and an
increasing portion of the remaining balance would end up locked on
each transaction.
There are two new settings (min-output-count and min-output-value)
which can control when to stop adding such unneeded second outputs.
The idea is that small "dust" outputs will still get added, but
larger ones will not.
Enable with, eg:
set min-output-count 10
set min-output-value 30
to avoid using an unneeded second output of 30 monero or more, if
there would be less than 10 such outputs left.
This does not invalidate any other reason why such outputs would
be used (ie, when they're really needed to satisfy a transfer, or
when randomly picked in the normal course of selection). This may
be improved in the future.
|
|
Includes a new RPC to get tx pool hashes fast.
|
|
350e99ae wallet2: cache which pool txes were scanned already (moneromooo-monero)
|
|
c1e9ccc7 wallet2: speed up transactions using remote nodes (moneromooo-monero)
|
|
This massively speeds up the wallet updating the pool on mainnet,
where the tx backlog is more than 500 txes.
|
|
Waiting would mean the fee used is 1x base, but the base will
have suddenly dropped
|
|
Asking for a full histogram from a remote node (since it's
untrusted) is pretty slow, and spams the remote node, so
we replace it by only adding a second input if we have rct
ones, which are for all intents and purposes always mixable.
|
|
This is a potentially long lasting daemon RPC call
|
|
Minimum mixin 4 and enforced ringct is moved from v5 to v6.
v5 is now used for an increased minimum block size (from 60000
to 300000) to cater for larger typical/minimum transaction size.
The fee algorithm is also changed to decrease the base per kB
fee, and add a cheap tier for those transactions which we do
not care if they get delayed (or even included in a block).
|
|
4b48565c wallet: add password command (moneromooo-monero)
|
|
Also tweak wallet2 password code to verify password without
saying it's a new wallet, because it's assuming things.
|
|
This reverts commit d47dac9a88ddd46b88850a899311363b3261c89e.
Callers actually expect the key to be payment id, so this
needs a lot more changes (like storing payment ids in the
structure, and possibly also to other existing structures
which do the same thing).
|
|
|
|
2c468dd4 allow user I/O in millinero, micronero, nanonero, piconero (moneromooo-monero)
|
|
d47dac9a wallet: fix insertion of pool transactions (moneromooo-monero)
|
|
|
|
They were inserted using payment id as key, not txid
|
|
|
|
|
|
|
|
|
|
|
|
5a3b1e98 wallet2: fix failure to send (relatedness check in wrong case) (moneromooo-monero)
|
|
A relatedness check was meant to be done in the case of adding
an extra output if just one was enough. This was mistakenly
added to the "preferred output" case.
|
|
|
|
ce7fcbb4 Add server auth to monerod, and client auth to wallet-cli and wallet-rpc (Lee Clagett)
|
|
bceaf4b7 wallet2: fix transactions not considering rct inputs (moneromooo-monero)
|
|
|
|
I broke this very recently in 2bf029be172a47ace8134143e1320fdb10d3ea44
and didn't notice in time
|
|
|
|
Makes it possible for GUI to reinit with new daemon without closing and reopening wallet.
|
|
f97526e6 simplewallet: option to always ask password for any crytical operations (kenshi84)
|
|
|
|
fba9332d Changed console output for transaction from L0 to L1 (NanoAkron)
|
|
2bf029be wallet2: fix corner case failing to send a second output (moneromooo-monero)
|
|
99f58437 Fix invalid + of std::string and int (Timothy D. Prime)
|
|
c02e1cb9 Updates to epee HTTP client code - http_simple_client now uses std::chrono for timeouts - http_simple_client accepts timeouts per connect / invoke call - shortened names of epee http invoke functions - invoke command functions only take relative path, connection is not automatically performed (Lee Clagett)
|
|
|
|
If a rct transaction can be made with just one input, a second
output will be added. This output will be the smallest amount
output available. However, if this output is a non rct output
with less available fake outs than requested, the transaction
will be rejected. We now check the histogram to only consider
outputs with enough available fake outs in the first place.
|
|
These warnings were emitted by clang++, and they are real bugs.
src/rpc/core_rpc_server.cpp:208:58: warning: adding 'uint64_t'
(aka 'unsigned long') to a string does not append to the string
[-Wstring-plus-int]
res.status = "Error retrieving block at height " + height;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
The obvious intent is achieved by using std::to_string().
|
|
- http_simple_client now uses std::chrono for timeouts
- http_simple_client accepts timeouts per connect / invoke call
- shortened names of epee http invoke functions
- invoke command functions only take relative path, connection
is not automatically performed
|
|
|
|
This would have tried to send a second output to make the tx
look like the 2/2 ideal, but it would not fail to find one
because picking an output from preferred_inputs priority list
did not remove it from the unused tranfer/dust outputs, so
it would try to send the same output twice.
While there, I also added a check to avoid sending a second
input if it's related to the first. Better 1/2 than linking
inputs, I think.
|
|
Mostly getinfo and get_hard_fork_info, which are called
pretty often. This speeds up transfers as a bonus.
|
|
This avoids indirectly leaking the real output to the daemon,
and is faster.
This will still happen for more complex cases, especially
when cancelling a tx and "re-rolling" it.
|
|
16b8b66a specify restore height by YYYY-MM-DD format (kenshi84)
|
|
|
|
This replaces the epee and data_loggers logging systems with
a single one, and also adds filename:line and explicit severity
levels. Categories may be defined, and logging severity set
by category (or set of categories). epee style 0-4 log level
maps to a sensible severity configuration. Log files now also
rotate when reaching 100 MB.
To select which logs to output, use the MONERO_LOGS environment
variable, with a comma separated list of categories (globs are
supported), with their requested severity level after a colon.
If a log matches more than one such setting, the last one in
the configuration string applies. A few examples:
This one is (mostly) silent, only outputting fatal errors:
MONERO_LOGS=*:FATAL
This one is very verbose:
MONERO_LOGS=*:TRACE
This one is totally silent (logwise):
MONERO_LOGS=""
This one outputs all errors and warnings, except for the
"verify" category, which prints just fatal errors (the verify
category is used for logs about incoming transactions and
blocks, and it is expected that some/many will fail to verify,
hence we don't want the spam):
MONERO_LOGS=*:WARNING,verify:FATAL
Log levels are, in decreasing order of priority:
FATAL, ERROR, WARNING, INFO, DEBUG, TRACE
Subcategories may be added using prefixes and globs. This
example will output net.p2p logs at the TRACE level, but all
other net* logs only at INFO:
MONERO_LOGS=*:ERROR,net*:INFO,net.p2p:TRACE
Logs which are intended for the user (which Monero was using
a lot through epee, but really isn't a nice way to go things)
should use the "global" category. There are a few helper macros
for using this category, eg: MGINFO("this shows up by default")
or MGINFO_RED("this is red"), to try to keep a similar look
and feel for now.
Existing epee log macros still exist, and map to the new log
levels, but since they're used as a "user facing" UI element
as much as a logging system, they often don't map well to log
severities (ie, a log level 0 log may be an error, or may be
something we want the user to see, such as an important info).
In those cases, I tried to use the new macros. In other cases,
I left the existing macros in. When modifying logs, it is
probably best to switch to the new macros with explicit levels.
The --log-level options and set_log commands now also accept
category settings, in addition to the epee style log levels.
|
|
d561f4ad enable clang checks that were disabled (Chris Vickio)
0aefb2f6 remove std::move from return statements (pessimizing-move warning) (Chris Vickio)
629d5b76 change counter from bool to int (deprecated-increment-bool warning) (Chris Vickio)
fb76d439 add extra braces around subobjects (missing-braces warning) (Chris Vickio)
3b6d5f25 make struct/class declarations consistent (mismatched-tags warning) (Chris Vickio)
fcf66925 remove unused fields from network_throttle (unused-private-field warning) (Chris Vickio)
296f8c16 inline unused function (for unused-function warning) (Chris Vickio)
|
|
d276a165 wallet2: use at least two rct inputs if possible (moneromooo-monero)
|
|
dea53962 fix timeout in check_connection (Jaquee)
|
|
|
|
|
|
If we'd make a rct tx with just one input, we try to add
a second one to match the 2/2 ideal. This means more txes
use that template (and are thus using a larger anonymity
set), and it coalesces outputs "for free". We use the
smallest amount outputs in priority for this, so we can
"clean" the wallet at the same time.
|
|
|
|
|
|
a081b39c Move key image export/import functions to wallet2 (Jaquee)
|
|
db56a03f Wallet2 + API: Callbacks for unconfirmed transfers (Jaquee)
|
|
0d3918e1 Wallet api: Update trustedDaemon when daemon is changed (Jaquee)
dbb838f4 GUI cold signing (Jaquee)
afb85a02 Wallet API: functions for supporting/creating view only wallets (Jaquee)
|
