aboutsummaryrefslogtreecommitdiff
path: root/src/simplewallet (follow)
AgeCommit message (Collapse)AuthorFilesLines
2016-12-08simplewallet: restore automatically setting trusted local daemonmoneromooo-monero1-0/+43
2016-12-04Merge pull request #1379Riccardo Spagni1-7/+12
d6086f5b Improve daemon RPC version handling (moneromooo-monero)
2016-11-26Improve daemon RPC version handlingmoneromooo-monero1-7/+12
Daemon RPC version is now composed of a major and minor number, so that incompatible changes bump the major version, while compatible changes can still bump the minor version without causing clients to unnecessarily complain.
2016-11-25Added command_line::is_yesLee Clagett1-17/+15
2016-11-23simplewallet: remove double confirmation when submitting signed txmoneromooo-monero1-51/+0
2016-11-17Merge pull request #1344Riccardo Spagni2-16/+58
a0131c8 wallet: auto sync outputs and key images in cold signing files (moneromooo-monero) f806611 wallet2: fill key image and pubkey maps when importing outputs (moneromooo-monero) 5fe363c wallet: cast indices to string in logs to be nice to CLANG (moneromooo-monero) 11ae187 wallet2: try all tx keys when scanning a new transaction (moneromooo-monero) 072d646 wallet2: fill in key image map when importing key images (moneromooo-monero) 23d80b1 core: remove any tx pubkey from extra before adding one (moneromooo-monero) d72376d simplewallet: add a verbose flag to incoming_transfers (moneromooo-monero) 47413a5 simplewallet: spell out change when signing a transfer (moneromooo-monero) 14cb088 simplewallet: print public keys too on spendkey/viewkey commands (moneromooo-monero) a99ab49 wallet: fix serialization of new m_key_image_known member (moneromooo-monero)
2016-11-16wallet: auto sync outputs and key images in cold signing filesmoneromooo-monero2-8/+22
When passing around unsigned and signed transactions, outputs and key images are passed along (outputs are passed along unsigned transactions from the hot wallet to the cold wallet, key images are passed along with signed transations from the cold wallet to the hot wallet), to allow more user friendly syncing between hot and cold wallets.
2016-11-13simplewallet: add a verbose flag to incoming_transfersmoneromooo-monero1-6/+18
Prints pubkey and key image as well
2016-11-13simplewallet: spell out change when signing a transfermoneromooo-monero1-2/+16
Also catch change to multiple addresses, this is unexpected
2016-11-13simplewallet: print public keys too on spendkey/viewkey commandsmoneromooo-monero1-2/+4
2016-11-13simplewallet: include amount sent in transfer confirmationmoneromooo-monero1-0/+10
2016-11-12Fixed generate-from-json bug introduced in 358e068Lee Clagett1-1/+2
2016-11-10Created monero-wallet-rpc, moving functionality from monero-wallet-cliLee Clagett5-1036/+118
2016-11-07wallet: encrypt outputs and key images files with the view keymoneromooo-monero1-14/+43
This key is available to both cold and hot wallet. Authenticated encryption will guard against interception and/or modification of the file.
2016-11-02wallet: fix bad amounts/fees againmoneromooo-monero1-2/+2
m_amount_out was sometimes getting initialized with the sum of an transaction's outputs, and sometimes with the sum of outputs that were not change. This caused confusion and bugs. We now always set it to the sum of outputs. This reverts an earlier fix for bad amounts as this used the other semantics. The wallet data should be converted automatically in a percentage of cases that I'm hesitant to estimate. In any case, restoring from seed or keys or rebuilding the cache will get it right.
2016-11-01Merge pull request #1281Riccardo Spagni2-0/+102
bb560dd wallet: new import_outputs/export_outputs commands (moneromooo-monero)
2016-11-01Merge pull request #1277Riccardo Spagni2-5/+17
7e6d3cf wallet: set incoming outputs' key image to 0 on view wallets (moneromooo-monero) 1f9e6a4 wallet: print tx overview on submit_transfer too (moneromooo-monero)
2016-10-30wallet: new import_outputs/export_outputs commandsmoneromooo-monero2-0/+102
The intended use is to export outputs from a hot wallet, which can scan incoming transfers from the network, and import them in the cold wallet, which can't. The cold wallet can then compute key images for those outputs, which can then be exported with export_key_images, etc.
2016-10-30wallet: print tx overview on submit_transfer toomoneromooo-monero2-5/+17
This is on the potentially compromised wallet, but still guards against stupid mistakes.
2016-10-30simplewallet: remove destinations with zero amount in sign_transfermoneromooo-monero1-0/+2
This will happen when sending to another address, after removing the fee.
2016-10-26simplewallet: log transactions to submit in submit_transfermoneromooo-monero1-1/+1
Not as trustworthy as this is in the view wallet, the one that's considered compromised.
2016-10-25wallet: fix pre-rct cold wallet signing not splitting changemoneromooo-monero1-6/+16
Re-creating the transaction on the cold wallet was not splitting the change, causing the transaction to be rejected by the network. This worked on testnet since amounts do not have to be split. Also add selected_transfers, which can now be saved since they're size_t rather than iterators. This allows the view wallet to properly set the sent outputs as spent and update balance. Bump transfer file version numbers to match.
2016-10-23simplewallet: factor locked_transfer, and fix a few rough edgesmoneromooo-monero1-256/+43
Factor locked_transfer into transfer_main, which brings various improvements for free (multiple addresses, proper detection of multiple payment ids, obeying the prompt settings). Also fix a few things, such as using uint64_t instead of int for block heights, actually checking whether getting blockchain height succeeded, etc.
2016-10-22Merge pull request #1224Riccardo Spagni1-10/+4
8231997 simplewallet: fix sweep_all misreporting sweeped amount for rct outputs (moneromooo-monero) 985f61a wallet: force 0 mixin transactions to use pre-rct txes (moneromooo-monero)
2016-10-22Merge pull request #1220Riccardo Spagni1-7/+43
e76dcdd wallet: improve error messages when not enough money for transfer (moneromooo-monero)
2016-10-22Merge pull request #1219Riccardo Spagni1-1/+1
2d7083c wallet_api: fix wrong amount in tx history (moneromooo-monero) b5f2001 simplewallet: fix wrong amount in show_transfers (moneromooo-monero)
2016-10-22Merge pull request #1200Riccardo Spagni1-53/+67
a3748f4 Rewrote add_wallet_create_if_needed for clearer flow and behaviour (NanoAkron)
2016-10-15Rewrote add_wallet_create_if_needed for clearer flow and behaviourNanoAkron1-53/+67
2016-10-15simplewallet: fix sweep_all misreporting sweeped amount for rct outputsmoneromooo-monero1-10/+4
RingCT outputs will be 0 in the vin, so we need to get the actual amount from elsewhere.
2016-10-15wallet: improve error messages when not enough money for transfermoneromooo-monero1-7/+43
2016-10-15simplewallet: fix wrong amount in show_transfersmoneromooo-monero1-1/+1
2016-10-04simplewallet: add mixin and payment id to sweep_all helpmoneromooo-monero1-1/+1
2016-10-04Merge pull request #1179Riccardo Spagni2-0/+254
714ee99 Fix description for locked_transfer (Oyvind Kvanes) 71538f3 Rename to lockblocks and add max value (Oyvind Kvanes) 68ac060 Fix locked_transfer (Oyvind Kvanes) 7d020bd Add locked_transfer (Oyvind Kvanes) d5f918a Revert transfer_main in simplewallet (Oyvind Kvanes) 3451963 Add motifications to test out locked_transfer (Oyvind Kvanes) e5e6d88 Add more information to transaction in wallet (Oyvind Kvanes) 9b8a062 Make a small test change (Oyvind Kvanes)
2016-10-04Merge pull request #1160Riccardo Spagni2-1/+81
80b4da3 wallet: wallet option to confirm transfers with no payment id (moneromooo-monero)
2016-10-04Merge pull request #1139Riccardo Spagni1-2/+2
01ec195 Update CMakeLists.txt (codehalo) 446ebbc Update CMakeLists.txt (codehalo) bd773e7 Update CMakeLists.txt (codehalo) 3627cea Cleanup. Dropped "bit" from bitmonero. (Randi Joseph) 2a51396 Dropped "bit" from bitmonero. (Randi Joseph) 78b13d6 Cleanup. Dropped "bit" from bitmonero. (Randi Joseph) 1e6aedb Cleanup. Dropped "bit" from bitmonero. (Randi Joseph) 9e54616 Dropped "bit" from bitmonero. (Randi Joseph)
2016-10-04Fix description for locked_transferOyvind Kvanes1-1/+1
2016-10-04Merge pull request #1162Riccardo Spagni1-1/+1
e5f8642 Update minimum mixin in transfer_original help text (TedTheFicus) ea45d61 Update minimum mixin in transfer_original help text (TedTheFicus)
2016-10-04Merge pull request #1140Riccardo Spagni2-26/+273
bba6af9 wallet: cold wallet transaction signing (moneromooo-monero) 9872dcb wallet: fix log confusion between bytes and kilobytes (moneromooo-monero) d9b0bf9 cryptonote_core: make extra field removal more generic (moneromooo-monero) 98f19d4 serialization: add support for serializing std::pair and std::list (moneromooo-monero)
2016-10-04Rename to lockblocks and add max valueOyvind Kvanes1-45/+30
2016-10-01Update minimum mixin in transfer_original help textTedTheFicus1-1/+1
Changed the wording from "from 0 to maximum available" to "from 2 to maximum available". May I also suggest putting in a number rather than "maximum available" and also clarifying that mixin = 0 is still allowed if the user has unmixable outputs (dust), which he wants to "undust" using sweep_unmixable (comment from dEBRUYNE-1 ).
2016-10-01wallet: wallet option to confirm transfers with no payment idmoneromooo-monero2-1/+81
set confirm-missing-payment-id 0|1 Defaults to true.
2016-09-28Fix locked_transferOyvind Kvanes1-6/+3
2016-09-28Add locked_transferOyvind Kvanes1-87/+83
2016-09-28Revert transfer_main in simplewalletOyvind Kvanes2-22/+279
2016-09-28Add motifications to test out locked_transferOyvind Kvanes1-6/+18
2016-09-28Add more information to transaction in walletOyvind Kvanes1-1/+8
2016-09-28Make a small test changeOyvind Kvanes1-1/+1
2016-09-27wallet: cold wallet transaction signingmoneromooo-monero2-26/+273
This change adds the ability to create a new unsigned transaction from a watch only wallet, and save it to a file. This file can then be moved to another computer/VM where a cold wallet may load it, sign it, and save it. That cold wallet does not need to have a blockchain nor daemon. The signed transaction file can then be moved back to the watch only wallet, which can load it and send it to the daemon. Two new simplewallet commands to use it: sign_transfer (on the cold wallet) submit_transfer (on the watch only wallet) The transfer command used on a watch only wallet now writes an unsigned transaction set in a file called 'unsigned_monero_tx' instead of submitting the tx to the daemon as a normal wallet does. The signed tx file is called 'signed_monero_tx'.
2016-09-26Dropped "bit" from bitmonero.Randi Joseph1-2/+2
2016-09-26Merge pull request #1117Riccardo Spagni1-1/+1
fc855c1 Made error message consistent with other, more helpful, message (Will Skinner)
2016-09-22Made error message consistent with other, more helpful, messageWill Skinner1-1/+1
2016-09-19Remove redundant "default" in set mixin help descJ Ryan Littlefield1-1/+1
2016-09-18Merge pull request #1094Riccardo Spagni1-3/+5
06bb692 cmake: support BUILD_SHARED_LIBS built-in option (redfish) e1c7af3 cmake: transitive deps and remove deprecated LINK_* (redfish) 54010b9 crypto: armv7: slow-hash: remove redundant source include (redfish)
2016-09-18Merge pull request #1089Riccardo Spagni1-10/+11
368485d simplewallet: do not expose the details of tx splitting to the user (moneromooo-monero)
2016-09-18cmake: transitive deps and remove deprecated LINK_*redfish1-3/+5
Keep the immediate direct deps at the library that depends on them, declare deps as PUBLIC so that targets that link against that library get the library's deps as transitive deps. Break dep cycle between blockchain_db <-> crytonote_core. No code refactoring, just hide cycle from cmake so that it doesn't complain (cycles are allowed only between static libs, not shared libs). This is in preparation for supproting BUILD_SHARED_LIBS cmake built-in option for building internal libs as shared.
2016-09-17simplewallet: do not expose the details of tx splitting to the usermoneromooo-monero1-10/+11
They're confusing, as people think it reports their balance.
2016-09-17simplewallet: fix wrong amount in show_transfers for pending transactionsmoneromooo-monero1-1/+1
Change was not taken into consideration
2016-09-16wallet: change priority/fee to ArticMine's recommendationmoneromooo-monero2-16/+16
We keep 1, 2, 3 multipliers till the fee decrase from 0.01/kB to 0.002/kB, where we start using 1, 20, 166 multipliers. This ensures the higher multiplier will compensate for the block reward penalty when pushing past 100% of the past median. The fee-multiplier wallet setting is now rename to priority, since it keeps its [0..3] range, but maps to different multiplier values.
2016-09-11Add snap packaging.Casey Marshall1-1/+2
This adds [snap](https://snapcraft.io) packaging to the project. See the link for more information on snaps. Snap packages install on all Linux distributions. On Ubuntu, snap confinement with apparmor and seccomp provide an additional layer of security. This snap sets up monerod as a systemd service, which should start immediately on install. To access the wallet CLI, simply run `monero` (/snap/bin/monero). I think it's a really quick & easy way to get started with monero. I've made some opinionated decisions in the packaging just to kick this off, but I'm happy to iterate on this stuff.
2016-09-03fix remaining bitmonero and simplewallet bitsRiccardo Spagni1-5/+5
2016-09-03rename simplewalletRiccardo Spagni1-0/+3
2016-09-01simplewallet: add magic and public keys to key image export filemoneromooo-monero1-5/+30
This ensures it's hard to mix files up
2016-09-01simplewallet: make the key image export format binarymoneromooo-monero1-18/+5
Saves on space, and on some pointless hex conversions
2016-08-28wallet: fix some "may be used uninitialized" warningsmoneromooo-monero1-8/+8
The compiler can't always work out the _found booleans are set iff the value is initialized.
2016-08-28rct amount key modified as per luigi1111's recommendationsmoneromooo-monero1-8/+20
This allows the key to be not the same for two outputs sent to the same address (eg, if you pay yourself, and also get change back). Also remove the key amounts lists and return parameters since we don't actually generate random ones, so we don't need to save them as we can recalculate them when needed if we have the correct keys.
2016-08-28wallet: do not store signatures in the wallet cachemoneromooo-monero1-1/+1
Saves some substantial space. Also avoid calculating tx hashes we don't need.
2016-08-28simplewallet: better check_tx_key feedbackmoneromooo-monero1-2/+20
Print number of confirmations if the tx is in the blockchain, or a warning if it's in the pool.
2016-08-28rct: make the amount key derivable by a third party with the tx keymoneromooo-monero1-24/+16
Scheme design from luigi1114.
2016-08-28port get_tx_key/check_tx_key to rctmoneromooo-monero1-12/+51
2016-08-28wallet: factor transfer_rct code with transfer codemoneromooo-monero2-13/+2
The "transfer" simplewallet command is renamed to "transfer_original". "transfer_new" is renamed "transfer", "transfer_rct" is removed, and the new "transfer" now selects rct or non rct transactions based on the current block height.
2016-08-28add rct to the protocolmoneromooo-monero2-20/+43
It is not yet constrained to a fork, so don't use on the real network or you'll be orphaned or rejected.
2016-08-26Merge pull request #982Riccardo Spagni1-1/+1
65238d2 fix #691 removed help about leaving wallet name empty on --generate-new-wallet (guzzi_jones)
2016-08-26Merge pull request #976Riccardo Spagni1-1/+8
c2f4e16 simplewallet: default to max-concurrency 1 on MacOS X (moneromooo-monero)
2016-08-24fix #691 removed help about leaving wallet name empty on --generate-new-walletguzzi_jones1-1/+1
2016-08-21simplewallet: default to max-concurrency 1 on MacOS Xmoneromooo-monero1-1/+8
A suspected bug in pthread/kernel, though might be that I messed something up too... This might rope in more platforms though.
2016-08-16simplewallet: do not suggest removing cache if the password was wrongmoneromooo-monero1-1/+3
2016-08-11Merge pull request #948Riccardo Spagni1-6/+6
11dc091 Fake outs set is now decided by the wallet (moneromooo-monero) 1593553 new unlocked parameter to output_histogram (moneromooo-monero)
2016-08-11Fake outs set is now decided by the walletmoneromooo-monero1-6/+6
This plugs a privacy leak from the wallet to the daemon, as the daemon could previously see what input is included as a transaction input, which the daemon hadn't previously supplied. Now, the wallet requests a particular set of outputs, including the real one. This can result in transactions that can't be accepted if the wallet happens to select too many outputs with non standard unlock times. The daemon could know this and select another output, but the wallet is blind to it. It's currently very unlikely since I don't think anything uses non default unlock times. The wallet requests more outputs than necessary so it can use spares if any of the returns outputs are still locked. If there are not enough spares to reach the desired mixin, the transaction will fail.
2016-08-11Merge pull request #952Riccardo Spagni2-4/+9
709c724 Better fix (#4) (hyc) d2644c1 fix restore-deterministic height (luigi1111)
2016-08-11Merge pull request #949Riccardo Spagni2-69/+64
da1007f simplewallet: make the refresh thread into more generic idle thread (moneromooo-monero)
2016-08-09Better fix (#4)hyc2-4/+9
2016-08-09fix restore-deterministic heightluigi11111-2/+2
Simplewallet improperly skipped the restore from height code if restoring a deterministic wallet AND not specifying a wallet file in the command line. The other generate options require a wallet file as an argument, which prevents "ask_wallet_create_if_needed()" from being called, which in turn causes "m_generate_new" to remain unset. Specifying a wallet file at launch with --restore-deterministic emulated this behavior.
2016-08-07simplewallet: make the refresh thread into more generic idle threadmoneromooo-monero2-69/+64
2016-08-01Fix #864guzzi_jones4-53/+106
Squashed commit of the following: commit 9af9e4223b58bbb65a3519af2c2bfc273cbd23d6 fixed some formatting commit c7920e1cf88ff46eb9294101344d9a567f22e2da Merge: 97eb28b 1da1c68 fix#864 fix using boolean commit 97eb28ba5dd49ddde8c8785f39b24d955e5de31c Fix #864 boolean value used to verify on new wallet commit 1da1c68bd3a9a373c70482b6e6e95251096149f1 fix #864 changed to boolean to prompt for verify commit 5bee96652434762d2c91ce31a1b1c9f169446ddc fix 864; made variable names easier for understanding branching. commit 45715960d30293f781b2ff9e5e647c2ec893f4a3 fix #864; allow password to be entered twice for new wallets for verification. fix #864 password entry verification; ammended boolean fix #864 ; default constructor for password_container should set verify=true
2016-07-24wallet: new {ex,im}port_key_images commands and RPC callsmoneromooo-monero2-0/+109
They are used to export a signed set of key images from a wallet with a private spend key, so an auditor with the matching view key may see which of those are spent, and which are not.
2016-07-23Merge pull request #923Riccardo Spagni1-0/+1
8312887 simplewallet: suggest removing cache when loading fails (moneromooo-monero)
2016-07-23Merge pull request #916Riccardo Spagni1-2/+28
b89b963 wallet: add unconfirmed incoming txes from the txpool (moneromooo-monero)
2016-07-22simplewallet: suggest removing cache when loading failsmoneromooo-monero1-0/+1
2016-07-20wallet: add unconfirmed incoming txes from the txpoolmoneromooo-monero1-2/+28
Shown in show_transfers simplewallet command, and get_transfers RPC command, if req.pool is true.
2016-07-20simplewallet: revert to foreground refresh at startupmoneromooo-monero1-0/+2
Background refresh is confusing to users at startup.
2016-07-20Merge pull request #902Riccardo Spagni2-9/+27
014f3a0 Add a daemon RPC version, and make simplewallet check it (moneromooo-monero)
2016-07-19wallet: add command and RPC to sign/verify datamoneromooo-monero2-0/+69
Signing is done using the spend key, since the view key may be shared. This could be extended later, to let the user choose which key (even a per tx key). simplewallet's sign/verify API uses a file. The RPC uses a string (simplewallet can't easily do strings since commands receive a tokenized set of arguments).
2016-07-10Add a daemon RPC version, and make simplewallet check itmoneromooo-monero2-9/+27
If the version is different, simplewallet will refuse to use that daemon, unless --allow-mismatched-daemon-version is used.
2016-07-06Merge pull request #879Riccardo Spagni1-0/+1
6b08001 simplewallet: mention the background refresh thread when starting (moneromooo-monero)
2016-07-06Merge pull request #878Riccardo Spagni2-1/+80
945c272 wallet: add a fee multiplier (moneromooo-monero)
2016-06-23TransactionHistory continuedIlya Kitaev1-1/+1
2016-06-22simplewallet: mention the background refresh thread when startingmoneromooo-monero1-0/+1
It should be less confusing for people who're used to the foreground refresh from earlier versions.
2016-06-22wallet: add a fee multipliermoneromooo-monero2-1/+80
Fee can now be multiplied by 2 or 3, if users want to give priority to their transactions. There are only three levels to avoid too much fingerprinting. Default is 1 (minimum fee). The default multiplier can be set by "set fee-multiplier X".
2016-06-21Merge pull request #870Riccardo Spagni1-2/+6
57dce80 gmtime for Windows (luigi1111)
2016-06-20gmtime for Windowsluigi11111-2/+6
gmtime_r is not available in Windows, use gmtime_s instead. Also change shorthand codes (also not working in Windows).
2016-06-20simplewallet: add a status commandmoneromooo-monero2-0/+25
It matches the daemon, and should allow people who're suspicious of the background refresh to know they're synced.
2016-05-17Merge pull request #827Riccardo Spagni1-14/+16
f1e70d1 Only log 1/N skipped blocks (Howard Chu) cebb97c Move refresh height to keys file from cache file (Howard Chu) 590c439 Make fast_refresh interruptible (Howard Chu) 687855d Set refresh height earlier (Howard Chu) 2fb00c0 Fix 19fe8ae3ef1aa46ae8fdd4e4d6862510390ddab7 (Howard Chu)
2016-04-29Set refresh height earlierHoward Chu1-13/+15
Do it before the generate() call so the value actually gets stored.
2016-04-29Merge pull request #826Riccardo Spagni1-27/+44
76c6bf1 simplewallet: display all settings on set with no arguments (moneromooo-monero)
2016-04-29Fix 19fe8ae3ef1aa46ae8fdd4e4d6862510390ddab7Howard Chu1-2/+2
Don't prompt for restore-height on generate-new-wallet
2016-04-28simplewallet: display all settings on set with no argumentsmoneromooo-monero1-27/+44
2016-04-28add a --max-concurrency flagmoneromooo-monero1-1/+6
It sets the max number of threads to use for a parallel job. This is different that the number of total threads, since monero binaries typically start a lot of them.
2016-04-27Merge pull request #823Riccardo Spagni1-1/+1
a687e6e simplewallet: fix pending transfers fee display in show_transfers (moneromooo-monero)
2016-04-26simplewallet: fix pending transfers fee display in show_transfersmoneromooo-monero1-1/+1
2016-04-26simplewallet: more threading fixesmoneromooo-monero1-1/+5
2016-04-26wallet: allow attaching notes to txidsmoneromooo-monero2-3/+63
2016-04-26wallet: add GMT timestamps to transfers/paymentsmoneromooo-monero1-3/+20
2016-04-26Merge pull request #817Riccardo Spagni2-11/+45
4b1c0d6 simplewallet: some background refresh threading fixes (moneromooo-monero)
2016-04-26Merge pull request #815Riccardo Spagni2-63/+307
b0850a9 wallet: add a new sweep_all command and RPC command (moneromooo-monero)
2016-04-26Merge pull request #814Riccardo Spagni1-7/+19
68cbe15 modified: src/wallet/wallet2.cpp modified: src/wallet/wallet2.h (awfulcrawler) 4b325bd modified: src/simplewallet/simplewallet.cpp modified: src/wallet/wallet2.cpp modified: src/wallet/wallet2.h (awfulcrawler)
2016-04-21simplewallet: some background refresh threading fixesmoneromooo-monero2-11/+45
We want to lock operations which access the blockchain in wallet2. We also want the background refresh to happen again when we cancel a foreground refresh. Wrap the locking setup in a macro so it doesn't get copy/pasted/mangled, and use a scope exit trick to ensure it's always properly restored.
2016-04-19wallet: add a new sweep_all command and RPC commandmoneromooo-monero2-63/+307
This sends all outputs in a wallet to a given address, alleviating the difficulty people have had trying to send all monero but being left with some small amount left.
2016-04-18 modified: src/simplewallet/simplewallet.cppawfulcrawler1-7/+19
modified: src/wallet/wallet2.cpp modified: src/wallet/wallet2.h Update to fix unconfirmed balance and give a slightly more verbose and informative confirmation message for transfers
2016-04-17Add --restore-height optionHoward Chu2-0/+25
For specifying the block height from which to start a restore
2016-04-17Speed up new wallet refreshHoward Chu1-0/+6
Use the current blockchain height as the refresh_from_block_height.
2016-04-14Merge pull request #803Riccardo Spagni1-2/+13
c33ffc8 simplewallet: save fixes in RPC mode (moneromooo-monero)
2016-04-14Merge pull request #785Riccardo Spagni1-5/+66
1a58d20 simplewallet: optional address in --generate-from-json (moneromooo-monero)
2016-04-14Merge pull request #783Riccardo Spagni1-2/+2
48d0747 wallet: better output selection for transfer/transfer_new (moneromooo-monero)
2016-04-14Merge pull request #801Riccardo Spagni1-0/+1
ed61a2c simplewallet: set strict umask at start (moneromooo-monero) 7385c03 util: add a function to set umask to 077 (moneromooo-monero)
2016-04-10simplewallet: save fixes in RPC modemoneromooo-monero1-2/+13
^C when in RPC mode would not save the wallet while it was still refreshing after starting up. Also, save the wallet out of the signal handler. We don't want to call complex stuff in a signal handler.
2016-04-09rpc: add pool/blockchain and block height results to gettransactionsmoneromooo-monero1-2/+7
2016-04-06simplewallet: set strict umask at startmoneromooo-monero1-0/+1
2016-04-02simplewallet: optional address in --generate-from-jsonmoneromooo-monero1-5/+66
When present, it can be used to validate the keys, as well as deduce the spend key, if it is absent (watch wallet).
2016-04-02wallet: better output selection for transfer/transfer_newmoneromooo-monero1-2/+2
This now requests the set of outputs that can be mixed first, to avoid trying non dust but unmixable outputs, which we know will fail.
2016-04-02Merge pull request #772Riccardo Spagni1-0/+34
ead6956 simplewallet: always gracefully exit on EOF (moneromooo-monero)
2016-04-02Merge pull request #769Riccardo Spagni1-41/+31
b4eada9 wallet: make load_keys check types when loading JSON (moneromooo-monero) 3e55725 wallet: make the JSON reading type safe (moneromooo-monero) f8d05f3 common: new json_util.h (moneromooo-monero)
2016-04-02Merge pull request #767Riccardo Spagni1-0/+6
24b3e90 Convey tx verification failure reasons to the RPC client (moneromooo-monero)
2016-04-02Merge pull request #766Riccardo Spagni1-0/+42
77d1c6b simplewallet: default to trusted daemon for loopback address (moneromooo-monero)
2016-03-29simplewallet: always gracefully exit on EOFmoneromooo-monero1-0/+34
2016-03-27wallet: make the JSON reading type safemoneromooo-monero1-41/+31
2016-03-27Convey tx verification failure reasons to the RPC clientmoneromooo-monero1-0/+6
This allows appropriate action to be taken, like displaying the reason to the user. Do just that in simplewallet, which should help a lot in determining why users fail to send. Also make it so a tx which is accepted but not relayed is seen as a success rather than a failure.
2016-03-27simplewallet: default to trusted daemon for loopback addressmoneromooo-monero1-0/+42
2016-03-26wallet: do not leak owned amounts to the daemon unless --trusted-daemonmoneromooo-monero1-1/+1
This will be slower, though more private. New trusted_daemon parameter to the matching RPC call, false by default.
2016-03-26wallet: change sweep_dust to sweep_unmixablemoneromooo-monero2-14/+23
With the change in mixin rules for v2, the "annoying" outputs are slightly changed. There is high correlation between dust and unmixable, but no equivalence.
2016-03-25wallet: add a --generate-from-json flagmoneromooo-monero2-6/+182
It takes a filename containing JSON data to generate a wallet. The following fields are valid: version: integer, should be 1 filename: string, path/filename for the newly created wallet scan_from_height: 64 bit unsigned integer, optional password: string, optional viewkey: string, hex representation spendkey: string, hex representation seed: string, optional, list of words separated by spaces Either seed or private keys should be given. If using private keys, the spend key may be omitted (the wallet will not be able to spend, but will see incoming transactions). If scan_from_height is given, blocks below this height will not be checked for transactions as an optimization.
2016-03-21Revert "Print stack trace upon exceptions"moneromooo-monero1-1/+1
Ain't nobody got time for link/cmake skullduggery. This reverts commit fff238ec94ac6d45fc18c315d7bc590ddfaad63d.
2016-03-20Merge pull request #734Riccardo Spagni1-42/+54
b525457 simplewallet: make --password-file work in RPC mode (moneromooo-monero)
2016-03-19simplewallet: make --password-file work in RPC modemoneromooo-monero1-42/+54
2016-03-19Print stack trace upon exceptionsmoneromooo-monero1-1/+1
Useful for debugging users' logs
2016-03-12Merge pull request #718Riccardo Spagni1-0/+1
41ea91a simplewallet: fix hang when setting auto-refresh to 0 (moneromooo-monero)
2016-03-12simplewallet: fix hang when setting auto-refresh to 0moneromooo-monero1-0/+1
It would try to join the auto refresh thread, which would only happen after it was done, which would take a long time when doing so on a newly created wallet.
2016-03-12simplewallet: special ^C handling for windowsmoneromooo-monero1-0/+4
Because obviously it doesn't work as other POSIX platforms. Reported and tested by luigi1111.
2016-03-11Use boost::thread instead of std::threadHoward Chu2-10/+10
and all other associated IPC
2016-02-29Merge pull request #688Riccardo Spagni2-19/+117
c2a1fee simplewallet: prompt for private keys when generating wallets (moneromooo-monero) 4513b4c simplewallet: add a new --restore-from-keys option (moneromooo-monero)
2016-02-27simplewallet: prompt for private keys when generating walletsmoneromooo-monero1-32/+33
instead of supplying them on the command line. It's more unwieldy, but better protects against information leaks.
2016-02-22simplewallet: add a new --restore-from-keys optionmoneromooo-monero2-5/+102
It is similar in use to --restore-from-view-key, but also expects a spend private key. Requested by luigi1112, and useful to restore MyMonero wallets.
2016-02-22move g_test_dbg_lock_sleep from a global to a function level staticmoneromooo-monero1-2/+0
This avoids the need to define that variable in every program which uses epee.
2016-02-20simplewallet: wording change for single tx confirmationmoneromooo-monero1-3/+12
2016-02-05simplewallet: check watch-only view key matches standard addressmoneromooo-monero1-0/+11
2016-01-30simplewallet: show_transfers can now show just failed txesmoneromooo-monero1-6/+13
2016-01-29wallet: detect and handle failed outgoing transfersmoneromooo-monero1-1/+2
When a transaction is not found in the pool anymore, it is marked as failed, and displayed as such in show_transfers.
2016-01-29Fix V1/V2 use of hard fork related parametersmoneromooo-monero1-1/+2
Some of it uses hardcoded height, which will need some thinking for next (voted upon) fork.
2016-01-25simplewallet: remove leftover command line refresh-type handlingmoneromooo-monero2-5/+0
2016-01-09use load_file_to_string and exit with error on file read errorsFabian Hirschmann1-3/+9
2016-01-09remove new lines at the end of the password onlyFabian Hirschmann1-2/+2
2016-01-09add --password-file optionFabian Hirschmann1-0/+19
2015-12-31update versionRiccardo Spagni1-3/+3
2015-12-31updated copyright yearRiccardo Spagni5-5/+5
2015-12-30wallet: add a rescan_bc command and rescan_blockchain RPCmoneromooo-monero2-13/+28
Blockchain hashes and key images are flushed, and blocks are pulled anew from the daemon. The console command is shortened to match bc_height. This should make it a lot easier on users who are currently told to remove this particular cache file but keep the keys one, etc, etc.
2015-12-19Add missing semicolons after log statementsmoneromooo-monero1-1/+1
2015-12-11Stop displaying internal commands for --helpluigi11111-1/+1
Displaying in-program commands with --help doesn't match daemon behaviour (or make sense)
2015-12-11simplewallet help & error cleanupluigi11111-120/+120
Typos, grammar, consistency. I don't claim to have gotten everything.
2015-12-05wallet: make the wallet refresh type a wallet settingmoneromooo-monero2-33/+78
instead of a command line setting. It makes sense that is is a long lived setting.
2015-11-30Merge pull request #512Riccardo Spagni1-8/+8
36a298c simplewallet: add tr markers in a few missing user visible strings (moneromooo-monero)
2015-11-29wallet: cancellable refreshmoneromooo-monero2-7/+50
^C while in manual refresh will cancel the refresh, since that's often an annoying thing to have to wait for. Also, a manual refresh command will interrupt any running background refresh and take over, rather than wait for the background refresh to be done, and look to be hanging.
2015-11-30Merge pull request #511Riccardo Spagni1-1/+1
66849ac simplewallet: swap colors in show_transfers (moneromooo-monero)
2015-11-29simplewallet: add tr markers in a few missing user visible stringsmoneromooo-monero1-8/+8
2015-11-29simplewallet: swap colors in show_transfersmoneromooo-monero1-1/+1
Green is now used for incoming transfers, and magenta for outgoing transfers. This is consistent to the scheme used by other logging.
2015-11-28wallet: optional automatic refresh from the daemonmoneromooo-monero2-9/+113
The daemon will be polled every 90 seconds for new blocks. It is enabled by default, and can be turned on/off with set auto-refresh 1 and set auto-refresh 0 in the wallet.
2015-11-22wallet: make the refresh optimizations selectable via command linemoneromooo-monero2-3/+42
Take the opportunity to add a no-coinbase case too, for even faster sync when an address is known to never have mined to.
2015-11-22Merge pull request #496Riccardo Spagni2-16/+35
db1fb66 wallet: storing outgoing tx info now defaults to enabled (moneromooo-monero) 9156ba3 wallet: rename store-tx-keys to store-tx-info (moneromooo-monero) b3d4d41 wallet: improve show_transfers (moneromooo-monero) 725ae4e wallet: use incoming blocks to keep track of payments too (moneromooo-monero) 00790a8 simplewallet: lessen display flicker confusion (moneromooo-monero)
2015-11-22wallet: rename store-tx-keys to store-tx-infomoneromooo-monero2-7/+7
With backward compatibility
2015-11-22wallet: improve show_transfersmoneromooo-monero1-8/+25
More information is now saved and displayed
2015-11-21wallet: use incoming blocks to keep track of payments toomoneromooo-monero1-4/+6
2015-11-21simplewallet: lessen display flicker confusionmoneromooo-monero1-2/+2
Height seemed to be flying all over the place on a rescan here. Logging to a file shows the heights are actually correct, and this is some kind of screen refresh artifact. Flush after \r and update less often to reduce this effect a lot.
2015-11-21Fix startup crash when using a locale boost does not likemoneromooo-monero1-1/+4
There are various locale related bugs in various versions of boost, where exceptions are thrown in boost::filesystem APIs when the current locale is not to boost's liking. It's not clear what "not to boost's liking" means in detail, though "en" and "en_US.UTF-8" are not to its liking. Fix it by running a test function that's known to throw in such a case, and resetting LANG and LC_ALL to C if an exception is thrown. In simplewallet, the locale is queried before that so the correct translations will still be used.
2015-11-15wallet: track outgoing payments and add a show_transfers commandmoneromooo-monero2-0/+100
It's a user friendly display of incoming and outgoing transfers, listed by height, within an optional height range.
2015-10-30simplewallet: add a set default-mixin commandmoneromooo-monero2-3/+77
The default default mixin is 4. It can now be changed per wallet.
2015-10-27Fix a possibly-unused warning, and rationalize typesmoneromooo-monero1-3/+3
2015-10-14simplewallet: add a check_tx_key commandmoneromooo-monero2-0/+106
It allows one to check the amount of monero sent to a particular address in a particular transaction, given that transaction's tx key
2015-10-12simplewallet: hide start_mining behind --trusted-daemonmoneromooo-monero1-0/+6
because it leaks your standard address
2015-10-11Merge pull request #427Riccardo Spagni2-0/+10
df8a110 simplewallet: add a --trusted-daemon flag (moneromooo-monero)
2015-10-11simplewallet: add a --trusted-daemon flagmoneromooo-monero2-0/+10
It allows enabling the rescan_spent command only for trusted daemon
2015-10-11simplewallet: bump default mixin from 3 to 4moneromooo-monero1-1/+1
As recommended in MRL-0004
2015-08-26Merge pull request #390Riccardo Spagni1-1/+1
5dc53c2 wallet: use mutex protected random generation api (moneromooo-monero)
2015-08-26wallet: use mutex protected random generation apimoneromooo-monero1-1/+1
2015-08-24simplewallet: add a store-tx-keys option to setmoneromooo-monero2-1/+46
To enable storing tx keys in the (now encrypted) wallet cache.
2015-08-19make tx keys available to the usermoneromooo-monero2-0/+33
They are also stored in the cache file, to be retrieved using a new get_tx_key command.
2015-08-16simplewallet: Use default log file name when executable's file path is unknownwarptangent1-3/+21
Default to "simplewallet.log" in current directory when file path isn't obtained from epee. In this situation previously, it defaulted to the file name of ".log" ("" + ".log") in the current directory. (Thanks to @sammy007 for reporting bug.) An earlier version yet used "" + "/" + ".log" = "/.log", which resulted in silently not logging in most cases, due to lack of permission. Test: PATH=$PATH:</path/to/simplewallet/folder> && simplewallet --wallet-file /dev/null This results in epee not finding the executable's file path, so simplewallet will now use a default log filename.
2015-08-11wallet: new rescan_spent command to update outputs' spent statusmoneromooo-monero2-0/+41
This obsoletes the need for a lengthy blockchain rescan when a transaction doesn't end up in the chain after being accepted by the daemon, or any other reason why the wallet's idea of spent and unspent outputs gets out of sync from the blockchain's.
2015-08-09encrypted payment ids are now 64 bit, instead of 256 bitmoneromooo-monero1-28/+30
Pros: - smaller on the blockchain - shorter integrated addresses Cons: - less sparseness - less ability to embed actual information The boolean argument to encrypt payment ids is now gone from the RPC calls, since the decision is made based on the length of the payment id passed.
2015-08-09Encrypted payment IDsmoneromooo-monero1-2/+8
A payment ID may be encrypted using the tx secret key and the receiver's public view key. The receiver can decrypt it with the tx public key and the receiver's secret view key. Using integrated addresses now cause the payment IDs to be encrypted. Payment IDs used manually are not encrypted by default, but can be encrypted using the new 'encrypt_payment_id' field in the transfer and transfer_split RPC calls. It is not possible to use an encrypted payment ID by specifying a manual simplewallet transfer/transfer_new command, though this is just a limitation due to input parsing.
2015-07-22wallet: new transaction construction algorithmmoneromooo-monero2-2/+19
It should avoid a lot of the issues sending more than half the wallet's contents due to change. Actual output selection is still random. Changing this would improve the matching of transaction amounts to output sizes, but may have non obvious effects on blockchain analysis. Mapped to the new transfer_new command in simplewallet, and transfer uses the existing algorithm. To use in RPC, add "new_algorithm: true" in the transfer_split JSON command. It is not used in the transfer command.
2015-07-19simplewallet: fix context/string order mismatchmoneromooo-monero1-1/+1
2015-07-19simplewallet: use unsigned long long instead of size_t in messagemoneromooo-monero1-4/+4
boost doesn't support %zu for size_t, and the previous change to %u could technically lose bits (though it would require splitting a transfer into 4 billion transactions, which seems unlikely).