Age | Commit message (Collapse) | Author | Files | Lines |
|
aee7a4e3 wallet_rpc_server: do not use RPC data if the call failed (moneromooo-monero)
1a0733e5 windows_service: fix memory leak (moneromooo-monero)
0dac3c64 unit_tests: do not rethrow a copy of an exception (moneromooo-monero)
5d9915ab cryptonote: fix get_unit for non default settings (moneromooo-monero)
d4f50cb1 remove some unused code (moneromooo-monero)
61163971 a few minor (but easy) performance tweaks (moneromooo-monero)
30023074 tests: slow_memmem now returns size_t (moneromooo-monero)
|
|
96e6b439 blockchain_stats: don't use gmtime_r on Windows (moneromooo-monero)
|
|
3998a937 Enhance help text for print_ring. (Tadeas Moravec)
3900fb77 Enhance help text for incoming_transfers. (Tadeas Moravec)
|
|
- simple device callback object added. Device can request passphrase/PIN entry via the callback or notify user some action is required
- callback is routed to wallet2, which routes the callback to i_wallet_callback so CLI or GUI wallets can support passphrase entry for HW tokens
- wallet: device open needs wallet callback first - passphrase protected device needs wallet callback so user can enter passphrase
|
|
for show_transfers
Followup on #4728
|
|
|
|
Found by codacy.com
|
|
In some cases, it doesn't like it (I don't know the details).
Factor into a new epee function
|
|
|
|
|
|
79b4dae6 simplewallet: slightly adjust wording when printing multisig seed (stoffu)
|
|
5d4f3df8 simplewallet: reorganize SCOPED_WALLET_UNLOCK a bit more (stoffu)
|
|
5878fe95 simplewallet: don't skip asking for password when watch-only (stoffu)
|
|
c22e85fe simplewallet: remove redundant messages on daemon connection failure (stoffu)
|
|
a9357141 Add new command "export_transfers" to save transfers to csv (sachaaaaa)
|
|
|
|
|
|
|
|
f26ce08c wallet: add a non destructive blockchain rescan (moneromooo-monero)
|
|
1f35de23 simplewallet: display locked/unlocked state in show_transfers (moneromooo-monero)
|
|
|
|
and disable annoying test that requires ridiculous amounts
of skullduggery every time some format changes
|
|
Followup on #4555
|
|
|
|
|
|
|
|
try_connect_to_daemon with silent=false already prints failure message
|
|
6f88c03d Simplewallet: update help text for show_transfers. (Ted Moravec)
|
|
68e9744d simplewallet: perform trivial error checks before password prompt (xiphon)
|
|
f2c2c47a simplewallet: fixed deadlock if a user hits CTRL+C twice (xiphon)
|
|
it doesn't display the details, which are already displayed
in show_transfer
|
|
Apparently some people seem to think it's a censorship list...
|
|
Describe the output format.
|
|
c0822fdd simplewallet: mark default-ring-size setting as obsolete (moneromooo-monero)
|
|
|
|
|
|
Co-authored-by: moneromooo-monero <moneromooo-monero@users.noreply.github.com>
|
|
|
|
9acf42d3 Multisig M/N functionality core tests added (naughtyfox)
9f3963e8 Arbitrary M/N multisig schemes: * support in wallet2 * support in monero-wallet-cli * support in monero-wallet-rpc * support in wallet api * support in monero-gen-trusted-multisig * unit tests for multisig wallets creation (naughtyfox)
|
|
Some strings were not detected by lupdate because "tr() cannot be called without
context".
|
|
a0613532 secure_pwd_reader: Add proper Unicode handling [Ryo contribution] (fireice-uk)
579383c2 simplewallet: Add Unicode input_line [Ryo backport] (fireice-uk)
|
|
* support in wallet2
* support in monero-wallet-cli
* support in monero-wallet-rpc
* support in wallet api
* support in monero-gen-trusted-multisig
* unit tests for multisig wallets creation
|
|
|
|
bcf3f6af fuzz_tests: catch unhandled exceptions (moneromooo-monero)
3ebd05d4 miner: restore stream flags after changing them (moneromooo-monero)
a093092e levin_protocol_handler_async: do not propagate exception through dtor (moneromooo-monero)
1eebb82b net_helper: do not propagate exceptions through dtor (moneromooo-monero)
fb6a3630 miner: do not propagate exceptions through dtor (moneromooo-monero)
2e2139ff epee: do not propagate exception through dtor (moneromooo-monero)
0749a8bd db_lmdb: do not propagate exceptions in dtor (moneromooo-monero)
1b0afeeb wallet_rpc_server: exit cleanly on unhandled exceptions (moneromooo-monero)
418a9936 unit_tests: catch unhandled exceptions (moneromooo-monero)
ea7f9543 threadpool: do not propagate exceptions through the dtor (moneromooo-monero)
6e855422 gen_multisig: nice exit on unhandled exception (moneromooo-monero)
53df2deb db_lmdb: catch error in mdb_stat calls during migration (moneromooo-monero)
e67016dd blockchain_blackball: catch failure to commit db transaction (moneromooo-monero)
661439f4 mlog: don't remove old logs if we failed to rename the current file (moneromooo-monero)
5fdcda50 easylogging++: test for NULL before dereference (moneromooo-monero)
7ece1550 performance_test: fix bad last argument calling add_arg (moneromooo-monero)
a085da32 unit_tests: add check for page size > 0 before dividing (moneromooo-monero)
d8b1ec8b unit_tests: use std::shared_ptr to shut coverity up about leaks (moneromooo-monero)
02563bf4 simplewallet: top level exception catcher to print nicer messages (moneromooo-monero)
c57a65b2 blockchain_blackball: fix shift range for 32 bit archs (moneromooo-monero)
|
|
174f31bf simplewallet: don't complain about payment id on pool mined blocks (moneromooo-monero)
|
|
8db2d8d4 simplewallet: fix --generate-from-json setting wrong wallet filename (moneromooo-monero)
|
|
66901901 README: harmonize command formatting inside README.md (Andrea)
8cd98408 disable AES on s390x architecture (Tuan M. Hoang)
4ed30bab wallet: implement coin splitting for sweep_* 'outputs' option (whythat)
24f52396 wallet: add 'outputs' option for sweep_* commands (whythat)
52e19d69 README: Compile boost with cxxflags=-fPIC cflags=-fPIC (Italocoin Project)
0c77523d README: fill in libsodium package name for Arch (phloatingman)
|
|
05edc969 simplewallet: remove obsolete transfer_original command (moneromooo-monero)
|
|
2ace509a simplewallet: print reason why refresh+password is needed (moneromooo-monero)
|
|
|
|
|
|
56b50faa wallet: use wipeable_string in more places where a secret is used (moneromooo-monero)
07ec748c wipeable_string: add hex_to_pod function (moneromooo-monero)
|
|
ba8dd347 api/wallet: properly disable key encryption (stoffu)
|
|
'outputs' option allows to specify the number of
separate outputs of smaller denomination that will
be created by sweep operation.
rebased by moneromooo
|
|
|
|
|
|
- device name is a new wallet property
- full device name is now a bit more structured so we can address particular device vendor + device path. Example: 'Ledger', 'Trezor:udp', 'Trezor:udp:127.0.0.1:21324', 'Trezor:bridge:usb01'. The part before ':' identifies HW device implementation, the optional part after ':' is device path to look for.
- new --hw-device parameter added to the wallet, can name the hardware device
- device reconnect added
|
|
44259e56 wallet: ask-password can now ask without encrypting the secret spend key (moneromooo-monero)
|
|
|
|
20171746 wallet2: factor the creation of a new wallet keys file (moneromooo-monero)
be6acfd5 wallet2: factor new blockchain setup (moneromooo-monero)
|
|
be001326 remove obsolete daemon selection of fake outs and old tx construction (moneromooo-monero)
|
|
|
|
a54dbaee blockchain_blackball: add --force-chain-reaction-pass flag (moneromooo-monero)
44439c32 record blackballs as amount/offset, and add export ability (moneromooo-monero)
4bce935b blockchain_blackball: more optimizations (moneromooo-monero)
b66ba783 blockchain_blackball: do not process duplicate blockchains parts (moneromooo-monero)
639a3c01 blockchain_blackball: make it clear secondary passes are not incremental (moneromooo-monero)
eb8a51be blockchain_blackball: detect spent outputs by partial ring reuse (moneromooo-monero)
d6d276c6 blockchain_blackball: fix chain reaction phase in incremental mode (moneromooo-monero)
2b2a681b blockchain_blackball: avoid false positives for different amounts (moneromooo-monero)
80e4fef3 blockchain_blackball: set transaction looping txn to read only (moneromooo-monero)
4801d6b5 blockchain_blackball: add stats (moneromooo-monero)
846190fd blockchain_blackball: support pre-v2 databases (moneromooo-monero)
daa6cc7d blockchain_blackball: use LMDB for the cache (moneromooo-monero)
50cb370d ringdb: allow blackballing many outputs at once (moneromooo-monero)
|
|
2c636e45 simplewallet: handle transfers using a monero: URI (moneromooo-monero)
|
|
|
|
|
|
|
|
|
|
c3c14f3 simplewallet: allow named priority levels for default-priority (moneromooo-monero)
|
|
|
|
|
|
|
|
77655b0 simplewallet: Simplify LOCK_IDLE_SCOPE macro (rbrunner7)
|
|
3e914ad simplewallet: add a warning and prompt on rescan_blockchain (moneromooo-monero)
|
|
2fd9be1 simplewallet: correct number of human-readable months (rbrunner7)
|
|
The secret spend key is kept encrypted in memory, and
decrypted on the fly when needed.
Both spend and view secret keys are kept encrypted in a JSON
field in the keys file. This avoids leaving the keys in
memory due to being manipulated by the JSON I/O API.
|
|
|
|
f13c7a8 simplewallet: make sure wallet config is stored right after creation (stoffu)
|
|
a3fe1c5 simplewallet: add set_tx_key for importing tx keys from 3rd party wallets (stoffu)
|
|
3a4c3ac simplewallet.unspent_outputs: fix wrong logic for parsing (stoffu)
|
|
5e675de simplewallet: fix language detection when using --use-english-language-names (moneromooo-monero)
|
|
37f0799 wallet: distinguish coinbase from other txes in show_transfers (moneromooo-monero)
|
|
20eb192 simplewallet: reword 'seed encryption' to 'seed offset' (moneromooo-monero)
|
|
5a2864c simplewallet: fix delay when setting auto-refresh off (moneromooo-monero)
|
|
to match those used by the various transfer functions
|
|
|
|
Many people are using this as a "let's see what this does" command
when something doesn't work as they thought it should, and thus
destroying info that they might still need.
|
|
|
|
|
|
|
|
|
|
2951436 wallet: warn when payment IDs are used (moneromooo-monero)
|
|
|
|
|
|
|
|
8c4db68 node_rpc_proxy: factor a few RPC calls using get_info (moneromooo-monero)
|
|
438d52d remove epee from link lines where it's redundant (moneromooo-monero)
|
|
d6d78f1 Allow fractional outputs to be ignored (stoffu)
|
|
13851b2 simplewallet.sweep_all: show usage when parsing fails (stoffu)
|
|
6cb9707 simplewallet: remove leftover global debug trace (moneromooo-monero)
|
|
Subaddresses are better for privacy
|
|
avoids people thinking it's somehow a generic AE system
|
|
9d7f6e60 simplewallet: init trusted daemon flag to false when autodetecting (moneromooo-monero)
|
|
|
|
Takes advantage of caching
|
|
For some reason, this confuses and kills ASAN on startup
as it thinks const uint8_t ipv4_network_address::ID is
defined multiple times.
|
|
dcbc17e wallet: include a suggested number of confirmations based on amount (moneromooo-monero)
|
|
8db23df wallet: on first refresh, start off with a quantized height (moneromooo-monero)
|
|
798dfcf wallet: allow unspendable unmixable outputs to be discarded (stoffu)
|
|
08b85a8 cryptonote_config: add get_config to refactor x = testnet ? config::testnet::X : stagenet ? config::stagenet::X : config::X (stoffu)
0cf80ba net_node: resolve host for node addresses given via command line flags (stoffu)
|
|
This is based on how much an attacking miner stands to lose in block
rewardy by mining a private chain which double spends a payment.
This is not foolproof, since mining is based on luck, and breaks
down as the attacking miner nears 50% of the network hash rate,
and the estimation is based on a constant block reward.
|
|
362f5e6 simplewallet: don't confirm missing payment ID when sending to only subaddresses (stoffu)
|
|
|
|
948c482 simplewallet: grammar fix in warning message (moneromooo-monero)
|
|
8fc0cdb wallet2: lower default for subaddress lookahead when restoring with hardware (stoffu)
248310d Move parse_subaddress_lookahead() from simplewallet.cpp to util.cpp (stoffu)
46e90b7 Wallet API: add support for wallet creation from hardware device (stoffu)
|
|
d45cd37 fix typos in language files and rpc_args.cpp (ordtrogen)
|
|
7bf99a2 fix string handling for donation message (cryptochangements34)
|
|
|
|
|
|
|
|
261ee56 don't limit miner threads in wallet (cryptochangements34)
|
|
|
|
8962f00 simplewallet: add optional trusted/untrusted argument to set_daemon (moneromooo-monero)
941a608 util: consider Tor/I2P addresses to be non local (moneromooo-monero)
2b3357e README: mention --untrusted-daemon (moneromooo-monero)
|
|
6b8568e simplewallet.sign_transfer: rename export to export_raw, add help message (stoffu)
|
|
|
|
|
|
89e51ec simple-wallet-cli: Add warnings about inaccurate balances to to watch-only wallet (jcktm)
|
|
f357210 Fix Typo (Rafficer)
|
|
9c2a7b4 wallet-rpc: watch-only and cold wallet features added (ph4r05)
|
|
f4e3295 simplewallet: set_ring can now take a file with rings (moneromooo-monero)
|
|
for privacy reasons, so an untrusted node can't easily track
wallets from IP address to IP address, etc. The granularity
is 1024 blocks, which is about a day and a half.
|
|
|
|
6f36cf0 Improve 'show_transfers' date formatting (ryan-ronnander)
|
|
e2b7558 handle improper log levels (cryptochangements34)
|
|
config::testnet::X : stagenet ? config::stagenet::X : config::X
|
|
|
|
|
|
|
|
Otherwise the previous daemon's trustedness would carry over.
If not specified, the local address check is performed again.
|
|
- unsigned_txset, signed_txset in transfer / submit_transfer / sign_transfer
- export_outputs, import_outputs
Squashed commits:
[f4d9f3d4] wallet-rpc: do_not_relay removed from submit_transfer
[5b16a86f] wallet-rpc: review-fix - method signature changes, renaming
[b7fbb10a] wallet-rpc: naming fixes (unsigned vs signed), consts renamed
[8c7d2727] wallet-rpc: sign_transfer added
[481d024a] wallet2: sign_tx splitted to work with strings and structs, more granular
[2a474db9] wallet-rpc: wallet2::load_unsigned_tx split to load from str, file
[b1e3a018] wallet-rpc: review fix, load_tx_from_str variable rename
[1f6373be] wallet-rpc: review fix: save_tx_to_{str,file}
[2a08eafc] wallet-rpc: review comments fixes
- redundant this removed from wallet2.cpp
- load_tx_from_str, load_tx_from_file
[43498052] wallet-rpc: submit_transfer added
[9c45d1ad] wallet-rpc: watch_only check, return unsigned_txset
[62831396] wallet2: added string variants to load_tx, save_tx
- analogously to save_multisig_tx
- required for monero-wallet-rpc to support watch-only wallet
|
|
|
|
f36132a wallet cli/rpc: terminate execution with code 0 when --help or --version is given (stoffu)
|
|
c8cb5fc exit if specified wallet file doesn't exist (cryptochangements34)
|
|
3f5fb6f simplewallet: add --untrusted-daemon option (moneromooo-monero)
|
|
ad19f86 don't show error twice when starting simplewallet (cryptochangements34)
|
|
|
|
wallet
|
|
|
|
|
|
given
|
|
0b88fff3 simplewallet: fix help message of sign_transfer (stoffu)
|
|
Change the wallet's 'show_transfers' command to always output the transaction date with timestamp (24 hour UTC).
|
|
|
|
|
|
eecfb57d wallet: warn if not using the default ring size (moneromooo-monero)
|
|
aa5c2e01 simplewallet: warn about key reuse on startup (moneromooo-monero)
|
|
c77d2bfa Add the possibility to export private view key for fast scan. (cslashm)
100b7bc1 Change mutex lock model to avoid dead lock and ensure locks are always released. (cslashm)
641dfc99 Automatic height setup when creating/restoring hw device. (cslashm)
|
|
|
|
When creating/restoring wallet, if --restore-height option is not used the current estimate
height is used for starting the scan. In other words it is assume we are creating a new account.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
8ea3c4d5 simplewallet: new --use-english-language-names flag (moneromooo-monero)
|
|
On some Windows systems, displaying language names in their own
languages freezes the display.
|
|
via user setting first, then DNS TXT record, hardcoded fallback
|
|
lookahead in order to avoid
so looooong time of set-up when creating a HW based wallet.
|
|
6f54c910 simplewallet: fix restore height prompt that got disabled by #3175 (stoffu)
|
|
833f9fcf show '<Not set>' for empty wallet description (cryptochangements34)
|
|
57c0b1ed Fix typos in various files (Dimitris Apostolou)
|
|
It can now take a txid (to display rings for all its inputs),
and will print rings in a format that set_ring understands
|
|
This is so one can set rings for spent key images in case the
attackers don't merge the ring matching patch set.
|
|
|
|
|
|
If a pre-fork output is spent on both Monero and attack chain,
any post-fork output can be deduced to be a fake output, thereby
decreasing the effective ring size.
The segregate-per-fork-outputs option, on by default, allows
selecting only pre-fork outputs in this case, so that the same
ring can be used when spending it on the other side, which does
not decrease the effective ring size.
This is intended to be SET when intending to spend Monero on the
attack fork, and to be UNSET if not intending to spend Monero
on the attack fork (since it leaks the fact that the output being
spent is pre-fork).
If the user is not certain yet whether they will spend pre-fork
outputs on a key reusing fork, the key-reuse-mitigation2 option
should be SET instead.
If you use this option and intend to spend Monero on both forks,
then spend real Monero first.
|
|
This maps key images to rings, so that different forks can reuse
the rings by key image. This avoids revealing the real inputs like
would happen if two forks spent the same outputs with different
rings. This database is meant to be shared with all Monero forks
which don't bother making a new chain, putting users' privacy at
risk in the process. It is placed in a shared data directory by
default ($HOME/.shared-ringdb on UNIX like systems). You may
use --shared-ringdb-dir to override this location, and should
then do so for all Monero forks for them to share the database.
|
|
|
|
|
|
|
|
c5024c5b simplewallet: add a warning when getting a daemon error in transfer (moneromooo-monero)
|
|
A malicious daemon (or MITM) could attempt to add spurious errors
so the wallet tries again, sending another set of fake outs.
|
|
calls to wallet2
|
|
b63ea060 simplewallet: do not call a RPC when displaying the prompt (moneromooo-monero)
|
|
When #3303 was merged, a cyclic dependency chain was generated:
libdevice <- libcncrypto <- libringct <- libdevice
This was because libdevice needs access to a set of basic crypto operations
implemented in libringct such as scalarmultBase(), while libringct also needs
access to abstracted crypto operations implemented in libdevice such as
ecdhEncode(). To untangle this cyclic dependency chain, this patch splits libringct
into libringct_basic and libringct, where the basic crypto ops previously in
libringct are moved into libringct_basic. The cyclic dependency is now resolved
thanks to this separation:
libcncrypto <- libringct_basic <- libdevice <- libcryptonote_basic <- libringct
This eliminates the need for crypto_device.cpp and rctOps_device.cpp.
Also, many abstracted interfaces of hw::device such as encrypt_payment_id() and
get_subaddress_secret_key() were previously implemented in libcryptonote_basic
(cryptonote_format_utils.cpp) and were then called from hw::core::device_default,
which is odd because libdevice is supposed to be independent of libcryptonote_basic.
Therefore, those functions were moved to device_default.cpp.
|
|
1979d53d wallet: fixes and tweaks to the save_watch_only command (moneromooo-monero)
|
|
649a1b7a wallet2 / simplewallet: Must opt-in to create '.address.txt' files for new wallets (Leon Klingele)
|
|
Speeds up refresh when you have a lot of in/out transactions
|
|
wallets
Previously, a file containing the unencrypted Monero address was
created by default in the wallet's directory. This file might pose
as a privacy risk. The creation of this file is now opt-in and can
be enabled by providing
--create-address-file
|
|
- save the new keys file as FOO-watchonly.keys, not FOO.keys-watchonly
- catch any exception (eg, I/O errors) and error out
- print the new keys filename in simplewallet
|
|
|
|
f2bb8085 Fix #3297 use the password_prompter helper (Howard Chu)
|
|
399120dd simplewallet: set seed language when restoring from english-old seed (stoffu)
|
|
43026822 Wallet2 + CLI wallet: UTF-8 support for filenames and paths under Windows (rbrunner7)
|
|
6b40ea93 simplewallet: fix print_ring_members printing wrong heights (moneromooo-monero)
|
|
0e7ad2e2 Wallet API: generalize 'bool testnet' to 'NetworkType nettype' (stoffu)
af773211 Stagenet (stoffu)
cc9a0bee command_line: allow args to depend on more than one args (stoffu)
55f8d917 command_line::get_arg: remove 'required' for dependent args as they're always optional (stoffu)
450306a0 command line: allow has_arg to handle arg_descriptor<bool,false,true> #3318 (stoffu)
9f9e095a Use `genesis_tx` parameter in `generate_genesis_block`. #3261 (Jean Pierre Dudey)
|
|
|
|
|
|
The basic approach it to delegate all sensitive data (master key, secret
ephemeral key, key derivation, ....) and related operations to the device.
As device has low memory, it does not keep itself the values
(except for view/spend keys) but once computed there are encrypted (with AES
are equivalent) and return back to monero-wallet-cli. When they need to be
manipulated by the device, they are decrypted on receive.
Moreover, using the client for storing the value in encrypted form limits
the modification in the client code. Those values are transfered from one
C-structure to another one as previously.
The code modification has been done with the wishes to be open to any
other hardware wallet. To achieve that a C++ class hw::Device has been
introduced. Two initial implementations are provided: the "default", which
remaps all calls to initial Monero code, and the "Ledger", which delegates
all calls to Ledger device.
|