aboutsummaryrefslogtreecommitdiff
path: root/src/simplewallet (follow)
AgeCommit message (Collapse)AuthorFilesLines
2017-04-11Merge pull request #1949Riccardo Spagni1-9/+9
0ee018b4 wallet2: do not go over the target tx size if many destinations (moneromooo-monero) 9ae566d0 simplewallet: fix cold signing of split transactions (moneromooo-monero) aae14a10 simplewallet: allow setting confirm-missing-payment-id in watch wallets (moneromooo-monero)
2017-04-11Merge pull request #1940Riccardo Spagni1-4/+17
17c7c62d Add per transaction fee to transfer command (Antti Keränen)
2017-04-11Merge pull request #1931Riccardo Spagni1-1/+0
89e100bc wallet cli: remove redundant password confirm in donate command (kenshi84)
2017-04-02simplewallet: fix cold signing of split transactionsmoneromooo-monero1-3/+9
They'd be rejected as suspicious as the change goes to more than one destination. However, split transactions will most likely include fake zero amount change to random addresses, so we only consider change with non zero amount for this.
2017-04-02simplewallet: allow setting confirm-missing-payment-id in watch walletsmoneromooo-monero1-6/+0
These can create transactions, even though they cannot sign them.
2017-04-01Add per transaction fee to transfer commandAntti Keränen1-4/+17
Allows priority argument default/unimportant/normal/elevated/priority to be used per transaction in CLI wallet's transfer command. Resolves #1913.
2017-03-27wallet cli: remove redundant password confirm in donate commandkenshi841-1/+0
2017-03-26simplewallet: factor the per-variable code in set_variablemoneromooo-monero1-170/+28
2017-03-25wallet: option to merge destinationsmoneromooo-monero2-1/+27
With the change from the original transfer method to the new algorithm, payments to the same destination were merged. It seemed like a good idea, optimizing space. However, it is a useful tool for people who want to split large outputs into several smaller ones (ie, service providers making frequent payments, and who do not like a large chunk of their balance being locked for 10 blocks after each payment). Default to off, which is a change from the previous behavior.
2017-03-25Merge pull request #1921Riccardo Spagni1-1/+1
2bee92db Fixed typo in v5 hard fork finalized date (Derek Zhang) d17179d1 Fixed typo in CLI wallet help message (Derek Zhang)
2017-03-24Fixed typo in CLI wallet help messageDerek Zhang1-1/+1
2017-03-24wallet: try to save large outputs when using an unneeded second inputmoneromooo-monero2-1/+67
When a single input is enough to satisfy a transfer, the code would previously try to add a second input, to match the "canonical" makeup of a transaction with two inputs and two outputs. This would cause wallets to slowly merge outputs till all the monero ends up in a single output, which causes trouble when making two transactions one after the other, since change is locked for 10 blocks, and an increasing portion of the remaining balance would end up locked on each transaction. There are two new settings (min-output-count and min-output-value) which can control when to stop adding such unneeded second outputs. The idea is that small "dust" outputs will still get added, but larger ones will not. Enable with, eg: set min-output-count 10 set min-output-value 30 to avoid using an unneeded second output of 30 monero or more, if there would be less than 10 such outputs left. This does not invalidate any other reason why such outputs would be used (ie, when they're really needed to satisfy a transfer, or when randomly picked in the normal course of selection). This may be improved in the future.
2017-03-22Transfer helpAkademik Prokhor Zakharov1-2/+2
New pull request because I couldn't figure out how to change the previous one. 1. For clarity, I want to focus the help text for the 'transfer' command on the most typical use case (a single payment). 2. New users will prefer to use 'transfer', so the older method 'transfer_original' should refer to 'transfer' rather than the other way around.
2017-03-21wallet: fix set_log not handling 0,xxx style settingsmoneromooo-monero1-15/+1
2017-03-18Merge pull request #1886Riccardo Spagni1-5/+0
f9a2b527 simplewallet: allow setting tx priority in watch wallets (moneromooo-monero)
2017-03-18Merge pull request #1883Riccardo Spagni1-2/+2
d0238313 use const references in catch blocks (moneromooo-monero)
2017-03-18simplewallet: allow setting tx priority in watch walletsmoneromooo-monero1-5/+0
Those can create unsigned transactions
2017-03-18use const references in catch blocksmoneromooo-monero1-2/+2
2017-03-18simplewallet: catch case where no transactions are mademoneromooo-monero1-1/+7
This would otherwise be a silent noop, which is confusing. This can happen if the daemon is started, but not yet ready to service all requests, and this is a safe catch all.
2017-03-15Add intervening v5 fork for increased min block sizemoneromooo-monero1-6/+6
Minimum mixin 4 and enforced ringct is moved from v5 to v6. v5 is now used for an increased minimum block size (from 60000 to 300000) to cater for larger typical/minimum transaction size. The fee algorithm is also changed to decrease the base per kB fee, and add a cheap tier for those transactions which we do not care if they get delayed (or even included in a block).
2017-03-05wallet: add password commandmoneromooo-monero1-3/+4
Also tweak wallet2 password code to verify password without saying it's a new wallet, because it's assuming things.
2017-03-03Merge pull request #1826Riccardo Spagni2-1/+46
2c468dd4 allow user I/O in millinero, micronero, nanonero, piconero (moneromooo-monero)
2017-03-03Merge pull request #1820Riccardo Spagni2-11/+11
7a44f38a Add support for the wallet to refresh pruned blocks (moneromooo-monero) da18898f ringct: do not require range proof in decodeRct/decodeRctSimple (moneromooo-monero) b49c6ab4 rpc: add a default category for daemon rpc (moneromooo-monero) f113b92b core: add functions to serialize base tx info (moneromooo-monero) 6fd4b827 node_rpc_proxy: allow caching daemon RPC version (moneromooo-monero) b5c74e40 wallet: invalidate node proxy cache when reconnecting (moneromooo-monero)
2017-03-02allow user I/O in millinero, micronero, nanonero, piconeromoneromooo-monero2-1/+46
2017-02-28wallet: fix --log-file not workingmoneromooo-monero1-1/+2
2017-02-27Add support for the wallet to refresh pruned blocksmoneromooo-monero2-11/+11
2017-02-24simplewallet: updated help message for 'set ask-password'kenshi841-1/+1
2017-02-22Merge pull request #1765Riccardo Spagni1-8/+7
5cfddd74 Add support for smart mining through wallet. (Dion Ahmetaj)
2017-02-21update copyright year, fix occasional lack of newline at line endRiccardo Spagni3-3/+3
2017-02-21Add support for smart mining through wallet.Dion Ahmetaj1-8/+7
2017-02-14simplewallet: validate hex input sizemoneromooo-monero1-9/+9
2017-02-11Merge pull request #1698Riccardo Spagni1-0/+6
9459f331 simplewallet: print error when address is wrong (kenshi84)
2017-02-11Merge pull request #1689Riccardo Spagni2-2/+2
ce7fcbb4 Add server auth to monerod, and client auth to wallet-cli and wallet-rpc (Lee Clagett)
2017-02-08simplewallet: print error when address is wrongkenshi841-0/+6
2017-02-08extract some basic code from libcryptonote_core into libcryptonote_basickenshi842-3/+3
2017-02-06Add server auth to monerod, and client auth to wallet-cli and wallet-rpcLee Clagett2-2/+2
2017-02-04Merge pull request #1665Riccardo Spagni1-6/+1
34719071 simplewallet: cleanup (moneromooo-monero) a9a9b64b simplewallet: fix build (unqualified type not in current scope) (moneromooo-monero)
2017-02-04Merge pull request #1640Riccardo Spagni2-0/+43
f97526e6 simplewallet: option to always ask password for any crytical operations (kenshi84)
2017-02-03simplewallet: option to always ask password for any crytical operationskenshi842-0/+43
2017-02-02simplewallet: cleanupmoneromooo-monero1-5/+0
Remove empty static function which was refactored, as well as leftover exception testing code.
2017-02-02simplewallet: fix build (unqualified type not in current scope)moneromooo-monero1-1/+1
2017-02-02Merge pull request #1645Riccardo Spagni1-29/+2
9bd9906e Factor is_address_local code into a tools function (moneromooo-monero)
2017-02-02Merge pull request #1639Riccardo Spagni2-0/+28
48aa9cf0 Add change_password for simplewallet (Ashley Perpetual)
2017-02-02Merge pull request #1629Riccardo Spagni1-6/+7
c02e1cb9 Updates to epee HTTP client code - http_simple_client now uses std::chrono for timeouts - http_simple_client accepts timeouts per connect / invoke call - shortened names of epee http invoke functions - invoke command functions only take relative path, connection is not automatically performed (Lee Clagett)
2017-01-29Add change_password for simplewalletAshley Perpetual2-0/+28
2017-01-28Factor is_address_local code into a tools functionmoneromooo-monero1-29/+2
2017-01-25Updates to epee HTTP client codeLee Clagett1-6/+7
- http_simple_client now uses std::chrono for timeouts - http_simple_client accepts timeouts per connect / invoke call - shortened names of epee http invoke functions - invoke command functions only take relative path, connection is not automatically performed
2017-01-24moved get_account_address_from_str_or_url from libcommon to libcryptonote_corekenshi841-5/+5
2017-01-20Merge pull request #1599Riccardo Spagni1-8/+8
17246d05 wallet: print exception message on get_random_outs_error (moneromooo-monero)
2017-01-20wallet: print exception message on get_random_outs_errormoneromooo-monero1-8/+8
2017-01-18simplewallet: use MAKE_CORE_RPC_VERSION(1,4) instead of 0x10004kenshi841-1/+1
2017-01-15Merge pull request #1569Riccardo Spagni1-16/+64
16b8b66a specify restore height by YYYY-MM-DD format (kenshi84)
2017-01-16specify restore height by YYYY-MM-DD formatkenshi841-16/+64
2017-01-16Change logging to easylogging++moneromooo-monero2-32/+41
This replaces the epee and data_loggers logging systems with a single one, and also adds filename:line and explicit severity levels. Categories may be defined, and logging severity set by category (or set of categories). epee style 0-4 log level maps to a sensible severity configuration. Log files now also rotate when reaching 100 MB. To select which logs to output, use the MONERO_LOGS environment variable, with a comma separated list of categories (globs are supported), with their requested severity level after a colon. If a log matches more than one such setting, the last one in the configuration string applies. A few examples: This one is (mostly) silent, only outputting fatal errors: MONERO_LOGS=*:FATAL This one is very verbose: MONERO_LOGS=*:TRACE This one is totally silent (logwise): MONERO_LOGS="" This one outputs all errors and warnings, except for the "verify" category, which prints just fatal errors (the verify category is used for logs about incoming transactions and blocks, and it is expected that some/many will fail to verify, hence we don't want the spam): MONERO_LOGS=*:WARNING,verify:FATAL Log levels are, in decreasing order of priority: FATAL, ERROR, WARNING, INFO, DEBUG, TRACE Subcategories may be added using prefixes and globs. This example will output net.p2p logs at the TRACE level, but all other net* logs only at INFO: MONERO_LOGS=*:ERROR,net*:INFO,net.p2p:TRACE Logs which are intended for the user (which Monero was using a lot through epee, but really isn't a nice way to go things) should use the "global" category. There are a few helper macros for using this category, eg: MGINFO("this shows up by default") or MGINFO_RED("this is red"), to try to keep a similar look and feel for now. Existing epee log macros still exist, and map to the new log levels, but since they're used as a "user facing" UI element as much as a logging system, they often don't map well to log severities (ie, a log level 0 log may be an error, or may be something we want the user to see, such as an important info). In those cases, I tried to use the new macros. In other cases, I left the existing macros in. When modifying logs, it is probably best to switch to the new macros with explicit levels. The --log-level options and set_log commands now also accept category settings, in addition to the epee style log levels.
2017-01-13Merge pull request #1562Riccardo Spagni1-78/+9
a081b39c Move key image export/import functions to wallet2 (Jaquee)
2017-01-13Merge pull request #1559Riccardo Spagni2-0/+6
db56a03f Wallet2 + API: Callbacks for unconfirmed transfers (Jaquee)
2017-01-13Merge pull request #1545Riccardo Spagni1-0/+1
5ae00f0f add msg for donate (luigi1111)
2017-01-13Merge pull request #1492Riccardo Spagni2-14/+152
f1dde1a4 wallet cli: print originating block heights of mixin keys when making transfer (kenshi84)
2017-01-13Move key image export/import functions to wallet2Jaquee1-78/+9
2017-01-12Wallet2 + API: Callbacks for unconfirmed transfersJaquee2-0/+6
2017-01-09wallet cli: print originating block heights of mixin keys when making transferkenshi842-14/+152
2017-01-08add msg for donateluigi11111-0/+1
#1498
2017-01-08Fix monero-wallet-cli compileluigi11111-1/+1
Not 100$ sure this is the right fix, nor whether address book entries from URL should be stored as addresses or URLs (or both with a check for change on payment).
2017-01-08Merge pull request #1537Riccardo Spagni2-0/+124
c2135082 simplewallet: add a show_transfer <txid> command (moneromooo-monero) 19c4041d wallet_rpc_server: new RPC call to get a transfer by txid (moneromooo-monero)
2017-01-08Merge pull request #1503Riccardo Spagni1-24/+8
542571f5 simplewallet: remove unnecessary local_args.erase(...) in set_variable() (kenshi84)
2017-01-08Merge pull request #1496Riccardo Spagni2-0/+120
adee1644 wallet cli: print unspent outputs with histogram (kenshi84)
2017-01-08Merge pull request #1482Riccardo Spagni2-0/+82
38f00d07 wallet cli: viewing and editing address book (kenshi84)
2017-01-08simplewallet: add a show_transfer <txid> commandmoneromooo-monero2-0/+124
2016-12-26wallet cli: print unspent outputs with histogramkenshi842-0/+120
2016-12-26simplewallet: remove unnecessary local_args.erase(...) in set_variable()kenshi841-24/+8
2016-12-21make openalias also available for solo miner; introduce namespace ↵kenshi842-74/+5
tools::dns_utils; support integrated address with dns lookup
2016-12-21wallet cli: viewing and editing address bookkenshi842-0/+82
2016-12-20simplewallet: bump output file format versionmoneromooo-monero1-1/+1
The serialization format changed, and while there is code to load the older serialization format, an older monerod will not be able to load a file saved by a new monerod, even though both share the same version. This is not good, and we prefer a version bump.
2016-12-20Merge pull request #1472Riccardo Spagni2-163/+59
2bddb8eb Refactored password prompting for wallets (Lee Clagett)
2016-12-20Merge pull request #1469Riccardo Spagni1-1/+1
9e4b3724 simplewallet: add pending/pool/failed in the show_transfers help (moneromooo-monero)
2016-12-20Merge pull request #1466Riccardo Spagni1-1/+3
c367d7df README: add note about the donate command (anonimal) b9a28677 simplewallet: add return type for donate function (anonimal) d36669fd simplewallet: hardcode Monero's donation address (anonimal)
2016-12-20support importing unportable outputskenshi841-3/+12
2016-12-19Refactored password prompting for walletsLee Clagett2-163/+59
2016-12-17simplewallet: add pending/pool/failed in the show_transfers helpmoneromooo-monero1-1/+1
reported by nioc
2016-12-17simplewallet: add return type for donate functionanonimal1-0/+1
Resolves -Wreturn-type References #1447 #1451
2016-12-17simplewallet: hardcode Monero's donation addressanonimal1-1/+2
Closes #1447 References #1451
2016-12-16added experimental boost::archive::portable_binary_{i|o}archivekenshi841-2/+2
2016-12-15wallet cli: donate commandKenshi Takayama2-0/+41
2016-12-12monero-wallet-cli wording changes 'n' stuffluigi11111-11/+13
Possibly other pedantry. Pedants are people too.
2016-12-08simplewallet: restore automatically setting trusted local daemonmoneromooo-monero1-0/+43
2016-12-04Merge pull request #1379Riccardo Spagni1-7/+12
d6086f5b Improve daemon RPC version handling (moneromooo-monero)
2016-11-26Improve daemon RPC version handlingmoneromooo-monero1-7/+12
Daemon RPC version is now composed of a major and minor number, so that incompatible changes bump the major version, while compatible changes can still bump the minor version without causing clients to unnecessarily complain.
2016-11-25Added command_line::is_yesLee Clagett1-17/+15
2016-11-23simplewallet: remove double confirmation when submitting signed txmoneromooo-monero1-51/+0
2016-11-17Merge pull request #1344Riccardo Spagni2-16/+58
a0131c8 wallet: auto sync outputs and key images in cold signing files (moneromooo-monero) f806611 wallet2: fill key image and pubkey maps when importing outputs (moneromooo-monero) 5fe363c wallet: cast indices to string in logs to be nice to CLANG (moneromooo-monero) 11ae187 wallet2: try all tx keys when scanning a new transaction (moneromooo-monero) 072d646 wallet2: fill in key image map when importing key images (moneromooo-monero) 23d80b1 core: remove any tx pubkey from extra before adding one (moneromooo-monero) d72376d simplewallet: add a verbose flag to incoming_transfers (moneromooo-monero) 47413a5 simplewallet: spell out change when signing a transfer (moneromooo-monero) 14cb088 simplewallet: print public keys too on spendkey/viewkey commands (moneromooo-monero) a99ab49 wallet: fix serialization of new m_key_image_known member (moneromooo-monero)
2016-11-16wallet: auto sync outputs and key images in cold signing filesmoneromooo-monero2-8/+22
When passing around unsigned and signed transactions, outputs and key images are passed along (outputs are passed along unsigned transactions from the hot wallet to the cold wallet, key images are passed along with signed transations from the cold wallet to the hot wallet), to allow more user friendly syncing between hot and cold wallets.
2016-11-13simplewallet: add a verbose flag to incoming_transfersmoneromooo-monero1-6/+18
Prints pubkey and key image as well
2016-11-13simplewallet: spell out change when signing a transfermoneromooo-monero1-2/+16
Also catch change to multiple addresses, this is unexpected
2016-11-13simplewallet: print public keys too on spendkey/viewkey commandsmoneromooo-monero1-2/+4
2016-11-13simplewallet: include amount sent in transfer confirmationmoneromooo-monero1-0/+10
2016-11-12Fixed generate-from-json bug introduced in 358e068Lee Clagett1-1/+2
2016-11-10Created monero-wallet-rpc, moving functionality from monero-wallet-cliLee Clagett5-1036/+118
2016-11-07wallet: encrypt outputs and key images files with the view keymoneromooo-monero1-14/+43
This key is available to both cold and hot wallet. Authenticated encryption will guard against interception and/or modification of the file.
2016-11-02wallet: fix bad amounts/fees againmoneromooo-monero1-2/+2
m_amount_out was sometimes getting initialized with the sum of an transaction's outputs, and sometimes with the sum of outputs that were not change. This caused confusion and bugs. We now always set it to the sum of outputs. This reverts an earlier fix for bad amounts as this used the other semantics. The wallet data should be converted automatically in a percentage of cases that I'm hesitant to estimate. In any case, restoring from seed or keys or rebuilding the cache will get it right.
2016-11-01Merge pull request #1281Riccardo Spagni2-0/+102
bb560dd wallet: new import_outputs/export_outputs commands (moneromooo-monero)
2016-11-01Merge pull request #1277Riccardo Spagni2-5/+17
7e6d3cf wallet: set incoming outputs' key image to 0 on view wallets (moneromooo-monero) 1f9e6a4 wallet: print tx overview on submit_transfer too (moneromooo-monero)
2016-10-30wallet: new import_outputs/export_outputs commandsmoneromooo-monero2-0/+102
The intended use is to export outputs from a hot wallet, which can scan incoming transfers from the network, and import them in the cold wallet, which can't. The cold wallet can then compute key images for those outputs, which can then be exported with export_key_images, etc.
2016-10-30wallet: print tx overview on submit_transfer toomoneromooo-monero2-5/+17
This is on the potentially compromised wallet, but still guards against stupid mistakes.
2016-10-30simplewallet: remove destinations with zero amount in sign_transfermoneromooo-monero1-0/+2
This will happen when sending to another address, after removing the fee.
2016-10-26simplewallet: log transactions to submit in submit_transfermoneromooo-monero1-1/+1
Not as trustworthy as this is in the view wallet, the one that's considered compromised.
2016-10-25wallet: fix pre-rct cold wallet signing not splitting changemoneromooo-monero1-6/+16
Re-creating the transaction on the cold wallet was not splitting the change, causing the transaction to be rejected by the network. This worked on testnet since amounts do not have to be split. Also add selected_transfers, which can now be saved since they're size_t rather than iterators. This allows the view wallet to properly set the sent outputs as spent and update balance. Bump transfer file version numbers to match.
2016-10-23simplewallet: factor locked_transfer, and fix a few rough edgesmoneromooo-monero1-256/+43
Factor locked_transfer into transfer_main, which brings various improvements for free (multiple addresses, proper detection of multiple payment ids, obeying the prompt settings). Also fix a few things, such as using uint64_t instead of int for block heights, actually checking whether getting blockchain height succeeded, etc.
2016-10-22Merge pull request #1224Riccardo Spagni1-10/+4
8231997 simplewallet: fix sweep_all misreporting sweeped amount for rct outputs (moneromooo-monero) 985f61a wallet: force 0 mixin transactions to use pre-rct txes (moneromooo-monero)
2016-10-22Merge pull request #1220Riccardo Spagni1-7/+43
e76dcdd wallet: improve error messages when not enough money for transfer (moneromooo-monero)
2016-10-22Merge pull request #1219Riccardo Spagni1-1/+1
2d7083c wallet_api: fix wrong amount in tx history (moneromooo-monero) b5f2001 simplewallet: fix wrong amount in show_transfers (moneromooo-monero)
2016-10-22Merge pull request #1200Riccardo Spagni1-53/+67
a3748f4 Rewrote add_wallet_create_if_needed for clearer flow and behaviour (NanoAkron)
2016-10-15Rewrote add_wallet_create_if_needed for clearer flow and behaviourNanoAkron1-53/+67
2016-10-15simplewallet: fix sweep_all misreporting sweeped amount for rct outputsmoneromooo-monero1-10/+4
RingCT outputs will be 0 in the vin, so we need to get the actual amount from elsewhere.
2016-10-15wallet: improve error messages when not enough money for transfermoneromooo-monero1-7/+43
2016-10-15simplewallet: fix wrong amount in show_transfersmoneromooo-monero1-1/+1
2016-10-04simplewallet: add mixin and payment id to sweep_all helpmoneromooo-monero1-1/+1
2016-10-04Merge pull request #1179Riccardo Spagni2-0/+254
714ee99 Fix description for locked_transfer (Oyvind Kvanes) 71538f3 Rename to lockblocks and add max value (Oyvind Kvanes) 68ac060 Fix locked_transfer (Oyvind Kvanes) 7d020bd Add locked_transfer (Oyvind Kvanes) d5f918a Revert transfer_main in simplewallet (Oyvind Kvanes) 3451963 Add motifications to test out locked_transfer (Oyvind Kvanes) e5e6d88 Add more information to transaction in wallet (Oyvind Kvanes) 9b8a062 Make a small test change (Oyvind Kvanes)
2016-10-04Merge pull request #1160Riccardo Spagni2-1/+81
80b4da3 wallet: wallet option to confirm transfers with no payment id (moneromooo-monero)
2016-10-04Merge pull request #1139Riccardo Spagni1-2/+2
01ec195 Update CMakeLists.txt (codehalo) 446ebbc Update CMakeLists.txt (codehalo) bd773e7 Update CMakeLists.txt (codehalo) 3627cea Cleanup. Dropped "bit" from bitmonero. (Randi Joseph) 2a51396 Dropped "bit" from bitmonero. (Randi Joseph) 78b13d6 Cleanup. Dropped "bit" from bitmonero. (Randi Joseph) 1e6aedb Cleanup. Dropped "bit" from bitmonero. (Randi Joseph) 9e54616 Dropped "bit" from bitmonero. (Randi Joseph)
2016-10-04Fix description for locked_transferOyvind Kvanes1-1/+1
2016-10-04Merge pull request #1162Riccardo Spagni1-1/+1
e5f8642 Update minimum mixin in transfer_original help text (TedTheFicus) ea45d61 Update minimum mixin in transfer_original help text (TedTheFicus)
2016-10-04Merge pull request #1140Riccardo Spagni2-26/+273
bba6af9 wallet: cold wallet transaction signing (moneromooo-monero) 9872dcb wallet: fix log confusion between bytes and kilobytes (moneromooo-monero) d9b0bf9 cryptonote_core: make extra field removal more generic (moneromooo-monero) 98f19d4 serialization: add support for serializing std::pair and std::list (moneromooo-monero)
2016-10-04Rename to lockblocks and add max valueOyvind Kvanes1-45/+30
2016-10-01Update minimum mixin in transfer_original help textTedTheFicus1-1/+1
Changed the wording from "from 0 to maximum available" to "from 2 to maximum available". May I also suggest putting in a number rather than "maximum available" and also clarifying that mixin = 0 is still allowed if the user has unmixable outputs (dust), which he wants to "undust" using sweep_unmixable (comment from dEBRUYNE-1 ).
2016-10-01wallet: wallet option to confirm transfers with no payment idmoneromooo-monero2-1/+81
set confirm-missing-payment-id 0|1 Defaults to true.
2016-09-28Fix locked_transferOyvind Kvanes1-6/+3
2016-09-28Add locked_transferOyvind Kvanes1-87/+83
2016-09-28Revert transfer_main in simplewalletOyvind Kvanes2-22/+279
2016-09-28Add motifications to test out locked_transferOyvind Kvanes1-6/+18
2016-09-28Add more information to transaction in walletOyvind Kvanes1-1/+8
2016-09-28Make a small test changeOyvind Kvanes1-1/+1
2016-09-27wallet: cold wallet transaction signingmoneromooo-monero2-26/+273
This change adds the ability to create a new unsigned transaction from a watch only wallet, and save it to a file. This file can then be moved to another computer/VM where a cold wallet may load it, sign it, and save it. That cold wallet does not need to have a blockchain nor daemon. The signed transaction file can then be moved back to the watch only wallet, which can load it and send it to the daemon. Two new simplewallet commands to use it: sign_transfer (on the cold wallet) submit_transfer (on the watch only wallet) The transfer command used on a watch only wallet now writes an unsigned transaction set in a file called 'unsigned_monero_tx' instead of submitting the tx to the daemon as a normal wallet does. The signed tx file is called 'signed_monero_tx'.
2016-09-26Dropped "bit" from bitmonero.Randi Joseph1-2/+2
2016-09-26Merge pull request #1117Riccardo Spagni1-1/+1
fc855c1 Made error message consistent with other, more helpful, message (Will Skinner)
2016-09-22Made error message consistent with other, more helpful, messageWill Skinner1-1/+1
2016-09-19Remove redundant "default" in set mixin help descJ Ryan Littlefield1-1/+1
2016-09-18Merge pull request #1094Riccardo Spagni1-3/+5
06bb692 cmake: support BUILD_SHARED_LIBS built-in option (redfish) e1c7af3 cmake: transitive deps and remove deprecated LINK_* (redfish) 54010b9 crypto: armv7: slow-hash: remove redundant source include (redfish)
2016-09-18Merge pull request #1089Riccardo Spagni1-10/+11
368485d simplewallet: do not expose the details of tx splitting to the user (moneromooo-monero)
2016-09-18cmake: transitive deps and remove deprecated LINK_*redfish1-3/+5
Keep the immediate direct deps at the library that depends on them, declare deps as PUBLIC so that targets that link against that library get the library's deps as transitive deps. Break dep cycle between blockchain_db <-> crytonote_core. No code refactoring, just hide cycle from cmake so that it doesn't complain (cycles are allowed only between static libs, not shared libs). This is in preparation for supproting BUILD_SHARED_LIBS cmake built-in option for building internal libs as shared.
2016-09-17simplewallet: do not expose the details of tx splitting to the usermoneromooo-monero1-10/+11
They're confusing, as people think it reports their balance.
2016-09-17simplewallet: fix wrong amount in show_transfers for pending transactionsmoneromooo-monero1-1/+1
Change was not taken into consideration
2016-09-16wallet: change priority/fee to ArticMine's recommendationmoneromooo-monero2-16/+16
We keep 1, 2, 3 multipliers till the fee decrase from 0.01/kB to 0.002/kB, where we start using 1, 20, 166 multipliers. This ensures the higher multiplier will compensate for the block reward penalty when pushing past 100% of the past median. The fee-multiplier wallet setting is now rename to priority, since it keeps its [0..3] range, but maps to different multiplier values.
2016-09-11Add snap packaging.Casey Marshall1-1/+2
This adds [snap](https://snapcraft.io) packaging to the project. See the link for more information on snaps. Snap packages install on all Linux distributions. On Ubuntu, snap confinement with apparmor and seccomp provide an additional layer of security. This snap sets up monerod as a systemd service, which should start immediately on install. To access the wallet CLI, simply run `monero` (/snap/bin/monero). I think it's a really quick & easy way to get started with monero. I've made some opinionated decisions in the packaging just to kick this off, but I'm happy to iterate on this stuff.
2016-09-03fix remaining bitmonero and simplewallet bitsRiccardo Spagni1-5/+5
2016-09-03rename simplewalletRiccardo Spagni1-0/+3
2016-09-01simplewallet: add magic and public keys to key image export filemoneromooo-monero1-5/+30
This ensures it's hard to mix files up
2016-09-01simplewallet: make the key image export format binarymoneromooo-monero1-18/+5
Saves on space, and on some pointless hex conversions
2016-08-28wallet: fix some "may be used uninitialized" warningsmoneromooo-monero1-8/+8
The compiler can't always work out the _found booleans are set iff the value is initialized.
2016-08-28rct amount key modified as per luigi1111's recommendationsmoneromooo-monero1-8/+20
This allows the key to be not the same for two outputs sent to the same address (eg, if you pay yourself, and also get change back). Also remove the key amounts lists and return parameters since we don't actually generate random ones, so we don't need to save them as we can recalculate them when needed if we have the correct keys.
2016-08-28wallet: do not store signatures in the wallet cachemoneromooo-monero1-1/+1
Saves some substantial space. Also avoid calculating tx hashes we don't need.
2016-08-28simplewallet: better check_tx_key feedbackmoneromooo-monero1-2/+20
Print number of confirmations if the tx is in the blockchain, or a warning if it's in the pool.
2016-08-28rct: make the amount key derivable by a third party with the tx keymoneromooo-monero1-24/+16
Scheme design from luigi1114.
2016-08-28port get_tx_key/check_tx_key to rctmoneromooo-monero1-12/+51
2016-08-28wallet: factor transfer_rct code with transfer codemoneromooo-monero2-13/+2
The "transfer" simplewallet command is renamed to "transfer_original". "transfer_new" is renamed "transfer", "transfer_rct" is removed, and the new "transfer" now selects rct or non rct transactions based on the current block height.
2016-08-28add rct to the protocolmoneromooo-monero2-20/+43
It is not yet constrained to a fork, so don't use on the real network or you'll be orphaned or rejected.
2016-08-26Merge pull request #982Riccardo Spagni1-1/+1
65238d2 fix #691 removed help about leaving wallet name empty on --generate-new-wallet (guzzi_jones)
2016-08-26Merge pull request #976Riccardo Spagni1-1/+8
c2f4e16 simplewallet: default to max-concurrency 1 on MacOS X (moneromooo-monero)
2016-08-24fix #691 removed help about leaving wallet name empty on --generate-new-walletguzzi_jones1-1/+1
2016-08-21simplewallet: default to max-concurrency 1 on MacOS Xmoneromooo-monero1-1/+8
A suspected bug in pthread/kernel, though might be that I messed something up too... This might rope in more platforms though.
2016-08-16simplewallet: do not suggest removing cache if the password was wrongmoneromooo-monero1-1/+3
2016-08-11Merge pull request #948Riccardo Spagni1-6/+6
11dc091 Fake outs set is now decided by the wallet (moneromooo-monero) 1593553 new unlocked parameter to output_histogram (moneromooo-monero)
2016-08-11Fake outs set is now decided by the walletmoneromooo-monero1-6/+6
This plugs a privacy leak from the wallet to the daemon, as the daemon could previously see what input is included as a transaction input, which the daemon hadn't previously supplied. Now, the wallet requests a particular set of outputs, including the real one. This can result in transactions that can't be accepted if the wallet happens to select too many outputs with non standard unlock times. The daemon could know this and select another output, but the wallet is blind to it. It's currently very unlikely since I don't think anything uses non default unlock times. The wallet requests more outputs than necessary so it can use spares if any of the returns outputs are still locked. If there are not enough spares to reach the desired mixin, the transaction will fail.
2016-08-11Merge pull request #952Riccardo Spagni2-4/+9
709c724 Better fix (#4) (hyc) d2644c1 fix restore-deterministic height (luigi1111)
2016-08-11Merge pull request #949Riccardo Spagni2-69/+64
da1007f simplewallet: make the refresh thread into more generic idle thread (moneromooo-monero)
2016-08-09Better fix (#4)hyc2-4/+9
2016-08-09fix restore-deterministic heightluigi11111-2/+2
Simplewallet improperly skipped the restore from height code if restoring a deterministic wallet AND not specifying a wallet file in the command line. The other generate options require a wallet file as an argument, which prevents "ask_wallet_create_if_needed()" from being called, which in turn causes "m_generate_new" to remain unset. Specifying a wallet file at launch with --restore-deterministic emulated this behavior.
2016-08-07simplewallet: make the refresh thread into more generic idle threadmoneromooo-monero2-69/+64
2016-08-01Fix #864guzzi_jones4-53/+106
Squashed commit of the following: commit 9af9e4223b58bbb65a3519af2c2bfc273cbd23d6 fixed some formatting commit c7920e1cf88ff46eb9294101344d9a567f22e2da Merge: 97eb28b 1da1c68 fix#864 fix using boolean commit 97eb28ba5dd49ddde8c8785f39b24d955e5de31c Fix #864 boolean value used to verify on new wallet commit 1da1c68bd3a9a373c70482b6e6e95251096149f1 fix #864 changed to boolean to prompt for verify commit 5bee96652434762d2c91ce31a1b1c9f169446ddc fix 864; made variable names easier for understanding branching. commit 45715960d30293f781b2ff9e5e647c2ec893f4a3 fix #864; allow password to be entered twice for new wallets for verification. fix #864 password entry verification; ammended boolean fix #864 ; default constructor for password_container should set verify=true
2016-07-24wallet: new {ex,im}port_key_images commands and RPC callsmoneromooo-monero2-0/+109
They are used to export a signed set of key images from a wallet with a private spend key, so an auditor with the matching view key may see which of those are spent, and which are not.
2016-07-23Merge pull request #923Riccardo Spagni1-0/+1
8312887 simplewallet: suggest removing cache when loading fails (moneromooo-monero)
2016-07-23Merge pull request #916Riccardo Spagni1-2/+28
b89b963 wallet: add unconfirmed incoming txes from the txpool (moneromooo-monero)
2016-07-22simplewallet: suggest removing cache when loading failsmoneromooo-monero1-0/+1
2016-07-20wallet: add unconfirmed incoming txes from the txpoolmoneromooo-monero1-2/+28
Shown in show_transfers simplewallet command, and get_transfers RPC command, if req.pool is true.
2016-07-20simplewallet: revert to foreground refresh at startupmoneromooo-monero1-0/+2
Background refresh is confusing to users at startup.
2016-07-20Merge pull request #902Riccardo Spagni2-9/+27
014f3a0 Add a daemon RPC version, and make simplewallet check it (moneromooo-monero)
2016-07-19wallet: add command and RPC to sign/verify datamoneromooo-monero2-0/+69
Signing is done using the spend key, since the view key may be shared. This could be extended later, to let the user choose which key (even a per tx key). simplewallet's sign/verify API uses a file. The RPC uses a string (simplewallet can't easily do strings since commands receive a tokenized set of arguments).
2016-07-10Add a daemon RPC version, and make simplewallet check itmoneromooo-monero2-9/+27
If the version is different, simplewallet will refuse to use that daemon, unless --allow-mismatched-daemon-version is used.
2016-07-06Merge pull request #879Riccardo Spagni1-0/+1
6b08001 simplewallet: mention the background refresh thread when starting (moneromooo-monero)
2016-07-06Merge pull request #878Riccardo Spagni2-1/+80
945c272 wallet: add a fee multiplier (moneromooo-monero)
2016-06-23TransactionHistory continuedIlya Kitaev1-1/+1
2016-06-22simplewallet: mention the background refresh thread when startingmoneromooo-monero1-0/+1
It should be less confusing for people who're used to the foreground refresh from earlier versions.
2016-06-22wallet: add a fee multipliermoneromooo-monero2-1/+80
Fee can now be multiplied by 2 or 3, if users want to give priority to their transactions. There are only three levels to avoid too much fingerprinting. Default is 1 (minimum fee). The default multiplier can be set by "set fee-multiplier X".
2016-06-21Merge pull request #870Riccardo Spagni1-2/+6
57dce80 gmtime for Windows (luigi1111)
2016-06-20gmtime for Windowsluigi11111-2/+6
gmtime_r is not available in Windows, use gmtime_s instead. Also change shorthand codes (also not working in Windows).
2016-06-20simplewallet: add a status commandmoneromooo-monero2-0/+25
It matches the daemon, and should allow people who're suspicious of the background refresh to know they're synced.
2016-05-17Merge pull request #827Riccardo Spagni1-14/+16
f1e70d1 Only log 1/N skipped blocks (Howard Chu) cebb97c Move refresh height to keys file from cache file (Howard Chu) 590c439 Make fast_refresh interruptible (Howard Chu) 687855d Set refresh height earlier (Howard Chu) 2fb00c0 Fix 19fe8ae3ef1aa46ae8fdd4e4d6862510390ddab7 (Howard Chu)
2016-04-29Set refresh height earlierHoward Chu1-13/+15
Do it before the generate() call so the value actually gets stored.
2016-04-29Merge pull request #826Riccardo Spagni1-27/+44
76c6bf1 simplewallet: display all settings on set with no arguments (moneromooo-monero)
2016-04-29Fix 19fe8ae3ef1aa46ae8fdd4e4d6862510390ddab7Howard Chu1-2/+2
Don't prompt for restore-height on generate-new-wallet
2016-04-28simplewallet: display all settings on set with no argumentsmoneromooo-monero1-27/+44
2016-04-28add a --max-concurrency flagmoneromooo-monero1-1/+6
It sets the max number of threads to use for a parallel job. This is different that the number of total threads, since monero binaries typically start a lot of them.
2016-04-27Merge pull request #823Riccardo Spagni1-1/+1
a687e6e simplewallet: fix pending transfers fee display in show_transfers (moneromooo-monero)
2016-04-26simplewallet: fix pending transfers fee display in show_transfersmoneromooo-monero1-1/+1
2016-04-26simplewallet: more threading fixesmoneromooo-monero1-1/+5
2016-04-26wallet: allow attaching notes to txidsmoneromooo-monero2-3/+63
2016-04-26wallet: add GMT timestamps to transfers/paymentsmoneromooo-monero1-3/+20
2016-04-26Merge pull request #817Riccardo Spagni2-11/+45
4b1c0d6 simplewallet: some background refresh threading fixes (moneromooo-monero)
2016-04-26Merge pull request #815Riccardo Spagni2-63/+307
b0850a9 wallet: add a new sweep_all command and RPC command (moneromooo-monero)
2016-04-26Merge pull request #814Riccardo Spagni1-7/+19
68cbe15 modified: src/wallet/wallet2.cpp modified: src/wallet/wallet2.h (awfulcrawler) 4b325bd modified: src/simplewallet/simplewallet.cpp modified: src/wallet/wallet2.cpp modified: src/wallet/wallet2.h (awfulcrawler)
2016-04-21simplewallet: some background refresh threading fixesmoneromooo-monero2-11/+45
We want to lock operations which access the blockchain in wallet2. We also want the background refresh to happen again when we cancel a foreground refresh. Wrap the locking setup in a macro so it doesn't get copy/pasted/mangled, and use a scope exit trick to ensure it's always properly restored.