aboutsummaryrefslogtreecommitdiff
path: root/src/simplewallet (follow)
AgeCommit message (Collapse)AuthorFilesLines
2018-01-25Merge pull request #3011Riccardo Spagni1-1/+2
619bb723 daemon+simplewallet: given an unknown command, show it (stoffu)
2018-01-25Merge pull request #3008Riccardo Spagni1-3/+3
50786ac7 simplewallet: Correct 3 multisig command usage help texts, e.g. for 'export_multisig_info' (rbrunner7)
2018-01-11Keep readline optionalJethro Grassie1-1/+1
2018-01-10Merge pull request #2981Riccardo Spagni1-0/+7
b63afbaa simplewallet: detect typo for incoming_transfers options (stoffu)
2018-01-10Merge pull request #2976Riccardo Spagni1-0/+6
c765f951 simplewallet: disable donations on testnet (Matt Smith)
2018-01-10Merge pull request #2972Riccardo Spagni1-0/+4
586ee642 simplewallet: lock idle scope in {im,ex}port_{key_images,outputs} (moneromooo-monero)
2018-01-02Merge pull request #2960Riccardo Spagni2-45/+150
5cbcf0aa wallet: support for multisig seeds (moneromooo-monero)
2017-12-28Merge pull request #2949Riccardo Spagni1-5/+5
e20e489a Better definite article use (xmr-eric)
2017-12-28Merge pull request #2942Riccardo Spagni1-82/+1
4f45f9da simplewallet: factor out tx exceptions (moneromooo-monero)
2017-12-28simplewallet: detect typo for incoming_transfers optionsstoffu1-0/+7
2017-12-27daemon+simplewallet: given an unknown command, show itstoffu1-1/+2
2017-12-26simplewallet: Correct 3 multisig command usage help texts, e.g. for ↵rbrunner71-3/+3
'export_multisig_info'
2017-12-25Merge pull request #2926Riccardo Spagni2-4/+134
6b5bd129 Account tagging (stoffu)
2017-12-25Merge pull request #2920Riccardo Spagni1-4/+4
bd5cce07 network_throttle: fix ineffective locking (moneromooo-monero) e0a61299 network_throttle: remove unused xxx static member (moneromooo-monero) 24f584d9 cryptonote_core: remove unused functions with off by one bugs (moneromooo-monero) b1634aa3 blockchain: don't leave dangling pointers in this (moneromooo-monero) 8e60b81c cryptonote_core: fix db leak on error (moneromooo-monero) 213e326c abstract_tcp_server2: log init_server errors as fatal (moneromooo-monero) b51dc566 use const refs in for loops for non tiny types (moneromooo-monero) f0568ca6 net_parse_helpers: fix regex error checking (moneromooo-monero) b49ddc76 check accessing an element past the end of a container (moneromooo-monero) 2305bf26 check return value for generate_key_derivation and derive_public_key (moneromooo-monero) a4240d9f catch const exceptions (moneromooo-monero) 45a1c4c0 add empty container sanity checks when using front() and back() (moneromooo-monero) 56fa6ce1 tests: fix a buffer overread in a unit test (moneromooo-monero) b4524892 rpc: guard against json parsing a non object (moneromooo-monero) c2ed8618 easylogging++: avoid buffer underflow (moneromooo-monero) 187a6ab2 epee: trap failure to parse URI from request (moneromooo-monero) 061789b5 checkpoints: trap failure to load JSON checkpoints (moneromooo-monero) ba2fefb9 checkpoints: pass std::string by const ref, not const value (moneromooo-monero) 38c8f4e0 mlog: terminate a string at last char, just in case (moneromooo-monero) d753d716 fix a few leaks by throwing objects, not newed pointers to objects (moneromooo-monero) fe568db8 p2p: use size_t for arbitrary counters instead of uint8_t (moneromooo-monero) 46d6fa35 cryptonote_protocol: sanity check chain hashes from peer (moneromooo-monero) 25584f86 cryptonote_protocol: print peer versions when unexpected (moneromooo-monero) 490a5d41 rpc: do not try to use an invalid txid in relay_tx (moneromooo-monero)
2017-12-25Merge pull request #2918Riccardo Spagni1-1/+1
f5bc7f18 simplewallet: fix default unspent_outputs output with subaddresses (moneromooo-monero)
2017-12-20simplewallet: disable donations on testnetMatt Smith1-0/+6
2017-12-20simplewallet: lock idle scope in {im,ex}port_{key_images,outputs}moneromooo-monero1-0/+4
This ensures we can't get races
2017-12-20wallet: support for multisig seedsmoneromooo-monero2-45/+150
They are hex rather than words, because they are a lot longer than "normal" seeds, as they have to embed a lot more information
2017-12-18simplewallet: factor out tx exceptionsmoneromooo-monero1-82/+1
2017-12-18catch const exceptionsmoneromooo-monero1-2/+2
2017-12-18add empty container sanity checks when using front() and back()moneromooo-monero1-2/+2
2017-12-18Account taggingstoffu2-4/+134
2017-12-17Better definite article usexmr-eric1-5/+5
2017-12-17wallet: factor multisig info parsingmoneromooo-monero1-52/+5
2017-12-17wallet: use raw encrypted data in multisig import/export RPCmoneromooo-monero1-76/+4
2017-12-17Match surae's recommendation to derive multisig keysmoneromooo-monero1-2/+3
2017-12-17simplewallet: add export_raw_multisig commandmoneromooo-monero2-0/+74
It exports raw transactions, so they may be used by other tools, for instance to be relayed to the network externally.
2017-12-17simplewallet: add multisig to wallet type in wallet_info outputmoneromooo-monero1-1/+11
2017-12-17wallet: guard against partly initialized multisig walletmoneromooo-monero1-8/+39
2017-12-17add multisig core test and factor multisig building blocksmoneromooo-monero1-14/+1
2017-12-17N-1/N multisigmoneromooo-monero2-11/+71
2017-12-17gen_multisig: generates multisig wallets if participants trust each othermoneromooo-monero1-0/+1
2017-12-17Add N/N multisig tx generation and signingmoneromooo-monero2-117/+538
Scheme by luigi1111: Multisig for RingCT on Monero 2 of 2 User A (coordinator): Spendkey b,B Viewkey a,A (shared) User B: Spendkey c,C Viewkey a,A (shared) Public Address: C+B, A Both have their own watch only wallet via C+B, a A will coordinate spending process (though B could easily as well, coordinator is more needed for more participants) A and B watch for incoming outputs B creates "half" key images for discovered output D: I2_D = (Hs(aR)+c) * Hp(D) B also creates 1.5 random keypairs (one scalar and 2 pubkeys; one on base G and one on base Hp(D)) for each output, storing the scalar(k) (linked to D), and sending the pubkeys with I2_D. A also creates "half" key images: I1_D = (Hs(aR)+b) * Hp(D) Then I_D = I1_D + I2_D Having I_D allows A to check spent status of course, but more importantly allows A to actually build a transaction prefix (and thus transaction). A builds the transaction until most of the way through MLSAG_Gen, adding the 2 pubkeys (per input) provided with I2_D to his own generated ones where they are needed (secret row L, R). At this point, A has a mostly completed transaction (but with an invalid/incomplete signature). A sends over the tx and includes r, which allows B (with the recipient's address) to verify the destination and amount (by reconstructing the stealth address and decoding ecdhInfo). B then finishes the signature by computing ss[secret_index][0] = ss[secret_index][0] + k - cc[secret_index]*c (secret indices need to be passed as well). B can then broadcast the tx, or send it back to A for broadcasting. Once B has completed the signing (and verified the tx to be valid), he can add the full I_D to his cache, allowing him to verify spent status as well. NOTE: A and B *must* present key A and B to each other with a valid signature proving they know a and b respectively. Otherwise, trickery like the following becomes possible: A creates viewkey a,A, spendkey b,B, and sends a,A,B to B. B creates a fake key C = zG - B. B sends C back to A. The combined spendkey C+B then equals zG, allowing B to spend funds at any time! The signature fixes this, because B does not know a c corresponding to C (and thus can't produce a signature). 2 of 3 User A (coordinator) Shared viewkey a,A "spendkey" j,J User B "spendkey" k,K User C "spendkey" m,M A collects K and M from B and C B collects J and M from A and C C collects J and K from A and B A computes N = nG, n = Hs(jK) A computes O = oG, o = Hs(jM) B anc C compute P = pG, p = Hs(kM) || Hs(mK) B and C can also compute N and O respectively if they wish to be able to coordinate Address: N+O+P, A The rest follows as above. The coordinator possesses 2 of 3 needed keys; he can get the other needed part of the signature/key images from either of the other two. Alternatively, if secure communication exists between parties: A gives j to B B gives k to C C gives m to A Address: J+K+M, A 3 of 3 Identical to 2 of 2, except the coordinator must collect the key images from both of the others. The transaction must also be passed an additional hop: A -> B -> C (or A -> C -> B), who can then broadcast it or send it back to A. N-1 of N Generally the same as 2 of 3, except participants need to be arranged in a ring to pass their keys around (using either the secure or insecure method). For example (ignoring viewkey so letters line up): [4 of 5] User: spendkey A: a B: b C: c D: d E: e a -> B, b -> C, c -> D, d -> E, e -> A Order of signing does not matter, it just must reach n-1 users. A "remaining keys" list must be passed around with the transaction so the signers know if they should use 1 or both keys. Collecting key image parts becomes a little messy, but basically every wallet sends over both of their parts with a tag for each. Thia way the coordinating wallet can keep track of which images have been added and which wallet they come from. Reasoning: 1. The key images must be added only once (coordinator will get key images for key a from both A and B, he must add only one to get the proper key actual key image) 2. The coordinator must keep track of which helper pubkeys came from which wallet (discussed in 2 of 2 section). The coordinator must choose only one set to use, then include his choice in the "remaining keys" list so the other wallets know which of their keys to use. You can generalize it further to N-2 of N or even M of N, but I'm not sure there's legitimate demand to justify the complexity. It might also be straightforward enough to support with minimal changes from N-1 format. You basically just give each user additional keys for each additional "-1" you desire. N-2 would be 3 keys per user, N-3 4 keys, etc. The process is somewhat cumbersome: To create a N/N multisig wallet: - each participant creates a normal wallet - each participant runs "prepare_multisig", and sends the resulting string to every other participant - each participant runs "make_multisig N A B C D...", with N being the threshold and A B C D... being the strings received from other participants (the threshold must currently equal N) As txes are received, participants' wallets will need to synchronize so that those new outputs may be spent: - each participant runs "export_multisig FILENAME", and sends the FILENAME file to every other participant - each participant runs "import_multisig A B C D...", with A B C D... being the filenames received from other participants Then, a transaction may be initiated: - one of the participants runs "transfer ADDRESS AMOUNT" - this partly signed transaction will be written to the "multisig_monero_tx" file - the initiator sends this file to another participant - that other participant runs "sign_multisig multisig_monero_tx" - the resulting transaction is written to the "multisig_monero_tx" file again - if the threshold was not reached, the file must be sent to another participant, until enough have signed - the last participant to sign runs "submit_multisig multisig_monero_tx" to relay the transaction to the Monero network
2017-12-17wallet: add multisig key generationmoneromooo-monero2-2/+144
Scheme by luigi1111
2017-12-16Wallets now do not depend on the daemon rpc libmoneromooo-monero1-1/+1
The shared RPC code is now moved off into a separate lib
2017-12-16Merge pull request #2873Riccardo Spagni1-2/+2
1c838552 Simplewallet.cpp: Fewer pleases in seed NOTE (xmr-eric) 3f18c642 Fix password capitalization mismatch (xmr-eric)
2017-12-16Merge pull request #2860Riccardo Spagni1-4/+4
3dffe71b new wipeable_string class to replace std::string passphrases (moneromooo-monero) 7a2a5741 utils: initialize easylogging++ in on_startup (moneromooo-monero) 54950829 use memwipe in a few relevant places (moneromooo-monero) 000666ff add a memwipe function (moneromooo-monero)
2017-12-13simplewallet: fix default unspent_outputs output with subaddressesmoneromooo-monero1-1/+1
If no subaddress index is given, consider all of them
2017-12-06set_node command, allows setting node without restartTobias Hoffmann2-2/+44
2017-12-02Merge pull request #2833Riccardo Spagni1-0/+10
b0426d4c Fixes #759 Add sanity check on restore height (Cifrado)
2017-12-02Merge pull request #2853Riccardo Spagni1-0/+10
c0ae52c0 simplewallet: prevent (wrong) integrated adresses on accounts > 0 (moneromooo-monero)
2017-11-28Simplewallet.cpp: Fewer pleases in seed NOTExmr-eric1-2/+2
Monero.ts: Fewer pleases in seed NOTE Monero_it.ts: Fewer pleases in seed NOTE Monero_fr.ts: Fewer pleases in seed NOTE
2017-11-27new wipeable_string class to replace std::string passphrasesmoneromooo-monero1-4/+4
2017-11-26Added command descriptionsCifrado2-58/+270
2017-11-25Merge pull request #2825Riccardo Spagni1-1/+1
ac5cd865 simplewallet: fix typo in incoming monero message (moneromooo-monero)
2017-11-25Merge pull request #2822Riccardo Spagni1-1/+1
93c33985 simplewallet: translate ring size 0 to mixin 0 (default values) (moneromooo-monero)
2017-11-25Merge pull request #2796Riccardo Spagni1-5/+7
b42ee213 Wallet: update ring size in outdated error msgs with set_default_ring_size (binaryFate)
2017-11-25Merge pull request #2368Riccardo Spagni2-0/+89
b0b7e0f0 Spend proof without txkey (stoffu)
2017-11-22simplewallet: prevent (wrong) integrated adresses on accounts > 0moneromooo-monero1-0/+10
2017-11-21Spend proof without txkeystoffu2-0/+89
2017-11-21fix for tx proof: use exception instead of error_str when signature gen failedstoffu1-13/+5
2017-11-18Tx proof (revised):stoffu2-356/+101
- refactoring: proof generation/checking code was moved from simplewallet.cpp to wallet2.cpp - allow an arbitrary message to be signed together with txid - introduce two types (outbound & inbound) of tx proofs; with the same syntax, inbound is selected when <address> belongs to this wallet, outbound otherwise. see GitHub thread for more discussion - wallet RPC: added get_tx_key, check_tx_key, get_tx_proof, check_tx_proof - wallet API: moved WalletManagerImpl::checkPayment to Wallet::checkTxKey, added Wallet::getTxProof/checkTxProof - get_tx_key/check_tx_key: handle additional tx keys by concatenating them into a single string
2017-11-17Fixes #759 Add sanity check on restore heightCifrado1-0/+10
2017-11-15simplewallet: fix typo in incoming monero messagemoneromooo-monero1-1/+1
2017-11-15simplewallet: translate ring size 0 to mixin 0 (default values)moneromooo-monero1-1/+1
Avoids turning it to a huge number
2017-11-15simplewallet: wrong ns for input_line in sweep_single (fix #2634)stoffu1-2/+2
2017-11-15wallet: add sweep_single commandstoffu2-0/+271
2017-11-14Fix 383ff4f68943c5d998fba8caa20aee481583f214Howard Chu1-1/+1
Missed a crypto::null_pkey in PR#2629
2017-11-14Fix e89994e98f85be95d68c7bf471fcadf9aabbc93aHoward Chu1-1/+1
Missed an input_line() change
2017-11-14Merge pull request #2765Riccardo Spagni1-3/+3
fc85d7a9 simplewallet: fix in show_transfer passing wrong arg to wallet2::get_payments etc (stoffu)
2017-11-14Merge pull request #2736Riccardo Spagni2-30/+73
0d9c0db9 Do not build against epee_readline if it was not built (Howard Chu) 178014c9 split off readline code into epee_readline (moneromooo-monero) a9e14a19 link against readline only for monerod and wallet-wallet-{rpc,cli} (moneromooo-monero) 437421ce wallet: move some scoped_message_writer calls from the libs (moneromooo-monero) e89994e9 wallet: rejig to avoid prompting in wallet2 (moneromooo-monero) ec5135e5 move input_line from command_line to simplewallet (moneromooo-monero) 082db75f move cryptonote command line options to cryptonote_core (moneromooo-monero)
2017-11-14Merge pull request #2636Riccardo Spagni1-338/+101
ad03f778 simplewallet: factor transfer related exception handling (moneromooo-monero)
2017-11-14Merge pull request #2629Riccardo Spagni1-2/+2
383ff4f6 remove "using namespace std" from headers (moneromooo-monero)
2017-11-14Do not build against epee_readline if it was not builtHoward Chu1-1/+1
2017-11-14split off readline code into epee_readlinemoneromooo-monero1-0/+2
2017-11-14link against readline only for monerod and wallet-wallet-{rpc,cli}moneromooo-monero1-0/+1
2017-11-14wallet: move some scoped_message_writer calls from the libsmoneromooo-monero1-1/+10
2017-11-14wallet: rejig to avoid prompting in wallet2moneromooo-monero1-30/+48
wallet2 is a library, and should not prompt for stdin. Instead, pass a function so simplewallet can prompt on stdin, and a GUI might display a window, etc.
2017-11-14move input_line from command_line to simplewalletmoneromooo-monero1-0/+13
It was only used there, and this removes one part of the common dependency on libreadline
2017-11-14simplewallet: factor transfer related exception handlingmoneromooo-monero1-338/+101
This ensures they don't go out of sync when adding/changing them, and makes the code easier to deal with.
2017-11-14remove "using namespace std" from headersmoneromooo-monero1-2/+2
It's nasty, and actually breaks on Solaris, where if.h fails to build due to: struct map *if_memmap;
2017-11-15simplewallet: fix in show_transfer passing wrong arg to ↵stoffu1-3/+3
wallet2::get_payments etc
2017-11-14Merge pull request #2750Riccardo Spagni1-6/+6
424852a6 Fix 'sweep_all' command when called with no args (Leon Klingele)
2017-11-14Merge pull request #2747Riccardo Spagni1-2/+3
37e1fd94 simplewallet: mark the active account in print_accounts (moneromooo-monero)
2017-11-14Merge pull request #2745Riccardo Spagni2-2/+0
6cf33446 Remove wallet dependency on p2p (moneromooo-monero)
2017-11-14simplewallet: forbid 0 ring sizemoneromooo-monero1-0/+10
It'd be interpreted as a huge one (~0 fake outs)
2017-11-14simplewallet: reject attempts to use too low mixin earlymoneromooo-monero1-0/+12
This yields a clear error message rather then some possibly confusing more technical errors down the line
2017-11-14Merge pull request #2683Riccardo Spagni1-26/+79
105425b7 simplewallet: reject invalid argument for boolean parameter (stoffu)
2017-11-14Merge pull request #2682Riccardo Spagni1-2/+2
8ddcf1e7 simplewallet: remove XMR mentions (moneromooo-monero)
2017-11-14Merge pull request #2633Riccardo Spagni2-3/+27
ad96c478 wallet-cli: added --generate-from-spend-key option (stoffu)
2017-11-14simplewallet: reject invalid argument for boolean parameterstoffu1-26/+79
2017-11-14wallet-cli: added --generate-from-spend-key optionstoffu2-3/+27
2017-11-13Wallet: update ring size in outdated error msgs with set_default_ring_sizebinaryFate1-5/+7
2017-11-06track double spending in the txpoolmoneromooo-monero1-7/+12
Transactions in the txpool are marked when another transaction is seen double spending one or more of its inputs. This is then exposed wherever appropriate. Note that being marked with this "double spend seen" flag does NOT mean this transaction IS a double spend and will never be mined: it just means that the network has seen at least another transaction spending at least one of the same inputs, so care should be taken to wait for a few confirmations before acting upon that transaction (ie, mostly of use for merchants wanting to accept unconfirmed transactions).
2017-11-06Merge pull request #2605Riccardo Spagni2-0/+38
b370ef54 Wallet: Descriptions through new commands 'set_description', 'get_description' (rbrunner7)
2017-11-06Merge pull request #2595Riccardo Spagni1-15/+23
8041b4e9 wallet-cli: allow priority argument for sweep_all and donate (stoffu)
2017-11-04wallet-cli: allow priority argument for sweep_all and donatestoffu1-15/+23
2017-11-03Fix 'sweep_all' command when called with no argsLeon Klingele1-6/+6
Executing 'sweep_all' with no arguments segfaulted before.
2017-11-02simplewallet: mark the active account in print_accountsmoneromooo-monero1-2/+3
2017-11-02Remove wallet dependency on p2pmoneromooo-monero2-2/+0
2017-10-19simplewallet: remove XMR mentionsmoneromooo-monero1-2/+2
They are actually wrong if the wallet is setup in a different denomination, and it's incursion of extrinsic lingo where monero fits perfectly in the first place.
2017-10-16Wallet: Descriptions through new commands 'set_description', 'get_description'rbrunner72-0/+38
2017-10-16Distinguish "not enough money" and "not enough unlocked money"binaryFate1-4/+32
Fix #1530
2017-10-15Merge pull request #2606Riccardo Spagni2-1/+21
4090e8c6 simplewallet: add get/set for refresh-from-height (moneromooo-monero)
2017-10-15Merge pull request #2586Riccardo Spagni2-32/+46
7b8d3ec6 wallet-cli: add --do-not-relay option (stoffu)
2017-10-15Merge pull request #2569Riccardo Spagni1-2/+0
b5b4abb8 simplewallet: fix setting default-ring-size to 0 (moneromooo-monero)
2017-10-15Merge pull request #2554Riccardo Spagni1-1/+18
d74336d5 wallet: encrypt (un)signed tx, also optionally save unencrypted raw tx hexstr (stoffu)
2017-10-15Merge pull request #2550Riccardo Spagni1-3/+3
735fafec simplewallet: allow 1/yes/y as well as true for start_mining options (moneromooo-monero)
2017-10-15Merge pull request #2549Riccardo Spagni1-1/+2
bf2d9113 simplewallet: fix --restore-from-height being ignored (moneromooo-monero)
2017-10-08simplewallet: add get/set for refresh-from-heightmoneromooo-monero2-1/+21
2017-10-07Subaddresseskenshi842-203/+637
2017-10-07wallet-cli: add --do-not-relay optionstoffu2-32/+46
2017-10-07wallet: encrypt (un)signed tx, also optionally save unencrypted raw tx hexstrstoffu1-1/+18
2017-10-06Merge pull request #2468Riccardo Spagni2-2/+23
986d03d4 simplewallet: allow to set threshold before warning about tx backlog (selsta)
2017-10-03simplewallet: fix setting default-ring-size to 0moneromooo-monero1-2/+0
It'd be set to the current wallet default instead
2017-10-02Merge pull request #2515Riccardo Spagni1-0/+3
c34093db simplewallet: add privacy warning when using an untrusted demon (moneromooo-monero)
2017-10-02Merge pull request #2512Riccardo Spagni1-3/+5
792ba4f0 Log categories can now be added to and removed from (moneromooo-monero) 48f92eb6 easylogging++: add categories getter (moneromooo-monero) f35afe62 epee: factor log level/categories setting (moneromooo-monero)
2017-10-02simplewallet: allow to set threshold before warning about tx backlogselsta2-2/+23
2017-09-29simplewallet: allow 1/yes/y as well as true for start_mining optionsmoneromooo-monero1-3/+3
Also mention those options in the start_mining help line
2017-09-29simplewallet: fix --restore-from-height being ignoredmoneromooo-monero1-1/+2
2017-09-25move checkpoints in a separate librarymoneromooo-monero1-1/+1
2017-09-25Merge pull request #2452Riccardo Spagni1-0/+3
0aaaca29 tx_pool: set the "invalid input" bit when check_tx_inputs fails (moneromooo-monero) 9236823b simplewallet: print tx rejection reason where it was missing (moneromooo-monero) 3dee3301 core_rpc_server: print tx rejection reason at L0 too (moneromooo-monero)
2017-09-25Merge pull request #2424Riccardo Spagni1-3/+12
28b72b6e tx_pool: pre-init tvc.m_verifivation_failed before processing (moneromooo-monero) 50a629b2 core_tests: catch (impossible in practice) tx extra api failure (moneromooo-monero) fee15ef1 wallet2: catch failure to parse address (moneromooo-monero) 1399e26d net_peerlist: remove dead code (moneromooo-monero) 50e09698 tx_pool: guard against failure getting tx hash (moneromooo-monero) 54cc209a wallet_rpc_server: catch failure to create directory (moneromooo-monero) 3e55099c wallet_rpc_server: init m_vm to NULL in ctor (moneromooo-monero) 7d0dde5e wallet_args: remove redundant default value for --log-file (moneromooo-monero) ed4a3350 wallet2: catch failure to save keys file (moneromooo-monero) 44434c8a wallet2_api: check whether dynamic_cast returns NULL (moneromooo-monero) 92f2f687 core: check return value from parse_hexstr_to_binbuff (moneromooo-monero) 5475692e wallet2_api: remove an unused, uninitialized, field (moneromooo-monero) a7ba3de1 libwallet_api_tests: initialize newblock_triggered on reset (moneromooo-monero) b2763ace wallet2_api: init error code to "no error" in the ctor (moneromooo-monero) b5faac53 get_blockchain_top now returns void (moneromooo-monero) 2e44d8f2 wallet_rpc_server: guard against exceptions (moneromooo-monero) 4230876b simplewallet: guard against I/O exceptions (moneromooo-monero) 06c1e057 daemon: initialize decode_as_json in RPC request (moneromooo-monero) 11f71af5 http_base: init size_t in http_request_info ctor (moneromooo-monero)
2017-09-25Merge pull request #2442Riccardo Spagni1-2/+1
e29282d2 build: auto update version info without manually deleting version.h (stoffu)
2017-09-25simplewallet: guard against I/O exceptionsmoneromooo-monero1-3/+12
CID 175308
2017-09-25Merge pull request #2257Riccardo Spagni2-2/+31
651baaec wallet: add encrypted seed functionality (moneromooo-monero)
2017-09-22simplewallet: add privacy warning when using an untrusted demonmoneromooo-monero1-0/+3
2017-09-22Log categories can now be added to and removed frommoneromooo-monero1-3/+5
Also, set_log without parameters now prints the log categories
2017-09-21build: auto update version info without manually deleting version.hstoffu1-2/+1
2017-09-20Merge pull request #2412Riccardo Spagni1-2/+2
81fb2f53 Silence more stupid gcc warnings (Howard Chu)
2017-09-20Merge pull request #2381Riccardo Spagni2-0/+11
840aed1c monero-wallet-cli: New command 'wallet_info' improved (rbrunner7) 9bdd985c monero-wallet-cli: New command 'wallet_info' (rbrunner7)
2017-09-16simplewallet: print tx rejection reason where it was missingmoneromooo-monero1-0/+3
2017-09-12wallet: add encrypted seed functionalitymoneromooo-monero2-2/+31
This uses luigi1111's CN_Add method. See https://xmr.llcoins.net for details.
2017-09-08Silence more stupid gcc warningsHoward Chu1-2/+2
2017-09-02Merge pull request #2362Riccardo Spagni2-3/+67
adce8ae4 simplewallet: new "fee" command to display fee information (moneromooo-monero)
2017-09-02Merge pull request #2316Riccardo Spagni1-0/+1
0c6c3eb3 Silence stupid fallthru warning in gcc 7 (Howard Chu)
2017-08-31monero-wallet-cli: New command 'wallet_info' improvedrbrunner71-5/+4
2017-08-31monero-wallet-cli: New command 'wallet_info'rbrunner72-0/+12
2017-08-29simplewallet: new "fee" command to display fee informationmoneromooo-monero2-3/+67
including expected transaction backlog at different priorities
2017-08-26Merge pull request #2320Riccardo Spagni1-0/+8
c656dd0e Fix refresh counter display (Howard Chu) c088d38a Simplify readline support (Howard Chu)
2017-08-26wallet: new option to check/confirm txpool backlog when sendingmoneromooo-monero2-1/+58
2017-08-22Fix refresh counter displayHoward Chu1-0/+8
Suspend readline when refreshing
2017-08-21Silence stupid fallthru warning in gcc 7Howard Chu1-0/+1
2017-08-15Merge pull request #2293Riccardo Spagni2-1/+14
dee41efa simplewallet: mnemonic language command-line arg (Eugene Otto)
2017-08-15Merge pull request #2281Riccardo Spagni1-80/+8
e499ff33 simplewallet: factor out message_writer (moneromooo-monero) 7ed5ab47 scoped_message_writer: pause readline to match simplewallet (moneromooo-monero)
2017-08-15Merge pull request #2279Riccardo Spagni1-0/+6
359517c7 wallet_rpc_server: fix possible privacy leak in on_import_key_images() (Jaquee) 20495b27 simplewallet: fix possible privacy leak in import_key_images() (Jaquee)
2017-08-15Merge pull request #2256Riccardo Spagni1-6/+11
042b86c4 simplewallet: do not ask wallet filename twice when restoring (moneromooo-monero)
2017-08-15Merge pull request #2255Riccardo Spagni1-2/+2
8bbed275 simplewallet: Be explicit about secret keys (Erik de Castro Lopo)
2017-08-15Merge pull request #2240Riccardo Spagni2-2/+15
b7d6ec83 simplewallet: add (out of sync) or (no daemon) markers in the prompt (moneromooo-monero) fa23a500 wallet2: add a is_synced function (moneromooo-monero) f1307bbd node_rpc_proxy: add a proxy for target height (moneromooo-monero)
2017-08-15Merge pull request #2205Riccardo Spagni1-0/+35
c97d1bd3 wallet: return unlock_time in get_transfers (moneromooo-monero)
2017-08-13simplewallet: mnemonic language command-line argEugene Otto2-1/+14
Add `--mnemonic-language` command-line arg so it's possible to generate a wallet without interacting with the CLI.
2017-08-11simplewallet: factor out message_writermoneromooo-monero1-80/+8
2017-08-11simplewallet: fix possible privacy leak in import_key_images()Jaquee1-0/+6
2017-08-07change mixin to ring size in user visible placesmoneromooo-monero2-40/+44
2017-08-07Merge pull request #2218Riccardo Spagni2-3/+145
02f13d6c Fix handling of strings & simplify summation of spendkeys (JollyMort) 40fc9d7b Add option to join multisig wallet pieces together (JollyMort)
2017-08-07Merge pull request #2210Riccardo Spagni1-7/+43
cb0b5594 Move OpenAlias console input back from libs (moneromooo-monero)
2017-08-07Merge pull request #2196Riccardo Spagni1-12/+50
16a55347 simplewallet: show payment ids on sign_transfer (moneromooo-monero)
2017-08-06simplewallet: do not ask wallet filename twice when restoringmoneromooo-monero1-6/+11
It's annoying and pointless (especially as it's the only thing where the user is asked twice)
2017-08-06simplewallet: Be explicit about secret keysErik de Castro Lopo1-2/+2
Previously, the wallet just asked for "Spend key" and "View key" but now it specifies that these should be the secret versions of these keys.
2017-08-04simplewallet: show payment ids on sign_transfermoneromooo-monero1-12/+50
Integrated addresses are shown when an encrypted payment id is used
2017-08-02simplewallet: add (out of sync) or (no daemon) markers in the promptmoneromooo-monero2-2/+15
Should help people who don't realize why they haven't seen their monero yet.
2017-08-02wallet: return unlock_time in get_transfersmoneromooo-monero1-0/+35
also show it in simplewallet's show_transfer
2017-07-29Fix handling of strings & simplify summation of spendkeysJollyMort1-13/+7
2017-07-29Add option to join multisig wallet pieces togetherJollyMort2-3/+151
Asks user for all the data required to merge secret keys from multisig wallets into one master wallet, which then gets full control of the multisig wallet. The resulting wallet will be the same as any other regular wallet.
2017-07-27Move OpenAlias console input back from libsmoneromooo-monero1-7/+43
Library code should definitely not ask for console input unless it's clearly an input function. Delegating the user interaction part to the caller means it can now be used by a GUI, or have a decision algorithm better adapted to a particular caller.
2017-07-22Make successful transfer log message more informativeJollyMort1-1/+2
"Payment successfully sent" can be misleading if the TX isn't confirmed and drops from TX-pool.
2017-07-19Merge pull request #2159Riccardo Spagni1-2/+2
6955976b Add various readline related fixes (Jethro Grassie)
2017-07-19Merge pull request #2135Riccardo Spagni1-0/+2
5cea3552 simplewallet: lock idle scope when sweeping (moneromooo-monero)
2017-07-09Add various readline related fixesJethro Grassie1-2/+2
- Add missing unbind key - Fix colored messages - Add command completion - Preserve last command input - Fix cursor position issues - Fix trailing whitespace in commands - Synchronize set_prompt
2017-07-03Merge pull request #2124Riccardo Spagni1-12/+0
3b599d2b wallet2: get current height from the daemon on creation (moneromooo-monero) d3bb72ff wallet2: fix infinite loop on future refresh height (moneromooo-monero) 32754784 wallet: fix refresh_from_height setting on new wallet (moneromooo-monero)
2017-07-03Merge pull request #2112Riccardo Spagni1-0/+15
76043b17 monero-wallet-cli: hang on exit in readline code (#2117) (moneromooo-monero) a73a42a6 monero-wallet-cli: hang on exit in readline code (#2117) (moneromooo-monero) be9d4f04 Fix multiline wallet cli output with readline (Jethro Grassie)
2017-07-03Merge pull request #2110Riccardo Spagni1-4/+4
7d2c89b6 Add french translation (Guillaume LE VAILLANT) 3255887f simplewallet: typo fixes (Guillaume LE VAILLANT)
2017-06-30simplewallet: lock idle scope when sweepingmoneromooo-monero1-0/+2
This ensures the chain and related structures can't change while we're using them
2017-06-26wallet: fix refresh_from_height setting on new walletmoneromooo-monero1-12/+0
The previous patch was based on a wrong premise (that the daemon height was 0 because the daemon calling code wasn't yet initialized). In fact, current height approximation was not setup for testnet. Fix this.
2017-06-25Fix multiline wallet cli output with readlineJethro Grassie1-0/+15
monero-wallet-cli commands which have multine output sometimes causes issues with the readline support. This patch fixes show_transfers, payments and incoming_transfers.
2017-06-23simplewallet: typo fixesGuillaume LE VAILLANT1-4/+4
2017-06-22simplewallet: removed unneeded LOCK_IDLE_SCOPE() from check_tx_key()stoffu1-2/+0
2017-06-22simplewallet: replace assert(m_wallet) with error outstoffu1-5/+25
2017-06-22Signature proving payment to destination by only revealing key derivation, ↵stoffu2-15/+220
not the actual tx secret key
2017-06-18Merge pull request #2081Riccardo Spagni2-0/+15
b2319a03 simplewallet: new command to generate a random payment id (moneromooo-monero)
2017-06-10simplewallet: new command to generate a random payment idmoneromooo-monero2-0/+15
This is trivial, but often requested, and possibly hard to do in Windows. That makes it more user friendly.
2017-06-07add simplewallet --generate-new-wallet arg checksMichael Shick1-0/+9
Add fail-fast paths that reduce frustration around the misuse of --wallet-file combined with --restore-deterministic-wallet. Flow now gives more descriptive errors and avoids having users type in their whole seed before the failure condition is noticed.
2017-05-30Merge pull request #2053Riccardo Spagni1-10/+13
05f3dcf7 simplewallet: fix refresh height for new wallets (moneromooo-monero)
2017-05-30Merge pull request #2039Riccardo Spagni1-1/+1
4b932ff3 changed crypto to cncrypto so it generated libcncrypto (Gentian)
2017-05-28simplewallet: fix refresh height for new walletsmoneromooo-monero1-10/+13
With the recent change to wallet creation code, the code was calling to the daemon before the wallet's daemon address was initialized, and thus failing. This was causing all new wallets to refresh from 0 instead of just fetching early block hashes.
2017-05-23changed crypto to cncrypto so it generated libcncryptoGentian1-1/+1
fix a cmakelist
2017-05-09corrected typo in help regarding min-outputs-*stoffu1-1/+1
2017-04-24wallet: add sweep_below functionmoneromooo-monero2-2/+26
It sweeps all outputs below the given threshold This is available via the existing sweep_all RPC, by setting amount_threshold the desired amount (in atomic units)
2017-04-24Merge pull request #1984Riccardo Spagni1-7/+22
a255a540 simplewallet: allow multiline seed (moneromooo-monero) 5fce581c mnemonics: ignore multiple whitespace between words (moneromooo-monero)
2017-04-16simplewallet: allow multiline seedmoneromooo-monero1-7/+22
People are likely to enter it in three lines as it is how it is displayed at creation time
2017-04-12wallet cli: removed some inappropriate return-falsekenshi841-16/+6
2017-04-11Merge pull request #1949Riccardo Spagni1-9/+9
0ee018b4 wallet2: do not go over the target tx size if many destinations (moneromooo-monero) 9ae566d0 simplewallet: fix cold signing of split transactions (moneromooo-monero) aae14a10 simplewallet: allow setting confirm-missing-payment-id in watch wallets (moneromooo-monero)
2017-04-11Merge pull request #1940Riccardo Spagni1-4/+17
17c7c62d Add per transaction fee to transfer command (Antti Keränen)
2017-04-11Merge pull request #1931Riccardo Spagni1-1/+0
89e100bc wallet cli: remove redundant password confirm in donate command (kenshi84)
2017-04-02simplewallet: fix cold signing of split transactionsmoneromooo-monero1-3/+9
They'd be rejected as suspicious as the change goes to more than one destination. However, split transactions will most likely include fake zero amount change to random addresses, so we only consider change with non zero amount for this.
2017-04-02simplewallet: allow setting confirm-missing-payment-id in watch walletsmoneromooo-monero1-6/+0
These can create transactions, even though they cannot sign them.
2017-04-01Add per transaction fee to transfer commandAntti Keränen1-4/+17
Allows priority argument default/unimportant/normal/elevated/priority to be used per transaction in CLI wallet's transfer command. Resolves #1913.
2017-03-27wallet cli: remove redundant password confirm in donate commandkenshi841-1/+0
2017-03-26simplewallet: factor the per-variable code in set_variablemoneromooo-monero1-170/+28
2017-03-25wallet: option to merge destinationsmoneromooo-monero2-1/+27
With the change from the original transfer method to the new algorithm, payments to the same destination were merged. It seemed like a good idea, optimizing space. However, it is a useful tool for people who want to split large outputs into several smaller ones (ie, service providers making frequent payments, and who do not like a large chunk of their balance being locked for 10 blocks after each payment). Default to off, which is a change from the previous behavior.
2017-03-25Merge pull request #1921Riccardo Spagni1-1/+1
2bee92db Fixed typo in v5 hard fork finalized date (Derek Zhang) d17179d1 Fixed typo in CLI wallet help message (Derek Zhang)
2017-03-24Fixed typo in CLI wallet help messageDerek Zhang1-1/+1
2017-03-24wallet: try to save large outputs when using an unneeded second inputmoneromooo-monero2-1/+67
When a single input is enough to satisfy a transfer, the code would previously try to add a second input, to match the "canonical" makeup of a transaction with two inputs and two outputs. This would cause wallets to slowly merge outputs till all the monero ends up in a single output, which causes trouble when making two transactions one after the other, since change is locked for 10 blocks, and an increasing portion of the remaining balance would end up locked on each transaction. There are two new settings (min-output-count and min-output-value) which can control when to stop adding such unneeded second outputs. The idea is that small "dust" outputs will still get added, but larger ones will not. Enable with, eg: set min-output-count 10 set min-output-value 30 to avoid using an unneeded second output of 30 monero or more, if there would be less than 10 such outputs left. This does not invalidate any other reason why such outputs would be used (ie, when they're really needed to satisfy a transfer, or when randomly picked in the normal course of selection). This may be improved in the future.
2017-03-22Transfer helpAkademik Prokhor Zakharov1-2/+2
New pull request because I couldn't figure out how to change the previous one. 1. For clarity, I want to focus the help text for the 'transfer' command on the most typical use case (a single payment). 2. New users will prefer to use 'transfer', so the older method 'transfer_original' should refer to 'transfer' rather than the other way around.
2017-03-21wallet: fix set_log not handling 0,xxx style settingsmoneromooo-monero1-15/+1
2017-03-18Merge pull request #1886Riccardo Spagni1-5/+0
f9a2b527 simplewallet: allow setting tx priority in watch wallets (moneromooo-monero)
2017-03-18Merge pull request #1883Riccardo Spagni1-2/+2
d0238313 use const references in catch blocks (moneromooo-monero)
2017-03-18simplewallet: allow setting tx priority in watch walletsmoneromooo-monero1-5/+0
Those can create unsigned transactions
2017-03-18use const references in catch blocksmoneromooo-monero1-2/+2
2017-03-18simplewallet: catch case where no transactions are mademoneromooo-monero1-1/+7
This would otherwise be a silent noop, which is confusing. This can happen if the daemon is started, but not yet ready to service all requests, and this is a safe catch all.