Age | Commit message (Collapse) | Author | Files | Lines |
|
7194506 Blockchain: remove old fee calc logic (jeffro256)
|
|
|
|
Related to https://github.com/monero-project/research-lab/issues/78
Added a relay rule that enforces the `unlock_time` field is equal to 0 for non-coinbase transactions.
UIs changed:
* Removed `locked_transfer` and `locked_sweep_all` commands from `monero-wallet-cli`
APIs changed:
* Removed `unlock_time` parameters from `wallet2` transfer methods
* Wallet RPC transfer endpoints send error codes when requested unlock time is not 0
* Removed `unlock_time` parameters from `construct_tx*` cryptonote core functions
|
|
eed975d Fix missing checks for IsObject in ZMQ jsonrpc reading (Lee Clagett)
|
|
2525200 serialization: remove container wrappers and serialize directly (jeffro256)
|
|
53e632b fix merge mining with more than one merge mined chain (Crypto City)
|
|
4acae11 Fix EAGAIN bug in ZMQ-RPC/ZMQ-PUB (Lee *!* Clagett)
|
|
reported by sech1
|
|
|
|
Some downstream code (most notably PR https://github.com/UkoeHB/monero/pull/25) wants to use the src/serialization lib
for storing information persistently. When one builds classes/machines wishing to serialize containers, they must use
the `serializable_*` container classes. In this case, this makes the Seraphis library code unnecessarily tightly coupled
with the src/serialization code since one cannot swap out their type of storage format without major refactoring of class
field types. By serializing STL containers directly, we can abstract the serialization details away, making for much
cleaner design. Also small bonus side effect of this change is that STL containers with custom Comparators, Allocators,
and Hashers are serializable. `std::multimap` is added to the list of serializable containers.
Depends upon https://github.com/monero-project/monero/pull/9069.
|
|
1e2e703 core_rpc_server: silence unused warnings (jeffro256)
|
|
|
|
8190f25 KV_SERIALIZE: remove extraneous semicolons in DSL (jeffro256)
|
|
b0bf49a blockchain_db: add k-anonymity to txid fetching (jeffro256)
|
|
e8cac61 core_rpc_server: return ID of submitted block (jeffro256)
|
|
Prereq of https://github.com/monero-project/monero/pull/8867
|
|
|
|
Read more about k-anonymity [here](https://en.wikipedia.org/wiki/K-anonymity). We implement this feature in the monero daemon for transactions
by providing a "Txid Template", which is simply a txid with all but `num_matching_bits` bits zeroed out, and the number `num_matching_bits`. We add an operation to `BlockchainLMDB` called
`get_txids_loose` which takes a txid template and returns all txids in the database (chain and mempool) that satisfy that template. Thus, a client can
ask about a specific transaction from a daemon without revealing the exact transaction they are inquiring about. The client can control the statistical
chance that other TXIDs (besides the one in question) match the txid template sent to the daemon up to a power of 2. For example, if a client sets their `num_matching_bits`
to 5, then statistically any txid has a 1/(2^5) chance to match. With `num_matching_bits`=10, there is a 1/(2^10) chance, so on and so forth.
Co-authored-by: ACK-J <60232273+ACK-J@users.noreply.github.com>
|
|
|
|
|
|
4e16559 rpc: give reason when sending non-hex raw tx (jeffro256)
|
|
5b4fea7 Copyright: Update to 2023 (mj-xmr)
|
|
3771641 Add a size limit for tx_extra in tx pool (tevador)
|
|
c4af33e Enforce restricted # pool txs served via RPC + optimize chunked reqs (j-berman)
9752116 wallet2, RPC: Optimize RPC calls for periodic refresh from 3 down to 1 call (rbrunner7)
|
|
|
|
- `/getblocks.bin` respects the `RESTRICTED_TX_COUNT` (=100) when
returning pool txs via a restricted RPC daemon.
- A restricted RPC daemon includes a max of `RESTRICTED_TX_COUNT` txs
in the `added_pool_txs` field, and returns any remaining pool hashes
in the `remaining_added_pool_txids` field. The client then requests
the remaining txs via `/gettransactions` in chunks.
- `/gettransactions` no longer does expensive no-ops for ALL pool txs
if the client requests a subset of pool txs. Instead it searches for
the txs the client explicitly requests.
- Reset `m_pool_info_query_time` when a user:
(1) rescans the chain (so the wallet re-requests the whole pool)
(2) changes the daemon their wallets points to (a new daemon would
have a different view of the pool)
- `/getblocks.bin` respects the `req.prune` field when returning
pool txs.
- Pool extension fields in response to `/getblocks.bin` are optional
with default 0'd values.
|
|
|
|
934b798 rpc: do not misidentify coinbase txes as pruned (moneromooo-monero)
|
|
Co-authored-by: plowsof <plowsof@protonmail.com>
extra files
|
|
- Straight-forward call interface: `void rx_slow_hash(const char *seedhash, const void *data, size_t length, char *result_hash)`
- Consensus chain seed hash is now updated by calling `rx_set_main_seedhash` whenever a block is added/removed or a reorg happens
- `rx_slow_hash` will compute correct hash no matter if `rx_set_main_seedhash` was called or not (the only difference is performance)
- New environment variable `MONERO_RANDOMX_FULL_MEM` to force use the full dataset for PoW verification (faster block verification)
- When dataset is used for PoW verification, dataset updates don't stall other threads (verification is done in light mode then)
- When mining is running, PoW checks now also use dataset for faster verification
|
|
|
|
|
|
|
|
2639c4f rpc: skip bootstrap nodes that are lower than last checkpoint (selsta)
|
|
a4cb77f epee: update 'http_server_handlers_map2.h' macros to use fully qualified names (Jeffrey Ryan)
|
|
|
|
This reverts commit 50410d1f7d04bf60053f2263410c39e81d3ddad1, reversing
changes made to d054def63f9b8950fe20b2d8e841f5a9ae09418f.
|
|
quick patch which fixes the issue where if you use some macros from `http_server_handlers_map2.h` you have to be in the `epee` namespace or it doesn't compile. Now can remove `using namespace epee;` from header file `core_rpc_server.h`, which caused a couple of name qualifying mistakes
|
|
While copying my data dir to another drive, I missed copying the rpc_ssl.key file b/c of the file permissions.
This change will give a much more clear, descriptive error in that scenario.
|
|
reported by m31007
|
|
|
|
https://github.com/ArticMine/Monero-Documents/blob/master/MoneroScaling2021-02.pdf
with a change to use 1.7 instead of 2.0 for the max long term increase rate
|
|
da9aa1f Copyright: Update to 2022 (mj-xmr)
|
|
83bb027 Make RPC server functions that read db thread safe (j-berman)
|
|
- grab an lmdb db_rtxn_guard to ensure consistent data from the db
- fixed on_getblockhash error resp when requested height >= blockchain height
- left functions that read shared memory untouched for now
|
|
9bde2db Fixes: Don't require --rpc-login with --rpc-access-control-origins #8168 (Jeffrey)
|
|
|
|
This PR removes the requirement for --rpc-login to be specified if --rpc-access-control-origins is.
This will allow public nodes to serve cross-origin requests. You can still use --rpc-login with
--rpc-access-control-origins, but it is no longer mandatory.
Original Issue: #8168
|
|
|
|
3a90be4 rpc: don't set error code as status string (selsta)
|
|
e8e507f rpc: fix DoS vector in get_output_distribution (moneromooo-monero)
|
|
Calculate PoW hash for a block candidate
|
|
This will prevent people spending old pre-rct outputs using a
stranger's node, which may be a good thing
|
|
2e8936f rpc: Fix get_transactions failing when not found (Nathan Dorfman)
|
|
dfee15e RPC and ZeroMQ APIs to support p2pool (SChernykh)
|
|
|
|
|
|
Adds the following:
- "get_miner_data" to RPC API
- "json-miner-data" to ZeroMQ subscriber contexts
Both provide the necessary data to create a custom block template. They are used by p2pool.
Data provided:
- major fork version
- current height
- previous block id
- RandomX seed hash
- network difficulty
- median block weight
- coins mined by the network so far
- mineable mempool transactions
|
|
4ced092 daemon: allow proxy configuration (anon, selsta, tobtoht)
|
|
Co-authored-by: selsta <selsta@sent.at>
Co-authored-by: tobtoht <thotbot@protonmail.com>
|
|
|
|
08e4497 Improve cryptonote (block and tx) binary read performance (Lee Clagett)
|
|
4da1112 rpc: send confirmations in get_transactions result (moneromooo-monero)
|
|
494f2e1 rpc: fix some error return codes/status (moneromooo-monero)
|
|
673c6d2 Reduce compilation time of epee/portable_storage_template_helper.h (mj-xmr)
|
|
if the wallet does it, it would get a wrong result (possibly even
negative) if its local chain is not synced up to the daemon's yet
|
|
cf266d6 bootstrap_daemon: proxy configuration support (xiphon)
|
|
|
|
Some RPC return an error string in status, and the code must return
true on error (with a status string).
|
|
|
|
9867a91 Store RPC SSL key/cert for consistent authentication between runs (Lee Clagett)
|
|
19b2283 New add_aux_pow RPC to support merge mining (moneromooo-monero)
|
|
|
|
|
|
There are quite a few variables in the code that are no longer
(or perhaps never were) in use. These were discovered by enabling
compiler warnings for unused variables and cleaning them up.
In most cases where the unused variables were the result
of a function call the call was left but the variable
assignment removed, unless it was obvious that it was
a simple getter with no side effects.
|
|
|
|
|
|
47590fc rpc: report target height as 0 when synced (moneromooo-monero)
|
|
|
|
do not include blocked hosts in peer lists or public node lists by default,
warn about no https on clearnet and about untrusted peers likely being spies
|
|
true if and pretty much only if new blocks are being added
|
|
It would otherwise be possible for a peer to send bad blocks,
then disconnect and reconnect again, escaping bans
|
|
since it only makes sense when syncing, and it confuses people
|
|
0363476ee rpc: get_info - add 'synchronized' field (xiphon)
|
|
aaf837cf5 rpc: skip non-synced bootstrap daemons in --no-sync mode too (xiphon)
|
|
65903d2cf Add rpc-restricted-bind-ip option (Howard Chu)
|
|
3247f11 Silence stupid warnings (Howard Chu)
|
|
5569a8e rpc: on_send_raw_tx (bootstrap) - send to bootstrap daemon and P2P (xiphon)
|
|
aad780b Fix CLI and unrestricted RPC relay_tx with stempool (Lee Clagett)
|
|
b49f489 fix next_seed_height regression in getblocktemplate rpc (xnbya)
|
|
ad7ea2c core_rpc_server: on_send_raw_tx - fix bootstrap daemon mode check (xiphon)
|
|
f4b2382 rpc_private_headers declaration fix (malbit)
|
|
|
|
|
|
|
|
|
|
|
|
Fixes #6369
|
|
|
|
|
|
|
|
|
|
|
|
|
|
d20ff4f64 functional_tests: add a large (many randomx epochs) p2p reorg test (moneromooo-monero)
6a0b3b1f8 functional_tests: add randomx tests (moneromooo-monero)
9d42649d5 core: fix mining from a block that's not the current top (moneromooo-monero)
|
|
bdc6b10 Fix ZMQ pruned bulletproof transactions (vtnerd)
|
|
|
|
They are allowed from v12, and MLSAGs are rejected from v13.
|
|
728ba38b1 rpc: always send raw txes through P2P (don't use bootstrap daemon) (xiphon)
|
|
|
|
This reduces the attack surface for data that can come from
malicious sources (exported output and key images, multisig
transactions...) since the monero serialization is already
exposed to the outside, and the boost lib we were using had
a few known crashers.
For interoperability, a new load-deprecated-formats wallet
setting is added (off by default). This allows loading boost
format data if there is no alternative. It will likely go
at some point, along with the ability to load those.
Notably, the peer lists file still uses the boost serialization
code, as the data it stores is define in epee, while the new
serialization code is in monero, and migrating it was fairly
hairy. Since this file is local and not obtained from anyone
else, the marginal risk is minimal, but it could be migrated
later if needed.
Some tests and tools also do, this will stay as is for now.
|
|
13eee1d6a rpc: reject wrong sized txid (moneromooo-monero)
92e6b7df2 easylogging++: fix crash with reentrant logging (moneromooo-monero)
6dd95d530 epee: guard against exceptions in RPC handlers (moneromooo-monero)
90016ad74 blockchain: guard against exceptions in add_new_block/children (moneromooo-monero)
|
|
c1b03fb1a rpc: return empty txid get_outs rather than 00..00 when not requested (moneromooo-monero)
|
|
4e2377995 Change ZMQ-JSON txextra to hex and remove unnecessary base fields (Lee Clagett)
|
|
It turns out that some remote (bootstrap) nodes silently drop /
don't broadcast client's transactions.
|
|
|
|
|
|
|
|
Reporter requested credit to be given to Decred
|
|
It's more obvious there's no txid, and it saves space
|
|
5ef0607da Update copyright year to 2020 (SomaticFanatic)
|
|
4df8f9c rpc: fix loading rpc payment data from file (moneromooo-monero)
|
|
dc1a053 rpc: fix comparison of seconds vs microseconds (moneromooo-monero)
|
|
6e4a55b rpc: fix relay_tx error return mixup (moneromooo-monero)
9b86e14 functional_tests: add simple relay_tx test (moneromooo-monero)
|
|
78d435a rpc: don't display invalid json errors on default log level (moneromooo-monero)
|
|
7ebb351 rpc: lock access to the rpc payment object (moneromooo-monero)
|
|
4d3c2d0 rpc: add a sanity limit to a few RPC in restricted mode (moneromooo-monero)
|
|
Got broken after making one of those micro optimizations requested on review..
|
|
|
|
|
|
|
|
It's not something the user needs to know, and will display
attacker controlled data
|
|
|
|
|
|
Update copyright year to 2020
|
|
feee455 Fixes for ZMQ JSON-RPC endpoint names for raw tx (vtnerd)
|
|
119f706 rpc: fix 'use_bootstrap_daemon_if_necessary' return value (xiphon)
|
|
|
|
|
|
|
|
|
|
d2d3a81 bootstrap_daemon: fix missing virtual destructor and lambda capture (clang warning) (xiphon)
|
|
warning)
|
|
68a6507 Fixed bug in ZMQ JSON-RPC method field (vtnerd)
|
|
42a7a4d daemon: auto public nodes - cache and prioritize most stable nodes (xiphon)
|
|
81c5943 Remove temporary std::string creation in some hex->bin calls (vtnerd)
5fcc23a Move hex->bin conversion to monero copyright files and with less includes (vtnerd)
3387f0e Reduce template bloat in hex->bin for ZMQ json (vtnerd)
|
|
82da832 rpc: Add check for too old timestamps in payment signatures. (glv2)
|
|
80d5320 Hash domain separation (SarangNoether)
|
|
|
|
|
|
|
|
3627e53 rpc: fix print_pool_sh not finding local txes (moneromooo-monero)
|
|
320bc84 rpc: add --rpc-payment-allow-free-loopback (moneromooo-monero)
|
|
|
|
ffe7165e wallet: reroll fake outs selection on local tx_sanity_check failure (xiphon)
|
|
- New flag in NOTIFY_NEW_TRANSACTION to indicate stem mode
- Stem loops detected in tx_pool.cpp
- Embargo timeout for a blackhole attack during stem phase
|
|
This allows RPC coming from the loopback interface to not have
to pay for service. This makes it possible to run an externally
accessible RPC server for payment while also having a local RPC
server that can be run unrestricted and payment free.
|
|
0f78b06e Various improvements to the ZMQ JSON-RPC handling: (Lee Clagett)
|
|
|
|
- Finding handling function in ZMQ JSON-RPC now uses binary search
- Temporary `std::vector`s in JSON output now use `epee::span` to
prevent allocations.
- Binary -> hex in JSON output no longer allocates temporary buffer
- C++ structs -> JSON skips intermediate DOM creation, and instead
write directly to an output stream.
|
|
69336931 rpc: fill miner_tx_hash again (moneromooo-monero)
|
|
716012ca rpc: drop the obsolete and wrong "unpruned size" log (moneromooo-monero)
|
|
987c3139 print_coinbase_tx_sum now supports 128 bits sums (moneromooo-monero)
|
|
a2578892 --disable-ban-rpc option to prevent RPC users from banning (naughtyfox)
|
|
5985c5af rpc: add bad-blocks to flush_cache RPC (moneromooo-monero)
|
|
|
|
5f2a32c daemon: run with -rpc-payment-address and --rpc-restricted-bind-port (moneromooo-monero)
|
|
|
|
|
|
2f8f3a94 rpc: base flush_cache request/response on the new base structs (moneromooo-monero)
|
|
b90c4bc3 rpc: error out from get_info if the proxied call errors out (moneromooo-monero)
fa16df99 make_test_signature: exit nicely on top level exception (moneromooo-monero)
054b2621 node_rpc_proxy: init some new rpc payment fields in invalidate (moneromooo-monero)
d0faae2a rpc: init a few missing client_info members (moneromooo-monero)
d56a483a rpc: do not propagate exceptions out of a dtor (moneromooo-monero)
3c849188 rpc: always set the update field in update on sucess (moneromooo-monero)
|
|
8231c7cd rpc: fix bootstrap RPC payment RPC being made in raw JSON, not JSON RPC (moneromooo-monero)
81c26589 rpc: don't auto fail RPC needing payment in bootstrap mode (moneromooo-monero)
|
|
d7cf8727 rpc: add received_timestamp for pool txes in gettransactions (moneromooo-monero)
|
|
a7a40e28 Actually concatenate error strings. (Bert Peters)
|
|
|
|
It was removed to save duplicated generation time, but it can
be copied from another instance instead
|
|
Since we now get pruned data in the first place, the "unpruned" data
size will in fact be the pruned data size, leading to confusion
|
|
dce6f05 rpc: Only show version string if it matches expected pattern (ndorf)
3293780 daemon: Use rpc for 'version' command (ndorf)
|
|
The tail emission will bring the total above 64 bits
|
|
|
|
Flushes m_invalid_blocks in Blockchain.
|
|
|
|
Coverity 205410
|
|
Coverity 205414
|
|
Coverity 205415
|
|
Coverity 205416
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
ebc6ce44f cryptonote: untangle dependency from miner to blockchain (moneromooo-monero)
|
|
It causes link errors at least on mac
|
|
|
|
|
|
5734686 rpc: Include tag in get_info version string (ndorf)
|
|
|
|
This allows flushing internal caches (for now, the bad tx cache,
which will allow debugging a stuck monerod after it has failed to
verify a transaction in a block, since it would otherwise not try
again, making subsequent log changes pointless)
|