aboutsummaryrefslogtreecommitdiff
path: root/src/ringct (follow)
AgeCommit message (Collapse)AuthorFilesLines
2017-12-09ringct: always use outPk.mask to decode amountsmoneromooo-monero1-19/+3
2017-12-09ringct: do not include bulletproof commitments in signed messagemoneromooo-monero1-3/+3
Those are not serialized, but are restored from the outPk masks, so depending on what tries to validate the tx, those commitments may or may not be filled with valid data at the time. The outPk masks are already hashed as part of the rctSigBase field.
2017-12-08add bulletproofs from v7 on testnetmoneromooo-monero2-41/+90
2017-12-08bulletproofs: switch H/G in Pedersen commitments to match rctmoneromooo-monero1-13/+14
Changes from sarang
2017-12-08integrate bulletproofs into moneromoneromooo-monero4-55/+113
2017-12-08add bulletproofs to the build, with basic unit testsmoneromooo-monero3-2/+843
Based on Java code from Sarang Noether
2017-12-07add a version of ge_double_scalarmult_precomp_vartime with A precompmoneromooo-monero2-0/+10
2017-12-07ringct: add a version of addKeys which returns the resultmoneromooo-monero2-0/+6
2017-11-14remove "using namespace std" from headersmoneromooo-monero3-29/+15
It's nasty, and actually breaks on Solaris, where if.h fails to build due to: struct map *if_memmap;
2017-10-07Subaddresseskenshi841-0/+2
2017-09-14Use a threadpoolHoward Chu1-26/+23
Instead of constantly creating and destroying threads
2017-05-23changed crypto to cncrypto so it generated libcncryptoGentian1-1/+1
fix a cmakelist
2017-04-11Simplified the implementation and features of spanLee Clagett1-1/+4
2017-04-11Improvements for epee binary to hex functions:Lee Clagett1-2/+2
- Performance improvements - Added `span` for zero-copy pointer+length arguments - Added `std::ostream` overload for direct writing to output buffers - Removal of unused `string_tools::buff_to_hex`
2017-03-22ringct: move ge_frombytes_vartime failure error to warningmoneromooo-monero1-11/+13
Avoids scaring people when seeing some invalid txes
2017-02-27ringct: do not require range proof in decodeRct/decodeRctSimplemoneromooo-monero1-4/+2
These fields aren't used, and they'll actually be pruned in some cases
2017-02-21update copyright year, fix occasional lack of newline at line endRiccardo Spagni2-2/+2
2017-02-20core: test key images against validity domainmoneromooo-monero1-0/+4
2017-02-08extract some basic code from libcryptonote_core into libcryptonote_basickenshi842-1/+2
2017-01-26Fix clang build failure, caused by mixing C and C++Timothy D. Prime1-1/+1
Easily fixed by moving a C++ header out of 'extern "C" {...}'. When building with CC=clang CXX=clang++ make, [ 21%] Building CXX object src/ringct/CMakeFiles/obj_ringct.dir/rctTypes.cpp.o In file included from /home/tdprime/bitmonero/src/ringct/rctTypes.cpp:31: In file included from /home/tdprime/bitmonero/src/ringct/rctTypes.h:43: In file included from /home/tdprime/bitmonero/src/crypto/generic-ops.h:34: /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/cstring:100:3: error: conflicting types for 'memchr' memchr(void* __s, int __c, size_t __n) ^ /usr/include/string.h:92:14: note: previous declaration is here extern void *memchr (const void *__s, int __c, size_t __n) ^ ... and 4 more similar errors
2017-01-21ringct: reorder a bit to check quicker tests firstmoneromooo-monero1-17/+17
2017-01-16Change logging to easylogging++moneromooo-monero3-0/+9
This replaces the epee and data_loggers logging systems with a single one, and also adds filename:line and explicit severity levels. Categories may be defined, and logging severity set by category (or set of categories). epee style 0-4 log level maps to a sensible severity configuration. Log files now also rotate when reaching 100 MB. To select which logs to output, use the MONERO_LOGS environment variable, with a comma separated list of categories (globs are supported), with their requested severity level after a colon. If a log matches more than one such setting, the last one in the configuration string applies. A few examples: This one is (mostly) silent, only outputting fatal errors: MONERO_LOGS=*:FATAL This one is very verbose: MONERO_LOGS=*:TRACE This one is totally silent (logwise): MONERO_LOGS="" This one outputs all errors and warnings, except for the "verify" category, which prints just fatal errors (the verify category is used for logs about incoming transactions and blocks, and it is expected that some/many will fail to verify, hence we don't want the spam): MONERO_LOGS=*:WARNING,verify:FATAL Log levels are, in decreasing order of priority: FATAL, ERROR, WARNING, INFO, DEBUG, TRACE Subcategories may be added using prefixes and globs. This example will output net.p2p logs at the TRACE level, but all other net* logs only at INFO: MONERO_LOGS=*:ERROR,net*:INFO,net.p2p:TRACE Logs which are intended for the user (which Monero was using a lot through epee, but really isn't a nice way to go things) should use the "global" category. There are a few helper macros for using this category, eg: MGINFO("this shows up by default") or MGINFO_RED("this is red"), to try to keep a similar look and feel for now. Existing epee log macros still exist, and map to the new log levels, but since they're used as a "user facing" UI element as much as a logging system, they often don't map well to log severities (ie, a log level 0 log may be an error, or may be something we want the user to see, such as an important info). In those cases, I tried to use the new macros. In other cases, I left the existing macros in. When modifying logs, it is probably best to switch to the new macros with explicit levels. The --log-level options and set_log commands now also accept category settings, in addition to the epee style log levels.
2017-01-15Merge pull request #1561Riccardo Spagni1-64/+64
d561f4ad enable clang checks that were disabled (Chris Vickio) 0aefb2f6 remove std::move from return statements (pessimizing-move warning) (Chris Vickio) 629d5b76 change counter from bool to int (deprecated-increment-bool warning) (Chris Vickio) fb76d439 add extra braces around subobjects (missing-braces warning) (Chris Vickio) 3b6d5f25 make struct/class declarations consistent (mismatched-tags warning) (Chris Vickio) fcf66925 remove unused fields from network_throttle (unused-private-field warning) (Chris Vickio) 296f8c16 inline unused function (for unused-function warning) (Chris Vickio)
2017-01-14rct: split rct checks between semantics and othermoneromooo-monero2-78/+101
Semantics can be checked early
2017-01-14add extra braces around subobjects (missing-braces warning)Chris Vickio1-64/+64
2016-12-19Removed unused functionsLee Clagett1-16/+0
2016-12-14fix MGs jsonmoneroexamples1-3/+3
2016-12-12Tx verification failing is not an errorluigi11111-5/+5
And rangeProofs are on outputs...
2016-12-08Merge pull request #1414Riccardo Spagni1-0/+19
3b005275 ringct: add sc_check calls in MLSAG_Ver for ss and cc (moneromooo-monero) 2f1732a7 ringct: guard against bad data exceptions in worker threads (moneromooo-monero)
2016-12-07ringct: add sc_check calls in MLSAG_Ver for ss and ccmoneromooo-monero1-0/+5
luigi1111's recommendation
2016-12-07ringct: guard against bad data exceptions in worker threadsmoneromooo-monero1-0/+14
If purported pubkeys aren't actually valid pubkeys, exceptions will fly. These will terminate if thrown in a worker thread. Guard against this.
2016-12-04ringct: luigi1111's changes to fix and speedup Borromean sigsluigi11111-16/+15
2016-12-04ringct: switch to Borromean signaturesShen Noether5-114/+88
2016-12-02ringct: fix MGs serialization to JSONmoneromooo-monero1-1/+5
2016-11-23Added task_region - a fork/join task implementationLee Clagett1-60/+45
2016-11-02adding thread_group for managing async tasksLee Clagett1-98/+50
2016-11-01Merge pull request #1272Riccardo Spagni1-3/+5
48b57d8 monero.supp: valgrind suppressions file (moneromooo-monero) ffd8c41 ringct: check the size of amount_keys is the same as destinations (moneromooo-monero) 836669d ringct: always shutdown the boost io service (moneromooo-monero)
2016-10-29ringct: check the size of amount_keys is the same as destinationsmoneromooo-monero1-0/+2
2016-10-29ringct: always shutdown the boost io servicemoneromooo-monero1-3/+3
Even if no worker threads were started, it needs shutting down or it will cause an invalid access in the io service thread
2016-10-23ringct: some more small optimizationsmoneromooo-monero2-58/+25
2016-10-15ringct: thread verRct and verRctSimplemoneromooo-monero1-17/+119
2016-10-15ringct: remove unneeded type conversionsmoneromooo-monero2-3/+3
2016-10-15ringct: reserve space in vectors to avoid excessive reallocationmoneromooo-monero1-0/+2
2016-10-15ringct: avoid unnecessary memcpymoneromooo-monero1-16/+3
2016-10-15ringct: add a few consts where possiblemoneromooo-monero1-4/+4
2016-10-15ringct: pass vectors by const ref where possiblemoneromooo-monero2-4/+4
2016-10-10Add performance timers for ringct tx verificationmoneromooo-monero1-0/+7
2016-10-08ringct: use const refs as parameters where appropriatemoneromooo-monero3-5/+5
2016-09-26Dropped "bit" from bitmonero.Randi Joseph1-2/+2
2016-09-18cmake: transitive deps and remove deprecated LINK_*redfish1-8/+2
Keep the immediate direct deps at the library that depends on them, declare deps as PUBLIC so that targets that link against that library get the library's deps as transitive deps. Break dep cycle between blockchain_db <-> crytonote_core. No code refactoring, just hide cycle from cmake so that it doesn't complain (cycles are allowed only between static libs, not shared libs). This is in preparation for supproting BUILD_SHARED_LIBS cmake built-in option for building internal libs as shared.
2016-09-14rct: rework serialization to avoid storing vector sizesmoneromooo-monero2-36/+130
2016-08-28ringct: remove unused codemoneromooo-monero1-245/+0
2016-08-28ringct: pass structure by const ref, not valuemoneromooo-monero2-2/+2
2016-08-28ringct: use memcpy/memset instead of handwritten loop where appropriatemoneromooo-monero1-29/+11
2016-08-28ringct: remove spurious copiesmoneromooo-monero1-24/+4
2016-08-28rct: faster Cryptonote/rct conversionsmoneromooo-monero1-8/+8
2016-08-28rct: early out on failure on verRangemoneromooo-monero1-3/+5
2016-08-28ringct: use Cryptonote serialization to hash non prunable datamoneromooo-monero1-21/+9
2016-08-28New "Halfway RingCT" outputs for coinbase transactionsmoneromooo-monero1-2/+7
When RingCT is enabled, outputs from coinbase transactions are created as a single output, and stored as RingCT output, with a fake mask. Their amount is not hidden on the blockchain itself, but they are then able to be used as fake inputs in a RingCT ring. Since the output amounts are hidden, their "dustiness" is not an obstacle anymore to mixing, and this makes the coinbase transactions a lot smaller, as well as helping the TXO set to grow more slowly. Also add a new "Null" type of rct signature, which decreases the size required when no signatures are to be stored, as in a coinbase tx.
2016-08-28rct: log why verification failsmoneromooo-monero1-9/+13
and remove some unnecessary variables in the checking code
2016-08-28rct: serialize txnFee as varintmoneromooo-monero1-1/+1
2016-08-28rct amount key modified as per luigi1111's recommendationsmoneromooo-monero4-42/+12
This allows the key to be not the same for two outputs sent to the same address (eg, if you pay yourself, and also get change back). Also remove the key amounts lists and return parameters since we don't actually generate random ones, so we don't need to save them as we can recalculate them when needed if we have the correct keys.
2016-08-28rct: rework v2 txes into prunable and non prunable datamoneromooo-monero2-31/+43
Nothing is pruned, but this allows easier changes later.
2016-08-28rct: rework the verification preparation processmoneromooo-monero2-63/+77
The whole rct data apart from the MLSAGs is now included in the signed message, to avoid malleability issues. Instead of passing the data that's not serialized as extra parameters to the verification API, the transaction is modified to fill all that information. This means the transaction can not be const anymore, but it cleaner in other ways.
2016-08-28rct: change the simple flag to a typemoneromooo-monero2-10/+14
for future expansion
2016-08-28rct: avoid the need for the last II elementShen Noether3-33/+44
This element is used in the generation of the MLSAG, but isn't needed in verification. Also misc changes in the cryptonote code to match, by mooo.
2016-08-28rct: do not serialize senderPk - it is not used anymoremoneromooo-monero1-1/+1
2016-08-28rct: make the amount key derivable by a third party with the tx keymoneromooo-monero5-24/+52
Scheme design from luigi1114.
2016-08-28rct: do not serialize public keys in outPkmoneromooo-monero3-17/+29
They can be reconstructed from vout
2016-08-28rct: use the already defined H where possiblemoneromooo-monero1-2/+1
Found by luigi1111w
2016-08-28port get_tx_key/check_tx_key to rctmoneromooo-monero2-8/+10
2016-08-28integrate simple rct apimoneromooo-monero3-67/+76
2016-08-28ringct: optimization/cleanup of hash functionsShen Noether3-22/+45
2016-08-28ringct: "simple" ringct variantShen Noether5-3/+249
Allows the fake outs to be in different positions for each ring. For rct inputs only.
2016-08-28ringct: fix size unit mismatch calling keccakmoneromooo-monero1-1/+1
2016-08-28ringct: do not serialize what can be reconstructedmoneromooo-monero3-21/+43
The mixRing (output keys and commitments) and II fields (key images) can be reconstructed from vin data. This saves some modest amount of space in the tx.
2016-08-28ringct: catch errors from ge_frombytes_vartimemoneromooo-monero1-11/+12
2016-08-28ringct: add missing size check for ecdhInfomoneromooo-monero1-0/+1
2016-08-28ringct: change asserts to return false for boolean functionsmoneromooo-monero1-10/+10
2016-08-28add rct to the protocolmoneromooo-monero1-15/+23
It is not yet constrained to a fork, so don't use on the real network or you'll be orphaned or rejected.
2016-08-28ringct: add functions to commit to an amountmoneromooo-monero2-0/+21
One to commit to an amount with zero key (for use with fake commitments for pre-rct outputs), and one with an arbitrary key (for rct outputs).
2016-08-28make rct tx serialization workmoneromooo-monero1-0/+48
It may be suboptimal, but it's a pain to have to rebuild everything when some of this changes. Also, no clue why there seems to be two different code paths for serializing a tx...
2016-08-28ringct: allow no outputs, and add tests for this and feesmoneromooo-monero1-2/+0
2016-08-28ringct: make fee optionalmoneromooo-monero1-2/+9
2016-08-28ringct: txn fee stuffShen Noether3-13/+24
2016-08-28ringct: new {gen,decode}Rct APIs for conveniencemoneromooo-monero2-11/+27
A new version of genRct takes the mixRing as parameter, instead of the inPk. inPk are part of the mixRing, and it is cleaner to pass the mixRing data than to fetch it from the RingCT code. A new version of decodeRct also returns the mask. Also, failure to decode throws, so errors are properly detected.
2016-08-28ringct: add more convenience functionsmoneromooo-monero1-4/+14
2016-08-28ringct: add convenience functions to bridge ringct and cryptonotemoneromooo-monero1-0/+5
2016-08-28ringct: restore verRange check in debug modemoneromooo-monero1-1/+1
2016-08-28ringct: add check for destinations/amount size being equalmoneromooo-monero1-0/+1
2016-08-28ringct: fix off by 1 in mixin usagemoneromooo-monero1-3/+3
2016-08-28ringct: simplify random key generationmoneromooo-monero1-7/+2
2016-08-28ringct: cosmetic fixesShen Noether4-46/+9
Ported from Shen's RingCT repo
2016-08-28ringct: changes to hashToPointSimple to calcualte H2 valuesShen Noether1-0/+5
Ported from Shen's RingCT repo
2016-08-28ringct: compare keys with bitwise equality, not crypto opsShen Noether1-7/+6
Ported from Shen's RingCT repo
2016-08-28ringct: fix size argument to cn_fast_hashShen Noether1-1/+1
Ported from Shen's RingCT repo
2016-08-28Fix sc_0 to skGen in ProveRangeShen Noether1-1/+1
2016-08-28ringct: add a few consts where appropriatemoneromooo-monero2-6/+6
2016-08-28tests: more ringct range proof testsmoneromooo-monero1-1/+1
2016-08-28rct: add serialization machinery to rct typesmoneromooo-monero1-10/+32
2016-08-28serialization: declare do_serialize specializations before usemoneromooo-monero1-1/+1
This lets my gcc picks those instead of the generic template where appropriate (and then fail since std::vector<something> does not have a serialize method.
2016-08-28Added note on generating H2Shen Noether1-1/+2
2016-08-28Fixed missing last index H2Shen Noether1-1/+2
2016-08-28ringct: lock access to the PRNGmoneromooo-monero1-2/+2
2016-08-28ringct: add simple input validationmoneromooo-monero2-32/+74
Throw when inputs aren't the expected size.
2016-08-28ringct: add convenience operators to keymoneromooo-monero1-0/+4
2016-08-28ringct: import of Shen Noether's ring confidential transactionsmoneromooo-monero9-0/+2374
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-29 12:53:17 +0000